[jdk17] Integrated: 8269218: GaloisCounterMode.overlapDetection misses the JDK-8263436 fix again

2021-06-24 Thread Aleksey Shipilev
On Wed, 23 Jun 2021 08:10:40 GMT, Aleksey Shipilev  wrote:

> SonarCloud again complains about GaloisCounterMode.overlapDetection, in the 
> similar way JDK-8263436 did. I think JDK-827 accidentally reintroduced 
> the old code.
> 
> The tangential question if JDK-827 reverted anything else.
> 
> Additional testing:
>  - [x] `jdk_security` passes

This pull request has now been integrated.

Changeset: 3fb28d30
Author:Aleksey Shipilev 
URL:   
https://git.openjdk.java.net/jdk17/commit/3fb28d3074dfb33d8b7e489c9a55f52d4e0b954b
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod

8269218: GaloisCounterMode.overlapDetection misses the JDK-8263436 fix again

Reviewed-by: ascarpino

-

PR: https://git.openjdk.java.net/jdk17/pull/124


Integrated: 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java

2021-06-24 Thread Aleksey Shipilev
On Wed, 23 Jun 2021 07:38:37 GMT, Aleksey Shipilev  wrote:

> SonarCloud reports:
> "Remove or correct this useless self-assignment."
> 
> 
> if (cipherAlgo.equals("AES")) {
> this.keysize = keysize; // < here
> switch (keysize) {
> case 128:
> cipherAlgo_OID = aes128CBC_OID;
> 
> 
> Seems to be here since initial addition in JDK-6383200.
> 
> Additional testing:
>  - [x] `jdk_security` pass

This pull request has now been integrated.

Changeset: e515873f
Author:Aleksey Shipilev 
URL:   
https://git.openjdk.java.net/jdk/commit/e515873f887ce4071ab4878a4bafca8eea67afea
Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod

8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java

Reviewed-by: valeriep

-

PR: https://git.openjdk.java.net/jdk/pull/4570


Re: Authorization layer API and low level access checks.

2021-06-24 Thread Peter Firmstone

Thanks Remi,

We're still building on 8, for CORBA-IIOP stubs, but will look into this 
when we've found an alternative IIOP stub compiler.


--
Regards,
 
Peter


On 23/06/2021 8:02 pm, Remi Forax wrote:

- Mail original -

De: "Andrew Dinn" 
À: "Peter Firmstone" , "discuss" 

Cc: "security-dev" 
Envoyé: Mercredi 23 Juin 2021 11:19:42
Objet: Re: Authorization layer API and low level access checks.
OHi Peter,

n 23/06/2021 04:02, Peter Firmstone wrote:

  1. StackWalker - Can stack walker be back ported to Java 8?

The right place to ask about this is the jdk8u updates project list.
However, you probably don't need to ask there because the answer is
almost certainly going to be a very loud no.

JDK8u is in long term maintenance mode. The goal of the updates project
for that release is to fix security issues and critical bugs *and
nothing else* so that existing deployments remain stable as far as
possible. Except when required to meet those goals backporting of new
functionality is done only under exceptional circumstances.

The only recent examples of new function backports that I am aware of
have involved merging up functionality from downstream releases in order
to 1) unify the platform and 2) enable downstream contributors to help
to maintain a single, standard release i.e. highly exceptional cases
where there was a problem for existing users. Your request, by contrast,
is exactly the sort of case that maintainers are trying to avoid -- it
will introduce change with no gain and the potential of breakage for the
vast majority of users.

If you want to deal with  deployments pre and post removal of the
Authorization support that you currently rely on I suggest you consider
doing that by using a multi-release implementation and package it using
the multi-release jar format. If you don't like the idea of
multi-release jars you can still implement a standard jar format
solution using a provider model. However, you will still need to build
the alternative provider jars using the relevant JDK releases so that
different providers can rely on different JDK capabilities..

Technically, you may not need several JDKs because you can ask javac to behave as if it 
was compiling like a previous JDK using the option "--release" (this option is 
also available with Maven and Gradle).
I believe that compiling as the release 8 will be supported up to Java 23.


regards,


Andrew Dinn
---
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill

regards,
Rémi