Integrated: 8286773: cleanup @returns in sun.security classes
On Sat, 14 May 2022 13:41:38 GMT, John Jiang wrote: > The below sun.security classes should use `@return` rather than `@returns`. > sun/security/tools/keytool/Main.java > sun/security/util/DerValue.java This pull request has now been integrated. Changeset: 63bd3b77 Author:John Jiang URL: https://git.openjdk.java.net/jdk/commit/63bd3b7728e0e717e6b4a45a519ff03002cbdb66 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8286773: cleanup @returns in sun.security classes Reviewed-by: xuelei - PR: https://git.openjdk.java.net/jdk/pull/8714
Re: RFR: 8286773: cleanup @returns in sun.security classes
On Sat, 14 May 2022 13:41:38 GMT, John Jiang wrote: > The below sun.security classes should use `@return` rather than `@returns`. > sun/security/tools/keytool/Main.java > sun/security/util/DerValue.java Looks good to me. - Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8714
RFR: 8286773: cleanup @returns in sun.security classes
The below sun.security classes should use `@return` rather than `@returns`. sun/security/tools/keytool/Main.java sun/security/util/DerValue.java - Commit messages: - 8286773: cleanup @returns in sun.security classes Changes: https://git.openjdk.java.net/jdk/pull/8714/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8714=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8286773 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/8714.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8714/head:pull/8714 PR: https://git.openjdk.java.net/jdk/pull/8714
Re: RFR: 8283577: SSLEngine.unwrap on read-only input ByteBuffer [v2]
On Sat, 14 May 2022 03:29:14 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review of this fix to allow a read-only 'src' buffer to be used >> with SSLEngine.unwrap(). A temporary read-write buffer is created in the >> SSLCipher operation when a read-only buffer is passed. If the 'src' is >> read-write, there is no effect on the current operation >> >> The PR also includes a CSR for an API implementation note to the >> SSLEngine.unwrap. The 'src' buffer may be modified during the decryption >> operation. 'unwrap()' has had this behavior forever, so there is no >> compatibility issue with this note. Using the 'src' buffer for in-place >> decryption was a performance decision. >> >> Tony > > Anthony Scarpino has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - review update > - update some nits > - PR ready > - Initial As the specification has been indicate that the input buffer could be updated, what do you think if closing the bug as "Not an issue" (or clarify the spec but no implementation update)? I was just wondering if it really worthy the effort to make the code more complicated. - PR: https://git.openjdk.java.net/jdk/pull/8462
