Integrated: 8284209: Replace remaining usages of 'a the' in source code

[Alexey Ivanov]

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov  wrote:

> Replaces usages of articles that follow each other in all combinations: 
> a/the, an?/an?, the/the…
> 
> It's the last issue in the series, and it still touches different areas of 
> the code.

This pull request has now been integrated.

Changeset: 9b7e42c0
Author:    Alexey Ivanov 
URL:   
https://git.openjdk.java.net/jdk/commit/9b7e42c0f078db778dda1011d85cd92e3e4eb979
Stats: 74 lines in 40 files changed: 0 ins; 2 del; 72 mod

8284209: Replace remaining usages of 'a the' in source code

Reviewed-by: lancea, wetmore, dfuchs, iris, jjg, ihse

-

PR: https://git.openjdk.java.net/jdk/pull/8771

Integrated: 8284191: Replace usages of 'a the' in hotspot and java.base

[Alexey Ivanov]

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov  wrote:

> Replaces usages of articles that follow each other in all combinations: 
> a/the, an?/an?, the/the…
> 
> Also, I fixed a couple of spelling mistakes.

This pull request has now been integrated.

Changeset: e0d361ce
Author:Alexey Ivanov 
URL:   
https://git.openjdk.java.net/jdk/commit/e0d361cea91d3dd1450aece73f660b4abb7ce5fa
Stats: 303 lines in 162 files changed: 0 ins; 11 del; 292 mod

8284191: Replace usages of 'a the' in hotspot and java.base

Reviewed-by: lancea, wetmore, naoto, iris, kevinw, xuelei

-

PR: https://git.openjdk.java.net/jdk/pull/8768

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code [v3]

[Alexey Ivanov]

> Replaces usages of articles that follow each other in all combinations: 
> a/the, an?/an?, the/the…
> 
> It's the last issue in the series, and it still touches different areas of 
> the code.

Alexey Ivanov has updated the pull request incrementally with one additional 
commit since the last revision:

  Update copyright to 2022

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8771/files
  - new: https://git.openjdk.java.net/jdk/pull/8771/files/fab0a4bb..4d529f79

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8771=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8771=01-02

  Stats: 24 lines in 24 files changed: 0 ins; 0 del; 24 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8771/head:pull/8771

PR: https://git.openjdk.java.net/jdk/pull/8771

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code [v2]

[Alexey Ivanov]

> Replaces usages of articles that follow each other in all combinations: 
> a/the, an?/an?, the/the…
> 
> It's the last issue in the series, and it still touches different areas of 
> the code.

Alexey Ivanov has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains 12 commits:

 - Merge master
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'an? an?' in source code
 - 8284209: Replace remaining usages of 'a the' in source code
 - ... and 2 more: https://git.openjdk.java.net/jdk/compare/5b7d066c...fab0a4bb

-

Changes: https://git.openjdk.java.net/jdk/pull/8771/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8771=01
  Stats: 50 lines in 40 files changed: 0 ins; 2 del; 48 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8771/head:pull/8771

PR: https://git.openjdk.java.net/jdk/pull/8771

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v3]

[Alexey Ivanov]

> Replaces usages of articles that follow each other in all combinations: 
> a/the, an?/an?, the/the…
> 
> Also, I fixed a couple of spelling mistakes.

Alexey Ivanov has updated the pull request incrementally with one additional 
commit since the last revision:

  Update copyright to 2022

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8768/files
  - new: https://git.openjdk.java.net/jdk/pull/8768/files/0669cdc1..fa2caaec

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8768=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8768=01-02

  Stats: 102 lines in 102 files changed: 0 ins; 0 del; 102 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8768.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8768/head:pull/8768

PR: https://git.openjdk.java.net/jdk/pull/8768

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v2]

[Alexey Ivanov]

On Thu, 19 May 2022 09:38:40 GMT, Kevin Walls  wrote:

>> Alexey Ivanov has updated the pull request incrementally with seven 
>> additional commits since the last revision:
>> 
>>  - ...set to the values...
>>  - ...will result in a Zip64 Extra (EXT) header
>>  - ...in addition to the main attributes...
>>  - ...and the address of the current archive
>>  - Merges the stack at the given bci...
>>  - Returns a single ...
>>  - ...when a peer shuts down an association.
>
> OK.  I started with serviceability but then went through everything as it's 
> hard to record what you have/haven't seen in these long reviews.

Thank you @kevinjwalls for your suggestions. I've incorporated them.

-

PR: https://git.openjdk.java.net/jdk/pull/8768

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v2]

[Alexey Ivanov]

On Thu, 19 May 2022 08:47:47 GMT, Kevin Walls  wrote:

>> Alexey Ivanov has updated the pull request incrementally with seven 
>> additional commits since the last revision:
>> 
>>  - ...set to the values...
>>  - ...will result in a Zip64 Extra (EXT) header
>>  - ...in addition to the main attributes...
>>  - ...and the address of the current archive
>>  - Merges the stack at the given bci...
>>  - Returns a single ...
>>  - ...when a peer shuts down an association.
>
> src/jdk.jdi/share/classes/com/sun/jdi/ClassType.java line 348:
> 
>> 346: 
>> 347: /**
>> 348:  * Returns the single non-abstract {@link Method} visible from
> 
> I would think "Returns a single ..." because the implementation returns the 
> first match it finds, from possibly many.

I've accepted it, yet I'm still unsure whether ‘a‘ or ‘the’…

-

PR: https://git.openjdk.java.net/jdk/pull/8768

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v2]

[Alexey Ivanov]

> Replaces usages of articles that follow each other in all combinations: 
> a/the, an?/an?, the/the…
> 
> Also, I fixed a couple of spelling mistakes.

Alexey Ivanov has updated the pull request incrementally with seven additional 
commits since the last revision:

 - ...set to the values...
 - ...will result in a Zip64 Extra (EXT) header
 - ...in addition to the main attributes...
 - ...and the address of the current archive
 - Merges the stack at the given bci...
 - Returns a single ...
 - ...when a peer shuts down an association.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8768/files
  - new: https://git.openjdk.java.net/jdk/pull/8768/files/c7e73658..0669cdc1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8768=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8768=00-01

  Stats: 7 lines in 7 files changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8768.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8768/head:pull/8768

PR: https://git.openjdk.java.net/jdk/pull/8768

RFR: 8284209: Replace remaining usages of 'a the' in source code

[Alexey Ivanov]

Replaces usages of articles that follow each other in all combinations: a/the, 
an?/an?, the/the…

It's the last issue in the series, and it still touches different areas of the 
code.

-

Commit messages:
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'an? an?' in source code
 - 8284209: Replace remaining usages of 'a the' in source code
 - 8284209: Replace remaining usages of 'an the' in source code
 - ... and 1 more: https://git.openjdk.java.net/jdk/compare/69ff86a3...8290c07e

Changes: https://git.openjdk.java.net/jdk/pull/8771/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8771=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284209
  Stats: 51 lines in 41 files changed: 0 ins; 2 del; 49 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8771/head:pull/8771

PR: https://git.openjdk.java.net/jdk/pull/8771

RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

[Alexey Ivanov]

Replaces usages of articles that follow each other in all combinations: a/the, 
an?/an?, the/the…

Also, I fixed a couple of spelling mistakes.

-

Commit messages:
 - 8284191: Replace usages of 'the an' in hotspot and java.base
 - 8284191: Replace usages of 'the an' in hotspot and java.base
 - 8284191: Replace usages of 'the an' in hotspot and java.base
 - 8284191: Replace usages of 'the the' in hotspot and java.base
 - 8284191: Replace usages of 'the the' in hotspot and java.base
 - 8284191: Replace usages of 'the the' in hotspot and java.base
 - 8284191: Replace usages of 'the the' in hotspot and java.base
 - 8284191: Replace usages of 'the the' in hotspot and java.base
 - 8284191: Replace usages of 'the the' in hotspot and java.base
 - 8284191: Replace usages of 'the the' in hotspot and java.base
 - ... and 13 more: https://git.openjdk.java.net/jdk/compare/69ff86a3...c7e73658

Changes: https://git.openjdk.java.net/jdk/pull/8768/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8768=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284191
  Stats: 202 lines in 162 files changed: 0 ins; 11 del; 191 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8768.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8768/head:pull/8768

PR: https://git.openjdk.java.net/jdk/pull/8768

Re: RFR: 8283426: Fix 'exeption' typo [v4]

[Alexey Ivanov]

On Wed, 23 Mar 2022 19:41:58 GMT, Andrey Turbanov  wrote:

>> Fix repeated typo `exeption`
>
> Andrey Turbanov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8283426: Fix 'exeption' typo
>   
>   Co-authored-by: Alexey Ivanov 
> <70774172+aivanov-...@users.noreply.github.com>

Marked as reviewed by aivanov (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8283426: Fix 'exeption' typo [v3]

[Alexey Ivanov]

On Wed, 23 Mar 2022 07:31:23 GMT, Andrey Turbanov  wrote:

>> Fix repeated typo `exeption`
>
> Andrey Turbanov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8283426: Fix 'exeption' typo
>   fix more typos, found by Sean Coffey

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/sql/testng/test/rowset/serial/SerialJavaObjectTests.java line 46:

> 44: 
> 45: /*
> 46:  * Validate that an SerialException is thrown when the object 
> specified

Suggestion:

 * Validate that a SerialException is thrown when the object specified

-

PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8283426: Fix 'exeption' typo [v2]

[Alexey Ivanov]

On Mon, 21 Mar 2022 09:02:17 GMT, Andrey Turbanov  wrote:

>> Fix repeated typo `exeption`
>
> Andrey Turbanov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8283426: Fix 'exeption' typo
>   
>   Apply suggestion
>   
>   Co-authored-by: Alexey Ivanov 
> <70774172+aivanov-...@users.noreply.github.com>

Marked as reviewed by aivanov (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8283426: Fix 'exeption' typo

[Alexey Ivanov]

On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov  wrote:

> Fix repeated typo `exeption`

Marked as reviewed by aivanov (Reviewer).

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java 
line 201:

> 199: /*
> 200:  * The method could not be implemented due to CALayer restrictions.
> 201:  * The exception enforce clients not to use it.

Suggestion:

 * The exception enforces clients not to use it.

-

PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8273528: Avoid ByteArrayOutputStream.toByteArray when converting stream to String

[Alexey Ivanov]

On Thu, 2 Sep 2021 20:19:40 GMT, Andrey Turbanov 
 wrote:

> Using `ByteArrayOutputStream.toString` to convert it's content to a String is 
> cleaner than `new String(out.toByteArray())`. Also it's a bit faster because 
> of one less array copy.

Marked as reviewed by aivanov (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5355

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

[Alexey Ivanov]

Hi Thomas,

There was a thread about failing build on 32 bit Windows:
http://mail.openjdk.java.net/pipermail/build-dev/2018-November/023767.html

It continued in February 2019:
http://mail.openjdk.java.net/pipermail/build-dev/2019-February/024925.html

Fast debug builds were affected. Likely there was mismatch between 
CALLBACK / JNICALL macro:

http://mail.openjdk.java.net/pipermail/build-dev/2019-February/024972.html
http://mail.openjdk.java.net/pipermail/build-dev/2019-February/024973.html

Magnus suggested a fix:
http://mail.openjdk.java.net/pipermail/build-dev/2019-February/024996.html

Yet there was no reply as whether it fixed the debug build or not.


Hope these pointers help.

Regards,
Alexey

On 25/03/2019 12:45, Thomas Stüfe wrote:

Hi all,

Following David's suggestion, I withdraw this bug and will open issues 
for each area separately.


Cheers, Thomas



On Mon, Mar 25, 2019 at 1:44 PM Thomas Stüfe > wrote:


Hi David,

Updating vs2017 did not help :/

Cheers, Thomas

On Mon, Mar 25, 2019 at 8:17 AM David Holmes
mailto:david.hol...@oracle.com>> wrote:

Hi Thomas,

On 25/03/2019 5:01 pm, Thomas Stüfe wrote:
> Hi David,
>
> (added net-dev, awt-dev, security-dev since part of these
fixes are in
> their territory)

May be better to split up the reviews, cross-posting that many
groups
gets very messy given most people won't be subscribed to them
all -
myself included.



> On Mon, Mar 25, 2019 at 1:34 AM David Holmes
mailto:david.hol...@oracle.com>
> >> wrote:
>
>     Hi Thomas,
>
>     A few queries, comments and concerns ...
>
>     On 25/03/2019 6:58 am, Thomas Stüfe wrote:
>      > Hi all,
>      >
>      > After a long time I tried to build a Windows 32bit VM
(VS2017)
>     and failed;
>
>     I'm somewhat surprised as I thought someone was actively
doing Windows
>     32-bit builds out there, plus there are shared code
changes that should
>     also have been caught by non-Windows 32-bit builds. :(
>
>
> Not sure what others do. I did a 32bit windows build,
slowdebug, warning
> enabled, and it failed with those 5+ issues.
>
>      > multiple errors and warnings. Lets reverse the bitrot:
>      >
>      > cr:
>      >
>

http://cr.openjdk.java.net/~stuefe/webrevs/8221375--windows-32bit-build-(vs2017)-broken-in-many-places/webrev.00/webrev/
>      >
>      > Issue: https://bugs.openjdk.java.net/browse/JDK-8221375
>      >
>      > Most of the fixes are trivial: Calling convention
mismatches (awt
>     DTRACE
>      > callbacks), printf specifiers etc.
>      >
>      > Had to supress a warning in os_windows_x86.cpp - I
was surprised
>     by this
>      > since this did not look 32bit specifc, do we disable
warnings on
>     Windows
>      > 64bit builds?
>
>     What version of VS2017? We use VS2017 15.9.6 and we
don't disable
>     warnings.
>
>
> I use VS2017 CE. Not sure which version spcifically, but my
compiler is at
>
> Microsoft (R) C/C++ Optimizing Compiler Version 19.14.26431
for x86

I think that would equate to an older version - 15.7

MSVC++ 14.14 _MSC_VER == 1914 (Visual Studio 2017 version 15.7)

Any chance you can upgrade to latest version? (Especially in
light of
the apparent compiler bug you cite below.)

Thanks,
David
-

>      > The error I had in vmStructs.cpp was a bit weird:
compiler
>     complained about
>      > an assignment of an enum value defined like this:
>      >
>      > hash_mask_in_place       = (address_word)hash_mask <<
hash_shift
>      >
>      > to an uint64_t variable, complaining about narrowing.
I did not
>     find out
>      > what his problem was. In the end, I decided to add an
explicit
>     cast to
>      > GENERATE_VM_LONG_CONSTANT_ENTRY(name) (see
vmStructs.hpp).
>
>     Not at all sure that's the right fix. In markOop.hpp we
see that value
>     gets special treatment on Windows-x64:
>
>
>     #ifndef _WIN64
>                ,hash_mask               =
right_n_bits(hash_bits),
>                hash_mask_in_place       =
(address_word)hash_mask <<
>     hash_shift
>     #endif