Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-02 Thread TheShermanTanker 
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers  wrote:

> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was 
> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / 
> Socket.shutdownOutput() and InputStream.close() / OutputStream.close() 
> performed half-close of TLS-1.3 connection. However this behaviour has 
> changed as result of JDK-8216326 [2]. InputStream.close() / 
> OutputStream.close() no longer perform half-close but full socket close, but 
> API Note was never updated.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8208526
> [2] https://bugs.openjdk.java.net/browse/JDK-8216326

@zzambers I've created a corresponding issue for you in the tracker, please 
rename your PR title to 8282529 and the system should automatically mark your 
PR as ready for review

-

PR: https://git.openjdk.java.net/jdk/pull/7648

Re: RFR: 8282534: Remove redundant null check in ChaCha20Cipher.engineInit

2022-03-02 Thread TheShermanTanker 
On Thu, 10 Feb 2022 13:20:34 GMT, Andrey Turbanov  wrote:

> 8282534: Remove redundant null check in ChaCha20Cipher.engineInit

@turbanoff I've created an entry for you in the tracker, for your PR to be 
marked as ready for review please rename your PR title to 8282534 and the rest 
should be taken care of automatically (Do give it some time though)

-

PR: https://git.openjdk.java.net/jdk/pull/7424