Re: Code review request, re-integrate JEP 115 into JDK 8

2013-04-11 Thread Brad Wetmore 



On 4/8/2013 7:24 AM, Xuelei Fan wrote:

Hi,

Because of conflicts, we backed out the implementation of JEP 115. This
fix resolves the conflicts and re-integrates JEP 115 into JDK 8.  The
merge is straightforward except the updates in MAC.java, CipherBox.java,
EngineInputRecord.java and InputRecord.java.  As it looks more like a
changeset merge, it's OK to me if you only want to review the above 4 files.

old webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.03/
new webrev: http://cr.openjdk.java.net./~xuelei/8011680/webrev.00/


There was a minor comment about a comment I made privately to Xuelei, 
but not important enough to mention here.


I didn't notice anything else.  Crossing fingers!  ;)

Brad

Code review request, re-integrate JEP 115 into JDK 8

2013-04-08 Thread Xuelei Fan 
Hi,

Because of conflicts, we backed out the implementation of JEP 115. This
fix resolves the conflicts and re-integrates JEP 115 into JDK 8.  The
merge is straightforward except the updates in MAC.java, CipherBox.java,
EngineInputRecord.java and InputRecord.java.  As it looks more like a
changeset merge, it's OK to me if you only want to review the above 4 files.

old webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.03/
new webrev: http://cr.openjdk.java.net./~xuelei/8011680/webrev.00/

Thanks,
Xuelei