Re: RFR: 8257788: Class fields could be local in the SunJSSE provider

2020-12-06 Thread Aleksey Shipilev
On Fri, 4 Dec 2020 22:58:07 GMT, Xue-Lei Andrew Fan  wrote:

> In the SunJSSE provider implementation, there are a few class fields are not 
> used other than the constructors. Those fields could be removed and replaced 
> with local variables.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8257788

Looks fine to me.

-

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1634


Re: RFR: 8257788: Class fields could be local in the SunJSSE provider

2020-12-04 Thread Hai-May Chao
On Fri, 4 Dec 2020 22:58:07 GMT, Xue-Lei Andrew Fan  wrote:

> In the SunJSSE provider implementation, there are a few class fields are not 
> used other than the constructors. Those fields could be removed and replaced 
> with local variables.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8257788

Looks good to me.

-

PR: https://git.openjdk.java.net/jdk/pull/1634


RFR: 8257788: Class fields could be local in the SunJSSE provider

2020-12-04 Thread Xue-Lei Andrew Fan
In the SunJSSE provider implementation, there are a few class fields are not 
used other than the constructors. Those fields could be removed and replaced 
with local variables.

Bug: https://bugs.openjdk.java.net/browse/JDK-8257788

-

Commit messages:
 - 8257788: Class fields could be local in the SunJSSE provider

Changes: https://git.openjdk.java.net/jdk/pull/1634/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1634=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8257788
  Stats: 15 lines in 4 files changed: 0 ins; 11 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1634.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1634/head:pull/1634

PR: https://git.openjdk.java.net/jdk/pull/1634