Re: RFR: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails [v2]
On Tue, 26 Jan 2021 09:06:57 GMT, Fernando Guallini wrote: >> Fixing manual Test >> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java". >> It was not handling "weak algorithm" warning during jarsigner output >> verification > > Fernando Guallini has updated the pull request incrementally with one > additional commit since the last revision: > > add bugid and missing space Marked as reviewed by rhalade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2224
Re: RFR: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails [v2]
On Mon, 25 Jan 2021 22:57:04 GMT, Hai-May Chao wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add bugid and missing space > > Change copyright year to 2021 Thanks for the review - PR: https://git.openjdk.java.net/jdk/pull/2224
Re: RFR: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails [v2]
> Fixing manual Test > "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java". > It was not handling "weak algorithm" warning during jarsigner output > verification Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision: add bugid and missing space - Changes: - all: https://git.openjdk.java.net/jdk/pull/2224/files - new: https://git.openjdk.java.net/jdk/pull/2224/files/e3b011d9..b1162373 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2224&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2224&range=00-01 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/2224.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2224/head:pull/2224 PR: https://git.openjdk.java.net/jdk/pull/2224
Re: RFR: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
On Mon, 25 Jan 2021 17:08:45 GMT, Fernando Guallini wrote: > Fixing manual Test > "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java". > It was not handling "weak algorithm" warning during jarsigner output > verification Change copyright year to 2021 - PR: https://git.openjdk.java.net/jdk/pull/2224
Re: RFR: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
On Mon, 25 Jan 2021 22:45:31 GMT, Hai-May Chao wrote: >> Marked as reviewed by rhalade (Reviewer). > > Looks good. One comment: Add bug id to the changed test. Thanks. - PR: https://git.openjdk.java.net/jdk/pull/2224
Re: RFR: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
On Mon, 25 Jan 2021 21:51:19 GMT, Rajan Halade wrote: >> Fixing manual Test >> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java". >> It was not handling "weak algorithm" warning during jarsigner output >> verification > > Marked as reviewed by rhalade (Reviewer). Looks good. - PR: https://git.openjdk.java.net/jdk/pull/2224
Re: RFR: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
On Mon, 25 Jan 2021 17:08:45 GMT, Fernando Guallini wrote: > Fixing manual Test > "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java". > It was not handling "weak algorithm" warning during jarsigner output > verification Marked as reviewed by rhalade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2224
RFR: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
Fixing manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java". It was not handling "weak algorithm" warning during jarsigner output verification - Commit messages: - rename method - handle warning for SHA-1 weak algorithm Changes: https://git.openjdk.java.net/jdk/pull/2224/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2224&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260286 Stats: 19 lines in 2 files changed: 17 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2224.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2224/head:pull/2224 PR: https://git.openjdk.java.net/jdk/pull/2224
