Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3]

2022-03-03 Thread Rajan Halade
On Thu, 3 Mar 2022 16:31:41 GMT, Xue-Lei Andrew Fan  wrote:

>> May I have this test update reviewed?
>> 
>> The certificates used in SSL testing template SSLExampleCert could expired 
>> in the future (for example 
>> [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398)).  It is not 
>> always easy to replace the certificates if the template has been used a lot.
>> 
>> This update is trying to use a fixed validation date, so that even the 
>> certificates are expired the test will continue to work with no surprises.
>> 
>> I also did a few code clean up in this patch.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   typo introduced in bug ID

Marked as reviewed by rhalade (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/7651


Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3]

2022-03-03 Thread Xue-Lei Andrew Fan
> May I have this test update reviewed?
> 
> The certificates used in SSL testing template SSLExampleCert could expired in 
> the future (for example 
> [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398)).  It is not 
> always easy to replace the certificates if the template has been used a lot.
> 
> This update is trying to use a fixed validation date, so that even the 
> certificates are expired the test will continue to work with no surprises.
> 
> I also did a few code clean up in this patch.

Xue-Lei Andrew Fan has updated the pull request incrementally with one 
additional commit since the last revision:

  typo introduced in bug ID

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7651/files
  - new: https://git.openjdk.java.net/jdk/pull/7651/files/64c60b39..1099e4be

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=7651=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7651=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7651.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7651/head:pull/7651

PR: https://git.openjdk.java.net/jdk/pull/7651