Re: RFR: 8285516: clearPassword should be called in a finally try block [v2]

2022-05-05 Thread Xue-Lei Andrew Fan 
On Wed, 4 May 2022 17:35:13 GMT, Weijun Wang  wrote:

> Please merge your PR with master and I can run it for you.

Merged.  Thank you!

-

PR: https://git.openjdk.java.net/jdk/pull/8377

Re: RFR: 8285516: clearPassword should be called in a finally try block [v2]

2022-05-04 Thread Hai-May Chao 
On Mon, 25 Apr 2022 14:23:17 GMT, Xue-Lei Andrew Fan  wrote:

>> Hi,
>> 
>> Could I have the simple update reviewed?
>> 
>> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword() 
>> should be called in a finally try block.  Otherwise, the password cleanup 
>> could be interrupted by exceptions.
>> 
>> Thanks,
>> Xuelei
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   an extra whitespace added

Marked as reviewed by hchao (Committer).

-

PR: https://git.openjdk.java.net/jdk/pull/8377

Re: RFR: 8285516: clearPassword should be called in a finally try block [v2]

2022-05-04 Thread Weijun Wang 
On Mon, 25 Apr 2022 14:23:17 GMT, Xue-Lei Andrew Fan  wrote:

>> Hi,
>> 
>> Could I have the simple update reviewed?
>> 
>> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword() 
>> should be called in a finally try block.  Otherwise, the password cleanup 
>> could be interrupted by exceptions.
>> 
>> Thanks,
>> Xuelei
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   an extra whitespace added

Please merge your PR with master and I can run it for you.

-

PR: https://git.openjdk.java.net/jdk/pull/8377

Re: RFR: 8285516: clearPassword should be called in a finally try block [v2]

2022-05-04 Thread Xue-Lei Andrew Fan 
On Mon, 25 Apr 2022 14:23:17 GMT, Xue-Lei Andrew Fan  wrote:

>> Hi,
>> 
>> Could I have the simple update reviewed?
>> 
>> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword() 
>> should be called in a finally try block.  Otherwise, the password cleanup 
>> could be interrupted by exceptions.
>> 
>> Thanks,
>> Xuelei
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   an extra whitespace added

Could someone in Oracle help to run Mach5 testing (tier1 and tier2), just in 
case unexpected failure happens?

-

PR: https://git.openjdk.java.net/jdk/pull/8377

Re: RFR: 8285516: clearPassword should be called in a finally try block [v2]

2022-04-25 Thread Xue-Lei Andrew Fan 
> Hi,
> 
> Could I have the simple update reviewed?
> 
> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword() should 
> be called in a finally try block.  Otherwise, the password cleanup could be 
> interrupted by exceptions.
> 
> Thanks,
> Xuelei

Xue-Lei Andrew Fan has updated the pull request incrementally with one 
additional commit since the last revision:

  an extra whitespace added

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8377/files
  - new: https://git.openjdk.java.net/jdk/pull/8377/files/123374d1..99079d30

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8377=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8377=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8377.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8377/head:pull/8377

PR: https://git.openjdk.java.net/jdk/pull/8377