Re: RFR: 8285743: Ensure each IntegerPolynomial object is only created once [v2]
On Fri, 29 Apr 2022 22:57:20 GMT, Weijun Wang wrote: >> All `IntegerPolynimial`s are singletons now. Also, hand-coded >> implementations for Ed25519 and Ed448 are removed. They were not used since >> `FieldGen` starts generating classes for them. >> >> No new regression test. This is a clean-up. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > move singleton back into impl and make constructor private I'm good with this change - Marked as reviewed by ascarpino (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8476
Re: RFR: 8285743: Ensure each IntegerPolynomial object is only created once [v2]
On Fri, 29 Apr 2022 22:57:20 GMT, Weijun Wang wrote: >> All `IntegerPolynimial`s are singletons now. Also, hand-coded >> implementations for Ed25519 and Ed448 are removed. They were not used since >> `FieldGen` starts generating classes for them. >> >> No new regression test. This is a clean-up. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > move singleton back into impl and make constructor private It looks good and safe cleanup to me. - Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8476
Re: RFR: 8285743: Ensure each IntegerPolynomial object is only created once [v2]
On Fri, 29 Apr 2022 22:57:20 GMT, Weijun Wang wrote: >> All `IntegerPolynimial`s are singletons now. Also, hand-coded >> implementations for Ed25519 and Ed448 are removed. They were not used since >> `FieldGen` starts generating classes for them. >> >> No new regression test. This is a clean-up. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > move singleton back into impl and make constructor private make/jdk/src/classes/build/tools/intpoly/FieldGen.java line 837: > 835: // c[i + j] += 2 * a[i] * a[j] > 836: // } > 837: // } The comment was in the hand-coded curve25519 code. Moved here. - PR: https://git.openjdk.java.net/jdk/pull/8476
Re: RFR: 8285743: Ensure each IntegerPolynomial object is only created once [v2]
> All `IntegerPolynimial`s are singletons now. Also, hand-coded implementations > for Ed25519 and Ed448 are removed. They were not used since `FieldGen` starts > generating classes for them. > > No new regression test. This is a clean-up. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: move singleton back into impl and make constructor private - Changes: - all: https://git.openjdk.java.net/jdk/pull/8476/files - new: https://git.openjdk.java.net/jdk/pull/8476/files/b24ca783..331e9519 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8476=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8476=00-01 Stats: 54 lines in 8 files changed: 7 ins; 19 del; 28 mod Patch: https://git.openjdk.java.net/jdk/pull/8476.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8476/head:pull/8476 PR: https://git.openjdk.java.net/jdk/pull/8476
