Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 [v2]
On Thu, 9 Jun 2022 22:29:36 GMT, Jamil Nimeh wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> verb > > src/java.base/share/classes/sun/security/util/math/IntegerModuloP.java line > 161: > >> 159: // This method is used in 2 cases: >> 160: // 1. To calculate the inverse of a number in ECDSAOperations, >> 161: //this number must be non zero (modulus p). > > Should that be "modulo p"? Other than that it looks good to me. Yes, it's a verb here. - PR: https://git.openjdk.org/jdk/pull/9115
Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 [v2]
On Thu, 9 Jun 2022 23:10:05 GMT, Weijun Wang wrote: >> Add comment to the method. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > verb Thanks, LGTM. - Marked as reviewed by jnimeh (Reviewer). PR: https://git.openjdk.org/jdk/pull/9115
Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 [v2]
> Add comment to the method. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: verb - Changes: - all: https://git.openjdk.org/jdk/pull/9115/files - new: https://git.openjdk.org/jdk/pull/9115/files/36741bba..15ef85fe Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9115=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9115=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/9115.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9115/head:pull/9115 PR: https://git.openjdk.org/jdk/pull/9115
