Re: RFR 8210786 : Typo s/overriden/overridden/ in several places
This makes sense. No other comment. Thanks Max > 在 2018年9月16日，05:10，Ivan Gerasimov 写道： > > Hi Max! > > >> On 9/15/18 6:28 AM, Weijun Wang wrote: >> In the bug description you listed some in jdk/internal/org/objectweb/asm, >> but they are not included in the fix. Is it because those are not doc only >> but inside source code? > For the ASM changes, I thought it may be better to fix them in the upstream > project. > I don't know how/if the ASM sources in OpenJDK are updated. If they are not, > then it may make sense to fix these typos too. > >> There are similar typos in other modules as well. Any reason not to include >> them. > Yep, there are 200+ occurrences in other modules, mostly in java.desktop. I > think I'll create another separate issue and will assign it to someone from > the jdk client team. > >> Thanks >> Max >> >>> On Sep 15, 2018, at 2:03 PM, Ivan Gerasimov >>> wrote: >>> >>> Hello! >>> >>> This is a followup of the fix of JDK-8210785 (Trivial typo fix in >>> X509ExtendedKeyManager javadoc). >>> >>> A few more occurrences of the typo were found. >>> >>> Would you please help review? >>> >>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8210786 >>> WEBREV: http://cr.openjdk.java.net/~igerasim/8210786/00/webrev/ >>> >>> -- >>> With kind regards, >>> Ivan Gerasimov >>> >> > > -- > With kind regards, > Ivan Gerasimov >
Re: RFR 8210786 : Typo s/overriden/overridden/ in several places
Hi Max! On 9/15/18 6:28 AM, Weijun Wang wrote: In the bug description you listed some in jdk/internal/org/objectweb/asm, but they are not included in the fix. Is it because those are not doc only but inside source code? For the ASM changes, I thought it may be better to fix them in the upstream project. I don't know how/if the ASM sources in OpenJDK are updated. If they are not, then it may make sense to fix these typos too. There are similar typos in other modules as well. Any reason not to include them. Yep, there are 200+ occurrences in other modules, mostly in java.desktop. I think I'll create another separate issue and will assign it to someone from the jdk client team. Thanks Max On Sep 15, 2018, at 2:03 PM, Ivan Gerasimov wrote: Hello! This is a followup of the fix of JDK-8210785 (Trivial typo fix in X509ExtendedKeyManager javadoc). A few more occurrences of the typo were found. Would you please help review? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8210786 WEBREV: http://cr.openjdk.java.net/~igerasim/8210786/00/webrev/ -- With kind regards, Ivan Gerasimov -- With kind regards, Ivan Gerasimov
Re: RFR 8210786 : Typo s/overriden/overridden/ in several places
In the bug description you listed some in jdk/internal/org/objectweb/asm, but they are not included in the fix. Is it because those are not doc only but inside source code? There are similar typos in other modules as well. Any reason not to include them. Thanks Max > On Sep 15, 2018, at 2:03 PM, Ivan Gerasimov wrote: > > Hello! > > This is a followup of the fix of JDK-8210785 (Trivial typo fix in > X509ExtendedKeyManager javadoc). > > A few more occurrences of the typo were found. > > Would you please help review? > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8210786 > WEBREV: http://cr.openjdk.java.net/~igerasim/8210786/00/webrev/ > > -- > With kind regards, > Ivan Gerasimov >
RFR 8210786 : Typo s/overriden/overridden/ in several places
Hello! This is a followup of the fix of JDK-8210785 (Trivial typo fix in X509ExtendedKeyManager javadoc). A few more occurrences of the typo were found. Would you please help review? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8210786 WEBREV: http://cr.openjdk.java.net/~igerasim/8210786/00/webrev/ -- With kind regards, Ivan Gerasimov
