Re: RFR 8242811: AlgorithmId::getDefaultAlgorithmParameterSpec returns incompatible PSSParameterSpec for an RSASSA-PSS key

2020-04-17 Thread Hai-May Chao 
Changes good to me.

Hai-May


> On Apr 17, 2020, at 3:27 PM, Valerie Peng  wrote:
> 
> 
> Changes look good~
> 
> Valerie
> 
> On 4/15/2020 3:34 AM, Weijun Wang wrote:
>> Please take a review at
>> 
>>https://cr.openjdk.java.net/~weijun/8242811/webrev.00/
>> 
>> The AlgorithmId::getDefaultAlgorithmParameterSpec method is used internally 
>> to retrieve a default AlgorithmParameterSpec to initialize a Signature, 
>> mainly be keytool.
>> 
>> The test shows a case where it can be called.
>> 
>> Thanks,
>> Max
>>

Re: RFR 8242811: AlgorithmId::getDefaultAlgorithmParameterSpec returns incompatible PSSParameterSpec for an RSASSA-PSS key

2020-04-17 Thread Valerie Peng 



Changes look good~

Valerie

On 4/15/2020 3:34 AM, Weijun Wang wrote:

Please take a review at

https://cr.openjdk.java.net/~weijun/8242811/webrev.00/

The AlgorithmId::getDefaultAlgorithmParameterSpec method is used internally to 
retrieve a default AlgorithmParameterSpec to initialize a Signature, mainly be 
keytool.

The test shows a case where it can be called.

Thanks,
Max

RFR 8242811: AlgorithmId::getDefaultAlgorithmParameterSpec returns incompatible PSSParameterSpec for an RSASSA-PSS key

2020-04-15 Thread Weijun Wang 
Please take a review at

   https://cr.openjdk.java.net/~weijun/8242811/webrev.00/

The AlgorithmId::getDefaultAlgorithmParameterSpec method is used internally to 
retrieve a default AlgorithmParameterSpec to initialize a Signature, mainly be 
keytool.

The test shows a case where it can be called.

Thanks,
Max