Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-09 Thread Sibabrata Sahoo 
On Thu, 9 Jun 2022 21:12:26 GMT, Sean Mullan  wrote:

>> Sibabrata Sahoo has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8209935: Test to cover CodeSource.getCodeSigners()
>
> test/jdk/java/security/CodeSource/CertsMatch.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 6299163
>> 27:  * @summary REGRESSION: java.security.CodeSource#equals not symmetric
> 
> I think you should remove this line about "REGRESSION" as the summary is 
> supposed to be about what the test is testing. Suggest changing this to 
> summarize what methods are being tested.

Updated the summary.

-

PR: https://git.openjdk.org/jdk/pull/8286

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-09 Thread Sean Mullan 
On Wed, 8 Jun 2022 10:30:45 GMT, Sibabrata Sahoo  wrote:

>> A Test updated to cover the getCodeSigners.
>
> Sibabrata Sahoo has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8209935: Test to cover CodeSource.getCodeSigners()

Marked as reviewed by mullan (Reviewer).

test/jdk/java/security/CodeSource/CertsMatch.java line 27:

> 25:  * @test
> 26:  * @bug 6299163
> 27:  * @summary REGRESSION: java.security.CodeSource#equals not symmetric

I think you should remove this line about "REGRESSION" as the summary is 
supposed to be about what the test is testing. Suggest changing this to 
summarize what methods are being tested.

-

PR: https://git.openjdk.org/jdk/pull/8286

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-08 Thread Sibabrata Sahoo 
> A Test updated to cover the getCodeSigners.

Sibabrata Sahoo has updated the pull request incrementally with one additional 
commit since the last revision:

  8209935: Test to cover CodeSource.getCodeSigners()

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8286/files
  - new: https://git.openjdk.java.net/jdk/pull/8286/files/c6318862..512cb615

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8286=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8286=02-03

  Stats: 144 lines in 2 files changed: 144 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8286.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8286/head:pull/8286

PR: https://git.openjdk.java.net/jdk/pull/8286