Re: code review request, CR 7166570: JSSE certificate validation has started to fail for certificate chains

2012-05-08 Thread Brad Wetmore 

Hi Xuelei,

I walked through the code in the debugger, it looks good.

Just a comment for the regression test, it might have been easier and 
likely faster performance-wise to simply create Simple and PKIX 
trustmanagers, and then directly call checkClientTrusted and passing a 
predefined chain, rather than incurring the overhead of SSL, much of 
what we cover in many other tests.


Brad


On 5/5/2012 8:06 AM, Xuelei Fan wrote:

The webrev URL should be:
http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev.00/

Xuelei

On 5/5/2012 9:38 PM, Xuelei Fan wrote:

Hi,

Please review the fix for JSSE certification path validation issue.

webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev/

Cause of the issue: in SimpleValiadtor, the count pathLenConstraint was
not calculated properly, the non-intermediate certificate (end-entity
certificate) was count in.

Thanks,
Xuelei

Re: code review request, CR 7166570: JSSE certificate validation has started to fail for certificate chains

2012-05-06 Thread Xuelei Fan 
Brad, thanks for the correct. The URL should be:
http://cr.openjdk.java.net/~xuelei/7166570/webrev.00/

Thanks,
Xuelei


On 5/6/2012 1:32 PM, Bradford Wetmore wrote:
 Hi Xuelei,
 
 Can you put these CR requests on cr.openjdk.java.net?  I can't see them
 from home.
 
 Brad
 
 On 5/5/2012 8:06 AM, Xuelei Fan wrote:
 The webrev URL should be:
 http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev.00/

 Xuelei

 On 5/5/2012 9:38 PM, Xuelei Fan wrote:
 Hi,

 Please review the fix for JSSE certification path validation issue.

 webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev/

 Cause of the issue: in SimpleValiadtor, the count pathLenConstraint was
 not calculated properly, the non-intermediate certificate (end-entity
 certificate) was count in.

 Thanks,
 Xuelei

code review request, CR 7166570: JSSE certificate validation has started to fail for certificate chains

2012-05-05 Thread Xuelei Fan 
Hi,

Please review the fix for JSSE certification path validation issue.

webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev/

Cause of the issue: in SimpleValiadtor, the count pathLenConstraint was
not calculated properly, the non-intermediate certificate (end-entity
certificate) was count in.

Thanks,
Xuelei

Re: code review request, CR 7166570: JSSE certificate validation has started to fail for certificate chains

2012-05-05 Thread Xuelei Fan 
The webrev URL should be:
http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev.00/

Xuelei

On 5/5/2012 9:38 PM, Xuelei Fan wrote:
 Hi,
 
 Please review the fix for JSSE certification path validation issue.
 
 webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev/
 
 Cause of the issue: in SimpleValiadtor, the count pathLenConstraint was
 not calculated properly, the non-intermediate certificate (end-entity
 certificate) was count in.
 
 Thanks,
 Xuelei

Re: code review request, CR 7166570: JSSE certificate validation has started to fail for certificate chains

2012-05-05 Thread Bradford Wetmore 

Hi Xuelei,

Can you put these CR requests on cr.openjdk.java.net?  I can't see them 
from home.


Brad

On 5/5/2012 8:06 AM, Xuelei Fan wrote:

The webrev URL should be:
http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev.00/

Xuelei

On 5/5/2012 9:38 PM, Xuelei Fan wrote:

Hi,

Please review the fix for JSSE certification path validation issue.

webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev/

Cause of the issue: in SimpleValiadtor, the count pathLenConstraint was
not calculated properly, the non-intermediate certificate (end-entity
certificate) was count in.

Thanks,
Xuelei