Re: [jdk18] RFR: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 [v3]
On Tue, 4 Jan 2022 06:59:58 GMT, Aleksey Shipilev wrote: >> SonarCloud reports: >> A "Map" cannot contain a "String" in a "ServiceKey" >> type. >> >> >> // clean up old alias if present >> Service prevAliasService = legacyMap.get(aliasAlg); >> >> >> Should be `aliasKey`, like other accesses to `legacyMap`. This code is >> introduced by >> [JDK-8276660](https://bugs.openjdk.java.net/browse/JDK-8276660), so it >> affects JDK 18. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug `jdk_security` > > Aleksey Shipilev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Whitespace > - Metadata updates > - Merge branch 'master' into JDK-8279222-jsp-get > - Test addition by Valerie > - Merge branch 'master' into JDK-8279222-jsp-get > - Fix Thanks for coordinating on this to ensure the change has a test. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk18/pull/70
Re: [jdk18] RFR: 8278897: Alignment of heap segments is not enforced correctly [v2]
> This PR fixes an issue with alignment constraints not being enforced > correctly on on-heap segments dereference/copy operations. Alignment of > on-heap segments cannot be computed exactly, as alignment of elements in > arrays is, ultimately a VM implementation detail. Because of this, alignment > checks on heap segments can fail or pass depending on the platform being used. > > For more details about the problem and the solution please refer to: > https://mail.openjdk.java.net/pipermail/panama-dev/2021-November/015852.html Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into heap-align - Initial push - Changes: - all: https://git.openjdk.java.net/jdk18/pull/37/files - new: https://git.openjdk.java.net/jdk18/pull/37/files/40a3acc3..3a860afa Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk18&pr=37&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk18&pr=37&range=00-01 Stats: 2046 lines in 116 files changed: 1430 ins; 125 del; 491 mod Patch: https://git.openjdk.java.net/jdk18/pull/37.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/37/head:pull/37 PR: https://git.openjdk.java.net/jdk18/pull/37
Re: [jdk18] RFR: 8278897: Alignment of heap segments is not enforced correctly [v2]
On Tue, 4 Jan 2022 11:39:08 GMT, Maurizio Cimadamore wrote: >> This PR fixes an issue with alignment constraints not being enforced >> correctly on on-heap segments dereference/copy operations. Alignment of >> on-heap segments cannot be computed exactly, as alignment of elements in >> arrays is, ultimately a VM implementation detail. Because of this, alignment >> checks on heap segments can fail or pass depending on the platform being >> used. >> >> For more details about the problem and the solution please refer to: >> https://mail.openjdk.java.net/pipermail/panama-dev/2021-November/015852.html > > Maurizio Cimadamore has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into heap-align > - Initial push Marked as reviewed by jvernee (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/37
Re: [jdk18] RFR: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 [v3]
On Tue, 4 Jan 2022 06:59:58 GMT, Aleksey Shipilev wrote: >> SonarCloud reports: >> A "Map" cannot contain a "String" in a "ServiceKey" >> type. >> >> >> // clean up old alias if present >> Service prevAliasService = legacyMap.get(aliasAlg); >> >> >> Should be `aliasKey`, like other accesses to `legacyMap`. This code is >> introduced by >> [JDK-8276660](https://bugs.openjdk.java.net/browse/JDK-8276660), so it >> affects JDK 18. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug `jdk_security` > > Aleksey Shipilev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Whitespace > - Metadata updates > - Merge branch 'master' into JDK-8279222-jsp-get > - Test addition by Valerie > - Merge branch 'master' into JDK-8279222-jsp-get > - Fix Marked as reviewed by valeriep (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/70
[jdk18] Integrated: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660
On Thu, 23 Dec 2021 13:33:26 GMT, Aleksey Shipilev wrote: > SonarCloud reports: > A "Map" cannot contain a "String" in a "ServiceKey" > type. > > > // clean up old alias if present > Service prevAliasService = legacyMap.get(aliasAlg); > > > Should be `aliasKey`, like other accesses to `legacyMap`. This code is > introduced by > [JDK-8276660](https://bugs.openjdk.java.net/browse/JDK-8276660), so it > affects JDK 18. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk_security` This pull request has now been integrated. Changeset: 0f4807e8 Author:Aleksey Shipilev URL: https://git.openjdk.java.net/jdk18/commit/0f4807e8fe2468f303b32a6f2dc9ccc7ecad82a1 Stats: 18 lines in 2 files changed: 12 ins; 0 del; 6 mod 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 Co-authored-by: Valerie Peng Reviewed-by: alanb, valeriep - PR: https://git.openjdk.java.net/jdk18/pull/70
Re: [jdk18] RFR: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 [v3]
On Tue, 4 Jan 2022 06:59:58 GMT, Aleksey Shipilev wrote: >> SonarCloud reports: >> A "Map" cannot contain a "String" in a "ServiceKey" >> type. >> >> >> // clean up old alias if present >> Service prevAliasService = legacyMap.get(aliasAlg); >> >> >> Should be `aliasKey`, like other accesses to `legacyMap`. This code is >> introduced by >> [JDK-8276660](https://bugs.openjdk.java.net/browse/JDK-8276660), so it >> affects JDK 18. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug `jdk_security` > > Aleksey Shipilev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Whitespace > - Metadata updates > - Merge branch 'master' into JDK-8279222-jsp-get > - Test addition by Valerie > - Merge branch 'master' into JDK-8279222-jsp-get > - Fix Thanks for reviews! - PR: https://git.openjdk.java.net/jdk18/pull/70
