Integrated: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider
On Tue, 24 May 2022 16:29:02 GMT, Sean Mullan wrote: > Please review this fix to the XML Signature implementation to check for null > or missing DSA parameters and throw a MarshalException before trying to > create a DSA public key from its XML encoding. This will allow the code to > fail earlier and not depend on the underlying provider to detect illegal or > missing parameters. This pull request has now been integrated. Changeset: f235955e Author:Sean Mullan URL: https://git.openjdk.java.net/jdk/commit/f235955eefb1141a2e72116dfcf345e40416f059 Stats: 30 lines in 1 file changed: 0 ins; 12 del; 18 mod 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider Reviewed-by: weijun - PR: https://git.openjdk.java.net/jdk/pull/8870
Integrated: 8286045: Use ForceGC for cleaner test cases
On Wed, 25 May 2022 15:20:45 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have the test case update reviewed? > > This patch is trying to use ForceGC for cleaner test cases. As would make > the test more stable and easier to maintain. > > Thanks, > Xuelei This pull request has now been integrated. Changeset: 7eb15593 Author:Xue-Lei Andrew Fan URL: https://git.openjdk.java.net/jdk/commit/7eb15593e18a923bbc18c8d596cff87d87019640 Stats: 57 lines in 3 files changed: 19 ins; 28 del; 10 mod 8286045: Use ForceGC for cleaner test cases Reviewed-by: rriggs - PR: https://git.openjdk.java.net/jdk/pull/8885
Re: RFR: 8282662: Use List.of() factory method to reduce memory consumption [v6]
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with > smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when > called with vararg of size 0, 1, 2. > > In general replacement of `Arrays.asList()` with `List.of()` is dubious as > the latter is null-hostile, however in some cases we are sure that arguments > are non-null. Into this PR I've included the following cases (in addition to > those where the argument is proved to be non-null at compile-time): > - `MethodHandles.longestParameterList()` never returns null > - parameter types are never null > - interfaces used for proxy construction and returned from > `Class.getInterfaces()` are never null > - exceptions types of method signature are never null Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - 8282662: Revert wrong copyright year change - 8282662: Revert ProxyGenerator - 8282662: Revert ProxyGenerator - 8282662: Revert dubious changes in MethodType - 8282662: Revert dubious changes - 8282662: Use List/Set.of() factory methods to save memory - Changes: https://git.openjdk.java.net/jdk/pull/7729/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7729=05 Stats: 12 lines in 4 files changed: 1 ins; 2 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/7729.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7729/head:pull/7729 PR: https://git.openjdk.java.net/jdk/pull/7729