Re: RFR: JDK-8259786: initialize last parameter of getpwuid_r [v4]

[Martin Doerr]

On Wed, 20 Jan 2021 12:05:03 GMT, Matthias Baesken  wrote:

>> We have a couple of calls to getpwuid_r  in the codebase, like 
>> g= getpwuid_r(getuid(), &resbuf, pwd_buf, sizeof(pwd_buf), &pwd);
>> 
>> Usually we NULL-check pwd after the call because we do not fully trust the 
>> return code of the function (it is documented in the codebase why we do not 
>> fully trust the return code) . However we miss to initialize pwd at some 
>> places before the call, which might we a little problematic and should be 
>> improved   (at other places we already initialize it).
>> 
>> This triggers also Sonar warnings like :
>> https://sonarcloud.io/project/issues?id=jdk&open=AXaE0dsA8L9hkQskGEbA&resolved=false&types=BUG
>> 
>> 
>> Aside from this issue ,  should we in other issue ,  unify the OS versions 
>> of  static char* get_user_name(uid_t uid)in posix code (currently we 
>> have it for bsd, linux, aix  but the functions look very similar ?
>
> Matthias Baesken has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains five commits:
> 
>  - bring initialization to perfMemory_posix
>  - Merge branch 'master' into JDK-8259786
>  - More revert
>  - revert perfMemory changes
>  - JDK-8259786

Marked as reviewed by mdoerr (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/2098

Re: RFR: JDK-8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

[Martin Doerr]

On Thu, 9 Dec 2021 08:25:17 GMT, Matthias Baesken  wrote:

> Please review this small test fix.
> KeytoolOpensslInteropTest.java fails with the output below.
> Seems on our SUSE Linux 15 (openssl is
> ~> openssl version
> OpenSSL 1.1.0i-fips 14 Aug 2018
> ) we get a slightly different output with a blank missing after "MAC:" :
> 
> :stdErr:
> Mon Dec 06 21:54:48 CET 2021
> stdout: [];
> stderr: [MAC:sha256 Iteration 1
>  . . .
> java.lang.RuntimeException: 'MAC: sha256, Iteration 1' missing from 
> stdout/stderr
> 
> So it is necessary to adjust the test to the other openssl version.

LGTM.

-

Marked as reviewed by mdoerr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6779