On Wed, Jul 5, 2017 at 9:15 AM, Dan Jurgens wrote:
> From: Daniel Jurgens
>
> ib_get_cached_subnet_prefix can technically fail, but the only way it
> could is not possible based on the loop conditions. Check the return
> value before using the variable sp to resolve a static analysis warning.
>
> Fixes: 8f408ab64be6 ("selinux lsm IB/core: Implement LSM notification
> system")
> Signed-off-by: Daniel Jurgens
> Reported-by: Dan Carpenter
>
> -v1:
> - Fix check to !ret. Paul Moore
> ---
> drivers/infiniband/core/device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks for the update, merged. I'm doing a sanity build right now,
assuming all goes well I'll send this up tomorrow.
> diff --git a/drivers/infiniband/core/device.c
> b/drivers/infiniband/core/device.c
> index 631eaa9..a5dfab6 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -376,7 +376,8 @@ static void ib_policy_change_task(struct work_struct
> *work)
> WARN_ONCE(ret,
> "ib_get_cached_subnet_prefix err: %d, this
> should never happen here\n",
> ret);
> - ib_security_cache_change(dev, i, sp);
> + if (!ret)
> + ib_security_cache_change(dev, i, sp);
> }
> }
> up_read(&lists_rwsem);
> --
> 1.8.3.1
--
paul moore
www.paul-moore.com
