Re: Why doesn't add_column :field, :boolean, index: true create an index?

2022-04-20 Thread aryk....@gmail.com
Sorry for the late reply here Jeremy. 

Thanks again for looking into this. I had to go back and add like like 100 
indexes on my foreign keys on my 2 year old project lol.

Aryk

On Sunday, March 27, 2022 at 4:17:33 PM UTC-7 Jeremy Evans wrote:

> On Sun, Mar 27, 2022 at 3:34 PM aryk@gmail.com  
> wrote:
>
>> When I create a new table I can put:
>>
>> create_table :foo do 
>>   column :bar, TrueClass, index: true
>> end
>>
>> and it creates an index, but "index: true" doesn't work with add_column 
>> and instead doesn't throw any error, so you think you are adding an index, 
>> but really you are not.
>>
>> Why this inconsistency?
>>
>
> Historical reasons I would guess, as it was like that when I took over 
> maintenance in 2008.  Not raising an error is expected, since unhandled 
> options generally do not raise an error in Sequel (this is also the 
> historical behavior).
>
> I suppose we could start handling :index in add_column.  I'll look into 
> doing that, probably after the release of 5.55.0.
>
> Thanks,
> Jeremy
>

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sequel-talk+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sequel-talk/db76c335-4b73-43f5-a186-6d5787c0291en%40googlegroups.com.


Re: Why doesn't add_column :field, :boolean, index: true create an index?

2022-03-27 Thread Jeremy Evans
On Sun, Mar 27, 2022 at 3:34 PM aryk@gmail.com 
wrote:

> When I create a new table I can put:
>
> create_table :foo do
>   column :bar, TrueClass, index: true
> end
>
> and it creates an index, but "index: true" doesn't work with add_column
> and instead doesn't throw any error, so you think you are adding an index,
> but really you are not.
>
> Why this inconsistency?
>

Historical reasons I would guess, as it was like that when I took over
maintenance in 2008.  Not raising an error is expected, since unhandled
options generally do not raise an error in Sequel (this is also the
historical behavior).

I suppose we could start handling :index in add_column.  I'll look into
doing that, probably after the release of 5.55.0.

Thanks,
Jeremy

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sequel-talk+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sequel-talk/CADGZSSeqR6nhiZ%3DJtVyjcNixwExh2hr-DbD%2BccdVFpmTMBisDg%40mail.gmail.com.