[2/2] james-project git commit: JAMES-1717 Make VacationIntegrationTest less timing dependent
JAMES-1717 Make VacationIntegrationTest less timing dependent
If the calls to get the Mailbox INBOX was done before its creation, tests fails
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/a951004f
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/a951004f
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/a951004f
Branch: refs/heads/master
Commit: a951004f457d23a785a3658d1929e1c89c42f7d1
Parents: b2d1726
Author: Benoit Tellier
Authored: Tue May 24 14:58:27 2016 +0700
Committer: Benoit Tellier
Committed: Wed May 25 09:59:50 2016 +0700
--
.../test/java/org/apache/james/jmap/VacationIntegrationTest.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/james-project/blob/a951004f/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/VacationIntegrationTest.java
--
diff --git
a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/VacationIntegrationTest.java
b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/VacationIntegrationTest.java
index c2672bc..75b5202 100644
---
a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/VacationIntegrationTest.java
+++
b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/VacationIntegrationTest.java
@@ -74,6 +74,8 @@ public abstract class VacationIntegrationTest {
guiceJamesServer.serverProbe().createMailbox(MailboxConstants.USER_NAMESPACE,
USER_2, "outbox");
guiceJamesServer.serverProbe().createMailbox(MailboxConstants.USER_NAMESPACE,
USER_1, "sent");
guiceJamesServer.serverProbe().createMailbox(MailboxConstants.USER_NAMESPACE,
USER_2, "sent");
+
guiceJamesServer.serverProbe().createMailbox(MailboxConstants.USER_NAMESPACE,
USER_1, "INBOX");
+
guiceJamesServer.serverProbe().createMailbox(MailboxConstants.USER_NAMESPACE,
USER_2, "INBOX");
await();
@@ -168,7 +170,6 @@ public abstract class VacationIntegrationTest {
*/
// Given
-
guiceJamesServer.serverProbe().createMailbox(MailboxConstants.USER_NAMESPACE,
USER_2, "INBOX");
AccessToken user1AccessToken =
JmapAuthentication.authenticateJamesUser(USER_1, PASSWORD);
AccessToken user2AccessToken =
JmapAuthentication.authenticateJamesUser(USER_2, PASSWORD);
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[1/2] james-project git commit: JAMES-1717 ActiveMQ broker should use temporary folder
Repository: james-project
Updated Branches:
refs/heads/master 1ed51b587 -> a951004f4
JAMES-1717 ActiveMQ broker should use temporary folder
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/b2d17265
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/b2d17265
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/b2d17265
Branch: refs/heads/master
Commit: b2d1726503cbd6129a14762b58886a031782185f
Parents: 1ed51b5
Author: Benoit Tellier
Authored: Tue May 24 16:33:48 2016 +0700
Committer: Benoit Tellier
Committed: Tue May 24 16:40:19 2016 +0700
--
.../java/org/apache/james/modules/server/EmbeddedActiveMQ.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/james-project/blob/b2d17265/server/container/guice/guice-common/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java
--
diff --git
a/server/container/guice/guice-common/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java
b/server/container/guice/guice-common/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java
index 748ae5b..2c38535 100644
---
a/server/container/guice/guice-common/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java
+++
b/server/container/guice/guice-common/src/main/java/org/apache/james/modules/server/EmbeddedActiveMQ.java
@@ -43,7 +43,7 @@ public class EmbeddedActiveMQ {
@Inject private EmbeddedActiveMQ(FileSystem fileSystem) {
try {
-launchEmbeddedBroker();
+launchEmbeddedBroker(fileSystem);
} catch (Exception e) {
throw Throwables.propagate(e);
}
@@ -80,12 +80,12 @@ public class EmbeddedActiveMQ {
return blobTransferPolicy;
}
-private void launchEmbeddedBroker() throws Exception {
+private void launchEmbeddedBroker(FileSystem fileSystem) throws Exception {
brokerService = new BrokerService();
brokerService.setBrokerName("james");
brokerService.setUseJmx(false);
brokerService.setPersistent(true);
-
brokerService.setDataDirectory("filesystem=file://var/store/activemq/brokers");
+
brokerService.setDataDirectoryFile(fileSystem.getFile("file://var/store/activemq/brokers"));
brokerService.setUseShutdownHook(false);
brokerService.setSchedulerSupport(false);
brokerService.setBrokerId("broker");
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JDKIM-36) DKIMVerifier returns only valid signatures if a message is signed multiple times and some signature does not pass
[ https://issues.apache.org/jira/browse/JDKIM-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298168#comment-15298168 ] Eric Charles commented on JDKIM-36: --- Sure, please open a PR on https://github.com/apache/james-jdkim/commits/master. We will review it. > DKIMVerifier returns only valid signatures if a message is signed multiple > times and some signature does not pass > - > > Key: JDKIM-36 > URL: https://issues.apache.org/jira/browse/JDKIM-36 > Project: James jDKIM > Issue Type: Bug >Affects Versions: 0.2 >Reporter: Enrico Olivelli >Priority: Blocker > > If a message contains a DKIM-Signature header which passes and one which does > not pass the verify method will return no error and return the list of valid > signatures. > Please provide an alternative method which gives the full result of the > validation -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-1738) Onami have reached end of life
[ https://issues.apache.org/jira/browse/JAMES-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298162#comment-15298162 ] Eric Charles commented on JAMES-1738: - I tried to prolonge onami life with luck... (active PMC was too small). Now we have to find an alternative to onami goodies. Would https://github.com/Netflix/governator do the job? > Onami have reached end of life > -- > > Key: JAMES-1738 > URL: https://issues.apache.org/jira/browse/JAMES-1738 > Project: James Server > Issue Type: Bug > Components: guice >Affects Versions: Trunk >Reporter: Tellier Benoit > Fix For: Trunk > > > As stated in https://onami.apache.org/lifecycle/ > 2016/02/07 - Apache Onami has been retired. > Thus the jar can not be found in the Apache snapshot repositories. > We are using Onami for Guice and MPT. For @PostConstruct and @PreDestroy. MPT > tests also relies heavily on MPT as it is used to run tests against specific > Guice modules. Getting a rid of Onami will require also rethiking genericity > of MPT tests. > We should see alternate libraries to achieve these functionnalities. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JDKIM-36) DKIMVerifier returns only valid signatures if a message is signed multiple times and some signature does not pass
[ https://issues.apache.org/jira/browse/JDKIM-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297809#comment-15297809 ] Enrico Olivelli commented on JDKIM-36: -- can I submit a patch for this ? > DKIMVerifier returns only valid signatures if a message is signed multiple > times and some signature does not pass > - > > Key: JDKIM-36 > URL: https://issues.apache.org/jira/browse/JDKIM-36 > Project: James jDKIM > Issue Type: Bug >Affects Versions: 0.2 >Reporter: Enrico Olivelli >Priority: Blocker > > If a message contains a DKIM-Signature header which passes and one which does > not pass the verify method will return no error and return the list of valid > signatures. > Please provide an alternative method which gives the full result of the > validation -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
