[jira] [Resolved] (JAMES-1787) Document attachment inline limitation

2016-07-03 Thread Antoine Duprat (JIRA) 

 [ 
https://issues.apache.org/jira/browse/JAMES-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antoine Duprat resolved JAMES-1787.
---
Resolution: Fixed

merged

> Document attachment inline limitation
> -
>
> Key: JAMES-1787
> URL: https://issues.apache.org/jira/browse/JAMES-1787
> Project: James Server
>  Issue Type: Bug
>  Components: JMAP
>Reporter: Raphaël Ouazana
>Assignee: Antoine Duprat
>
> Attachments are now supported, but inlined attachments are still not.
> We should document it, and so write an acceptance test that will be ignored 
> now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Closed] (JAMES-1787) Document attachment inline limitation

2016-07-03 Thread Antoine Duprat (JIRA) 

 [ 
https://issues.apache.org/jira/browse/JAMES-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antoine Duprat closed JAMES-1787.
-

> Document attachment inline limitation
> -
>
> Key: JAMES-1787
> URL: https://issues.apache.org/jira/browse/JAMES-1787
> Project: James Server
>  Issue Type: Bug
>  Components: JMAP
>Reporter: Raphaël Ouazana
>Assignee: Antoine Duprat
>
> Attachments are now supported, but inlined attachments are still not.
> We should document it, and so write an acceptance test that will be ignored 
> now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[1/2] james-project git commit: JAMES-1787 Document inlined attachments status

2016-07-03 Thread aduprat 
Repository: james-project
Updated Branches:
  refs/heads/master b6e967de7 -> aba9b9213


JAMES-1787 Document inlined attachments status


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/aba9b921
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/aba9b921
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/aba9b921

Branch: refs/heads/master
Commit: aba9b9213ac4264e757088e2369f1e88ab9d4015
Parents: 4986bca
Author: Raphael Ouazana 
Authored: Thu Jun 30 11:40:25 2016 +0200
Committer: Raphael Ouazana 
Committed: Fri Jul 1 17:34:01 2016 +0200

--
 server/protocols/jmap/doc/specs/spec/message.mdwn | 3 +++
 1 file changed, 3 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/james-project/blob/aba9b921/server/protocols/jmap/doc/specs/spec/message.mdwn
--
diff --git a/server/protocols/jmap/doc/specs/spec/message.mdwn 
b/server/protocols/jmap/doc/specs/spec/message.mdwn
index ab144cb..55d9523 100644
--- a/server/protocols/jmap/doc/specs/spec/message.mdwn
+++ b/server/protocols/jmap/doc/specs/spec/message.mdwn
@@ -112,6 +112,9 @@ An **Attachment** object has the following properties:
   The id used within the message body to reference this attachment. This is 
only unique when paired with the message id, and has no meaning without 
reference to that.
 - **isInline**: `Boolean`
   True if the attachment is referenced by a `cid:` link from within the HTML 
body of the message.
+  
+  Inlined attachments are not parsed yet.
+  
 - **width**: `Number|null`
   The width (in px) of the image, if the attachment is an image.
 - **height**: `Number|null`


-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[2/2] james-project git commit: JAMES-1787 Add acceptance test for inline attachment

2016-07-03 Thread aduprat 
JAMES-1787 Add acceptance test for inline attachment


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/4986bca6
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/4986bca6
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/4986bca6

Branch: refs/heads/master
Commit: 4986bca6ff9a826cf52ba1595799e7ad1909ca8c
Parents: b6e967d
Author: Raphael Ouazana 
Authored: Thu Jun 30 11:36:02 2016 +0200
Committer: Raphael Ouazana 
Committed: Fri Jul 1 17:34:01 2016 +0200

--
 .../integration/cucumber/DownloadStepdefs.java  | 12 +++
 .../resources/cucumber/DownloadEndpoint.feature |  7 ++
 .../src/test/resources/eml/oneInlinedImage.eml  | 82 
 3 files changed, 101 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/james-project/blob/4986bca6/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
--
diff --git 
a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
 
b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
index e675d10..b414de9 100644
--- 
a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
+++ 
b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
@@ -75,6 +75,18 @@ public class DownloadStepdefs {
 blobIdByAttachmentId.put(attachmentId, 
"4000c5145f633410b80be368c44e1c394bff9437");
 }
 
+@Given("^\"([^\"]*)\" mailbox \"([^\"]*)\" contains a message \"([^\"]*)\" 
with an inlined attachment \"([^\"]*)\"$")
+public void appendMessageWithInlinedAttachmentToMailbox(String user, 
String mailbox, String messageId, String attachmentId) throws Throwable {
+MailboxPath mailboxPath = new 
MailboxPath(MailboxConstants.USER_NAMESPACE, user, mailbox);
+
+mainStepdefs.jmapServer.serverProbe().appendMessage(user, mailboxPath,
+
ClassLoader.getSystemResourceAsStream("eml/oneInlinedImage.eml"), new Date(), 
false, new Flags());
+
+attachmentsByMessageId.put(messageId, attachmentId);
+// TODO
+//blobIdByAttachmentId.put(attachmentId, "");
+}
+
 @When("^\"([^\"]*)\" checks for the availability of the attachment 
endpoint$")
 public void optionDownload(String username) throws Throwable {
 AccessToken accessToken = userStepdefs.tokenByUser.get(username);

http://git-wip-us.apache.org/repos/asf/james-project/blob/4986bca6/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature
--
diff --git 
a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature
 
b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature
index df26b7f..d059572 100644
--- 
a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature
+++ 
b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature
@@ -50,3 +50,10 @@ Feature: Download endpoint
 And "us...@domain.tld" is connected
 When "us...@domain.tld" downloads "a1"
 Then the user should be authorized
+
+  @Ignore
+  Scenario: A user should have acess to an inlined attachment
+Given "us...@domain.tld" is connected
+And "us...@domain.tld" mailbox "INBOX" contains a message "m2" with an 
inlined attachment "ia1"
+When "us...@domain.tld" downloads "ia1"
+Then the user should be authorized

http://git-wip-us.apache.org/repos/asf/james-project/blob/4986bca6/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/eml/oneInlinedImage.eml
--
diff --git 
a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/eml/oneInlinedImage.eml
 
b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/eml/oneInlinedImage.eml
new file mode 100644
index 000..4a32093
--- /dev/null

Re: Git Repos

2016-07-03 Thread Eric Charles 

What about http://james.apache.org/contribute.html where we could also
introduce the different repositories and explain the overall
architecture of the James project and how we accept pull requests from
github.

Any thoughts?


The website needs a lot of love. Thank you for taking your time to go
through all these tasks that need to be done.



This can be followed on JAMES-1789 (consolidate documentation) and 
INFRA-12204 (Migrate James website from svnpubsub to the git workflow)


-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Created] (JAMES-1789) Consolidate Documentation

2016-07-03 Thread Eric Charles (JIRA) 
Eric Charles created JAMES-1789:
---

 Summary: Consolidate Documentation
 Key: JAMES-1789
 URL: https://issues.apache.org/jira/browse/JAMES-1789
 Project: James Server
  Issue Type: Sub-task
  Components: Documentation
Reporter: Eric Charles
Assignee: Eric Charles


We have a few places with mixed valid, depreacated and invalid content

http://james.apache.org/server/3/dev-build.html which is well updated.

However http://james.apache.org/mime4j/start/build.html still refers to
the svn tree.

What about http://james.apache.org/contribute.html where we could also
introduce the different repositories and explain the overall
architecture of the James project and how we accept pull requests from
github.

This task tracks initiative to migrate content to the website.

I have also create INFRA-12204 to migrate the site from svn to git.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Re: Git Repos

2016-07-03 Thread Eric Charles 

I have opened INFRA-12203 to remove the unused repos from github.

@manolo can you confirm james-hupa should migrate to git (and github)?

On 07/06/16 10:17, Echo wrote:

I guess Hupa can also be migrated to git. Need manolo's confirm.

On Tue, Jun 7, 2016 at 1:36 AM, Eric Charles  wrote:


Will open a few INFRA JIRA for this and begin migrating wiki to website.

For Hupa, there is still some recent activity. Manolo, Echo, Emma, dongxu,
what are your plans for Hupa?


On 06/06/16 16:57, Ioan Eugen Stan wrote:


Hello Eric,

On 29.05.2016 10:39, Eric Charles wrote:


Looking at the git repos:


https://git-wip-us.apache.org/repos/asf?a=project_list=james=Search
+ james-jdkim.git
+ james-jsieve.git
+ james-jspf.git
+ james-mime4j.git
+ james-postage.git
+ james-project.git

https://github.com/apache/?utf8=%E2%9C%93=james
+ james-project
+ james-mime4j
+ james-jsieve
+ james-jdkim
+ james-postage
+ james-jspf
+ james (*)
+ james-mpt (*)
+ james-mailbox (*)
+ james-protocols (*)
+ james-mailet (*)
+ james-hupa (**)
+ james-app (*)
+ james-imap (*)

(*) I propose to ask infra to remove the ones listed with a (*)



I agree with cleaning things up. If users can contribute to those
projects via another path (and I saw a lot of projects are merged in the
james-project), please go for it.

Keep it simple :).

A special case the james-hupa - Should we migrate it also to git?
Seems kind of dead. I would migrate it out of principle or ignore it
alltogether. If there are no users, we could reitre it. WDYT?



About the doc, I see for example
http://james.apache.org/server/3/dev-build.html which is well updated.

However http://james.apache.org/mime4j/start/build.html still refers to
the svn tree.

What about http://james.apache.org/contribute.html where we could also
introduce the different repositories and explain the overall
architecture of the James project and how we accept pull requests from
github.

Any thoughts?


The website needs a lot of love. Thank you for taking your time to go
through all these tasks that need to be done.

Regards,



-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org




-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-1091) Call for new logo

2016-07-03 Thread Eric Charles (JIRA) 

[ 
https://issues.apache.org/jira/browse/JAMES-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360473#comment-15360473
 ] 

Eric Charles commented on JAMES-1091:
-

Can you add the source (SVG if possible) of the logo proposals?
What about adding the other proposals listed on the home page (for these, we 
don't have the src)?

> Call for new logo
> -
>
> Key: JAMES-1091
> URL: https://issues.apache.org/jira/browse/JAMES-1091
> Project: James Server
>  Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Eric Charles
>Assignee: Ioan Eugen Stan
> Fix For: 3.0.0
>
>
> We already have some great contribution for a new james logo on 
> http://propositum.biz/james.html
> We should express a bit more the requirements (apache mention, different 
> types of logo,...).
> If we really have many contributions and different preferences from the 
> community, we also may propose a vote for the final choice.
> Up-to your imagination and favorite drawing tool !!!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org