[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572920#comment-14572920 ] Eric Charles commented on MAILBOX-11: - Sorry for the mess. Should be ok now. > MailboxQuery ignore namespace > - > > Key: MAILBOX-11 > URL: https://issues.apache.org/jira/browse/MAILBOX-11 > Project: James Mailbox > Issue Type: Bug > Environment: Linux, JDK 1.6 >Reporter: François-Denis Gonthier >Assignee: Eric Charles > Fix For: 0.6 > > Attachments: > 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch > > > MailboxQuery doesn't pay any attention to namespace of the mailbox it is > based on. For example, Mozilla Thunderbird might to mailbox search with > expressions like #private.%. That expression is passed directly to the > isExpressionMatch method of the MailboxQuery class. This has obviously > incorrect results. > Arguments to the isExpressionMatch method should be parsed to separate the > namespace from the mailbox name or isExpressionMatch should do the parsing > itself. In that case the argument name should be renamed to something like > 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570541#comment-14570541 ] Tellier Benoit commented on MAILBOX-11: --- I think you made a mistake. File that were not commited are : create mode 100644 memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxMapperTest.java create mode 100644 store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManagerTest.java File you commited are : Added: james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/mail/ james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManager.java I can not build on trunk because StoreMailboxManager is duplicated in a package, and there is still no tests for both InMemoryMailboxMapper and for StoreMailboxManager. Maybe things can be easier for you if we uses our Github integration tool. Do you want us to open the PR on Github corresponding to our uploaded awaiting patchs ? There is several advantages for you : - It preserve our Git history. - You can do the review on GitHub - Once done, you can't forget files, you just need to run one command. Regards, Benoit > MailboxQuery ignore namespace > - > > Key: MAILBOX-11 > URL: https://issues.apache.org/jira/browse/MAILBOX-11 > Project: James Mailbox > Issue Type: Bug > Environment: Linux, JDK 1.6 >Reporter: François-Denis Gonthier >Assignee: Eric Charles > Fix For: 0.6 > > Attachments: > 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch > > > MailboxQuery doesn't pay any attention to namespace of the mailbox it is > based on. For example, Mozilla Thunderbird might to mailbox search with > expressions like #private.%. That expression is passed directly to the > isExpressionMatch method of the MailboxQuery class. This has obviously > incorrect results. > Arguments to the isExpressionMatch method should be parsed to separate the > namespace from the mailbox name or isExpressionMatch should do the parsing > itself. In that case the argument name should be renamed to something like > 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569549#comment-14569549 ] Eric Charles commented on MAILBOX-11: - I have added them back. > MailboxQuery ignore namespace > - > > Key: MAILBOX-11 > URL: https://issues.apache.org/jira/browse/MAILBOX-11 > Project: James Mailbox > Issue Type: Bug > Environment: Linux, JDK 1.6 >Reporter: François-Denis Gonthier >Assignee: Eric Charles > Fix For: 0.6 > > Attachments: > 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch > > > MailboxQuery doesn't pay any attention to namespace of the mailbox it is > based on. For example, Mozilla Thunderbird might to mailbox search with > expressions like #private.%. That expression is passed directly to the > isExpressionMatch method of the MailboxQuery class. This has obviously > incorrect results. > Arguments to the isExpressionMatch method should be parsed to separate the > namespace from the mailbox name or isExpressionMatch should do the parsing > itself. In that case the argument name should be renamed to something like > 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569161#comment-14569161 ] Tellier Benoit commented on MAILBOX-11: --- I have errors when I rebase on trunk... Seems that : james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManagerTest.java james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/mail/InMemoryMailboxMapper.java Are missing... Benoit > MailboxQuery ignore namespace > - > > Key: MAILBOX-11 > URL: https://issues.apache.org/jira/browse/MAILBOX-11 > Project: James Mailbox > Issue Type: Bug > Environment: Linux, JDK 1.6 >Reporter: François-Denis Gonthier >Assignee: Eric Charles > Fix For: 0.6 > > Attachments: > 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch > > > MailboxQuery doesn't pay any attention to namespace of the mailbox it is > based on. For example, Mozilla Thunderbird might to mailbox search with > expressions like #private.%. That expression is passed directly to the > isExpressionMatch method of the MailboxQuery class. This has obviously > incorrect results. > Arguments to the isExpressionMatch method should be parsed to separate the > namespace from the mailbox name or isExpressionMatch should do the parsing > itself. In that case the argument name should be renamed to something like > 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568568#comment-14568568 ] Eric Charles commented on MAILBOX-11: - Hi Benoit, git apply --check 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch error: patch failed: store/pom.xml:86 error: store/pom.xml: patch does not apply Can you rebase? Thx. > MailboxQuery ignore namespace > - > > Key: MAILBOX-11 > URL: https://issues.apache.org/jira/browse/MAILBOX-11 > Project: James Mailbox > Issue Type: Bug > Environment: Linux, JDK 1.6 >Reporter: François-Denis Gonthier >Assignee: Norman Maurer > Fix For: 0.6 > > Attachments: > 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch > > > MailboxQuery doesn't pay any attention to namespace of the mailbox it is > based on. For example, Mozilla Thunderbird might to mailbox search with > expressions like #private.%. That expression is passed directly to the > isExpressionMatch method of the MailboxQuery class. This has obviously > incorrect results. > Arguments to the isExpressionMatch method should be parsed to separate the > namespace from the mailbox name or isExpressionMatch should do the parsing > itself. In that case the argument name should be renamed to something like > 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519100#comment-14519100 ] Tellier Benoit commented on MAILBOX-11: --- We want to solve this issue. We identified the problem : it comes from StoreMailboxManager :: search method : It relies on the MailboxMapper :: findMailboxWithPathLike. The behaviour of this metod is not standardized and differ in each and every implementation. Then the StoreMailboxMapper selects only mailboxes satisfying the provided expression. We can add a check for name and namespace there. It might be clever to standardize the MailboxMapper :: findMailboxWithPathLike method. This means provide standard test, test it in each implementation, and finally make the tests pass for each implementations. > MailboxQuery ignore namespace > - > > Key: MAILBOX-11 > URL: https://issues.apache.org/jira/browse/MAILBOX-11 > Project: James Mailbox > Issue Type: Bug > Environment: Linux, JDK 1.6 >Reporter: François-Denis Gonthier >Assignee: Norman Maurer > Fix For: 0.6 > > > MailboxQuery doesn't pay any attention to namespace of the mailbox it is > based on. For example, Mozilla Thunderbird might to mailbox search with > expressions like #private.%. That expression is passed directly to the > isExpressionMatch method of the MailboxQuery class. This has obviously > incorrect results. > Arguments to the isExpressionMatch method should be parsed to separate the > namespace from the mailbox name or isExpressionMatch should do the parsing > itself. In that case the argument name should be renamed to something like > 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213737#comment-13213737 ] Eric Charles commented on MAILBOX-11: - @norman is this still an issue? > MailboxQuery ignore namespace > - > > Key: MAILBOX-11 > URL: https://issues.apache.org/jira/browse/MAILBOX-11 > Project: James Mailbox > Issue Type: Bug > Environment: Linux, JDK 1.6 >Reporter: François-Denis Gonthier >Assignee: Norman Maurer > Fix For: 0.4 > > > MailboxQuery doesn't pay any attention to namespace of the mailbox it is > based on. For example, Mozilla Thunderbird might to mailbox search with > expressions like #private.%. That expression is passed directly to the > isExpressionMatch method of the MailboxQuery class. This has obviously > incorrect results. > Arguments to the isExpressionMatch method should be parsed to separate the > namespace from the mailbox name or isExpressionMatch should do the parsing > itself. In that case the argument name should be renamed to something like > 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098662#comment-13098662 ] Norman Maurer commented on MAILBOX-11: -- we shouldmfix it now > MailboxQuery ignore namespace > - > > Key: MAILBOX-11 > URL: https://issues.apache.org/jira/browse/MAILBOX-11 > Project: James Mailbox > Issue Type: Bug > Environment: Linux, JDK 1.6 >Reporter: François-Denis Gonthier >Assignee: Norman Maurer > Fix For: 0.4 > > > MailboxQuery doesn't pay any attention to namespace of the mailbox it is > based on. For example, Mozilla Thunderbird might to mailbox search with > expressions like #private.%. That expression is passed directly to the > isExpressionMatch method of the MailboxQuery class. This has obviously > incorrect results. > Arguments to the isExpressionMatch method should be parsed to separate the > namespace from the mailbox name or isExpressionMatch should do the parsing > itself. In that case the argument name should be renamed to something like > 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
