[jira] [Commented] (MAILBOX-223) ACL interfaces refactor
[ https://issues.apache.org/jira/browse/MAILBOX-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517692#comment-14517692 ] Eric Charles commented on MAILBOX-223: -- GroupFolderResolver now committed. Should maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailbox.java be in the svn src or should it be removed? ACL interfaces refactor --- Key: MAILBOX-223 URL: https://issues.apache.org/jira/browse/MAILBOX-223 Project: James Mailbox Issue Type: Improvement Reporter: Tellier Benoit Assignee: Eric Charles Fix For: 0.6 Attachments: 0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch ACL management should be delegated to mailbox manager. Updating ACL should be done in the MailboxMapper to allow implementation specific operations. We should not overwrite the SimpleMailbox Bean to achieve our goals. Currently available implementation should not have changed behavior. Hence Maildir implementation need to be updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-223) ACL interfaces refactor
[ https://issues.apache.org/jira/browse/MAILBOX-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517822#comment-14517822 ] Matthieu Baechler commented on MAILBOX-223: --- It should be removed. ACL interfaces refactor --- Key: MAILBOX-223 URL: https://issues.apache.org/jira/browse/MAILBOX-223 Project: James Mailbox Issue Type: Improvement Reporter: Tellier Benoit Assignee: Eric Charles Fix For: 0.6 Attachments: 0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch ACL management should be delegated to mailbox manager. Updating ACL should be done in the MailboxMapper to allow implementation specific operations. We should not overwrite the SimpleMailbox Bean to achieve our goals. Currently available implementation should not have changed behavior. Hence Maildir implementation need to be updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-223) ACL interfaces refactor
[ https://issues.apache.org/jira/browse/MAILBOX-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513711#comment-14513711 ] Eric Charles commented on MAILBOX-223: -- Could you create a simple diff (svn diff or git diff) and upload again. My working space is still svn, so git am does not work here. Sorry for this... ACL interfaces refactor --- Key: MAILBOX-223 URL: https://issues.apache.org/jira/browse/MAILBOX-223 Project: James Mailbox Issue Type: Improvement Reporter: Tellier Benoit Attachments: 0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch, 0002-MAILBOX-223-Remove-MaildirMailbox-use-SimpleMailbox-.patch ACL management should be delegated to mailbox manager. Updating ACL should be done in the MailboxMapper to allow implementation specific operations. We should not overwrite the SimpleMailbox Bean to achieve our goals. Currently available implementation should not have changed behavior. Hence Maildir implementation need to be updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-223) ACL interfaces refactor
[ https://issues.apache.org/jira/browse/MAILBOX-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513038#comment-14513038 ] Eric Charles commented on MAILBOX-223: -- tried to apply the 2 patches on latest SVN revision: eric@eric:/s/james/mailbox$ git apply /d/000 0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch 0002-MAILBOX-223-Remove-MaildirMailbox-use-SimpleMailbox-2.patch eric@eric:/s/james/mailbox$ git apply --check /d/0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch == OK eric@eric:/s/james/mailbox$ git apply --check /d/0002-MAILBOX-223-Remove-MaildirMailbox-use-SimpleMailbox-2.patch error: patch failed: maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirStore.java:125 error: maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirStore.java: patch does not apply error: patch failed: maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMailboxMapper.java:112 error: maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMailboxMapper.java: patch does not apply error: patch failed: maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailbox.java:1 error: maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailbox.java: patch does not apply == Patch is not applicable - Can you double check please? ACL interfaces refactor --- Key: MAILBOX-223 URL: https://issues.apache.org/jira/browse/MAILBOX-223 Project: James Mailbox Issue Type: Improvement Reporter: Tellier Benoit Attachments: 0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch, 0002-MAILBOX-223-Remove-MaildirMailbox-use-SimpleMailbox-.patch ACL management should be delegated to mailbox manager. Updating ACL should be done in the MailboxMapper to allow implementation specific operations. We should not overwrite the SimpleMailbox Bean to achieve our goals. Currently available implementation should not have changed behavior. Hence Maildir implementation need to be updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-223) ACL interfaces refactor
[
https://issues.apache.org/jira/browse/MAILBOX-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513054#comment-14513054
]
Matthieu Baechler commented on MAILBOX-223:
---
You can't just check the first patch then the second as the second uses parts
of the first.
To apply the patches, you can simply run git am 000{1,2}*
I've just checked here and it seems ok.
ACL interfaces refactor
---
Key: MAILBOX-223
URL: https://issues.apache.org/jira/browse/MAILBOX-223
Project: James Mailbox
Issue Type: Improvement
Reporter: Tellier Benoit
Attachments:
0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch,
0002-MAILBOX-223-Remove-MaildirMailbox-use-SimpleMailbox-.patch
ACL management should be delegated to mailbox manager.
Updating ACL should be done in the MailboxMapper to allow implementation
specific operations. We should not overwrite the SimpleMailbox Bean to
achieve our goals.
Currently available implementation should not have changed behavior. Hence
Maildir implementation need to be updated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
