Re: Call for vote: Using JDK 1.8 as a target for JSIEVE JDKIM & JSPF
+1 for all projects Thanks On Mon, Sep 9, 2019 at 11:04 AM Antoine Duprat wrote: > +1 for all projects > > Le lun. 9 sept. 2019 à 10:03, Tellier Benoit a > écrit : > > > +1 for all projects > > > > On 09/09/2019 14:59, Tellier Benoit wrote: > > > Hi, > > > > > > In order to improve maintenance of James related libraries, I propose > to > > switch target JDK version to JDK 1.8. > > > > > > This means: > > > - Upgrading JDK from 1.5 to 1.8 for JSPF project > > > - Upgrading JDK from 1.6 to 1.8 for JSIEVE project > > > - Upgrading JDK from 1.6 to 1.8 for JSDKIM project > > > > > > I do propose a vote to ensure consensus on it: > > > - Answer this mail with "+1 for all projects" to support all these > > > deprecations > > > - Answer this mail with "-1 for all projects" if you reject the idea > > > of removing components > > > - Answer this mail with "+1 [projects] -1 [projects]" to express > > > per project not favorable opinion. > > > > > > Negative votes should be motivated. Voting ends on 13th September 2019 > > 8am UTC. > > > > > > Best regards, > > > > > > Benoit Tellier > > > > > > > > > - > > > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > > > For additional commands, e-mail: server-dev-h...@james.apache.org > > > > > > > - > > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > > For additional commands, e-mail: server-dev-h...@james.apache.org > > > > >
[james-project] branch master updated (c89fe64 -> 70f3f27)
This is an automated email from the ASF dual-hosted git repository. btellier pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git. from c89fe64 JAMES-2886 Package apache-mailet-crypto as a JAR with dependency new da13fb2 JAMES-2885 avoid concurrent nexModSeq during flags update new e644a6f JAMES-2813 Demonstrate how exclusive consumer works new c89a8b2 JAMES-2721 Increase parallelism for mailbox/cassandra projects new 70f3f27 Modify some commiters no longer existing emails The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/james/backend/rabbitmq/Constants.java | 1 + .../james/backend/rabbitmq/InMemoryConsumer.java | 6 +- .../backend/rabbitmq/RabbitMQClusterTest.java | 2 +- .../james/backend/rabbitmq/RabbitMQTest.java | 79 ++ mailbox/cassandra/pom.xml | 13 .../cassandra/mail/CassandraMessageIdMapper.java | 9 ++- pom.xml| 4 +- 7 files changed, 103 insertions(+), 11 deletions(-) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[james-project] 04/04: Modify some commiters no longer existing emails
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git commit 70f3f277a106b509e99ada5d9af61df603dee21d Author: Benoit Tellier AuthorDate: Fri Sep 20 09:36:27 2019 +0700 Modify some commiters no longer existing emails --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 13db5ba..1e7eed7 100644 --- a/pom.xml +++ b/pom.xml @@ -478,11 +478,11 @@ Luc Duzan -ldu...@linagora.com +ldu...@apache.org Quynh Nguyen -qngu...@linagora.com +qngu...@apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[james-project] 03/04: JAMES-2721 Increase parallelism for mailbox/cassandra projects
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git commit c89a8b2fc502879e1faf9c270a78541bd49c26a2 Author: Benoit Tellier AuthorDate: Tue Sep 10 14:48:59 2019 +0700 JAMES-2721 Increase parallelism for mailbox/cassandra projects Last build (ci-02) for Mailbox :: Cassandra: [06:04 min] Running 2 Cassandra in parallel is doable and allow to gain 1 minute 30 --- mailbox/cassandra/pom.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/mailbox/cassandra/pom.xml b/mailbox/cassandra/pom.xml index fff5244..d3cb872 100644 --- a/mailbox/cassandra/pom.xml +++ b/mailbox/cassandra/pom.xml @@ -160,4 +160,17 @@ test + + + + +org.apache.maven.plugins +maven-surefire-plugin + +true +2 + + + + - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[james-project] 01/04: JAMES-2885 avoid concurrent nexModSeq during flags update
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit da13fb2739f8bd8bca7a12f624783e1983592d64
Author: Rémi Kowalski
AuthorDate: Tue Sep 10 10:55:33 2019 +0200
JAMES-2885 avoid concurrent nexModSeq during flags update
---
.../james/mailbox/cassandra/mail/CassandraMessageIdMapper.java | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
a/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdMapper.java
b/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdMapper.java
index 33db97c..a6637b8 100644
---
a/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdMapper.java
+++
b/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdMapper.java
@@ -210,17 +210,16 @@ public class CassandraMessageIdMapper implements
MessageIdMapper {
return Flux.fromIterable(mailboxIds)
.distinct()
.map(mailboxId -> (CassandraId) mailboxId)
-.filter(mailboxId -> haveMetaData(messageId, mailboxId))
-.flatMap(mailboxId -> flagsUpdateWithRetry(newState, updateMode,
mailboxId, messageId))
+.filterWhen(mailboxId -> haveMetaData(messageId, mailboxId))
+.concatMap(mailboxId -> flagsUpdateWithRetry(newState, updateMode,
mailboxId, messageId))
.flatMap(this::updateCounts)
.collect(Guavate.toImmutableMap(Pair::getLeft, Pair::getRight))
.block();
}
-private boolean haveMetaData(MessageId messageId, CassandraId mailboxId) {
+private Mono haveMetaData(MessageId messageId, CassandraId
mailboxId) {
return imapUidDAO.retrieve((CassandraMessageId) messageId,
Optional.of(mailboxId))
-.hasElements()
-.block();
+.hasElements();
}
private Mono> flagsUpdateWithRetry(Flags
newState, MessageManager.FlagsUpdateMode updateMode, MailboxId mailboxId,
MessageId messageId) {
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[james-project] 02/04: JAMES-2813 Demonstrate how exclusive consumer works
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit e644a6f591a3fe4423538aa98941d53b048560d0
Author: Matthieu Baechler
AuthorDate: Wed Aug 21 13:46:10 2019 +0200
JAMES-2813 Demonstrate how exclusive consumer works
---
.../apache/james/backend/rabbitmq/Constants.java | 1 +
.../james/backend/rabbitmq/InMemoryConsumer.java | 6 +-
.../backend/rabbitmq/RabbitMQClusterTest.java | 2 +-
.../james/backend/rabbitmq/RabbitMQTest.java | 79 ++
4 files changed, 84 insertions(+), 4 deletions(-)
diff --git
a/backends-common/rabbitmq/src/main/java/org/apache/james/backend/rabbitmq/Constants.java
b/backends-common/rabbitmq/src/main/java/org/apache/james/backend/rabbitmq/Constants.java
index 4fc2410..e6cea0f 100644
---
a/backends-common/rabbitmq/src/main/java/org/apache/james/backend/rabbitmq/Constants.java
+++
b/backends-common/rabbitmq/src/main/java/org/apache/james/backend/rabbitmq/Constants.java
@@ -26,6 +26,7 @@ public interface Constants {
boolean DURABLE = true;
boolean AUTO_DELETE = true;
boolean EXCLUSIVE = true;
+boolean NO_LOCAL = true;
boolean AUTO_ACK = true;
boolean MULTIPLE = true;
diff --git
a/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/InMemoryConsumer.java
b/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/InMemoryConsumer.java
index 712c70d..3cc93ae 100644
---
a/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/InMemoryConsumer.java
+++
b/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/InMemoryConsumer.java
@@ -32,14 +32,14 @@ public class InMemoryConsumer extends DefaultConsumer {
@FunctionalInterface
interface Operation {
-void perform();
+void perform(Envelope envelope, byte[] body) throws IOException;
}
private final ConcurrentLinkedQueue messages;
private final Operation operation;
public InMemoryConsumer(Channel channel) {
-this(channel, () -> { });
+this(channel, (envelope, body) -> { });
}
public InMemoryConsumer(Channel channel, Operation operation) {
@@ -50,7 +50,7 @@ public class InMemoryConsumer extends DefaultConsumer {
@Override
public void handleDelivery(String consumerTag, Envelope envelope,
AMQP.BasicProperties properties, byte[] body) throws IOException {
-operation.perform();
+operation.perform(envelope, body);
Integer payload = Integer.valueOf(new String(body,
StandardCharsets.UTF_8));
messages.add(payload);
}
diff --git
a/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/RabbitMQClusterTest.java
b/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/RabbitMQClusterTest.java
index 348d3ff..b4066a1 100644
---
a/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/RabbitMQClusterTest.java
+++
b/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/RabbitMQClusterTest.java
@@ -278,7 +278,7 @@ class RabbitMQClusterTest {
AtomicInteger counter = new AtomicInteger(0);
InMemoryConsumer consumer = new InMemoryConsumer(resilientChannel,
-() -> stopWhenHalfProcessed(cluster, nbMessages, counter));
+(envelope, body) -> stopWhenHalfProcessed(cluster, nbMessages,
counter));
resilientChannel.basicConsume(QUEUE, consumer);
awaitAtMostOneMinute.until(() ->
consumer.getConsumedMessages().size() == nbMessages);
diff --git
a/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/RabbitMQTest.java
b/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/RabbitMQTest.java
index b6f1b31..d858258 100644
---
a/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/RabbitMQTest.java
+++
b/backends-common/rabbitmq/src/test/java/org/apache/james/backend/rabbitmq/RabbitMQTest.java
@@ -23,17 +23,23 @@ import static
org.apache.james.backend.rabbitmq.Constants.AUTO_DELETE;
import static org.apache.james.backend.rabbitmq.Constants.DIRECT_EXCHANGE;
import static org.apache.james.backend.rabbitmq.Constants.DURABLE;
import static org.apache.james.backend.rabbitmq.Constants.EXCLUSIVE;
+import static org.apache.james.backend.rabbitmq.Constants.MULTIPLE;
+import static org.apache.james.backend.rabbitmq.Constants.NO_LOCAL;
import static org.apache.james.backend.rabbitmq.Constants.NO_PROPERTIES;
+import static org.apache.james.backend.rabbitmq.Constants.REQUEUE;
import static org.apache.james.backend.rabbitmq.RabbitMQFixture.EXCHANGE_NAME;
import static org.apache.james.backend.rabbitmq.RabbitMQFixture.ROUTING_KEY;
import static org.apache.james.backend.rabbitmq.RabbitMQFixture.WORK_QUEUE;
import static
org.apache.james.backend.rabbi
[jira] [Commented] (JAMES-2885) Avoid concurrent nexModSeq during flags update
[ https://issues.apache.org/jira/browse/JAMES-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935511#comment-16935511 ] Tellier Benoit commented on JAMES-2885: --- PR: https://github.com/linagora/james-project/pull/2682 > Avoid concurrent nexModSeq during flags update > -- > > Key: JAMES-2885 > URL: https://issues.apache.org/jira/browse/JAMES-2885 > Project: James Server > Issue Type: Improvement >Affects Versions: 3.4.0 >Reporter: Rémi Kowalski >Priority: Major > Fix For: 3.5.0 > > > When updating flags, the nextmodSeq is called concurrently. This PR aims to > fix this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2813) Implement a distributed task manager
[ https://issues.apache.org/jira/browse/JAMES-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935512#comment-16935512 ] Tellier Benoit commented on JAMES-2813: --- https://github.com/linagora/james-project/pull/2616 demonstrated the behavior of exclusive consumers > Implement a distributed task manager > > > Key: JAMES-2813 > URL: https://issues.apache.org/jira/browse/JAMES-2813 > Project: James Server > Issue Type: Task >Reporter: Matthieu Baechler >Priority: Major > > Following JAMES-2272, we now would like to handle tasks at a cluster level. > For that, we intend to use a combination of Event Sourcing for keeping track > of Tasks submitted and RabbitMQ for dispatching the tasks in the cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JAMES-2895) Remove link to the outdated wiki on the website
Tellier Benoit created JAMES-2895: - Summary: Remove link to the outdated wiki on the website Key: JAMES-2895 URL: https://issues.apache.org/jira/browse/JAMES-2895 Project: James Server Issue Type: Improvement Components: site Reporter: Tellier Benoit Articles on the wiki are from 2007 which is clearly outdated. Unreferencing this wiki, which just add confusion, would be a good step. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-2895) Remove link to the outdated wiki on the website
[ https://issues.apache.org/jira/browse/JAMES-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935514#comment-16935514 ] Tellier Benoit commented on JAMES-2895: --- https://github.com/linagora/james-project/pull/2702 proposes to fix this > Remove link to the outdated wiki on the website > --- > > Key: JAMES-2895 > URL: https://issues.apache.org/jira/browse/JAMES-2895 > Project: James Server > Issue Type: Improvement > Components: site >Reporter: Tellier Benoit >Priority: Major > > Articles on the wiki are from 2007 which is clearly outdated. > Unreferencing this wiki, which just add confusion, would be a good step. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Call for vote: Using JDK 1.8 as a target for JSIEVE JDKIM & JSPF
Hi, This proposal received 3 vote for (+1), 0 vote against, and reached the required PMC quorum size over the (slightly extended) voting period. I will create the related issues on the JIRA. Regards, Benoit Tellier On 23/09/2019 00:58, Manuel Carrasco Moñino wrote: > +1 for all projects > > Thanks > > On Mon, Sep 9, 2019 at 11:04 AM Antoine Duprat wrote: > >> +1 for all projects >> >> Le lun. 9 sept. 2019 à 10:03, Tellier Benoit a >> écrit : >> >>> +1 for all projects >>> >>> On 09/09/2019 14:59, Tellier Benoit wrote: Hi, In order to improve maintenance of James related libraries, I propose >> to >>> switch target JDK version to JDK 1.8. This means: - Upgrading JDK from 1.5 to 1.8 for JSPF project - Upgrading JDK from 1.6 to 1.8 for JSIEVE project - Upgrading JDK from 1.6 to 1.8 for JSDKIM project I do propose a vote to ensure consensus on it: - Answer this mail with "+1 for all projects" to support all these deprecations - Answer this mail with "-1 for all projects" if you reject the idea of removing components - Answer this mail with "+1 [projects] -1 [projects]" to express per project not favorable opinion. Negative votes should be motivated. Voting ends on 13th September 2019 >>> 8am UTC. Best regards, Benoit Tellier - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org >>> - >>> To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org >>> For additional commands, e-mail: server-dev-h...@james.apache.org >>> >>> - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JSPF-104) Use JDK 8 as a target JDK
Tellier Benoit created JSPF-104: --- Summary: Use JDK 8 as a target JDK Key: JSPF-104 URL: https://issues.apache.org/jira/browse/JSPF-104 Project: James jSPF Issue Type: Improvement Components: Core Reporter: Tellier Benoit In this thread [1] , we voted for switching JSPF to the 1.8 target JDK. [1]: https://www.mail-archive.com/server-dev@james.apache.org/msg62167.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JDKIM-44) Use JDK 8 as a target JDK
Tellier Benoit created JDKIM-44: --- Summary: Use JDK 8 as a target JDK Key: JDKIM-44 URL: https://issues.apache.org/jira/browse/JDKIM-44 Project: James jDKIM Issue Type: Improvement Reporter: Tellier Benoit In this thread [1] , we voted for switching JDKIM to the 1.8 target JDK. [1]: https://www.mail-archive.com/server-dev@james.apache.org/msg62167.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JSIEVE-113) Use JDK 8 as a target JDK
Tellier Benoit created JSIEVE-113: - Summary: Use JDK 8 as a target JDK Key: JSIEVE-113 URL: https://issues.apache.org/jira/browse/JSIEVE-113 Project: James jSieve Issue Type: Improvement Reporter: Tellier Benoit In this thread [1] , we voted for switching JSIEVE to the 1.8 target JDK. [1]: https://www.mail-archive.com/server-dev@james.apache.org/msg62167.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Call for vote: Using JDK 1.8 as a target for JSIEVE JDKIM & JSPF
Hi, I did open the JIRA and pull requests for contributing the JDK-8 switch: JSPF: - https://issues.apache.org/jira/browse/JSPF-104 - https://github.com/apache/james-jspf/pull/8 JDKIM: - https://issues.apache.org/jira/browse/JDKIM-44 - https://github.com/apache/james-jdkim/pull/10 JSIEVE: - https://issues.apache.org/jira/browse/JSIEVE-113 - https://github.com/apache/james-jsieve/pull/19 Best regards, Benoit Tellier On 23/09/2019 11:01, Tellier Benoit wrote: > Hi, > > This proposal received 3 vote for (+1), 0 vote against, and reached the > required PMC quorum size over the (slightly extended) voting period. > > I will create the related issues on the JIRA. > > Regards, > > Benoit Tellier > > On 23/09/2019 00:58, Manuel Carrasco Moñino wrote: >> +1 for all projects >> >> Thanks >> >> On Mon, Sep 9, 2019 at 11:04 AM Antoine Duprat wrote: >> >>> +1 for all projects >>> >>> Le lun. 9 sept. 2019 à 10:03, Tellier Benoit a >>> écrit : >>> +1 for all projects On 09/09/2019 14:59, Tellier Benoit wrote: > Hi, > > In order to improve maintenance of James related libraries, I propose >>> to switch target JDK version to JDK 1.8. > This means: > - Upgrading JDK from 1.5 to 1.8 for JSPF project > - Upgrading JDK from 1.6 to 1.8 for JSIEVE project > - Upgrading JDK from 1.6 to 1.8 for JSDKIM project > > I do propose a vote to ensure consensus on it: > - Answer this mail with "+1 for all projects" to support all these > deprecations > - Answer this mail with "-1 for all projects" if you reject the idea > of removing components > - Answer this mail with "+1 [projects] -1 [projects]" to express > per project not favorable opinion. > > Negative votes should be motivated. Voting ends on 13th September 2019 8am UTC. > Best regards, > > Benoit Tellier > > > - > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org > > - > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JSPF-105) Rely on slf4j-api for logging
Tellier Benoit created JSPF-105: --- Summary: Rely on slf4j-api for logging Key: JSPF-105 URL: https://issues.apache.org/jira/browse/JSPF-105 Project: James jSPF Issue Type: Improvement Reporter: Tellier Benoit By using a modern logging API, we can: - Avoid the Logger frontend API which: - Makes using JSPF easier - Reduces code size - Avoid forcing the Log4J dependency (that is later excluded in James) - Allow using placeholders - Remove the need of Logger wiring - Allow more precise logs: the classname the log is emmited from is then explicitly used. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
