hg: jdk8/tl/jdk: 7198904: (alt-rt) TreeMap.clone is broken
Changeset: f389bf27fc4f Author:dbuck Date: 2012-11-20 21:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f389bf27fc4f 7198904: (alt-rt) TreeMap.clone is broken Summary: Test case for cr7198904. Issue only found in OracleJDK, but test case is valid for OpenJDK as well Reviewed-by: mduigou, dholmes + test/java/util/TreeMap/Clone.java
Re: RFR (XS): 8003690: Example code in JVMTI GetStackTrace documentation is broken
Looks good to me Mikael.
David
On 21/11/2012 2:52 AM, Mikael Vidstedt wrote:
In the JVMTI documentation for GetStackTrace there is a code snippet
outlining how to use the functionality:
jvmtiFrameInfo frames[5];
jint count;
jvmtiError err;
err = (*jvmti)->GetStackTrace(jvmti, aThread, 0, 5,
&frames, &count);
if (err == JVMTI_ERROR_NONE && count >= 1) {
char *methodName;
err = (*jvmti)->GetMethodName(jvmti, frames[0].method,
&methodName, NULL);
if (err == JVMTI_ERROR_NONE) {
printf("Executing method: %s", methodName);
}
}
There are two errors in the code:
1. The 5th argument to GetStackTrace (frames) should not have an ampersand
2. GetMethodName takes 5 parameters, but the example only passes four
parameters to it
Please review the following change:
http://cr.openjdk.java.net/~mikael/8003690/webrev.00/
Thanks,
Mikael
Re: RFR (XS): 8003690: Example code in JVMTI GetStackTrace documentation is broken
Mikael,
The fix looks good.
Thank you for fixing it!
The first
The second problem was introduced when the JVMTI was updated with generics.
The GetMethodName got an extra parameter for generic signature,
but this code snippet was not fixed at this time.
Thanks,
Serguei
On 11/20/12 8:52 AM, Mikael Vidstedt wrote:
In the JVMTI documentation for GetStackTrace there is a code snippet
outlining how to use the functionality:
jvmtiFrameInfo frames[5];
jint count;
jvmtiError err;
err = (*jvmti)->GetStackTrace(jvmti, aThread, 0, 5,
&frames, &count);
if (err == JVMTI_ERROR_NONE && count >= 1) {
char *methodName;
err = (*jvmti)->GetMethodName(jvmti, frames[0].method,
&methodName, NULL);
if (err == JVMTI_ERROR_NONE) {
printf("Executing method: %s", methodName);
}
}
There are two errors in the code:
1. The 5th argument to GetStackTrace (frames) should not have an
ampersand
2. GetMethodName takes 5 parameters, but the example only passes four
parameters to it
Please review the following change:
http://cr.openjdk.java.net/~mikael/8003690/webrev.00/
Thanks,
Mikael
hg: jdk8/tl/langtools: 8003639: convert lambda testng tests to jtreg and add them
Changeset: d898d9ee352f Author:rfield Date: 2012-11-20 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d898d9ee352f 8003639: convert lambda testng tests to jtreg and add them Reviewed-by: mcimadamore + test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/defaultMethods/fd/FDTest.java - test/tools/javac/defaultMethods/fd/shapegen/ClassCase.java - test/tools/javac/defaultMethods/fd/shapegen/Hierarchy.java - test/tools/javac/defaultMethods/fd/shapegen/HierarchyGenerator.java - test/tools/javac/defaultMethods/fd/shapegen/Rule.java - test/tools/javac/defaultMethods/fd/shapegen/RuleGroup.java - test/tools/javac/defaultMethods/fd/shapegen/TTNode.java - test/tools/javac/defaultMethods/fd/shapegen/TTParser.java - test/tools/javac/defaultMethods/fd/shapegen/TTShape.java + test/tools/javac/lambda/lambdaExecution/InInterface.java + test/tools/javac/lambda/lambdaExecution/InnerConstructor.java + test/tools/javac/lambda/lambdaExecution/LambdaTranslationTest1.java + test/tools/javac/lambda/lambdaExecution/LambdaTranslationTest2.java + test/tools/javac/lambda/lambdaExecution/TBlock.java + test/tools/javac/lambda/lambdaExecution/TMapper.java + test/tools/javac/lambda/lambdaExecution/TPredicate.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestFDCCE.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerDefault.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerInstance.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerVarArgsThis.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInstance.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestKinds.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNew.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNewInner.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase1.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase2.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase4.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSuper.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSuperDefault.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestTypeConversion.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgs.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsExt.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsSuper.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsSuperDefault.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsThis.java + test/tools/javac/lambdaShapes/TEST.properties + test/tools/javac/lambdaShapes/org/openjdk/tests/javac/FDTest.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/AttributeInjector.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFile.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFilePreprocessor.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassToInterfaceConverter.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/Compiler.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/DirectedClassLoader.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/SourceModel.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/ClassCase.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/Hierarchy.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/HierarchyGenerator.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/Rule.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/RuleGroup.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/TTNode.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/TTParser.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/TTShape.java + test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java + test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java
Re: RFR (XS): 8003690: Example code in JVMTI GetStackTrace documentation is broken
Mikael,
The fix looks good.
Thank you for fixing it!
The second problem was introduced when the JVMTI was updated with generics.
The GetMethodName got 5th parameter for generic signature, but the
example was not updated.
Thanks,
Serguei
On 11/20/12 8:52 AM, Mikael Vidstedt wrote:
In the JVMTI documentation for GetStackTrace there is a code snippet
outlining how to use the functionality:
jvmtiFrameInfo frames[5];
jint count;
jvmtiError err;
err = (*jvmti)->GetStackTrace(jvmti, aThread, 0, 5,
&frames, &count);
if (err == JVMTI_ERROR_NONE && count >= 1) {
char *methodName;
err = (*jvmti)->GetMethodName(jvmti, frames[0].method,
&methodName, NULL);
if (err == JVMTI_ERROR_NONE) {
printf("Executing method: %s", methodName);
}
}
There are two errors in the code:
1. The 5th argument to GetStackTrace (frames) should not have an
ampersand
2. GetMethodName takes 5 parameters, but the example only passes four
parameters to it
Please review the following change:
http://cr.openjdk.java.net/~mikael/8003690/webrev.00/
Thanks,
Mikael
RFR (XS): 8003690: Example code in JVMTI GetStackTrace documentation is broken
In the JVMTI documentation for GetStackTrace there is a code snippet
outlining how to use the functionality:
jvmtiFrameInfo frames[5];
jint count;
jvmtiError err;
err = (*jvmti)->GetStackTrace(jvmti, aThread, 0, 5,
&frames, &count);
if (err == JVMTI_ERROR_NONE && count >= 1) {
char *methodName;
err = (*jvmti)->GetMethodName(jvmti, frames[0].method,
&methodName, NULL);
if (err == JVMTI_ERROR_NONE) {
printf("Executing method: %s", methodName);
}
}
There are two errors in the code:
1. The 5th argument to GetStackTrace (frames) should not have an ampersand
2. GetMethodName takes 5 parameters, but the example only passes four
parameters to it
Please review the following change:
http://cr.openjdk.java.net/~mikael/8003690/webrev.00/
Thanks,
Mikael
hg: jdk8/tl/langtools: 8003663: lambda test fails on Windows
Changeset: 7538e419a588 Author:mcimadamore Date: 2012-11-20 15:43 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7538e419a588 8003663: lambda test fails on Windows Summary: fix path separator issue in test Reviewed-by: jjg ! test/tools/javac/lambda/abort/Abort.java
hg: jdk8/tl/langtools: 8003650: java.lang.Exception: expected string not found: pkg/package-frame.html
Changeset: fb97eaf93d61 Author:jjg Date: 2012-11-20 07:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb97eaf93d61 8003650: java.lang.Exception: expected string not found: pkg/package-frame.html Reviewed-by: ksrini ! test/tools/javadoc/api/basic/GetTask_WriterTest.java ! test/tools/javadoc/api/basic/RunTest.java
hg: jdk8/tl/langtools: 8003649: regression/langtools: tools/javac/doctree
Changeset: a25c53e12bd0 Author:jjg Date: 2012-11-20 07:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a25c53e12bd0 8003649: regression/langtools: tools/javac/doctree Reviewed-by: ksrini ! test/tools/javac/doctree/DocCommentTester.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 914cd9b482c8 Author:ksrini Date: 2012-11-19 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/914cd9b482c8 8001533: java launcher must launch javafx applications Reviewed-by: ksrini, mchung, kcr, alanb Contributed-by: david.deha...@oracle.com ! src/share/bin/java.c ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! test/tools/launcher/TestHelper.java Changeset: b1c364c84d09 Author:ksrini Date: 2012-11-19 19:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1c364c84d09 8003660: (launcher) 8001533 regression tests Reviewed-by: ksrini, mchung, kcr, ddehaven Contributed-by: steve.si...@oracle.com + test/tools/launcher/FXLauncherTest.java
hg: jdk8/tl/jdk: 8000476: Memory Leaks and uninitialized memory access in PKCS11 and other native code
Changeset: 2d08b404cd91 Author:jzavgren Date: 2012-11-20 09:26 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2d08b404cd91 8000476: Memory Leaks and uninitialized memory access in PKCS11 and other native code Reviewed-by: dsamersoff, valeriep, chegar ! src/share/bin/wildcard.c ! src/share/native/sun/security/jgss/wrapper/GSSLibStub.c ! src/share/native/sun/security/pkcs11/wrapper/p11_mutex.c ! src/solaris/bin/java_md_solinux.c
