Integrated: 8281049: man page update for jstatd Security Manager dependency removal
On Wed, 2 Feb 2022 10:54:19 GMT, Kevin Walls wrote: > Policy settings are no longer required to run jstatd. > > This PR is the change to the source file src/jdk.jstatd/share/man/jstatd.1 > and in case that's hard to read, here is a diff of the text as rendered by > the man command: > https://cr.openjdk.java.net/~kevinw/8281049/jstatd.man.diff.txt > > And a copy of the new text rendered by man: > https://cr.openjdk.java.net/~kevinw/8281049/jstatd.man.new.txt This pull request has now been integrated. Changeset: 48523b09 Author:Kevin Walls URL: https://git.openjdk.java.net/jdk/commit/48523b090886f7b24ed4009f0c150efaa6f7b056 Stats: 16 lines in 1 file changed: 0 ins; 3 del; 13 mod 8281049: man page update for jstatd Security Manager dependency removal Reviewed-by: cjplummer - PR: https://git.openjdk.java.net/jdk/pull/7320
Re: RFR: 8281049: man page update for jstatd Security Manager dependency removal [v3]
On Thu, 3 Feb 2022 17:44:47 GMT, Kevin Walls wrote: >> Policy settings are no longer required to run jstatd. >> >> This PR is the change to the source file src/jdk.jstatd/share/man/jstatd.1 >> and in case that's hard to read, here is a diff of the text as rendered by >> the man command: >> https://cr.openjdk.java.net/~kevinw/8281049/jstatd.man.diff.txt >> >> And a copy of the new text rendered by man: >> https://cr.openjdk.java.net/~kevinw/8281049/jstatd.man.new.txt > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > Quotes/bold Marked as reviewed by cjplummer (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7320
Re: RFR: 8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing
On Fri, 4 Feb 2022 11:18:39 GMT, Alex Menkov wrote: > The test expects ClassFileReconstituter restores exactly the same bytes as > original classbytes. > This can be wrong if the class has more than 1 method (due to method sorting > in the VM). > MethodParametersTarget class had only 1 method (method1), but didn't have > constructors. This caused declaration of implicit default constructor, so the > class actually had 2 methods. > The fix converts the method to constructor to avoid default constructor > declaration. Marked as reviewed by lmesnik (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7345
Re: RFR: 8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing
On Fri, 4 Feb 2022 11:18:39 GMT, Alex Menkov wrote: > The test expects ClassFileReconstituter restores exactly the same bytes as > original classbytes. > This can be wrong if the class has more than 1 method (due to method sorting > in the VM). > MethodParametersTarget class had only 1 method (method1), but didn't have > constructors. This caused declaration of implicit default constructor, so the > class actually had 2 methods. > The fix converts the method to constructor to avoid default constructor > declaration. Thumbs up on the changes. However, there's no details on how this fix was tested. Please clarify. So far this test failure has been seen intermittently in Tier3. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7345
Re: RFR: 8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing
On Fri, 4 Feb 2022 11:18:39 GMT, Alex Menkov wrote: > The test expects ClassFileReconstituter restores exactly the same bytes as > original classbytes. > This can be wrong if the class has more than 1 method (due to method sorting > in the VM). > MethodParametersTarget class had only 1 method (method1), but didn't have > constructors. This caused declaration of implicit default constructor, so the > class actually had 2 methods. > The fix converts the method to constructor to avoid default constructor > declaration. Looks good to me. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7345
RFR: 8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing
The test expects ClassFileReconstituter restores exactly the same bytes as original classbytes. This can be wrong if the class has more than 1 method (due to method sorting in the VM). MethodParametersTarget class had only 1 method (method1), but didn't have constructors. This caused declaration of implicit default constructor, so the class actually had 2 methods. The fix converts the method to constructor to avoid default constructor declaration. - Commit messages: - Fixed indent - Converted target class method to ctor Changes: https://git.openjdk.java.net/jdk/pull/7345/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7345=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281243 Stats: 6 lines in 1 file changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/7345.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7345/head:pull/7345 PR: https://git.openjdk.java.net/jdk/pull/7345
