Integrated: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java
On Sun, 27 Mar 2022 08:59:40 GMT, Christoph Langer wrote: > Fix risv64 -> riscv64 This pull request has now been integrated. Changeset: f4eaa16c Author:Christoph Langer URL: https://git.openjdk.java.net/jdk/commit/f4eaa16c0fe0659376325cec1c912a13ef0f1be8 Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java Reviewed-by: fyang, jiefu, dholmes - PR: https://git.openjdk.java.net/jdk/pull/7977
Re: RFR: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java
On Sun, 27 Mar 2022 08:59:40 GMT, Christoph Langer wrote: > Fix risv64 -> riscv64 Interestingly, the thing compiles as the package name inside of RISCV64ThreadContext.java is correct and the compiler doesn't bother about the path. Only my Eclipse IDE complained. Thanks for the reviews. - PR: https://git.openjdk.java.net/jdk/pull/7977
RFR: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java
Fix risv64 -> riscv64 - Commit messages: - JDK-8283728 Changes: https://git.openjdk.java.net/jdk/pull/7977/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7977=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283728 Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/7977.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7977/head:pull/7977 PR: https://git.openjdk.java.net/jdk/pull/7977
Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v4]
On Sun, 6 Jun 2021 08:50:22 GMT, Anton Kozlov wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix windows flags (although complied fine) > > Thanks for the comments! Indeed, the change is about the "overwrite" option > only. The CSR describes why the option is necessary, and sockets and pipes > are just examples. I have rephrased CSR to be more explicit about the option, > but not examples. > @AntonKozlov This pull request has been inactive for more than 4 weeks and > will be automatically closed if another 4 weeks passes without any activity. > To avoid this, simply add a new comment to the pull request. Feel free to ask > for assistance if you need help with progressing this pull request towards > integration! Please keep this open :) We're waiting for the CSR. @jddarcy, is there any update? - PR: https://git.openjdk.java.net/jdk/pull/4183
Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v4]
On Wed, 2 Jun 2021 20:57:02 GMT, Anton Kozlov wrote: >> Please review a small change that adds an option to GC.heap_dump to use an >> existing file. >> >> The option is necessary if the target file is a predefined file-like object, >> like a named pipe. This opens up a lot of possibilities to process a heap >> dump without storing it to the file system first. >> >> Reviews of the CSR linked to the bug would be appreciated as well. > > Anton Kozlov has updated the pull request incrementally with one additional > commit since the last revision: > > Fix windows flags (although complied fine) Marked as reviewed by clanger (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4183
Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v4]
On Sun, 6 Jun 2021 08:50:22 GMT, Anton Kozlov wrote: > Thanks for the comments! Indeed, the change is about the "overwrite" option > only. The CSR describes why the option is necessary, and sockets and pipes > are just examples. I have rephrased CSR to be more explicit about the option, > but not examples. Perfect, looks good to me. - PR: https://git.openjdk.java.net/jdk/pull/4183
Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v4]
On Wed, 2 Jun 2021 20:57:02 GMT, Anton Kozlov wrote: >> Please review a small change that adds an option to GC.heap_dump to use an >> existing file. >> >> The option is necessary if the target file is a predefined file-like object, >> like a named pipe. This opens up a lot of possibilities to process a heap >> dump without storing it to the file system first. >> >> Reviews of the CSR linked to the bug would be appreciated as well. > > Anton Kozlov has updated the pull request incrementally with one additional > commit since the last revision: > > Fix windows flags (although complied fine) Thanks Alan for commenting on that one. > The CSR still has wording to suggest that the new option is also to support > socket/other files. I read the PR as just the overwrite existing file case. > If so then maybe those (two) sentences can be changed in the CSR to make it > clearer. I think it's ok to mention the use-cases like pipe support which is something that'll be enabled by this change. But feel free to remove it. I've marked the CSR as reviewed from my end. - PR: https://git.openjdk.java.net/jdk/pull/4183
Re: RFR: 8267666: Add option to jcmd GC.heap_dump to use existing file [v3]
On Wed, 2 Jun 2021 20:49:10 GMT, Anton Kozlov wrote: > SInce JDK-8263066 suggests more enhancements, it may be worth keeping it to > track the remaining ones. No, the issue we're trying to solve with JDK-8263066 is basically the same as with JDK-8267666, so we'll close it. There's also JDK-8200579 which could be closed then. > @AlanBateman The patch does not do anything special to the named pipe > use-case, although makes it possible. Do you suggest removing mentions of the > use-case from the CSR? Otherwise, what concerns could I address? I would suggest to change the CSR to use "overwrite" but other than that, it seems fine. Let's wait what Alan has to say but that would be my thinking. - PR: https://git.openjdk.java.net/jdk/pull/4183
Re: RFR: 8252837: Cleanup SAP Copyright file headers
On Mon, 7 Sep 2020 07:25:41 GMT, David Holmes wrote:
>> The format for SAP copyrights in OpenJDK headers should be like:
>> Copyright (c) SAP SE. All rights reserved.
>> or
>> Copyright (c) , SAP SE. All rights reserved.
>>
>> There should not be a comma character (",") before "SAP SE".
>>
>> This is inconsistent in some files which calls for some cleanup.
>>
>> Please review :)
>
> Marked as reviewed by dholmes (Reviewer).
> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
> [nio-dev](mailto:nio-...@openjdk.java.net):_
> Looks good to me - and trivial.
>
> Thanks,
> David
>
> On 7/09/2020 2:22 pm, Christoph Langer wrote:
Thanks, David!
-
PR: https://git.openjdk.java.net/jdk/pull/36
Integrated: 8252837: Cleanup SAP Copyright file headers
On Mon, 7 Sep 2020 04:14:06 GMT, Christoph Langer wrote:
> The format for SAP copyrights in OpenJDK headers should be like:
> Copyright (c) SAP SE. All rights reserved.
> or
> Copyright (c) , SAP SE. All rights reserved.
>
> There should not be a comma character (",") before "SAP SE".
>
> This is inconsistent in some files which calls for some cleanup.
>
> Please review :)
This pull request has now been integrated.
Changeset: cc5039e1
Author:Christoph Langer
URL: https://git.openjdk.java.net/jdk/commit/cc5039e1
Stats: 55 lines in 55 files changed: 0 ins; 0 del; 55 mod
8252837: Cleanup SAP Copyright file headers
Reviewed-by: dholmes
-
PR: https://git.openjdk.java.net/jdk/pull/36
Re: RFR: 8252837: Cleanup SAP Copyright file headers
On Mon, 7 Sep 2020 07:27:39 GMT, Christoph Langer wrote: >> Marked as reviewed by dholmes (Reviewer). > >> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on >> [nio-dev](mailto:nio-...@openjdk.java.net):_ >> Looks good to me - and trivial. >> >> Thanks, >> David >> >> On 7/09/2020 2:22 pm, Christoph Langer wrote: > > Thanks, David! > _Mailing list message from [Lindenmaier, > Goetz](mailto:goetz.lindenma...@sap.com) on > [nio-dev](mailto:nio-...@openjdk.java.net):_ > Hi Christoph, > > Looks good to me ?? > > Best regards, > Goetz. > Thanks, Goetz :) - PR: https://git.openjdk.java.net/jdk/pull/36
RFR: 8252837: Cleanup SAP Copyright file headers
The format for SAP copyrights in OpenJDK headers should be like:
Copyright (c) SAP SE. All rights reserved.
or
Copyright (c) , SAP SE. All rights reserved.
There should not be a comma character (",") before "SAP SE".
This is inconsistent in some files which calls for some cleanup.
Please review :)
-
Commit messages:
- 8252837: Cleanup SAP Copyright file headers
Changes: https://git.openjdk.java.net/jdk/pull/36/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=36=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8252837
Stats: 55 lines in 55 files changed: 0 ins; 0 del; 55 mod
Patch: https://git.openjdk.java.net/jdk/pull/36.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/36/head:pull/36
PR: https://git.openjdk.java.net/jdk/pull/36
