Re: RFR: 8284209: Replace remaining usages of 'a the' in source code [v3]
On Tue, 24 May 2022 09:52:29 GMT, Alexey Ivanov wrote: >> Replaces usages of articles that follow each other in all combinations: >> a/the, an?/an?, the/the… >> >> It's the last issue in the series, and it still touches different areas of >> the code. > > Alexey Ivanov has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright to 2022 Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8771
Re: RFR: 8284209: Replace remaining usages of 'a the' in source code
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8771
Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8768
Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v7]
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the HotSpot VM are disabled by default and >> require running with `--enable-preview` to enable. >> >> The patch has support for x64 and aarch64 on the usual operating systems >> (Linux, macOS, and Windows). There are stubs (calling Unimplemented) for >> zero and some of the other ports. Additional ports can be contributed via >> PRs against the fibers branch in the loom repo. >> >> There are changes in many areas. To reduce notifications/mails, the labels >> have been trimmed down for now to hotspot, serviceability and core-libs. >> We'll add the complete set of labels when the PR is further along. >> >> The changes include a refresh of java.util.concurrent and ForkJoinPool from >> Doug Lea's CVS. These changes will probably be proposed and integrated in >> advance of this PR. >> >> The changes include some non-exposed and low-level infrastructure to support >> the (in draft) JEPs for Structured Concurrency and Scope Locals. This is to >> make life a bit easier and avoid having to separate VM changes and juggle >> branches at this time. > > Alan Bateman has updated the pull request incrementally with one additional > commit since the last revision: > > Refresh 8d8f0a2fd646e57fe6b4e8ab669f836dc46dda69 I have been through all of the tests and they look good. - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8166
Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v5]
On Thu, 21 Apr 2022 11:35:57 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default and
>> require running with `--enable-preview` to enable.
>>
>> The patch has support for x64 and aarch64 on the usual operating systems
>> (Linux, macOS, and Windows). There are stubs (calling Unimplemented) for
>> zero and some of the other ports. Additional ports can be contributed via
>> PRs against the fibers branch in the loom repo.
>>
>> There are changes in many areas. To reduce notifications/mails, the labels
>> have been trimmed down for now to hotspot, serviceability and core-libs.
>> We'll add the complete set of labels when the PR is further along.
>>
>> The changes include a refresh of java.util.concurrent and ForkJoinPool from
>> Doug Lea's CVS. These changes will probably be proposed and integrated in
>> advance of this PR.
>>
>> The changes include some non-exposed and low-level infrastructure to support
>> the (in draft) JEPs for Structured Concurrency and Scope Locals. This is to
>> make life a bit easier and avoid having to separate VM changes and juggle
>> branches at this time.
>
> Alan Bateman has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refresh
test/jdk/jdk/internal/vm/Continuation/Basic.java line 327:
> 325:
> 326: // @Test
> 327: public void testPinnedNative() {
Are you disabling this test? if so, you can do `@Test(enabled=false)`
-
PR: https://git.openjdk.java.net/jdk/pull/8166
Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v6]
On Mon, 25 Apr 2022 13:19:49 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the HotSpot VM are disabled by default and >> require running with `--enable-preview` to enable. >> >> The patch has support for x64 and aarch64 on the usual operating systems >> (Linux, macOS, and Windows). There are stubs (calling Unimplemented) for >> zero and some of the other ports. Additional ports can be contributed via >> PRs against the fibers branch in the loom repo. >> >> There are changes in many areas. To reduce notifications/mails, the labels >> have been trimmed down for now to hotspot, serviceability and core-libs. >> We'll add the complete set of labels when the PR is further along. >> >> The changes include a refresh of java.util.concurrent and ForkJoinPool from >> Doug Lea's CVS. These changes will probably be proposed and integrated in >> advance of this PR. >> >> The changes include some non-exposed and low-level infrastructure to support >> the (in draft) JEPs for Structured Concurrency and Scope Locals. This is to >> make life a bit easier and avoid having to separate VM changes and juggle >> branches at this time. > > Alan Bateman has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains ten commits: > > - Refresh cf561073f48fad58e931a5285b92629aa83c9bd1 > - Merge with jdk-19+19 > - Refresh > - Refresh > - Refresh > - Refresh > - Merge with jdk-19+18 > - Refresh > - Initial push Test changes look good. One question/comment below - PR: https://git.openjdk.java.net/jdk/pull/8166
Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo What problem are you having editing the PR header? You should be able to do so as the author of the PR - PR: https://git.openjdk.java.net/jdk/pull/7268
Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo The changes look OK. The copyright year probably should be updated as part of this PR - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7268
Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189
Re: RFR: 8279918: Fix various doc typos [v2]
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote: >> - Most of the typos are of a trivial kind: missing whitespace. >> - If any of the typos should be fixed in the upstream projects instead, >> please say so; I will drop those typos from the patch. >> - As I understand it, ` ` in ImageInputStream and DataInput is an irrelevant >> formatting artefact and thus can be removed. >> - `'` is an apostrophe, which does not require to be encoded. > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Additional typos Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7063
Re: RFR: 8279918: Fix various doc typos [v2]
On Thu, 13 Jan 2022 13:48:02 GMT, Pavel Rappo wrote: > > Yes an "or" is probably worthwhile to add. > > I would prefer to leave it for the follow-up cleanup if only because adding > "or" here would make it inconsistent with other `@throws SQLException` > descriptions in that file and perhaps elsewhere in java.sql: > > * java/sql/Statement.java:59 > * java/sql/Statement.java:85 > * java/sql/Statement.java:346 > * java/sql/Statement.java:524 > * java/sql/Statement.java:745 > * java/sql/Statement.java:814 > * java/sql/Statement.java:860 > * java/sql/Statement.java:913 > * java/sql/Statement.java:962 > * java/sql/Statement.java:1225 > * java/sql/Statement.java:1269 > * java/sql/Statement.java:1314 I am fine with that. I guess a semi-colon could also be used vs. a comma to divide the Exception scenarios listed - PR: https://git.openjdk.java.net/jdk/pull/7063
Re: RFR: 8279918: Fix various doc typos [v2]
On Thu, 13 Jan 2022 12:37:46 GMT, Pavel Rappo wrote: > > The above is a bit confusing as it reads(same in ImageInputStream.java). I > > think that that can be looked at later. > > Just to clarify: you are okay with removing the ` ` entity, right? As for > ImageInputStream, some doc comments should probably use `@inheritDoc`. But > this is a much bigger clean-up. Yes I am. It just does not flow as well as it could IMHO - PR: https://git.openjdk.java.net/jdk/pull/7063
Re: RFR: 8279918: Fix various doc typos
On Thu, 13 Jan 2022 11:29:35 GMT, Pavel Rappo wrote:
>> src/java.sql/share/classes/java/sql/Statement.java line 784:
>>
>>> 782: * statement returns a {@code ResultSet} object, the second
>>> argument
>>> 783: * supplied to this method is not an
>>> 784: * {@code int} array whose elements are valid column indexes, the
>>> method is called on a
>>
>> Should it be "or the method is called on...", i.e. add the "or", otherwise
>> it's a list of problems but we don't know if they are all required, or are
>> alternatives. It probably does not mean that all these have to be true to
>> throw the exception, but it doesn't say that. We are nitpicking of course.
>
> You are right in that this `@throws` description reads a bit weird in its
> current form. That said, I wouldn't touch it in this PR for two reasons.
> Firstly, this wording seems to be consistent with other locations in that
> file. Secondly, this is a spec territory.
Yes an "or" is probably worthwhile to add.
-
PR: https://git.openjdk.java.net/jdk/pull/7063
Re: RFR: 8279918: Fix various doc typos
On Thu, 13 Jan 2022 11:28:34 GMT, Kevin Walls wrote: >> I thought about it too, but then noticed how the position of `[]` mimics >> that of the respective method signatures in code. > > OK, so lines 264, 295, 329, 364, 431 are arguably wrong as well? Separating > the [] completely looks quite rare. > I'll leave it up to you. 8-) I think that can be a follow on clean up. - PR: https://git.openjdk.java.net/jdk/pull/7063
Re: RFR: 8279918: Fix various doc typos
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream and DataInput is an irrelevant
> formatting artefact and thus can be removed.
> - `'` is an apostrophe, which does not require to be encoded.
Overall this looks good, thanks for the clean up :-)
A few comments below
src/java.base/share/classes/java/io/DataInput.java line 496:
> 494: * ceases. If the character {@code '\r'}
> 495: * is encountered, it is discarded and, if
> 496: * the following byte converts to the
The above is a bit confusing as it reads(same in ImageInputStream.java). I
think that that can be looked at later.
-
PR: https://git.openjdk.java.net/jdk/pull/7063
Re: RFR: JDK-8276681: Malformed Javadoc inline tags in JDK source jdk/internal/net/http/ResponseSubscribers.java
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote: > JDK-8276681: Malformed Javadoc inline tags in JDK source > jdk/internal/net/http/ResponseSubscribers.java Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6486
Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec for
> JEP 421. It also updates the relevant @SuppressWarning annotations.
>
> The CSR has been approved.
> An automated test build+test run passes cleanly (FWIW :D ).
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6465
Re: RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote: > More refactoring to limit the scope of `@SuppressWarnings` annotations. > > Sometimes I introduce new methods. Please feel free to suggest method names > you like to use. > > Note: this is copied from https://github.com/openjdk/jdk17/pull/152. The revisions you made as part of the push to JDK 18 look fine Max. - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4615
Re: [jdk17] RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K [v2]
On Fri, 25 Jun 2021 23:40:27 GMT, Weijun Wang wrote: >> More refactoring to limit the scope of `@SuppressWarnings` annotations. >> >> Sometimes I introduce new methods. Please feel free to suggest method names >> you like to use. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > one more Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/152
Re: [jdk17] RFR: 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote: > More refactoring to limit the scope of `@SuppressWarnings` annotations. > > Sometimes I introduce new methods. Please feel free to suggest method names > you like to use. Changes look good Max - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/152
Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v6]
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1 >> The essential change for this JEP, including the `@Deprecate` annotations >> and spec change. It also update the default value of the >> `java.security.manager` system property to "disallow", and necessary test >> change following this update. >> 2. >> https://github.com/openjdk/jdk/commit/26a54a835e9f84aa528740a7c5c35d07355a8a66 >> Manual changes to several files so that the next commit can be generated >> programatically. >> 3. >> https://github.com/openjdk/jdk/commit/eb6c566ff9207974a03a53335e0e697cffcf0950 >> Automatic changes to other source files to avoid javac warnings on >> deprecation for removal >> >> The 1st and 2nd commits should be reviewed carefully. The 3rd one is >> generated programmatically, see the comment below for more details. If you >> are only interested in a portion of the 3rd commit and would like to review >> it as a separate file, please comment here and I'll generate an individual >> webrev. >> >> Due to the size of this PR, no attempt is made to update copyright years for >> any file to minimize unnecessary merge conflict. >> >> Furthermore, since the default value of `java.security.manager` system >> property is now "disallow", most of the tests calling >> `System.setSecurityManager()` need to launched with >> `-Djava.security.manager=allow`. This is covered in a different PR at >> https://github.com/openjdk/jdk/pull/4071. >> >> Update: the deprecation annotations and javadoc tags, build, compiler, >> core-libs, hotspot, i18n, jmx, net, nio, security, and serviceability are >> reviewed. Rest are 2d, awt, beans, sound, and swing. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > default behavior reverted to allow Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4073
Re: RFR: JDK-8263104: fix warnings for empty paragraphs
On Fri, 5 Mar 2021 19:36:13 GMT, Jonathan Gibbons wrote: > Please review some simple cleanup for empty `` tags. > > Two of the tags are completely redundant, and simply deleted. > > The other three, in _package.html_ files are generally undesirable. Although > the presumed intent of the `id` declaration is to label the `@see` info, > proximity in the source code does not ensure proximity in the generated code. > The actual result is an empty paragraph at the end of the enclosing generated > ``, and before the generated output for the `@since` tag. > > The better solution is to move the `id` declaration into the `@see href...` and then delete the empty ``. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2850
Re: RFR: 8253497: Core Libs Terminology Refresh [v2]
On Tue, 15 Dec 2020 21:57:17 GMT, Brian Burkhalter wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates, per code review
>
> test/jdk/java/lang/ClassLoader/Assert.java line 65:
>
>> 63:
>> 64: int switchSource = 0;
>> 65: if (args.length == 0) { // This is the coordinator version
>
> Perhaps s/coordinator/controller/?
Let's change it to:
// This is the controller
-
PR: https://git.openjdk.java.net/jdk/pull/1771
Re: RFR: JDK-8255262: Remove use of legacy custom @spec tag
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote: > The change is (just) to remove legacy usages of a JDK-private custom tag. looks fine - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/814
Re: RFR: 8252537: Updated @exception with @throws [v4]
On Sun, 27 Sep 2020 12:46:21 GMT, Vipin Sharma wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks
>> of JDK-8252536.
>>
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>>
>> Previous conversation on this:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html
>
> Vipin Sharma has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Replaced ... with {@code ...} for modified statement in
> java.sql
The changes look good. Thank you for addressing this.
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/95
Re: RFR: 8252537: Updated @exception with @throws [v3]
On Thu, 24 Sep 2020 18:20:15 GMT, Vipin Sharma wrote:
> > Overall the changes look OK. in the java.sql set of classes, please updated
> > the modified statements to also use {@code}
>
> Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a
> separate bug JDK-8253612 to fix this for all
> java.sql and all other core-libs classes. Following is earlier discussion on
> this.
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068510.html
Hi Vipin, I agree overall that to replace all of places in the JDK with
{@code} where needed should be a separate task
with an umbrella issue with a subtask for each module. Unless there are a
large number of other exceptions that are
being modified and require updates for {@code} I would prefer to have it done
as part of this set of changes
-
PR: https://git.openjdk.java.net/jdk/pull/95
Re: RFR: 8252537: Updated @exception with @throws [v3]
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks
>> of JDK-8252536.
>>
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>>
>> Previous conversation on this:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html
>
> Vipin Sharma has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now
> contains one commit:
> JDK-8252537 Updated @exception with @throws, implemented review comments
Overall the changes look OK. in the java.sql set of classes, please updated
the modified statements to also use {@code}
src/java.sql/share/classes/java/sql/CallableStatement.java line 131:
> 129: * a ARRAY, BLOB, CLOB,
> 130: * DATALINK, JAVA_OBJECT,
> NCHAR,
> 131: * NCLOB, NVARCHAR,
> LONGNVARCHAR,
Please change to use {@code) as part of the update
src/java.sql/share/classes/java/sql/CallableStatement.java line 613:
> 611: * a ARRAY, BLOB, CLOB,
> 612: * DATALINK, JAVA_OBJECT,
> NCHAR,
> 613: * NCLOB, NVARCHAR,
> LONGNVARCHAR,
Same comment regarding {@code}
-
Changes requested by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/95
Re: RFR XS,docs,13 JDK-8226593 Fix HTML in com/sun/jdi/doc-files/signature.html
+1 > On Jun 21, 2019, at 2:58 PM, Jonathan Gibbons > wrote: > > Please review a fix for an accessibility issue reported by Axe in > src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html > > The issue is a conflict between an explicit `...`` > specified in the file and the automatic `` added by javadoc. The fix > is just to remove the `` element. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8226593 > > -- Jon > > > $ hg diff -R open > diff -r 97c75e545302 > src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html > --- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Fri Jun > 21 11:41:29 2019 -0700 > +++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Fri Jun > 21 11:52:35 2019 -0700 > @@ -40,7 +40,6 @@ > > > > - > JDI Type Signatures > > JDI Type Signatures > @@ -74,6 +73,5 @@ > has the following type signature: > (ILjava/lang/String;[I)J > > - > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Re: RFR: XXS,docs JDK-8225324 Bad HTML in jdk.jfr module-info.java
+1 > On Jun 4, 2019, at 7:47 PM, Jonathan Gibbons > wrote: > > Please review a fix to remove an unnecessary trailing from the > module-info file for jdk.jfr > > Patch below. > > -- Jon > > JBS: https://bugs.openjdk.java.net/browse/JDK-8225324 > > > $ hg diff -R open > diff -r e079a4cfad75 src/jdk.jfr/share/classes/module-info.java > --- a/src/jdk.jfr/share/classes/module-info.java Tue Jun 04 15:42:16 2019 > -0700 > +++ b/src/jdk.jfr/share/classes/module-info.java Tue Jun 04 16:40:53 2019 > -0700 > @@ -25,7 +25,6 @@ > > /** > * Defines the API for JDK Flight Recorder. > - * > * > * @moduleGraph > * @since 9 > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Re: RFR XS,docs JDK-8225309 HTML issues in jdk.jdi module
+1
> On Jun 4, 2019, at 5:42 PM, Jonathan Gibbons
> wrote:
>
> Please review another small patch for the jdk.jdi module, to fix a missing
> heading in one file and to adjust a heading in another.
>
> No webrev; patch below.
>
> That being said, the file
> src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html barely
> warrants being its own file, but even what content there is deserves to be
> fixed. The table caption is oversized, the table has no borders and not not
> use any CSS to "stripe" the rows. However, that cleanup is out of scope for
> this accessibility fix for the headings.
>
> -- Jon
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8225309
>
>
> $ hg diff -R open
> diff -r 4158e6a864d4
> src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
> --- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Tue Jun
> 04 13:47:59 2019 -0700
> +++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Tue Jun
> 04 14:35:34 2019 -0700
> @@ -41,6 +41,7 @@
>
>
>
> +JDI Type Signatures
>
> JDI Type Signatures
>
> diff -r 4158e6a864d4 src/jdk.jdi/share/classes/module-info.java
> --- a/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 13:47:59 2019
> -0700
> +++ b/src/jdk.jdi/share/classes/module-info.java Tue Jun 04 14:35:34 2019
> -0700
> @@ -46,7 +46,7 @@
> * This module includes a simple command-line debugger,
> * {@index jdb jdb tool}.
> *
> - * Global Exceptions
> + * Global Exceptions
> *
> * This section documents exceptions which apply to the entire API and are
> thus
> * not documented on individual methods.
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Re: RFR: XXS,doc JDK-8225207: redundant in Instrumentation.java
+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Jun 3, 2019, at 6:33 PM, Jonathan Gibbons > wrote: > > Please review a tiny delete-one-line change to fix the last HTML error in the > java.instrument module. > > Note to all: should only be used at the *beginning* of a paragraph. It is > not a terminator or separator. > In the context of a javadoc comment, it should not be used before the set of > block tags at the end of the comment. > > No webrev; patch is below. > > -- Jon > > JBS: https://bugs.openjdk.java.net/browse/JDK-8225207 > > $ hg diff -R open > diff -r 1cccaaf46c7b > src/java.instrument/share/classes/java/lang/instrument/Instrumentation.java > --- > a/src/java.instrument/share/classes/java/lang/instrument/Instrumentation.java > Mon Jun 03 10:52:18 2019 -0700 > +++ > b/src/java.instrument/share/classes/java/lang/instrument/Instrumentation.java > Mon Jun 03 15:27:43 2019 -0700 > @@ -65,7 +65,7 @@ > * > * Once an agent acquires an Instrumentation instance, > * the agent may call methods on the instance at any time. > - * > + * > * @apiNote This interface is not intended to be implemented outside of > * the java.instrument module. > * > >
Re: RFR: docs/accessibility: JDK-8220251: fix headings in java.management
looks ok Jon > On May 30, 2019, at 7:53 PM, Jonathan Gibbons > wrote: > > Please review a conceptually simple fix to adjust the rank of the headings in > the following files in 4 management-related modules: > > src/java.management.rmi/share/classes/javax/management/remote/rmi/package.html > src/java.management/share/classes/java/lang/management/LockInfo.java > src/java.management/share/classes/java/lang/management/ManagementFactory.java > src/java.management/share/classes/java/lang/management/MemoryMXBean.java > src/java.management/share/classes/java/lang/management/MemoryPoolMXBean.java > src/java.management/share/classes/java/lang/management/MemoryUsage.java > src/java.management/share/classes/java/lang/management/MonitorInfo.java > src/java.management/share/classes/java/lang/management/ThreadInfo.java > src/java.management/share/classes/java/lang/management/ThreadMXBean.java > src/java.management/share/classes/java/lang/management/package.html > src/java.management/share/classes/javax/management/MXBean.java > src/java.management/share/classes/javax/management/NotificationBroadcaster.java > src/java.management/share/classes/javax/management/NotificationEmitter.java > src/java.management/share/classes/javax/management/remote/package.html > src/jdk.management.jfr/share/classes/jdk/management/jfr/FlightRecorderMXBean.java > src/jdk.management/share/classes/com/sun/management/GcInfo.java > > In most files, the headings are simply adjusted "up" to close up "gaps" in > the sequence of headings. In a couple of files, the headings were > inconsistent and have been updated as seems best. To help understand the > changes, I've attached the output of a script that shows the lines containing > headings before and after the change. > > -- Jon > > JBS: https://bugs.openjdk.java.net/browse/JDK-8220251 > Webrev: http://cr.openjdk.java.net/~jjg/8220251/webrev.00/webrev/index.html > Docs: http://cr.openjdk.java.net/~jjg/8220251/docs/api/index.html > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Re: RFR (S): 8203500: Fix broken links to Specification in "specs" directory
The change looks fine. Iris
> On May 21, 2018, at 6:54 PM, Iris Clark wrote:
>
> Hi.
>
>
>
> Please review this small change to fix a few broken links to
>
> Specification in the "specs" directory from the JavaDoc API.
>
> The incorrect references either not include "{@docRoot}" or
>
> include the non-existent "{@docRootParent}". They should all
>
> begin with "{@docRoot}/../specs/".
>
>
>
> Bug:
>
>
>
>8203500 Fix broken links to Specification in "spec" directory
>
>https://bugs.openjdk.java.net/browse/JDK-8203500
>
>
>
> webrev:
>
>
>
>http://cr.openjdk.java.net/~iris/8203500/webrev/
>
>
>
> Thanks,
>
> Iris
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Re: JDK 9 RFR for JDK-8174241: ProblemList update for TestWsImport, JdbMethodExitTest and jimage tests
+1 > On Feb 9, 2017, at 4:32 AM, Amy Lu wrote: > > Please review the ProblemList.txt cleanup on updating bugid for several tests. > > javax/xml/ws/clientjar/TestWsImport.java8170370 generic-all > This test is in ProblemList, related bug JDK-8170370 has been resolved. Test > is going to be revisited in JDK-8173317 > > tools/jimage/JImageExtractTest.java 8169713 generic-all > tools/jimage/JImageListTest.java 8169713 generic-all > tools/jimage/JImageVerifyTest.java 8169713 generic-all > Mentioned bug JDK-8169713 has been closed, while test is going to be fixed in > JDK-8170120 > > com/sun/jdi/JdbMethodExitTest.sh 6902121 generic-all > Mentioned bug JDK-6902121 has been closed, test is going to be revisited in > JDK-8171483 > > Thanks, > Amy > > > > --- old/test/ProblemList.txt 2017-02-09 17:28:52.0 +0800 > +++ new/test/ProblemList.txt 2017-02-09 17:28:51.0 +0800 > @@ -253,9 +253,9 @@ > tools/launcher/FXLauncherTest.java 8068049 > linux-all,macosx-all > -tools/jimage/JImageExtractTest.java 8169713 > generic-all > -tools/jimage/JImageListTest.java8169713 > generic-all > -tools/jimage/JImageVerifyTest.java 8169713 > generic-all > +tools/jimage/JImageExtractTest.java 8170120 > generic-all > +tools/jimage/JImageListTest.java8170120 > generic-all > +tools/jimage/JImageVerifyTest.java 8170120 > generic-all > tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java 8169971 > windows-x64 > @@ -266,7 +266,7 @@ > com/sun/jdi/RedefineImplementor.sh 8004127 > generic-all > -com/sun/jdi/JdbMethodExitTest.sh6902121 > generic-all > +com/sun/jdi/JdbMethodExitTest.sh8171483 > generic-all > com/sun/jdi/RepStep.java8043571 > generic-all > @@ -307,6 +307,6 @@ > javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java 8169737 > linux-all > -javax/xml/ws/clientjar/TestWsImport.java 8170370 > generic-all > +javax/xml/ws/clientjar/TestWsImport.java 8173317 > generic-all > > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
Re: JDK 9 RFR of JDK-8072371: Add two failing svc tests to the problem list
loos fine joe On Feb 2, 2015, at 7:18 PM, joe darcy wrote: > Hello, > > We've observed two serviceability tests failing on mac platforms; I'd like to > put those tests on the problem list while the underlying causes are under > investigation: > >http://cr.openjdk.java.net/~darcy/8072371.0/ > > Patch below. > > Thanks, > > -Joe > > --- old/test/ProblemList.txt2015-02-02 16:14:34.644778488 -0800 > +++ new/test/ProblemList.txt2015-02-02 16:14:34.476778493 -0800 > @@ -132,6 +132,9 @@ > java/lang/instrument/RedefineBigClass.sh generic-all > java/lang/instrument/RetransformBigClass.sh generic-all > > +# 8072130 > +java/lang/instrument/BootClassPath/BootClassPathTest.sh macosx-all > + > > > # jdk_management > @@ -320,6 +323,9 @@ > # 8031482 > sun/tools/jcmd/TestJcmdSanity.javawindows-all > > +# 8072131 > +sun/tools/jmap/heapconfig/JMapHeapConfigTest.java macosx-all > + > # 8027668 > sun/tools/jstatd/TestJstatdDefaults.javageneric-all > sun/tools/jstatd/TestJstatdServer.java generic-all > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
Re: JDK 9 RFR of JDK-8054050: Fix stay raw and unchecked lint warnings in core libs
ava
> 2014-07-31 10:51:22.0 -0700
> @@ -39,7 +39,7 @@
> // Warnings from List filters and List[] requestLists is hard to fix.
> // Remove SuppressWarning when we fix the warnings from List filters
> // and List[] requestLists. The generic array is not supported.
> -@SuppressWarnings("unchecked")
> +@SuppressWarnings({"unchecked", "rawtypes"})
> class EventRequestManagerImpl extends MirrorImpl
>implements EventRequestManager
> {
> --- old/src/share/classes/jdk/nio/zipfs/ZipFileAttributeView.java 2014-07-31
> 10:51:22.0 -0700
> +++ new/src/share/classes/jdk/nio/zipfs/ZipFileAttributeView.java 2014-07-31
> 10:51:22.0 -0700
> @@ -59,6 +59,7 @@
> this.isZipView = isZipView;
> }
>
> +@SuppressWarnings("unchecked") // Cast to V
> static V get(ZipPath path, Class type) {
> if (type == null)
> throw new NullPointerException();
> --- old/src/share/classes/jdk/nio/zipfs/ZipFileSystemProvider.java 2014-07-31
> 10:51:23.0 -0700
> +++ new/src/share/classes/jdk/nio/zipfs/ZipFileSystemProvider.java 2014-07-31
> 10:51:23.0 -0700
> @@ -271,6 +271,7 @@
> }
>
> @Override
> +@SuppressWarnings("unchecked") // Cast to A
> public A
> readAttributes(Path path, Class type, LinkOption... options)
> throws IOException
> --- old/src/solaris/classes/sun/nio/ch/InheritedChannel.java 2014-07-31
> 10:51:24.0 -0700
> +++ new/src/solaris/classes/sun/nio/ch/InheritedChannel.java 2014-07-31
> 10:51:23.0 -0700
> @@ -165,7 +165,7 @@
> // Have to use reflection and also make assumption on how FD
> // is implemented.
>
> -Class paramTypes[] = { int.class };
> +Class paramTypes[] = { int.class };
> Constructor ctr =
> Reflect.lookupConstructor("java.io.FileDescriptor",
>paramTypes);
> Object args[] = { new Integer(fdVal) };
>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Re: RFR 80044461: Cleanup new Boolean and single character strings
Looks fine On May 30, 2014, at 2:30 PM, roger riggs wrote: > A quick sanity check please for these cleanup changes to remove uses of > new Boolean and using chars instead of single character strings contributed > by Otávio Gonçalves de Santana. > > These changes update multiple classes in the jdk9-dev repo (except client > packages). > > webrev: http://cr.openjdk.java.net/~rriggs/webrev-8044461-cleanup/ > Issue: https://bugs.openjdk.java.net/browse/JDK-8044461 > > Thanks, Roger > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
hg: jdk8/tl/jdk: 8029417: JDBC 4.2 javadoc updates
Changeset: bcf5fa5e9509 Author:lancea Date: 2013-12-02 16:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf5fa5e9509 8029417: JDBC 4.2 javadoc updates Reviewed-by: darcy ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLPermission.java
hg: jdk8/tl/jdk: 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal
Changeset: 59ff7957c26f Author:lancea Date: 2013-11-11 14:22 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59ff7957c26f 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/BaseRow.java
hg: jdk8/tl/jdk: 8026812: doclint clean up for java.sql and javax.sql
Changeset: 64c0ac7cd936 Author:lancea Date: 2013-10-17 15:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64c0ac7cd936 8026812: doclint clean up for java.sql and javax.sql Reviewed-by: mduigou ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Connection.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLException.java ! src/share/classes/java/sql/SQLFeatureNotSupportedException.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/sql/SQLWarning.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/javax/sql/CommonDataSource.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/share/classes/javax/sql/rowset/JoinRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/WebRowSet.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java
hg: jdk8/tl/jdk: 7097386: Correct error in Predicate javadoc example
Changeset: 657482758408 Author:lancea Date: 2013-09-17 07:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/657482758408 7097386: Correct error in Predicate javadoc example Reviewed-by: alanb, shade ! src/share/classes/javax/sql/rowset/Predicate.java
hg: jdk8/tl/jdk: 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null
Changeset: 5c7690923663 Author:lancea Date: 2013-09-13 19:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7690923663 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java
hg: jdk8/tl/jdk: 8015340: remove erroneous @since tag
Changeset: 60d6f60416ca Author:lancea Date: 2013-09-12 13:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60d6f60416ca 8015340: remove erroneous @since tag Reviewed-by: darcy ! src/share/classes/java/sql/PreparedStatement.java
hg: jdk8/tl/jdk: 8022753: SQLXML javadoc example typo
Changeset: cc64a05836a7 Author:lancea Date: 2013-08-12 16:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc64a05836a7 8022753: SQLXML javadoc example typo Reviewed-by: alanb, mchung ! src/share/classes/java/sql/SQLXML.java
hg: jdk8/tl/jdk: 8019286: Fix javadoc typo in ResultSet.next
Changeset: a4eb59bffb60 Author:lancea Date: 2013-06-29 06:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4eb59bffb60 8019286: Fix javadoc typo in ResultSet.next Reviewed-by: darcy, mchung ! src/share/classes/java/sql/ResultSet.java
hg: jdk8/tl/jdk: 8017471: Fix JDBC -Xdoclint public errors
Changeset: b9ba04dc210f Author:lancea Date: 2013-06-27 15:07 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9ba04dc210f 8017471: Fix JDBC -Xdoclint public errors Reviewed-by: darcy ! src/share/classes/java/sql/Blob.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Clob.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverAction.java ! src/share/classes/java/sql/NClob.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLInput.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Wrapper.java ! src/share/classes/javax/sql/CommonDataSource.java ! src/share/classes/javax/sql/ConnectionPoolDataSource.java ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/RowSetWarning.java ! src/share/classes/javax/sql/rowset/WebRowSet.java ! src/share/classes/javax/sql/rowset/package.html ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java
hg: jdk8/tl/jdk: 8016101: Fix typo in SerialRef and missing @param in SerialStruct
Changeset: e2333bd8514a Author:lancea Date: 2013-06-07 14:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2333bd8514a 8016101: Fix typo in SerialRef and missing @param in SerialStruct Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java
hg: jdk8/tl/jdk: 8010416: Add a way for java.sql.Driver to be notified when it is deregistered
Changeset: ac3e189c9099 Author:lancea Date: 2013-04-30 14:44 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac3e189c9099 8010416: Add a way for java.sql.Driver to be notified when it is deregistered Reviewed-by: alanb, ulfzibis ! src/share/classes/java/sql/Driver.java + src/share/classes/java/sql/DriverAction.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/SQLPermission.java
hg: jdk8/tl/jdk: 8011620: adding free form netbeans project for jdbc to jdk/make/netbeans
Changeset: b456f25c2075 Author:lancea Date: 2013-04-23 11:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b456f25c2075 8011620: adding free form netbeans project for jdbc to jdk/make/netbeans Reviewed-by: chegar ! make/netbeans/common/shared.xml + make/netbeans/jdbc/README + make/netbeans/jdbc/build.properties + make/netbeans/jdbc/build.xml + make/netbeans/jdbc/nbproject/project.xml
Re: Review Request: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt
+1 On Apr 18, 2013, at 2:07 PM, Mandy Chung wrote: > This fix adds GetSafepointSyncTime.java test in the ProblemList.txt > until 8010897 is resolved. It has been failing intermittently on macosx-x64. > > diff --git a/test/ProblemList.txt b/test/ProblemList.txt > --- a/test/ProblemList.txt > +++ b/test/ProblemList.txt > @@ -144,6 +144,9 @@ > > # jdk_management > > +# 8010897 > +sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java macosx-all > + > #### > > # jdk_jmx > > <> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
hg: jdk8/tl/jdk: 8006036: (process) cleanup code in java/lang/Runtime/exec/WinCommand.java
Changeset: 04617e462512 Author:lancea Date: 2013-04-08 15:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04617e462512 8006036: (process) cleanup code in java/lang/Runtime/exec/WinCommand.java Reviewed-by: lancea Contributed-by: Jim Gish ! test/java/lang/Runtime/exec/WinCommand.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 9f9dac5a9e74 Author:lancea Date: 2013-02-22 09:29 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f9dac5a9e74 8008716: address typo in CallableStatement javadocs Reviewed-by: chegar ! src/share/classes/java/sql/CallableStatement.java Changeset: 8d8a35ac7d40 Author:lancea Date: 2013-02-22 09:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d8a35ac7d40 Merge
Re: 8008662: Add @jdk.Supported to JDK-specific/supported API
Well, that was quite a few files to have to go through :-) Looks fine On Feb 21, 2013, at 1:46 PM, Alan Bateman wrote: > > Joe Darcy recently added @jdk.Supported [1] to make it possible to identify > JDK-specific APIs. > > I'd like to add this to a number of APIs in the com.sun namespace to make it > obvious these are "supported". Specifically I'm proposing to add it to: > > - Java Debug Interface (com.sun.jdi) > - Attach API (com.sun.tools.attach) > - SCTP API (com.sun.nio.sctp) > - HTTP server API (com.sun.net.httpserver) > - Management extensions (com.sun.management) > - JDK-specific API to JAAS (com.sun.security.auth) > - JDK-specific JGSS API (com.sun.security.jgss) > > The javadoc for all of these is generated as part of the regular JDK "docs" > build and so shouldn't be controversial. There are a number of other > candidates in com.sun with murkier status that I've stayed clear of for now. > > The webrev with the changes is here: > > http://cr.openjdk.java.net/~alanb/8008662/webrev/ > > In a couple of cases the package description is legacy package.html so I've > had to move/convert them to package-info.java. > > In all but one case I've added the annotation to the package-info, the one > exception is com.sun.management where there is at least one type that is > documented as "not supported". Joe Darcy might have suggestions on that. > > Otherwise this is mostly mechanical and the patch file is easier to review > that the webrev. > > -Alan > > [1] http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55cca2f38ee6 <> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
hg: jdk8/tl/jdk: 8006505: additional changes for JSR 310 support
Changeset: 1574fa3df1c0 Author:lancea Date: 2013-02-06 14:15 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1574fa3df1c0 8006505: additional changes for JSR 310 support Reviewed-by: naoto, ulfzibis ! src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/SQLInput.java ! src/share/classes/java/sql/SQLOutput.java ! src/share/classes/java/sql/Types.java
hg: jdk8/tl/jdk: 8006642: Fix javadoc warnings due to Integer.MAX_VALUE
Changeset: de30e46250c5 Author:lancea Date: 2013-01-21 14:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de30e46250c5 8006642: Fix javadoc warnings due to Integer.MAX_VALUE Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java
hg: jdk8/tl/jdk: 8005080: JDBC 4.2 Core changes
Changeset: d3da0d29d7cd Author:lancea Date: 2013-01-19 10:53 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3da0d29d7cd 8005080: JDBC 4.2 Core changes Reviewed-by: naoto ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverManager.java + src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLTimeoutException.java + src/share/classes/java/sql/SQLType.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Types.java ! src/share/classes/java/sql/package.html ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java
hg: jdk8/tl/jdk: 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl
Changeset: 78514544980d Author:lancea Date: 2013-01-19 10:11 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78514544980d 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl Reviewed-by: naoto, ulfzibis, alanb ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java
Re: RFR (trivial): 8003632 HPROF class file version java.lang.RuntimeException errors
+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone On Dec 13, 2012, at 6:30 PM, David Holmes wrote: > Trivial update of max classfile version to 52. > > http://cr.openjdk.java.net/~dholmes/8003632/webrev/ > > Pushing through tl/jdk > > Thanks, > David
hg: jdk8/tl/jdk: 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety
Changeset: 7a8978a5bb6e Author:lancea Date: 2012-12-12 20:57 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8978a5bb6e 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Reviewed-by: naoto ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java
hg: jdk8/tl/jdk: 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException
Changeset: 41a1b110f34d Author:lancea Date: 2012-12-06 15:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41a1b110f34d 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Reviewed-by: naoto ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java
hg: jdk8/tl/jdk: 8001536: Added readObject, writeObject, clone, equals, hashcode to SerialXLob
Changeset: 8748331f63cf Author:lancea Date: 2012-11-01 17:35 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8748331f63cf 8001536: Added readObject,writeObject,clone, equals, hashcode to SerialXLob Reviewed-by: alanb, forax ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java
hg: jdk8/tl/jdk: 8000712: Remove unused fields in SyncFactory
Changeset: 734ca9f4719c Author:lancea Date: 2012-10-10 17:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/734ca9f4719c 8000712: Remove unused fields in SyncFactory Reviewed-by: mchung ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
hg: jdk8/tl/jdk: 8000687: Correct javadoc typo for getLogWriter and setLogWriter
Changeset: 3c4be36de073 Author:lancea Date: 2012-10-10 11:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c4be36de073 8000687: Correct javadoc typo for getLogWriter and setLogWriter Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java
hg: jdk8/tl/jdk: 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC
Changeset: 036c55976cef Author:lancea Date: 2012-10-09 08:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC Reviewed-by: alanb, smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java
hg: jdk8/tl/jdk: 7192302: Remove JDBCRowSetImpl dependency on java.beans
Changeset: 8c6895afe204 Author:lancea Date: 2012-09-06 13:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c6895afe204 7192302: Remove JDBCRowSetImpl dependency on java.beans Reviewed-by: alanb, mchung ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java
hg: jdk8/tl/jdk: 7193683: DriverManager Iterator Warning cleanup
Changeset: 11bfec75d333 Author:lancea Date: 2012-08-30 13:38 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11bfec75d333 7193683: DriverManager Iterator Warning cleanup Reviewed-by: lancea Contributed-by: Dan Xu ! src/share/classes/java/sql/DriverManager.java
hg: jdk8/tl/jdk: 7145913: CachedRowSetSwriter.insertNewRow() throws SQLException
Changeset: 28588ace1fb9 Author:lancea Date: 2012-06-14 15:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28588ace1fb9 7145913: CachedRowSetSwriter.insertNewRow() throws SQLException Reviewed-by: joehw, naoto, psandoz, forax ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java
hg: jdk8/tl/jdk: 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly
Changeset: 6b6a73e8c036 Author:lancea Date: 2012-06-12 17:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b6a73e8c036 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java
hg: jdk8/tl/jdk: 7171917: CachedRowSetImpl.populate does not handle map properly
Changeset: 46ff1b63b0c3 Author:lancea Date: 2012-06-11 07:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ff1b63b0c3 7171917: CachedRowSetImpl.populate does not handle map properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 8305ddc88a5a Author:lancea Date: 2012-06-07 20:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8305ddc88a5a 7172551: Remove Native calls from DriverManager for jigsaw Reviewed-by: alanb, chegar, darcy, mchung ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/java/java/FILES_c.gmk ! makefiles/java/java/mapfile-vers ! src/share/classes/java/sql/DriverManager.java - src/share/native/java/sql/DriverManager.c Changeset: 7cb7bfae9d3a Author:lancea Date: 2012-06-08 09:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cb7bfae9d3a Merge
hg: jdk8/tl/jdk: 7166598: FilteredRowSetImpl can result in Invalid Cursor Position
Changeset: 4580652d9828 Author:lancea Date: 2012-05-04 16:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4580652d9828 7166598: FilteredRowSetImpl can result in Invalid Cursor Position Reviewed-by: lancea Contributed-by: Knut Anders Hatlen ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java
hg: jdk8/tl/jdk: 7133815: address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl
Changeset: b518b160607f Author:lancea Date: 2012-01-26 19:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b518b160607f 7133815: address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl Reviewed-by: forax ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/BaseRow.java ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java
hg: jdk8/tl/jdk: 7132879: address Findbugs issue in WebRowSetXmlWriter
Changeset: 303b67074666 Author:lancea Date: 2012-01-24 15:13 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/303b67074666 7132879: address Findbugs issue in WebRowSetXmlWriter Reviewed-by: forax ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java
hg: jdk8/tl/jdk: 7116445: Miscellaneous warnings in the JDBC/RowSet classes
Changeset: 3c524deb8431 Author:lancea Date: 2011-12-02 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431 7116445: Miscellaneous warnings in the JDBC/RowSet classes Reviewed-by: smarks, chegar ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/WebRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetReader.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/Row.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/Time.java ! src/share/classes/java/sql/Timestamp.java ! src/share/classes/javax/sql/StatementEvent.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
Re: 7117357: Warnings in sun.instrument, tools and other sun.* classes
Looks good to meBestLanceOn Dec 2, 2011, at 8:42 AM, Alan Bateman wrote:I'm down on the sign-up sheet for warnings in a couple of arcane areas. The following webrev fixes the warnings in sun.instrument.*, several serviceability tools, serialver, and some residual warnings left in sun.net.**. I've run all the tests for all these areas with the changes.http://cr.openjdk.java.net/~alanb/7117357/webrev/Thanks,Alan. Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037Oracle Java Engineering 1 Network Drive Burlington, MA 01803lance.ander...@oracle.com
hg: jdk8/tl/jdk: 7110111: Minor Java SE javadoc & Constructor clean up
Changeset: 830d2e46023a Author:lancea Date: 2011-11-10 11:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/830d2e46023a 7110111: Minor Java SE javadoc & Constructor clean up Reviewed-by: alanb, darcy Contributed-by: Martin Desruisseaux ! src/share/classes/java/io/Writer.java ! src/share/classes/java/lang/AssertionError.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/util/jar/Attributes.java
hg: jdk8/tl/jdk: 7077451: SerialLob, SerialClob have the wrong checks for setStream methods
Changeset: 7676670d1e97 Author:lancea Date: 2011-08-10 16:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97 7077451: SerialLob, SerialClob have the wrong checks for setStream methods Reviewed-by: alanb Contributed-by: Patrick Reinhart ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java + test/javax/sql/rowset/serial/SerialBlob/SetBinaryStream.java + test/javax/sql/rowset/serial/SerialClob/SetAsciiStream.java + test/javax/sql/rowset/serial/SerialClob/SetCharacterStream.java
hg: jdk7/tl/jdk: 7049107: Cannot call initCause() on BatchUpdateException
Changeset: a00f48c96345 Author:lancea Date: 2011-06-02 12:02 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a00f48c96345 7049107: Cannot call initCause() on BatchUpdateException Reviewed-by: darcy ! src/share/classes/java/sql/BatchUpdateException.java
hg: jdk7/tl/jdk: 7043443: address missed reason initialization in BatchUpdateException
Changeset: 6a3a41e0af88 Author:lancea Date: 2011-05-10 14:41 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a3a41e0af88 7043443: address missed reason initialization in BatchUpdateException Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java
hg: jdk7/tl/jdk: 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow
Changeset: 0b1354ecf5a3 Author:lancea Date: 2011-04-29 09:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1354ecf5a3 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow Reviewed-by: smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
hg: jdk7/tl/jdk: 7038565: address Findbugs issue in BatchUpdateException
Changeset: 28caa191884a Author:lancea Date: 2011-04-28 09:46 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/28caa191884a 7038565: address Findbugs issue in BatchUpdateException Reviewed-by: alanb, forax ! src/share/classes/java/sql/BatchUpdateException.java
hg: jdk7/tl/jdk: 7037085: Add hashCode() to Timestamp to address Findbugs warning
Changeset: 9b3e6baad033 Author:lancea Date: 2011-04-18 12:07 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b3e6baad033 7037085: Add hashCode() to Timestamp to address Findbugs warning Reviewed-by: darcy, alanb, emcmanus ! src/share/classes/java/sql/Timestamp.java
hg: jdk7/tl/jdk: 7036251: Correct SQLPermission constructor javadocs for permission target names
Changeset: d9248245a88c Author:lancea Date: 2011-04-13 11:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9248245a88c 7036251: Correct SQLPermission constructor javadocs for permission target names Reviewed-by: alanb ! src/share/classes/java/sql/SQLPermission.java
hg: jdk7/tl/jdk: 7007772: Address typos in javadoc for ResultSet
Changeset: 0bae251b548b Author:lancea Date: 2011-04-12 14:32 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bae251b548b 7007772: Address typos in javadoc for ResultSet Reviewed-by: ohair, smarks ! src/share/classes/java/sql/ResultSet.java
hg: jdk7/tl/jdk: 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset
Changeset: 1bb95f6ac753 Author:lancea Date: 2011-04-12 12:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bb95f6ac753 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset Reviewed-by: alanb, darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java
hg: jdk7/tl/jdk: 7034656: Address lint warnings for DriverManager
Changeset: 5137806a3e34 Author:lancea Date: 2011-04-07 11:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5137806a3e34 7034656: Address lint warnings for DriverManager Reviewed-by: alanb, forax, ohair ! src/share/classes/java/sql/DriverManager.java
hg: jdk7/tl/jdk: 7034471: Wrap registeredDrivers in DriverManager
Changeset: d5bc10b1aa2c Author:lancea Date: 2011-04-06 17:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5bc10b1aa2c 7034471: Wrap registeredDrivers in DriverManager Reviewed-by: alanb, briangoetz ! src/share/classes/java/sql/DriverManager.java
hg: jdk7/tl/jdk: 7026898: DriverManager to now use CopyOnWriteArrayList
Changeset: df9991dc1f0d Author:lancea Date: 2011-03-17 11:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df9991dc1f0d 7026898: DriverManager to now use CopyOnWriteArrayList Reviewed-by: alanb, briangoetz ! src/share/classes/java/sql/DriverManager.java
hg: jdk7/tl/jdk: 7014095: Broken link in java.sql package specification
Changeset: 9599534b1727 Author:lancea Date: 2011-02-04 09:07 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9599534b1727 7014095: Broken link in java.sql package specification Reviewed-by: alanb ! src/share/classes/java/sql/package.html
hg: jdk7/tl/jdk: 7000693: java.sql.Timestamp compareTo() issues using low values
Changeset: befe813e24d2 Author:lancea Date: 2011-01-11 12:36 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/befe813e24d2 7000693: java.sql.Timestamp compareTo() issues using low values Reviewed-by: okutsu ! src/share/classes/java/sql/Timestamp.java
hg: jdk7/tl/jdk: 6544224: Remove the need of sun.reflect.misc
Changeset: f4d755bbdabe Author:lancea Date: 2011-01-10 14:43 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4d755bbdabe 6544224: Remove the need of sun.reflect.misc Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java
hg: jdk7/tl/jdk: 7006454: Typo in javadocs typo for Statement.executeBatch @since
Changeset: a72e7147816f Author:lancea Date: 2010-12-14 16:08 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a72e7147816f 7006454: Typo in javadocs typo for Statement.executeBatch @since Reviewed-by: alanb ! src/share/classes/java/sql/Statement.java
hg: jdk7/tl/jdk: 6659234: Incorrect check in SerialBlob.getBytes
Changeset: 1bf378034d39 Author:lancea Date: 2010-12-09 13:01 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bf378034d39 6659234: Incorrect check in SerialBlob.getBytes Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: ff619988afac Author:lancea Date: 2010-11-19 17:15 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff619988afac 7000752: Duplicate entry in RowSetResourceBundles.properties Reviewed-by: alanb ! src/share/classes/com/sun/rowset/RowSetResourceBundle.properties ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java Changeset: bf407ff3e97b Author:lancea Date: 2010-11-19 17:18 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf407ff3e97b 7001669: Typo in javadocs for SQLPermission Reviewed-by: alanb ! src/share/classes/java/sql/SQLPermission.java
hg: jdk7/tl/jdk: 6999086: Clarify that SyncFactory.setLogger can throw an NullPointerException
Changeset: c4a38022fdc1 Author:lancea Date: 2010-11-12 08:41 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4a38022fdc1 6999086: Clarify that SyncFactory.setLogger can throw an NullPointerException Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
hg: jdk7/tl/jdk: 6982530: javadoc update to SyncFactory & JdbcResource bundle for synchronization issues
Changeset: af2de4de1076 Author:lancea Date: 2010-11-12 07:15 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/af2de4de1076 6982530: javadoc update to SyncFactory & JdbcResource bundle for synchronization issues Reviewed-by: alanb ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
hg: jdk7/tl/jdk: 2 new changesets
Changeset: 0f23a139e819 Author:lancea Date: 2010-10-06 10:09 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f23a139e819 6988310: SyncFactory.setLogger(Logger,Level) requires unspecified security permission Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java Changeset: 6fd4928b82a2 Author:lancea Date: 2010-10-06 10:11 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6fd4928b82a2 6988317: RowSetProvider.newFactory() may throw unspecified exception Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/RowSetProvider.java
hg: jdk7/tl/jdk: 6989139: Address JDBC Findbugs where Number type Constructor are used
Changeset: ffaf6a35b895 Author:lancea Date: 2010-10-04 13:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ffaf6a35b895 6989139: Address JDBC Findbugs where Number type Constructor are used Reviewed-by: ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java
hg: jdk7/tl/jdk: 6988993: Address Findbugs warnings for the use of String Constructor
Changeset: 9a8022905f6a Author:lancea Date: 2010-10-01 14:36 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a8022905f6a 6988993: Address Findbugs warnings for the use of String Constructor Reviewed-by: ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java
hg: jdk7/tl/jdk: 6987638: javadoc update to RowSetProvider and Statement
Changeset: 7b2b0131fa61 Author:lancea Date: 2010-09-27 18:05 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b2b0131fa61 6987638: javadoc update to RowSetProvider and Statement Reviewed-by: darcy, alanb ! src/share/classes/java/sql/Statement.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java
