Re: 15 RFR(XS): 8165276: Spec states that invoke the premain method in an agent class if it's public but implementation differs

[sundararajan . athijegannathan]

Looks good

-Sundar

On 24/06/20 7:35 am, serguei.spit...@oracle.com wrote:

Please, review a fix for:
  https://bugs.openjdk.java.net/browse/JDK-8165276


CSR draft (one CSR reviewer is needed before finalizing it):
  https://bugs.openjdk.java.net/browse/JDK-8248189


Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/instr-setAccessible.1/


The java.lang.instrument spec:
https://docs.oracle.com/en/java/javase/14/docs/api/java.instrument/java/lang/instrument/package-summary.html 




Summary:
  The java.lang.instrument spec clearly states:
    "The agent class must implement a public static premain method
     similar in principle to the main application entry point."
  Current implementation of sun/instrument/InstrumentationImpl.java
  allows the premain method be non-public which violates the spec.
  This fix aligns the implementation with the spec.


Testing:
  A mach5 run of jdk_instrument tests is in progress.


Thanks,
Serguei

Re: RFR(S): 8244668: Remove SA's javascript support

[sundararajan . athijegannathan]

Hi Chris,

Yes.

There are bugs with the label "nashorn_removal" for uses of nashorn. 
Many scripts are needed for now (till the respective test or make file 
use etc. are "ported" to do something else. For eg. make use of .js 
falls back to bootjdk for now).


Thanks

-Sundar

On 28/05/20 9:40 am, Chris Plummer wrote:

Hi Sundar,

make, test, doc, and bin all have .js files. I was counting them in 
them also. 36 total files (not 36 directories).


thanks,

Chris

On 5/27/20 8:12 PM, sundararajan.athijegannat...@oracle.com wrote:


Hi Chris,

Note that not all .js files are related to nashorn!

* The one in java.scripting module is init.js file used by jrunscript 
tool. The jrunscript is javax.script based scripting language 
independent shell tool. It uses init.js script if the underlying 
language engine happens to be 'javascript'. This tool still exists 
and can use js engine if user drops suitable js engine jar in 
classpath/modulepath.


* The ones in jdk.javadoc are used in the browser (jquery, 
search.js). There is a script to test javadoc's search feature. The 
test looks for js engine before using the test. Developer can drop 
another js engine and run the test.


PS. "find . -name *.java" found only 10 .js paths in "jdk/src" 
directory.36 directories?


Thanks
-Sundar

On 27/05/20 10:08 pm, Chris Plummer wrote:

Hi Serguei,

Possibly those should be deleted, but not as part of the removal of 
JS support from SA. They are for .js files in src/java.scripting, 
src/jdk.javadoc, and src/jdk.dev. There are no longer any .js files 
in src/jdk.dev, but there are in the other two directories. There 
are bunch more in other directories not listed, 36 in total. I'm 
guessing that some should have been removed when Nashorn was 
removed. Maybe Sundar can comment on this.


thanks,

Chris

On 5/27/20 1:56 AM, serguei.spit...@oracle.com wrote:

Hi Chris,

A couple of questions.

http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/make/CompileJavaModules.gmk.udiff.html 
-jdk.hotspot.agent_COPY += .gif .png sa.js .properties

+jdk.hotspot.agent_COPY += .gif .png .properties
There are more occurrences of the .js in that file:
  215 java.scripting_COPY += .js
  346 jdk.javadoc_COPY += .xml .css .js .png
  416 jdk.dev_COPY += .js oqlhelp.html .txt
Should all these be deleted?

Otherwise, looks good.
No need in another webrev.

Thanks,
Serguei


On 5/26/20 19:42, sundararajan.athijegannat...@oracle.com wrote:

Looks good to me.

-Sundar

On 27/05/20 5:01 am, Chris Plummer wrote:

Hello,

Please review the following changes to fully remove javascript 
support from SA. It's been non-functional since JDK 9 and there 
are no plans to support it anymore.


https://bugs.openjdk.java.net/browse/JDK-8244668
http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/index.html

If anyone thinks a CSR is needed for this, please let me know. 
There's no spec involved. The support was always pretty ad hoc, 
with some supporting documentation in the source tree in 
jsdb.html [1], but which doesn't appear itself to have ever been 
released.


There was one menu item in the hsdb GUI that used javascript (and 
as a result caused an exception). I was having a little trouble 
deciphering what it actually does, but it appears to allow you to 
write some javascript to produce (and filter) a list of objects, 
and then display the list of objects in a window where you could 
inspect them further. Since there is no way to do something 
similar in java without allowing the user to provide hsdb 
extensions in the form of .class files (or support writing and 
compiling java classes from within hsdb), I just removed the hsdb 
feature by removing the menu item and supporting code.


thanks,

Chris

[1] 
https://hg.openjdk.java.net/jdk/jdk/raw-file/a7e42c260029/src/jdk.hotspot.agent/doc/jsdb.html

Re: RFR(S): 8244668: Remove SA's javascript support

[sundararajan . athijegannathan]

Hi Chris,

Note that not all .js files are related to nashorn!

* The one in java.scripting module is init.js file used by jrunscript 
tool. The jrunscript is javax.script based scripting language 
independent shell tool. It uses init.js script if the underlying 
language engine happens to be 'javascript'. This tool still exists and 
can use js engine if user drops suitable js engine jar in 
classpath/modulepath.


* The ones in jdk.javadoc are used in the browser (jquery, search.js). 
There is a script to test javadoc's search feature. The test looks for 
js engine before using the test. Developer can drop another js engine 
and run the test.


PS. "find . -name *.java" found only 10 .js paths in "jdk/src" 
directory.36 directories?


Thanks
-Sundar

On 27/05/20 10:08 pm, Chris Plummer wrote:

Hi Serguei,

Possibly those should be deleted, but not as part of the removal of JS 
support from SA. They are for .js files in src/java.scripting, 
src/jdk.javadoc, and src/jdk.dev. There are no longer any .js files in 
src/jdk.dev, but there are in the other two directories. There are 
bunch more in other directories not listed, 36 in total. I'm guessing 
that some should have been removed when Nashorn was removed. Maybe 
Sundar can comment on this.


thanks,

Chris

On 5/27/20 1:56 AM, serguei.spit...@oracle.com wrote:

Hi Chris,

A couple of questions.

http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/make/CompileJavaModules.gmk.udiff.html 
-jdk.hotspot.agent_COPY += .gif .png sa.js .properties

+jdk.hotspot.agent_COPY += .gif .png .properties
There are more occurrences of the .js in that file:
  215 java.scripting_COPY += .js
  346 jdk.javadoc_COPY += .xml .css .js .png
  416 jdk.dev_COPY += .js oqlhelp.html .txt
Should all these be deleted?

Otherwise, looks good.
No need in another webrev.

Thanks,
Serguei


On 5/26/20 19:42, sundararajan.athijegannat...@oracle.com wrote:

Looks good to me.

-Sundar

On 27/05/20 5:01 am, Chris Plummer wrote:

Hello,

Please review the following changes to fully remove javascript 
support from SA. It's been non-functional since JDK 9 and there are 
no plans to support it anymore.


https://bugs.openjdk.java.net/browse/JDK-8244668
http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/index.html

If anyone thinks a CSR is needed for this, please let me know. 
There's no spec involved. The support was always pretty ad hoc, 
with some supporting documentation in the source tree in jsdb.html 
[1], but which doesn't appear itself to have ever been released.


There was one menu item in the hsdb GUI that used javascript (and 
as a result caused an exception). I was having a little trouble 
deciphering what it actually does, but it appears to allow you to 
write some javascript to produce (and filter) a list of objects, 
and then display the list of objects in a window where you could 
inspect them further. Since there is no way to do something similar 
in java without allowing the user to provide hsdb extensions in the 
form of .class files (or support writing and compiling java classes 
from within hsdb), I just removed the hsdb feature by removing the 
menu item and supporting code.


thanks,

Chris

[1] 
https://hg.openjdk.java.net/jdk/jdk/raw-file/a7e42c260029/src/jdk.hotspot.agent/doc/jsdb.html

Re: RFR(S): 8244668: Remove SA's javascript support

[sundararajan . athijegannathan]

Looks good to me.

-Sundar

On 27/05/20 5:01 am, Chris Plummer wrote:

Hello,

Please review the following changes to fully remove javascript support 
from SA. It's been non-functional since JDK 9 and there are no plans 
to support it anymore.


https://bugs.openjdk.java.net/browse/JDK-8244668
http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/index.html

If anyone thinks a CSR is needed for this, please let me know. There's 
no spec involved. The support was always pretty ad hoc, with some 
supporting documentation in the source tree in jsdb.html [1], but 
which doesn't appear itself to have ever been released.


There was one menu item in the hsdb GUI that used javascript (and as a 
result caused an exception). I was having a little trouble deciphering 
what it actually does, but it appears to allow you to write some 
javascript to produce (and filter) a list of objects, and then display 
the list of objects in a window where you could inspect them further. 
Since there is no way to do something similar in java without allowing 
the user to provide hsdb extensions in the form of .class files (or 
support writing and compiling java classes from within hsdb), I just 
removed the hsdb feature by removing the menu item and supporting code.


thanks,

Chris

[1] 
https://hg.openjdk.java.net/jdk/jdk/raw-file/a7e42c260029/src/jdk.hotspot.agent/doc/jsdb.html

Re: Removal of SA javascript support

[sundararajan . athijegannathan]

Hi,

I am going to reiterate. This will lead to maintenance nightmare! Any 
"Unsupported Java API" is still an API! Remember Unsafe? Once blessed in 
any form, it is very difficult to remove. Exposing hotspot VM internals 
as a Java API is very bad idea. No, not even as "unsupported API".


Exposing SA to scripts was a different beast. Scripting languages are 
dynamically typed. It is quite common in scripting world to check the 
existence of an attribute & then use it (if (!obj["foo"]) / if (typeof 
obj["foo"] == 'function') kind of code).  That'd be extremely painful in 
a statically typed language like Java (reflection or method/var 
handles?).  Platform debuggers like dbx support a scripting language 
along with access to the data structures from the target process. SA 
scripting was inspired from that model. Also scripts were never meant to 
be written & maintained for long time! Most scripts were expected to be 
written for a specific debugging exercise/session (thrown away).


-Sundar

On 20/12/19 6:38 am, Yasumasa Suenaga wrote:

Hi Chris,

Can we treat (part of) jdk.hotspot.agent like jdk.unsupported module?
jdk.unsupported exports unspec'd API like Unsafe.

If we do so, we might need to separate SA API into exported class and 
internal class.


I've proposed to export all SA packages in JDK-8157947, but it was 
rejected.



Thanks,

Yasumasa


On 2019/12/20 1:28, Chris Plummer wrote:

Hi Yasumasa,

I've had similar thoughts about how to extend clhsdb. Why not export 
everything since what we would export is not part of a spec, and the 
javascript support had the same issue of potentially breaking when 
the SA API changed. But maybe this type of unspec'd API exporting is 
considered bad policy. I'm not sure. I'll let the API spec guru's 
comment on that aspect of it.


thanks,

Chris

On 12/19/19 12:17 AM, Yasumasa Suenaga wrote:

Hi,

I think we can provide API for SA as following:

  Patch: http://cr.openjdk.java.net/~ysuenaga/sa-api/webrev/
  Plugin examples:
    browse: 
http://cr.openjdk.java.net/~ysuenaga/sa-api/plugin-examples/
    download: 
http://cr.openjdk.java.net/~ysuenaga/sa-api/plugin-examples.tar.gz


I think JS plugin (loading via `jsload` CLHSDB command) was 
supported "AS IS".
If HotSpot and/or SA code is changed, the user should follow it if 
need.
SA is not part of Java SE. We need not to maintain SA API when it 
happen IMHO.


The user who want to expand SA features (includes me!) should have 
responsible for it.
So I did not expose jdk.hotspot.agent module - the user need to 
build with --add-exports.


My proposal can write SA plugins with pure Java. So we don't need to 
depend on script engine.



Comments are welcome.

Thanks,

Yasumasa


On 2019/12/11 21:47, sundararajan.athijegannat...@oracle.com wrote:
Effectively you're asking for SA as API. I don't think that is a 
good idea. That implies supporting hotspot data structures as Java 
*API*. That will be maintainability nightmare - we've to keep 
tracking hotspot data structures in SA code. That itself is 
problematic. API would be next level nightmare.


-Sundar

On 11/12/19 11:57 am, Yasumasa Suenaga wrote:

Hi,

IMHO we need to export all packages in SA if we do not provide new 
API for SA.
sa.js in jdk.hotspot.agent could access all SA classes until JDK 8 
(before Jigsaw), so we could make various functions if we need.


OTOH we cannot know what classes are needed by the SA users. All 
packages in jdk.hotspot.agent module provides features, and they 
require other packages. For example, sun.jvm.hotspot.oops.Oop 
requires sun.jvm.hotspot.types, and it requires 
sun.jvm.hotspot.debugger .

It is difficult to track and to export minimally.
(I worked for it in JDK-8157947, but I gave up...)

Thus I guess it is a big challenge to export SA classes without 
refactoring.
If we provide new API for SA plugin, I guess we need to work some 
refactoring.



Yasumasa


On 2019/12/11 15:00, Chris Plummer wrote:

On 12/10/19 9:56 PM, Yasumasa Suenaga wrote:

On 2019/12/11 14:39, Krystal Mok wrote:

Hi Yasumasa,

That's a very nice idea. Basically what you're asking for is 
exposing the Command interface [1] so that plugins can 
implement it and get dynamically loaded / registered into 
CLHSDB / HSDB, right?


Yes, but we also need proxy API to access internal SA objects 
e.g. CodeCache, JavaThread, TypeDataBase, etc...


Yes, or export them. I should have read this email before posting 
my previous one.


Chris


Yasumasa


[1]: 
http://hg.openjdk.java.net/jdk/jdk/file/c71ec1f09f21/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java#l246


- Kris

On Tue, Dec 10, 2019 at 9:33 PM Yasumasa Suenaga 
mailto:suen...@oss.nttdata.com>> wrote:


    Hi Chris,

    It's a sad proposal, but I agree with you. To maintain SA 
in JS is difficult since Jigsaw.

    However I want SA to implement pluggable feature.
    I use custom script to list compiled codes in CodeCache.

    I guess other troubleshooters also want 

Re: Removal of SA javascript support

[sundararajan . athijegannathan]

Replacing one scripting language with another (jython) does not solve 
anything. You'd still face the same issues - accessing module private 
stuff from SA module from scripts. Besides you'll have a new problem in 
addition. How to bundle jython? We've been using bundled scripting 
engine (nashorn) so far.


-Sundar

On 11/12/19 1:14 pm, Dmitry Samersoff wrote:

Hello Chris,

I'm supporting you with this decision.

PS: For people who want SA scripting -

One thing I experimented with a long time ago -
has been exporting of some SA capabilities to jython.
This might be the way to go.

-Dmitry



On 11.12.19 05:52, Chris Plummer wrote:

Hi,

I like to propose the removal of SA javascript support. Few people even
realize this support exists, and hopefully even fewer are using it since
I'd like to remove it. Since I'm new to this myself, let me first
explain what I know about it's existence, and then explain why I want to
remove it.

If you run "jhsdb clhsdb", there are jsload and jseval commands. Don't
look for them in anything post JDK 8. I'll explain why later. jsload is
used to load a javascript file. In that file you can register new clhsdb
commands that are written in javascript. You can also evaluate
javascript using the jseval command. Some of this is explained in [1],
which is the only place I can find any reference to this support. It
does not appear to be officially supported, nor is there any oracle
provided documentation.

There also appear to be a few clhsdb commands that are written in
javascript. Doing a grep for "registerCommand" in sa.js shows the
following:

  registerCommand("class", "class name", "jclass");
  registerCommand("classes", "classes", "jclasses");
  registerCommand("dumpclass", "dumpclass { address | name } [ directory
]", "dclass");
  registerCommand("dumpheap", "dumpheap [ file ]", "dumpHeap");
  registerCommand("mem", "mem address [ length ]", "printMem");
  registerCommand("sysprops", "sysprops", "sysProps");
  registerCommand("whatis", "whatis address", "printWhatis");

Once again, don't go looking for these in anything newer than JDK8. You
won't find them. Again the only documentation I can fine is [1].

The other use of Javascript is the SOQL command (Simple Object Query
Language), a tool used to query the heap, and also the JSDB command.
The only SOQL documentation I could find is the blog reference [2]. I
could not find HSDB documentation, but I believe is is a javascript
support for looking at hotspot. So once again, neither of these seem to
be officially supported or documented.

The real purpose of the email is to propose removal of this support.
Here are the reasons:

(1) It's broken, and has been since 9. See [3]. This is why you don't
see the javascript related commands in clhsdb. Javascript fails to
initialize, so none of the javascript related commands are registered.
(2) Nashorn is deprecated and will be removed eventually.
(3) We have very little understanding of the javascript support.
(4) No resources to work on it (unless there is a community volunteer).
(5) Very questionable value (lack of users). The fact this support has
been broken since JDK 9 and no bug was filed until I did so this week is
a good indication of that. Another is that there are no other SA
Javascript related bugs filed. Lastly, the lack of any official
documentation and only minimal mention of it on the web is another good
indication of it's (lack of) value.

Also, regarding the 7 commands listed above that would be lost (but
currently don't work now anyway), if they are really wanted, they could
be implemented in java instead of javascript.

I'd like to remove javascript support in two steps. The first is simply
disable the clhsdb code that tries to initialize the javascript support.
I'd like to do this in 14 (actually as soon as possible). I'd like to
actually do this now even if we decide to keep javascript support and
eventually fix it because it will get rid of the warning you see
whenever you attach from clhsdb:

  Warning! JS Engine can't start, some commands will not be available.

This warning will become more of an issue for the clhsdb tests after I
push [4] because then you will also see the full stacktrace for the
underlying exception that caused the Javascript to fail to start.
Besides being unnecessary noise in passing test cases, it can also be
misleading in any test that fails because the exception will be
unrelated to the failure. This is actually what got me going down this
path of what the javascript support is all about.

The next step would be to strip out all Javascript related code,
including the SOQL and JSDB tools. This would be done in 15.

Please let me know what you think.

thanks,

Chris

[1]
https://cr.openjdk.java.net/~minqi/6830717/raw_files/new/agent/doc/clhsdb.html

[2]
http://javatroubleshooting.blogspot.com/2015/12/serviceability-agent-part-3.html

[3] https://bugs.openjdk.java.net/browse/JDK-8235594
[4] 

Re: Removal of SA javascript support

[sundararajan . athijegannathan]

Effectively you're asking for SA as API. I don't think that is a good 
idea. That implies supporting hotspot data structures as Java *API*. 
That will be maintainability nightmare - we've to keep tracking hotspot 
data structures in SA code. That itself is problematic. API would be 
next level nightmare.


-Sundar

On 11/12/19 11:57 am, Yasumasa Suenaga wrote:

Hi,

IMHO we need to export all packages in SA if we do not provide new API 
for SA.
sa.js in jdk.hotspot.agent could access all SA classes until JDK 8 
(before Jigsaw), so we could make various functions if we need.


OTOH we cannot know what classes are needed by the SA users. All 
packages in jdk.hotspot.agent module provides features, and they 
require other packages. For example, sun.jvm.hotspot.oops.Oop requires 
sun.jvm.hotspot.types, and it requires sun.jvm.hotspot.debugger .

It is difficult to track and to export minimally.
(I worked for it in JDK-8157947, but I gave up...)

Thus I guess it is a big challenge to export SA classes without 
refactoring.
If we provide new API for SA plugin, I guess we need to work some 
refactoring.



Yasumasa


On 2019/12/11 15:00, Chris Plummer wrote:

On 12/10/19 9:56 PM, Yasumasa Suenaga wrote:

On 2019/12/11 14:39, Krystal Mok wrote:

Hi Yasumasa,

That's a very nice idea. Basically what you're asking for is 
exposing the Command interface [1] so that plugins can implement it 
and get dynamically loaded / registered into CLHSDB / HSDB, right?


Yes, but we also need proxy API to access internal SA objects e.g. 
CodeCache, JavaThread, TypeDataBase, etc...


Yes, or export them. I should have read this email before posting my 
previous one.


Chris


Yasumasa


[1]: 
http://hg.openjdk.java.net/jdk/jdk/file/c71ec1f09f21/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java#l246


- Kris

On Tue, Dec 10, 2019 at 9:33 PM Yasumasa Suenaga 
mailto:suen...@oss.nttdata.com>> wrote:


    Hi Chris,

    It's a sad proposal, but I agree with you. To maintain SA in JS 
is difficult since Jigsaw.

    However I want SA to implement pluggable feature.
    I use custom script to list compiled codes in CodeCache.

    I guess other troubleshooters also want similar feature (via 
jsload) in future if they encounter JVM crash.



    Thanks,

    Yasumasa


    On 2019/12/11 11:52, Chris Plummer wrote:
 > Hi,
 >
 > I like to propose the removal of SA javascript support. Few 
people even realize this support exists, and hopefully even fewer 
are using it since I'd like to remove it. Since I'm new to this 
myself, let me first explain what I know about it's existence, and 
then explain why I want to remove it.

 >
 > If you run "jhsdb clhsdb", there are jsload and jseval 
commands. Don't look for them in anything post JDK 8. I'll explain 
why later. jsload is used to load a javascript file. In that file 
you can register new clhsdb commands that are written in 
javascript. You can also evaluate javascript using the jseval 
command. Some of this is explained in [1], which is the only place 
I can find any reference to this support. It does not appear to be 
officially supported, nor is there any oracle provided documentation.

 >
 > There also appear to be a few clhsdb commands that are 
written in javascript. Doing a grep for "registerCommand" in sa.js 
shows the following:

 >
 >   registerCommand("class", "class name", "jclass");
 >   registerCommand("classes", "classes", "jclasses");
 >   registerCommand("dumpclass", "dumpclass { address | name } 
[ directory ]", "dclass");

 >   registerCommand("dumpheap", "dumpheap [ file ]", "dumpHeap");
 >   registerCommand("mem", "mem address [ length ]", "printMem");
 >   registerCommand("sysprops", "sysprops", "sysProps");
 >   registerCommand("whatis", "whatis address", "printWhatis");
 >
 > Once again, don't go looking for these in anything newer 
than JDK8. You won't find them. Again the only documentation I can 
fine is [1].

 >
 > The other use of Javascript is the SOQL command (Simple 
Object Query Language), a tool used to query the heap, and also the 
JSDB command. The only SOQL documentation I could find is the blog 
reference [2]. I could not find HSDB documentation, but I believe 
is is a javascript support for looking at hotspot. So once again, 
neither of these seem to be officially supported or documented.

 >
 > The real purpose of the email is to propose removal of this 
support. Here are the reasons:

 >
 > (1) It's broken, and has been since 9. See [3]. This is why 
you don't see the javascript related commands in clhsdb. Javascript 
fails to initialize, so none of the javascript related commands are 
registered.

 > (2) Nashorn is deprecated and will be removed eventually.
 > (3) We have very little understanding of the javascript 
support.
 > (4) No resources to work on it (unless there is a community 
volunteer).
 > (5) Very 

Re: Removal of SA javascript support

[sundararajan . athijegannathan]

Hi Kris,

Glad to hear that someone used JS interface of SA :) Quick prototyping + 
debugger interactive scripting were the goals of JS interface! As you 
mentioned, given the current state of SA JS interface, it has to be 
removed :(


Thanks

-Sundar

On 11/12/19 8:56 am, Krystal Mok wrote:

Hi Chris,

Thanks for the proposal. I used to be one of the few heavy users of 
jsload / jseval in CLHSDB back in the JDK6 to JDK8 era. The way I used 
to use it is to quickly prototype new functionality in JS and later 
bake it into Java code, and also for exploring heap dumps beneath the 
existing commands available in CLHSDB (i.e. the underlying SA API is 
far more powerful than the set of commands exposed in HSDB).


I even collected my own library of SA-based JS functions for easy 
navigation of Java heap dumps. e.g. this objtree command: 
https://gist.github.com/rednaxelafx/1393698#file-objtree-js


I'm sad to see it go but given its current state I'd +1 on the 
proposal to remove it now.


Best regards,
Kris

On Tue, Dec 10, 2019 at 6:52 PM Chris Plummer 
mailto:chris.plum...@oracle.com>> wrote:


Hi,

I like to propose the removal of SA javascript support. Few people
even
realize this support exists, and hopefully even fewer are using it
since
I'd like to remove it. Since I'm new to this myself, let me first
explain what I know about it's existence, and then explain why I
want to
remove it.

If you run "jhsdb clhsdb", there are jsload and jseval commands.
Don't
look for them in anything post JDK 8. I'll explain why later.
jsload is
used to load a javascript file. In that file you can register new
clhsdb
commands that are written in javascript. You can also evaluate
javascript using the jseval command. Some of this is explained in
[1],
which is the only place I can find any reference to this support. It
does not appear to be officially supported, nor is there any oracle
provided documentation.

There also appear to be a few clhsdb commands that are written in
javascript. Doing a grep for "registerCommand" in sa.js shows the
following:

  registerCommand("class", "class name", "jclass");
  registerCommand("classes", "classes", "jclasses");
  registerCommand("dumpclass", "dumpclass { address | name } [
directory
]", "dclass");
  registerCommand("dumpheap", "dumpheap [ file ]", "dumpHeap");
  registerCommand("mem", "mem address [ length ]", "printMem");
  registerCommand("sysprops", "sysprops", "sysProps");
  registerCommand("whatis", "whatis address", "printWhatis");

Once again, don't go looking for these in anything newer than
JDK8. You
won't find them. Again the only documentation I can fine is [1].

The other use of Javascript is the SOQL command (Simple Object Query
Language), a tool used to query the heap, and also the JSDB command.
The only SOQL documentation I could find is the blog reference [2]. I
could not find HSDB documentation, but I believe is is a javascript
support for looking at hotspot. So once again, neither of these
seem to
be officially supported or documented.

The real purpose of the email is to propose removal of this support.
Here are the reasons:

(1) It's broken, and has been since 9. See [3]. This is why you don't
see the javascript related commands in clhsdb. Javascript fails to
initialize, so none of the javascript related commands are registered.
(2) Nashorn is deprecated and will be removed eventually.
(3) We have very little understanding of the javascript support.
(4) No resources to work on it (unless there is a community
volunteer).
(5) Very questionable value (lack of users). The fact this support
has
been broken since JDK 9 and no bug was filed until I did so this
week is
a good indication of that. Another is that there are no other SA
Javascript related bugs filed. Lastly, the lack of any official
documentation and only minimal mention of it on the web is another
good
indication of it's (lack of) value.

Also, regarding the 7 commands listed above that would be lost (but
currently don't work now anyway), if they are really wanted, they
could
be implemented in java instead of javascript.

I'd like to remove javascript support in two steps. The first is
simply
disable the clhsdb code that tries to initialize the javascript
support.
I'd like to do this in 14 (actually as soon as possible). I'd like to
actually do this now even if we decide to keep javascript support and
eventually fix it because it will get rid of the warning you see
whenever you attach from clhsdb:

  Warning! JS Engine can't start, some commands will not be
available.

This warning will become more of an issue for the clhsdb tests
after I
push [4] because then you will also see the full 

Re: 8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

[Sundararajan Athijegannathan]

Hi Yasumasa,

Sorry for delayed response. Your webrev looks like a good start! 
Unfortunately, dependency on nashorn is inevitable. But there is a 
similar (but different) object API for Graal.js. In future, someone may 
have to do some porting work.


Thanks,
-Sundar

On 19/04/19, 6:37 PM, Yasumasa Suenaga wrote:

Hi Sundar,

I tried to implement JSObject for SA.
Following webrev is not completed, but it can get VM object
and Debugger in it from sa.js:

  http://cr.openjdk.java.net/~ysuenaga/JDK-8157947/jsobject.work/

It is not completed (error will occur when CLSDB is attached.)
but I want to hear your opinion. So I share it.

AFAIK JSObject impl. idea needs to use AbstractJSObject, but it is
provided by jdk.scripting.nashorn module.
However Nashorn has been deprecated by JEP 335 and it might be removed.

Can we fix this issue not to depend on jdk.scripting.nashorn module?
If it can't, is it allowed to use deprecated module?

I guess Nashorn might be replaced to Graal.js in the future.
So I concern it is not better to depend on Nashorn.


Thanks,

Yasumasa


On 2019/04/19 11:36, Sundararajan Athijegannathan wrote:

Hi Yasumasa

Thanks for confirming that we've the same issue with Graal.js as 
well. I think JSObject impl. idea should be investigated. I think 
there is similar (script) reflective API in Graal.js as well.


Thanks
-Sundar

On 17/04/19, 7:37 PM, Yasumasa Suenaga wrote:

Hi Sundar,

On 2019/04/16 13:32, Sundararajan Athijegannathan wrote:

Hi Yasumasa,

Response comments inlined below..


On 16/04/19, 5:21 AM, Yasumasa Suenaga wrote:

Hi Sundar,

On 2019/04/15 16:58, Sundararajan Athijegannathan wrote:

Both options are hacks :( Personally I'm not comfortable with either
option.

JSObject wrapper suggested in the bug is not impossible to do.

VM.getVM() would the "initial object" -- a JSObject impl. that walks
through objects is possible. JSObject impls. can cache 
fields/methods
reflectively and invoke those as needed. If SA class is needed, 
we can

add JSClassObject impl. (which would a JSObject impl. that'd support
static method/field access).


I guess SA classes will be added / modified due to HotSpot 
improvement (e.g. GC, JIT, etc...)

So I think it is not reasonable to add JSClassObject implementations.


We need to add only *one* JSClassObject class (which can expose 
static fields/methods of a given java.lang.Class which is 
maintained as an instance field).


Also, we may need to add a hook for looking for a class (like 
Java.type - but constructs JSClassObject instance instead).


In addition, I guess this restriction is on Nashorn only.
Nashorn might be replaced to Graal.js .


I'm not sure. If a JS implementation is module aware, it'll have 
the same issue. The core issue issue here we don't want 
public/exposed API from hotspot module. But we want to allow access 
to hotspot types, methods *only* from scripts => we need some sort 
of backdoor. I'd like JS reflection (JSObject) based backdoors 
rather than breaking module boundary using JNI code.




Do we see this issue with other JS Engine?
If not so, I want to use other JS Engine (e,g, Graal).


Yes, definitely no harm trying to see if other impls. have the same 
issue or not.


I tried to use Graal in CLHSDB, but it did not work well.
Graal.js uses j.l.r.Proxy which is defined by dynamic module.
So I saw IllegalAccessError when CLHSDB attempt to call VM.getVM().


Thanks,

Yasumasa



Thanks,
-Sundar



Thanks,

Yasumasa



-Sundar

On 12/04/19, 7:35 PM, Yasumasa Suenaga wrote:

Hi all,

I saw the message when I attached CLHSDB to target VM as below:


javax.script.ScriptException: TypeError: sapkg.runtime.VM.getVM 
is not

a function in sa.js at line number 54
Warning! JS Engine can't start, some commands will not be 
available.



It has been reported as JDK-8157947.


It is caused that jdk.hotspot.agent module is not exported to
nashorn dynamic module.
The comment in JDK-8157947 says that it will be fixed if we 
implement

JSObject, but I think it is difficult because we cannot know
what classes in SA are used in user scripts.

So I think two approaches for this issue:


   1. Open all packages in module-info in jdk.hotspot.agent
I filed suggested fix to JBS, but it is not smart...

   2. Open all packages in JSJavaScriptEngine::
Opens all packages to Module.EVERYONE_MODULE.
But EVERYONE_MODULE is private field, so we need to access
from JNI code.
  
http://cr.openjdk.java.net/~ysuenaga/JDK-8157947/proposal/

This change has passed serviceability/sa jtreg tests.


Both ideas is hackish, but I prefer to 2. to fix it.
If 2. is accepted I will push it to submit repo and send review 
request.


What do you think?


Thanks,

Yasumasa

Re: 8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

[Sundararajan Athijegannathan]

Hi Yasumasa

Thanks for confirming that we've the same issue with Graal.js as well. I 
think JSObject impl. idea should be investigated. I think there is 
similar (script) reflective API in Graal.js as well.


Thanks
-Sundar

On 17/04/19, 7:37 PM, Yasumasa Suenaga wrote:

Hi Sundar,

On 2019/04/16 13:32, Sundararajan Athijegannathan wrote:

Hi Yasumasa,

Response comments inlined below..


On 16/04/19, 5:21 AM, Yasumasa Suenaga wrote:

Hi Sundar,

On 2019/04/15 16:58, Sundararajan Athijegannathan wrote:

Both options are hacks :( Personally I'm not comfortable with either
option.

JSObject wrapper suggested in the bug is not impossible to do.

VM.getVM() would the "initial object" -- a JSObject impl. that walks
through objects is possible. JSObject impls. can cache fields/methods
reflectively and invoke those as needed. If SA class is needed, we can
add JSClassObject impl. (which would a JSObject impl. that'd support
static method/field access).


I guess SA classes will be added / modified due to HotSpot 
improvement (e.g. GC, JIT, etc...)

So I think it is not reasonable to add JSClassObject implementations.


We need to add only *one* JSClassObject class (which can expose 
static fields/methods of a given java.lang.Class which is maintained 
as an instance field).


Also, we may need to add a hook for looking for a class (like 
Java.type - but constructs JSClassObject instance instead).


In addition, I guess this restriction is on Nashorn only.
Nashorn might be replaced to Graal.js .


I'm not sure. If a JS implementation is module aware, it'll have the 
same issue. The core issue issue here we don't want public/exposed 
API from hotspot module. But we want to allow access to hotspot 
types, methods *only* from scripts => we need some sort of backdoor. 
I'd like JS reflection (JSObject) based backdoors rather than 
breaking module boundary using JNI code.




Do we see this issue with other JS Engine?
If not so, I want to use other JS Engine (e,g, Graal).


Yes, definitely no harm trying to see if other impls. have the same 
issue or not.


I tried to use Graal in CLHSDB, but it did not work well.
Graal.js uses j.l.r.Proxy which is defined by dynamic module.
So I saw IllegalAccessError when CLHSDB attempt to call VM.getVM().


Thanks,

Yasumasa



Thanks,
-Sundar



Thanks,

Yasumasa



-Sundar

On 12/04/19, 7:35 PM, Yasumasa Suenaga wrote:

Hi all,

I saw the message when I attached CLHSDB to target VM as below:


javax.script.ScriptException: TypeError: sapkg.runtime.VM.getVM is 
not

a function in sa.js at line number 54
Warning! JS Engine can't start, some commands will not be available.


It has been reported as JDK-8157947.


It is caused that jdk.hotspot.agent module is not exported to
nashorn dynamic module.
The comment in JDK-8157947 says that it will be fixed if we implement
JSObject, but I think it is difficult because we cannot know
what classes in SA are used in user scripts.

So I think two approaches for this issue:


   1. Open all packages in module-info in jdk.hotspot.agent
I filed suggested fix to JBS, but it is not smart...

   2. Open all packages in JSJavaScriptEngine::
Opens all packages to Module.EVERYONE_MODULE.
But EVERYONE_MODULE is private field, so we need to access
from JNI code.
  http://cr.openjdk.java.net/~ysuenaga/JDK-8157947/proposal/
This change has passed serviceability/sa jtreg tests.


Both ideas is hackish, but I prefer to 2. to fix it.
If 2. is accepted I will push it to submit repo and send review 
request.


What do you think?


Thanks,

Yasumasa

Re: 8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

[Sundararajan Athijegannathan]

Hi Yasumasa,

Response comments inlined below..


On 16/04/19, 5:21 AM, Yasumasa Suenaga wrote:

Hi Sundar,

On 2019/04/15 16:58, Sundararajan Athijegannathan wrote:

Both options are hacks :( Personally I'm not comfortable with either
option.

JSObject wrapper suggested in the bug is not impossible to do.

VM.getVM() would the "initial object" -- a JSObject impl. that walks
through objects is possible. JSObject impls. can cache fields/methods
reflectively and invoke those as needed. If SA class is needed, we can
add JSClassObject impl. (which would a JSObject impl. that'd support
static method/field access).


I guess SA classes will be added / modified due to HotSpot improvement 
(e.g. GC, JIT, etc...)

So I think it is not reasonable to add JSClassObject implementations.


We need to add only *one* JSClassObject class (which can expose static 
fields/methods of a given java.lang.Class which is maintained as an 
instance field).


Also, we may need to add a hook for looking for a class (like Java.type 
- but constructs JSClassObject instance instead).


In addition, I guess this restriction is on Nashorn only.
Nashorn might be replaced to Graal.js .


I'm not sure. If a JS implementation is module aware, it'll have the 
same issue. The core issue issue here we don't want public/exposed API 
from hotspot module. But we want to allow access to hotspot types, 
methods *only* from scripts => we need some sort of backdoor. I'd like 
JS reflection (JSObject) based backdoors rather than breaking module 
boundary using JNI code.




Do we see this issue with other JS Engine?
If not so, I want to use other JS Engine (e,g, Graal).


Yes, definitely no harm trying to see if other impls. have the same 
issue or not.


Thanks,
-Sundar



Thanks,

Yasumasa



-Sundar

On 12/04/19, 7:35 PM, Yasumasa Suenaga wrote:

Hi all,

I saw the message when I attached CLHSDB to target VM as below:


javax.script.ScriptException: TypeError: sapkg.runtime.VM.getVM is not
a function in sa.js at line number 54
Warning! JS Engine can't start, some commands will not be available.


It has been reported as JDK-8157947.


It is caused that jdk.hotspot.agent module is not exported to
nashorn dynamic module.
The comment in JDK-8157947 says that it will be fixed if we implement
JSObject, but I think it is difficult because we cannot know
what classes in SA are used in user scripts.

So I think two approaches for this issue:


   1. Open all packages in module-info in jdk.hotspot.agent
I filed suggested fix to JBS, but it is not smart...

   2. Open all packages in JSJavaScriptEngine::
Opens all packages to Module.EVERYONE_MODULE.
But EVERYONE_MODULE is private field, so we need to access
from JNI code.
  http://cr.openjdk.java.net/~ysuenaga/JDK-8157947/proposal/
This change has passed serviceability/sa jtreg tests.


Both ideas is hackish, but I prefer to 2. to fix it.
If 2. is accepted I will push it to submit repo and send review 
request.


What do you think?


Thanks,

Yasumasa

Re: 8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

[Sundararajan Athijegannathan]

Both options are hacks :( Personally I'm not comfortable with either 
option.


JSObject wrapper suggested in the bug is not impossible to do.

VM.getVM() would the "initial object" -- a JSObject impl. that walks 
through objects is possible. JSObject impls. can cache fields/methods 
reflectively and invoke those as needed. If SA class is needed, we can 
add JSClassObject impl. (which would a JSObject impl. that'd support 
static method/field access).


-Sundar

On 12/04/19, 7:35 PM, Yasumasa Suenaga wrote:

Hi all,

I saw the message when I attached CLHSDB to target VM as below:


javax.script.ScriptException: TypeError: sapkg.runtime.VM.getVM is not 
a function in sa.js at line number 54

Warning! JS Engine can't start, some commands will not be available.


It has been reported as JDK-8157947.


It is caused that jdk.hotspot.agent module is not exported to
nashorn dynamic module.
The comment in JDK-8157947 says that it will be fixed if we implement
JSObject, but I think it is difficult because we cannot know
what classes in SA are used in user scripts.

So I think two approaches for this issue:


  1. Open all packages in module-info in jdk.hotspot.agent
   I filed suggested fix to JBS, but it is not smart...

  2. Open all packages in JSJavaScriptEngine::
   Opens all packages to Module.EVERYONE_MODULE.
   But EVERYONE_MODULE is private field, so we need to access
   from JNI code.
 http://cr.openjdk.java.net/~ysuenaga/JDK-8157947/proposal/
   This change has passed serviceability/sa jtreg tests.


Both ideas is hackish, but I prefer to 2. to fix it.
If 2. is accepted I will push it to submit repo and send review request.

What do you think?


Thanks,

Yasumasa

Re: 8215534: [testbug] some jfr test don't check @requires vm.hasJFR

[Sundararajan Athijegannathan]

Looks good.

PS. I just checked that there are other tests with the same requires clause.

-Sundar

On 13/12/18, 1:20 PM, Lindenmaier, Goetz wrote:

Hi,

These tests lack @requires vm.hasJFR, thus they are failing on AIX.
http://cr.openjdk.java.net/~goetz/wr18/8215334-JFR_requires/01/

Please review.
I will push this to jdk12 as it is a testbug if I miss  the RDP deadline.

Best regards,
   Goetz.

Re: RFR : JDK-8170299 - Debugger does not stop inside the low memory notifications code

[Sundararajan Athijegannathan]

+1. It is better not to fix this bug.

-Sundar

On 24/08/18, 7:36 PM, Daniel Fuchs wrote:

Hi Harsha,

On 23/08/2018 17:35, Daniel Fuchs wrote:

So all in all - maybe this is worth fixing but better early
in the release than late. I also wonder whether such a behavior
change should deserve a release note (or a switch to revert
to the old behavior - though I do hope that isn't necessary).


On second thought - it occurred to me that what you are proposing
to do in the platform could very well be implemented in the
client (listener) code instead.

The workaround would be simple:

---
package com.foo.monitoring;

import javax.management.*;

final class PlatformMXBeaNotificationListener implements
  NotificationListener {

private final NotoificationListener delegate;

PlatformMXBeaNotificationListener(NotoificationListener delegate) {
this.delegate = delegate;
}

public void handleNotification(Notification notification,
   Object handback) {
 executor.execute(() ->
   delegate.handleNotification(notification, handback));
}

private static final Executor executor
  = Executors.newSingleTreadExecutor();
}


This way the threading would remain in control of the
client application, and the debugger would be able to
step in the delegate's handleNotification(...) method?

Given the unquantifiable risk posed by changing the threading
model in the platform, then maybe leaving the current
implementation as is and documenting that workaround
leaving it up to the client code to decide whether to use
that or not, would be the better idea?

best regards,

-- daniel

Re: RFR: JDK-8199682 Clean up building the saproc library

[Sundararajan Athijegannathan]

Hi,

Sounds good - so long as we don't have scripts that depend on the old 
name. Or if those could be fixed...


-Sundar

On 20/03/18, 4:54 PM, Magnus Ihse Bursie wrote:


On 2018-03-16 19:12, Magnus Ihse Bursie wrote:

Hi Sundar,

I almost missed your mail, since you removed both me and build-dev 
from the cc list...


16 mars 2018 kl. 06:14 skrev Sundararajan Athijegannathan 
<sundararajan.athijegannat...@oracle.com>:


Renaming sawindbg as saproc sounds odd. For Linux, Solaris/Unix, we 
either use /proc & libproc, so calling saproc for those makes sense. 
But Windows? We have a separate debugger class to load platform 
specific native library. What is the reason for uniform naming?
This is the only library in the JDK that has a different name on 
different platform. This clashes with the design of the build system, 
and requires a clunky workaround. For the upcoming changes in the 
build system, this goes from an annoyance to a blocker.


No other components have their names based on the OS functionality 
they use, even if they use vastly different APIs on different 
platforms; rather they are named after the services they provide to 
the JDK.


My assumption was that ”saproc” meant ”serviceability agent process 
handling”, and that this was a reasonable name for all platforms. 
Also, the source code for all platforms reside in the ”libsaproc” 
directory, which is consistent with the JDK standard for matching 
source code to native library.


But if you believe this is an inappropriate name, let’s work together 
to find a name that works for all platforms. This of course will lead 
to new names for the current libsaproc.* libraries, and the source 
code directories.

Hi Sundar,

Are you okay with this rationale for changing to saproc, or do you 
want to discuss this further?


/Magnus


/Magnus


-Sundar

On 16/03/18, 12:19 AM, Magnus Ihse Bursie wrote:


On 2018-03-15 19:39, Erik Joelsson wrote:

Looks good to me.

The removed source files, are those some kind of tests?
I don't really know; they have been excluded from the build for all 
time. My guess is that the Bsd* stuff is, like in the case of the 
sound libraries, bsd-based stuff that arrived with the mac port 
(but disabled). The test.c is a trivial main() method which looks 
more like a left-over adhoc testing from the initial developer. 
Perhaps someone wants to turn it into a proper test, but it seems 
like it's not much even to start with. (And hopefully we have much 
better real test coverage of this now.)


/Magnus

/Erik


On 2018-03-15 11:22, Magnus Ihse Bursie wrote:
The saproc library has historically been built in quite odd ways 
on almost all platforms. When the old build system was converted, 
this was not changed.


However, now the time has come to streamline this and build this 
library just as any other.


The most visible change, perhaps, is that the library is now 
named saproc on all platforms, even Windows. Other changes include:

* Don't set flags that is already set by the default flags.
* Don't set flags that do not have anny effect.
* Don't subst away the WIN32_LEAN_AND_MEAN definition, it's 
perfectly okay to have it.
* Don't set CXX linker on solaris -- this was not needed so no 
reason to do it.
* Cleaned up some old hooks for closed code that is no longer 
needed.


I have verified this using COMPARE_BUILD. This shows only the 
expected differences:

* On all platforms: class file changes for WindbgDebuggerLocal.java.
* On solaris: some minor symbol differences, since the linker now 
uses C framework functions instead of C++. (And with symbol 
changes always comes disasm changes.)
* On linux: a binary difference for libsaproc.so, but no 
size/symbol/deps/disasm change.

* On macosx: no changes at all.
* On windows: sawindbg.dll is renamed to saproc.dll. When I made 
a manual comparison between the two files, I found no significant 
differences.


Bug: https://bugs.openjdk.java.net/browse/JDK-8199682
WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8199682-clean-up-saproc/webrev.01 



/Magnus

Re: RFR: JDK-8199682 Clean up building the saproc library

[Sundararajan Athijegannathan]

Renaming sawindbg as saproc sounds odd. For Linux, Solaris/Unix, we 
either use /proc & libproc, so calling saproc for those makes sense. But 
Windows? We have a separate debugger class to load platform specific 
native library. What is the reason for uniform naming?


-Sundar

On 16/03/18, 12:19 AM, Magnus Ihse Bursie wrote:



On 2018-03-15 19:39, Erik Joelsson wrote:

Looks good to me.

The removed source files, are those some kind of tests?
I don't really know; they have been excluded from the build for all 
time. My guess is that the Bsd* stuff is, like in the case of the 
sound libraries, bsd-based stuff that arrived with the mac port (but 
disabled). The test.c is a trivial main() method which looks more like 
a left-over adhoc testing from the initial developer. Perhaps someone 
wants to turn it into a proper test, but it seems like it's not much 
even to start with. (And hopefully we have much better real test 
coverage of this now.)


/Magnus


/Erik


On 2018-03-15 11:22, Magnus Ihse Bursie wrote:
The saproc library has historically been built in quite odd ways on 
almost all platforms. When the old build system was converted, this 
was not changed.


However, now the time has come to streamline this and build this 
library just as any other.


The most visible change, perhaps, is that the library is now named 
saproc on all platforms, even Windows. Other changes include:

* Don't set flags that is already set by the default flags.
* Don't set flags that do not have anny effect.
* Don't subst away the WIN32_LEAN_AND_MEAN definition, it's 
perfectly okay to have it.
* Don't set CXX linker on solaris -- this was not needed so no 
reason to do it.

* Cleaned up some old hooks for closed code that is no longer needed.

I have verified this using COMPARE_BUILD. This shows only the 
expected differences:

* On all platforms: class file changes for WindbgDebuggerLocal.java.
* On solaris: some minor symbol differences, since the linker now 
uses C framework functions instead of C++. (And with symbol changes 
always comes disasm changes.)
* On linux: a binary difference for libsaproc.so, but no 
size/symbol/deps/disasm change.

* On macosx: no changes at all.
* On windows: sawindbg.dll is renamed to saproc.dll. When I made a 
manual comparison between the two files, I found no significant 
differences.


Bug: https://bugs.openjdk.java.net/browse/JDK-8199682
WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8199682-clean-up-saproc/webrev.01


/Magnus

Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException

[Sundararajan Athijegannathan]

+1

-Sundar

On 21/11/17, 3:26 PM, Sharath Ballal wrote:


I have made minor modification to the test (added @bug and removed 
@modules).


The revised webrev is

http://cr.openjdk.java.net/~sballal/8184982/webrev.01/ 



Thanks,

Sharath

*From:* Sharath Ballal
*Sent:* Tuesday, November 21, 2017 12:27 PM
*To:* serviceability-dev@openjdk.java.net
*Subject:* RE: RFR: JDK-8184982 - SA: Running ClassDump on a simple 
java program generates NullPointerException


Gentle reminder.

Thanks,

Sharath

*From:* Sharath Ballal
*Sent:* Tuesday, November 14, 2017 10:31 AM
*To:* serviceability-dev@openjdk.java.net 

*Subject:* RFR: JDK-8184982 - SA: Running ClassDump on a simple java 
program generates NullPointerException


Hello,

Pls review the code changes and testcase for the following issue.

Bug ID: https://bugs.openjdk.java.net/browse/JDK-8184982

Webrev: http://cr.openjdk.java.net/~sballal/8184982/webrev.00/ 



Thanks,

Sharath

Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException

[Sundararajan Athijegannathan]

+1

-Sundar

On 21/11/17, 12:26 PM, Sharath Ballal wrote:


Gentle reminder.

Thanks,

Sharath

*From:* Sharath Ballal
*Sent:* Tuesday, November 14, 2017 10:31 AM
*To:* serviceability-dev@openjdk.java.net
*Subject:* RFR: JDK-8184982 - SA: Running ClassDump on a simple java 
program generates NullPointerException


Hello,

Pls review the code changes and testcase for the following issue.

Bug ID: https://bugs.openjdk.java.net/browse/JDK-8184982

Webrev: http://cr.openjdk.java.net/~sballal/8184982/webrev.00/ 



Thanks,

Sharath

Re: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall' often throws "Corrupted constant pool" assertion failure

[Sundararajan Athijegannathan]

New files (LingeredAppWithInvokeDynamic.java,
TestCpoolForInvokeDynamic.java) should just have current year for
copyright (2005, 2015 should be removed).

Other than that, +1

-Sundar


On 11/2/2016 9:29 AM, Jini Susan George wrote:
> Could I get one more review done for this, please ? 
> Thanks,
> Jini.
>
>> -Original Message-
>> From: Dmitry Samersoff
>> Sent: Monday, October 31, 2016 2:58 PM
>> To: Jini Susan George; serviceability-dev
>> Subject: Re: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall' often throws
>> "Corrupted constant pool" assertion failure
>>
>> Jini,
>>
>> Looks good for me!
>>
>> -Dmitry
>>
>>
>> On 2016-10-31 11:21, Jini Susan George wrote:
>>> Please do review the changes for the SA defect:
>>>
>>>
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8164783
>>>
>>>
>>>
>>> The webrev is at:
>>>
>>>
>>>
>>> http://cr.openjdk.java.net/~jgeorge/8164783/webrev.00/
>>>
>>>
>>>
>>> Thanks,
>>>
>>> - Jini Susan George
>>>
>>>
>>>
>>
>> --
>> Dmitry Samersoff
>> Oracle Java development team, Saint Petersburg, Russia
>> * I would love to change the world, but they won't give me the sources.

Re: RFR: JDK-8068155: [Findbugs]new sun.jvm.hotspot.utilities.ObjectReader() creates a sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which should be performed within a doPrivileged block

[Sundararajan Athijegannathan]

+1

PS.

* SA module does not export any package - as of now, only jhsdb is the
only way to use SA. So, most findbugs findings are noise. i.e., user
code or any code outside SA module cannot access SA programmatically.

Only way is to use command line switches of Java launcher - if untrusted
code can do that [it cannot!], all doomed anyway :)

-Sundar

On 9/15/2016 4:19 PM, Dmitry Samersoff wrote:
> Sharath,
>
> I don't see any requirements that ObjectReader should run with an
> application that install security manager but doesn't have
> RuntimePermission.createClassLoader
>
> So I would recommend to close this bug as "not an issue".
>
> -Dmitry
>
> On 2016-09-15 06:38, Harsha wardhana B wrote:
>> Hello,
>>
>> It is not required that SA should be run under security manager to
>> address this change. Any standalone application when run under security
>> manager can use ObjectReader class to exploit vulnerabilities. That is
>> something that should be evaluated.
>>
>> With the below fix any application when run under security manager
>> without RuntimePermission.createClassLoader will be able to create
>> ProcImageClassLoader. We need to check if it is something that is
>> desired and what vulnerabilities can be exploited, if any.
>>
>> -Harsha
>>
>> On 9/14/2016 5:58 PM, Sharath Ballal wrote:
>>> David,
 That aside, the code uses raw types, which is bad. It should also be
 able to retain the this(...) invocation e.g (I haven't compiled this):
>>> This works, Thanks.
>>>
>>>
>>> -Sharath Ballal
>>>
>>>
>>>
>>> -Original Message-
>>> From: David Holmes
>>> Sent: Wednesday, September 14, 2016 3:07 PM
>>> To: Sharath Ballal;serviceability-dev@openjdk.java.net
>>> Subject: Re: RFR: JDK-8068155: [Findbugs]new
>>> sun.jvm.hotspot.utilities.ObjectReader() creates a
>>> sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which
>>> should be performed within a doPrivileged block
>>>
>>> Hi Sharath,
>>>
>>> On 14/09/2016 6:14 PM, Sharath Ballal wrote:
 Hello,

 Please review this fix to add creation of classloader code into
 doPrivileged block

 Issue:https://bugs.openjdk.java.net/browse/JDK-8068155

 Webrev:http://cr.openjdk.java.net/~sballal/8068155/webrev.00/
>>> First I'm also curious about why FindBugs thinks this is needed. AFAIK
>>> you use the doPrivileged to allow you to create the classLoader when
>>> it would otherwise fail if a SecurityManager were present.
>>>
>>> That aside, the code uses raw types, which is bad. It should also be
>>> able to retain the this(...) invocation e.g (I haven't compiled this):
>>>
>>> public ObjectReader() {
>>> this(AccessController.doPrivileged(
>>>new PrivilegedAction() {
>>>   public ClassLoader run() {
>>>  return new ProcImageClassLoader();
>>>   }
>>>}
>>> ));
>>>  }
>>>
>>> Thanks,
>>> David
>>>
 -Sharath Ballal





>

Re: RFR: JDK-8068155: [Findbugs]new sun.jvm.hotspot.utilities.ObjectReader() creates a sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which should be performed within a doPrivileged block

[Sundararajan Athijegannathan]

Does SA runs under security manager at all? For eg. can jhsdb tool run
under security manager? I doubt.

Do we want to make it runnable under security manager? If not, does this
fix makes sense?

-Sundar

On 9/14/2016 1:44 PM, Sharath Ballal wrote:
>
> Hello,
>
> Please review this fix to add creation of classloader code into
> doPrivileged block
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8068155
>
> Webrev: http://cr.openjdk.java.net/~sballal/8068155/webrev.00/
> 
>
>  
>
> -Sharath Ballal
>
>  
>
>  
>

Re: JDK 9 RFR of 8161970, 8157664: Remove 4 tools tests from ProblemList.txt

[Sundararajan Athijegannathan]

+1 for the jlink test being removed from the problem test.

-Sundar

On 8/2/2016 11:27 AM, Amy Lu wrote:
> tools/jlink/JLinkOptimTest.java
> This test has been removed in JDK-8160829
>
> sun/tools/jinfo/JInfoSanityTest.java
> sun/tools/jinfo/JInfoRunningProcessFlagTest.java
> sun/tools/jmap/heapconfig/JMapHeapConfigTest.java
> These tests have been removed in JDK-8155091
>
> Please review the patch to delete these tests from ProblemList.txt.
>
> bug:
> https://bugs.openjdk.java.net/browse/JDK-8161970
> https://bugs.openjdk.java.net/browse/JDK-8157664
>
> webrev: http://cr.openjdk.java.net/~amlu/8161970-8157664/webrev.00/
>
> Thanks,
> Amy
>
> --- old/test/ProblemList.txt  2016-08-02 13:44:34.0 +0800
> +++ new/test/ProblemList.txt  2016-08-02 13:44:34.0 +0800
> @@ -318,7 +318,7 @@
>  
>  
>  
> -# jdk_tools
> +# core_tools
>  
>  tools/pack200/CommandLineTests.java 
> 7143279,8059906 generic-all
>  
> @@ -368,20 +368,14 @@
>  
>  sun/tools/jcmd/TestJcmdSanity.java  8031482 
> windows-all
>  
> -sun/tools/jmap/heapconfig/JMapHeapConfigTest.java   
> 8072131,8132452 generic-all
> -
>  sun/tools/jstatd/TestJstatdExternalRegistry.java8046285 
> generic-all
>  
>  sun/tools/jps/TestJpsJar.java   8160923 
> generic-all
>  
>  sun/tools/jps/TestJpsJarRelative.java   6456333 
> generic-all
>  
> -sun/tools/jinfo/JInfoRunningProcessFlagTest.java6734748 
> generic-all
> -
>  sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java8057732 
> generic-all
>  
> -sun/tools/jinfo/JInfoSanityTest.java8059035 
> generic-all
> -
>  demo/jvmti/compiledMethodLoad/CompiledMethodLoadTest.java   8151899 
> generic-all
>  
>  
> @@ -391,9 +385,3 @@
>  com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java   8141370 
> linux-i586,macosx-all
>  
>  
> -
> -# core_tools
> -
> -tools/jlink/JLinkOptimTest.java 8159264 
> generic-all
> -
> -
>

Re: RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

[Sundararajan Athijegannathan]

Hmm.. not sure. Entire (OS) page data is read and many such pages are
read + cached. "find pointer" like memory walking features would suffer
with this data cloning.  BTW, a very slow debugger against a large core
dump is useless at times.

As David mentioned, I'm not sure if this is even a bug! sun.* and other
package prefixes are listed under "package.access" and so these are not
accessible under a security manager even in jdk8 or below. With jdk9,
over and above "package.access" security check, we have modular access
checks which are done regardless of security manager.  Code scanning
tools need to be updated for jdk9 - which I'm sure will happen in
future. For now, we should just treat these warnings as false positives.

-Sundar

On 8/1/2016 9:43 AM, Jini Susan George wrote:
> Thank you, Sundar, Dan, David. Shouldn’t performance be of a slightly lesser 
> concern here given that this is a debugging scenario?
>
> Thanks,
> Jini.
>
>> -Original Message-
>> From: David Holmes
>> Sent: Monday, August 01, 2016 6:25 AM
>> To: Daniel Daugherty; Sundararajan Athijegannathan; Jini Susan George;
>> serviceability-dev@openjdk.java.net
>> Subject: Re: RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger
>> may expose internal representation
>>
>> On 30/07/2016 2:26 AM, Daniel D. Daugherty wrote:
>>> I didn't miss this part:
>>>
>>>> Besides, Page data may be very big - cloning that ever
>>>> constructor and getter may be too costly.
>>> of what you originally wrote. :-)
>>>
>>> In my opinion, even defense-in-depth security trumps space savings.
>> But in this case you have to explicitly enable module accessibility for
>> this to be an issue. Doesn't seem reasonable to guard against that when
>> it potentially involves a big penalty for well behaved users. It isn't
>> clear to me whether futzing with these byte[]'s is really an issue.
>>
>> David
>> -
>>
>>> Dan
>>>
>>>
>>> On 7/29/16 10:16 AM, Sundararajan Athijegannathan wrote:
>>>> Agreed that it could be considered as a defense-in-depth fix. But, in
>>>> this case Page data could be huge. I think it was not cloned in first
>>>> place to avoid copying many big byte[] instances around.
>>>>
>>>> -Sundar
>>>>
>>>> On 7/29/2016 9:36 PM, Daniel D. Daugherty wrote:
>>>>> Two points:
>>>>>
>>>>> 1) if Findbugs reports the same issue on JDK9 code, then we want to
>>>>>address such that we reduce any Findbugs noise
>>>>>
>>>>> 2) Fixing it could be considered to be a defense-in-depth change.
>>>>>
>>>>> Dan
>>>>>
>>>>>
>>>>> On 7/29/16 7:19 AM, Sundararajan Athijegannathan wrote:
>>>>>> Well, we can't code for that kind of overrides - Findbugs or any
>>>>>> such tool is about normal mode of execution. With that argument,
>>>>>> people can override classes using -Xpatch option as well!
>>>>>>
>>>>>> -Sundar
>>>>>>
>>>>>> On 7/29/2016 6:05 PM, Jini Susan George wrote:
>>>>>>> Thank you, JB and Sundar. Sundar, would that hold true even if
>>>>>>> –XaddExports is used ?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>> Jini.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> *From:*Sundararajan Athijegannathan
>>>>>>> *Sent:* Friday, July 29, 2016 5:11 PM
>>>>>>> *To:* serviceability-dev@openjdk.java.net
>>>>>>> *Subject:* Re: RFR: (XS): JDK-8068004:
>>>>>>> [Findbugs]sun.jvm.hotspot.debugger may expose internal
>> representation
>>>>>>>
>>>>>>>
>>>>>>> If cloning is done to avoid exposing byte[] outside SA, this fix is
>>>>>>> not needed in jdk9. In jdk9, none of the SA packages are exposed
>>>>>>> and code outside SA cannot access this. Besides, Page data may be
>>>>>>> very big - cloning that ever constructor and getter may be too costly.
>>>>>>>
>>>>>>> -Sundar
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 7/29/2016 5:07 PM, Jaroslav Bachorik wrote:
>>>>>>>
>>>>>>> Hi Jini,
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> 'null' seems to be a valid value for 'data' field in both of
>>>>>>> the places you are using 'data.clone()' - you should guard for
>>>>>>> null and call 'clone()' only if the passed in value is non-null.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> -JB-
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Jul 29, 2016 at 11:29 AM, Jini Susan George
>>>>>>> <jini.geo...@oracle.com <mailto:jini.geo...@oracle.com>> wrote:
>>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Please review the fix for the following SA defect (to avoid
>>>>>>> exposing internal representations by storing or returning
>>>>>>> externally mutable objects directly).
>>>>>>>
>>>>>>> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8068004
>>>>>>>
>>>>>>> Webrev:
>>>>>>>
>> http://cr.openjdk.java.net/~sballal/sponsorship/8068004/webrev.00/
>> <http://cr.openjdk.java.net/%7Esballal/sponsorship/8068004/webrev.00/>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> - Jini Susan George
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>

Re: RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

[Sundararajan Athijegannathan]

Agreed that it could be considered as a defense-in-depth fix. But, in
this case Page data could be huge. I think it was not cloned in first
place to avoid copying many big byte[] instances around.

-Sundar

On 7/29/2016 9:36 PM, Daniel D. Daugherty wrote:
> Two points:
>
> 1) if Findbugs reports the same issue on JDK9 code, then we want to
>address such that we reduce any Findbugs noise
>
> 2) Fixing it could be considered to be a defense-in-depth change.
>
> Dan
>
>
> On 7/29/16 7:19 AM, Sundararajan Athijegannathan wrote:
>> Well, we can't code for that kind of overrides - Findbugs or any such
>> tool is about normal mode of execution. With that argument, people
>> can override classes using -Xpatch option as well!
>>
>> -Sundar
>>
>> On 7/29/2016 6:05 PM, Jini Susan George wrote:
>>>
>>> Thank you, JB and Sundar. Sundar, would that hold true even if
>>> –XaddExports is used ?
>>>
>>>  
>>>
>>> Regards,
>>>
>>> Jini.
>>>
>>>  
>>>
>>> *From:*Sundararajan Athijegannathan
>>> *Sent:* Friday, July 29, 2016 5:11 PM
>>> *To:* serviceability-dev@openjdk.java.net
>>> *Subject:* Re: RFR: (XS): JDK-8068004:
>>> [Findbugs]sun.jvm.hotspot.debugger may expose internal representation
>>>
>>>  
>>>
>>> If cloning is done to avoid exposing byte[] outside SA, this fix is
>>> not needed in jdk9. In jdk9, none of the SA packages are exposed and
>>> code outside SA cannot access this. Besides, Page data may be very
>>> big - cloning that ever constructor and getter may be too costly.
>>>
>>> -Sundar
>>>
>>>  
>>>
>>> On 7/29/2016 5:07 PM, Jaroslav Bachorik wrote:
>>>
>>> Hi Jini,
>>>
>>>  
>>>
>>> 'null' seems to be a valid value for 'data' field in both of the
>>> places you are using 'data.clone()' - you should guard for null
>>> and call 'clone()' only if the passed in value is non-null.
>>>
>>>  
>>>
>>> Cheers,
>>>
>>>  
>>>
>>> -JB-
>>>
>>>  
>>>
>>> On Fri, Jul 29, 2016 at 11:29 AM, Jini Susan George
>>> <jini.geo...@oracle.com <mailto:jini.geo...@oracle.com>> wrote:
>>>
>>> Hi all,
>>>
>>> Please review the fix for the following SA defect (to avoid
>>> exposing internal representations by storing or returning
>>> externally mutable objects directly).
>>>
>>> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8068004
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~sballal/sponsorship/8068004/webrev.00/
>>> <http://cr.openjdk.java.net/%7Esballal/sponsorship/8068004/webrev.00/>
>>>
>>> Thanks,
>>>
>>> - Jini Susan George
>>>
>>>  
>>>
>>>  
>>>
>>
>

Re: RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

[Sundararajan Athijegannathan]

Well, we can't code for that kind of overrides - Findbugs or any such
tool is about normal mode of execution. With that argument, people can
override classes using -Xpatch option as well!

-Sundar

On 7/29/2016 6:05 PM, Jini Susan George wrote:
>
> Thank you, JB and Sundar. Sundar, would that hold true even if
> –XaddExports is used ?
>
>  
>
> Regards,
>
> Jini.
>
>  
>
> *From:*Sundararajan Athijegannathan
> *Sent:* Friday, July 29, 2016 5:11 PM
> *To:* serviceability-dev@openjdk.java.net
> *Subject:* Re: RFR: (XS): JDK-8068004:
> [Findbugs]sun.jvm.hotspot.debugger may expose internal representation
>
>  
>
> If cloning is done to avoid exposing byte[] outside SA, this fix is
> not needed in jdk9. In jdk9, none of the SA packages are exposed and
> code outside SA cannot access this. Besides, Page data may be very big
> - cloning that ever constructor and getter may be too costly.
>
> -Sundar
>
>  
>
> On 7/29/2016 5:07 PM, Jaroslav Bachorik wrote:
>
> Hi Jini,
>
>  
>
> 'null' seems to be a valid value for 'data' field in both of the
> places you are using 'data.clone()' - you should guard for null
> and call 'clone()' only if the passed in value is non-null.
>
>  
>
> Cheers,
>
>  
>
> -JB-
>
>  
>
> On Fri, Jul 29, 2016 at 11:29 AM, Jini Susan George
> <jini.geo...@oracle.com <mailto:jini.geo...@oracle.com>> wrote:
>
> Hi all,
>
> Please review the fix for the following SA defect (to avoid
> exposing internal representations by storing or returning
> externally mutable objects directly).
>
> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8068004
>
> Webrev:
> http://cr.openjdk.java.net/~sballal/sponsorship/8068004/webrev.00/
> <http://cr.openjdk.java.net/%7Esballal/sponsorship/8068004/webrev.00/>
>
> Thanks,
>
> - Jini Susan George
>
>  
>
>  
>

Re: RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

[Sundararajan Athijegannathan]

If cloning is done to avoid exposing byte[] outside SA, this fix is not
needed in jdk9. In jdk9, none of the SA packages are exposed and code
outside SA cannot access this. Besides, Page data may be very big -
cloning that ever constructor and getter may be too costly.

-Sundar


On 7/29/2016 5:07 PM, Jaroslav Bachorik wrote:
> Hi Jini,
>
> 'null' seems to be a valid value for 'data' field in both of the
> places you are using 'data.clone()' - you should guard for null and
> call 'clone()' only if the passed in value is non-null.
>
> Cheers,
>
> -JB-
>
> On Fri, Jul 29, 2016 at 11:29 AM, Jini Susan George
> > wrote:
>
> Hi all,
>
> Please review the fix for the followingSAdefect(to avoid exposing
> internal representations by storingor returningexternally mutable
> objectsdirectly).
>
> Bug ID:_https://bugs.openjdk.java.net/browse/JDK-8068004_
>
> 
> Webrev:_http://cr.openjdk.java.net/~sballal/sponsorship/8068004/webrev.00/_
>
> Thanks,
>
> - Jini Susan George
>
>

Re: RFR(S) 8151342: Add module name/version to class histogram output

[Sundararajan Athijegannathan]

+1

PS. Don't we have to update the SA code that dumps histogram so that -F
mode output would be similar?

-Sundar

On 4/27/2016 6:04 PM, harold seigel wrote:
> Hi,
>
> Please review this small change to add module information to the class
> histogram displayed by tools such as jmap and jcmd.  The module name
> and version will follow the class name and be enclosed in
> parentheses.  Classes not in modules will not contain module
> information.  For example:
>
>  num #instances #bytes  class name (module)
> ---
>1:  78921575952  [B (java.base@9-internal)
>2:  1783 214672  java.lang.Class
> (java.base@9-internal)
>3:  5749 183968  java.util.HashMap$Node
> (java.base@9-internal)
>4:  7081 169944  java.lang.String
> (java.base@9-internal)
>5:  1881  95312  [Ljava.lang.Object;
> (java.base@9-internal)
>6:   785  90832  [I (java.base@9-internal)
>   ...
>   16:  1024  16384  ClassHistogramTest$TestClass
>   ...
>
>
> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8151342/
>
> JBS bug:  https://bugs.openjdk.java.net/browse/JDK-8151342
>
> The fix was tested with JCK Lang, and VM tests, the UTE colocated and
> non-colocated quick tests, and the JTreg jdk_svc, hotspot, JDK
> java/io, java/lang, java/util, and java/security tests.
>
> Thanks, Harold
>

Re: RFR (XS): 8153902 remove com/sun/jdi/InterfaceMethodsTest.java, com/sun/jdi/InvokeTest.java from ProblemList

[Sundararajan Athijegannathan]

+1

-Sundar

On 4/12/2016 11:42 AM, serguei.spit...@oracle.com wrote:
> Ping...
>
> Thanks,
> Serguei
>
>
> On 4/8/16 16:04, serguei.spit...@oracle.com wrote:
>> Please, review this trivial, test-only change (enabling previously
>> excluded tests).
>>
>> Bug:
>>   https://bugs.openjdk.java.net/browse/JDK-8153902
>>
>> Summary:
>>   The tests need to be enabled again after the fix of:
>> JDK-8153673 [BACKOUT] JDWP: Memory Leak: GlobalRefs never deleted
>> when processing invokeMethod command
>>
>>
>> Below is the patch:
>>
>> diff -r 8f6aab6360a3 test/ProblemList.txt
>> --- a/test/ProblemList.txtFri Apr 08 12:26:47 2016 -0700
>> +++ b/test/ProblemList.txtFri Apr 08 15:57:28 2016 -0700
>> @@ -333,10 +333,6 @@
>>  
>>  com/sun/jdi/GetLocalVariables4Test.sh  
>> 8067354 windows-all
>>  
>> -com/sun/jdi/InterfaceMethodsTest.java8152586 generic-all
>> -
>> -com/sun/jdi/InvokeTest.java8152586 generic-all
>> -
>>  
>>  
>>  # jdk_util
>>
>>
>> Thanks,
>> Serguei

hg: jdk8/tl/nashorn: 8032944: Improve reflection in Nashorn

[sundararajan . athijegannathan]

Changeset: a43c125b03dc
Author:sundar
Date:  2014-01-30 18:34 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a43c125b03dc

8032944: Improve reflection in Nashorn
Reviewed-by: jlaskey, attila, ahgross

! src/jdk/nashorn/internal/objects/NativeObject.java
+ test/script/sandbox/classbind.js

hg: jdk8/tl/nashorn: 8032954: Nashorn: extend Java.extend

[sundararajan . athijegannathan]

Changeset: eca774d33fa4
Author:sundar
Date:  2014-01-30 19:04 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eca774d33fa4

8032954: Nashorn: extend Java.extend
Reviewed-by: attila, jlaskey, ahgross

! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! test/script/sandbox/classbind.js
! test/script/sandbox/classloader.js
! test/script/sandbox/classloader.js.EXPECTED

hg: jdk8/tl/nashorn: 8032949: Nashorn linkages awry

[sundararajan . athijegannathan]

Changeset: c59fb10cb0b5
Author:sundar
Date:  2014-01-30 19:45 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c59fb10cb0b5

8032949: Nashorn linkages awry
Reviewed-by: jlaskey, attila, ahgross

! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java
! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineSecurityTest.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 4706897b4dec
Author:attila
Date:  2013-12-09 10:52 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4706897b4dec

8029467: Widening of booleans causes bad results
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/Attr.java
+ test/script/basic/JDK-8029467.js
+ test/script/basic/JDK-8029467.js.EXPECTED

Changeset: 18edd7a1b166
Author:lagergren
Date:  2013-12-11 18:09 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/18edd7a1b166

8029780: ant externals broke our test harness with the latest version of the 
octane benchmarks
Reviewed-by: attila, sundar

! make/build-benchmark.xml
! test/script/basic/compile-octane-splitter.js.EXPECTED
! test/script/basic/compile-octane.js.EXPECTED
! test/script/basic/run-octane.js

Changeset: e452a3797290
Author:sundar
Date:  2013-12-12 09:18 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e452a3797290

Merge

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: e0b4483668a7
Author:jlaskey
Date:  2013-11-26 11:58 -0400
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e0b4483668a7

8029173: Debugger support doesn't handle ConsString
Reviewed-by: lagergren, hannesw, sundar
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/runtime/DebuggerSupport.java

Changeset: c14fe3f90616
Author:sundar
Date:  2013-12-04 14:37 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c14fe3f90616

Merge

hg: jdk8/tl/nashorn: 5 new changesets

[sundararajan . athijegannathan]

Changeset: fea9f0f9bbde
Author:sundar
Date:  2013-11-14 15:53 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fea9f0f9bbde

8028161: nashorn: src/jdk/nashorn/api/scripting/ScriptEngineTest.java
Reviewed-by: lagergren, hannesw

! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: a165c0fb5be6
Author:hannesw
Date:  2013-11-16 00:23 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a165c0fb5be6

8028210: Missing conversions on array index expression
Reviewed-by: attila, jlaskey, lagergren

! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java
+ test/script/basic/JDK-8028210.js
+ test/script/basic/JDK-8028210.js.EXPECTED

Changeset: bce2bbfb35ae
Author:lagergren
Date:  2013-11-18 16:35 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bce2bbfb35ae

8028434: Line number nodes were off for while nodes and do while nodes - the 
line number of a loop node should be treated as the location of the test 
expression
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8028434.js
+ test/script/basic/JDK-8028434.js.EXPECTED

Changeset: b375d261e56c
Author:lagergren
Date:  2013-11-19 10:29 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b375d261e56c

8028573: Line number nodes were off for while nodes and do while nodes - the 
line number of a loop node should be treated as the location of the test 
expression
Reviewed-by: attila, hannesw

! test/script/basic/JDK-8028434.js

Changeset: 73d741231651
Author:sundar
Date:  2013-11-22 08:52 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/73d741231651

Merge

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: e65a98146b94
Author:attila
Date:  2013-11-11 14:25 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e65a98146b94

8028020: Function parameter as last expression in comma in return value causes 
bad type calculation
Reviewed-by: jlaskey, lagergren, sundar

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8028020.js
+ test/script/basic/JDK-8028020.js.EXPECTED

Changeset: 2f0f8d1d0753
Author:sundar
Date:  2013-11-12 10:23 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2f0f8d1d0753

Merge

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: 2f07b4234451
Author:sundar
Date:  2013-11-07 17:26 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2f07b4234451

8027828: ClassCastException when converting return value of a Java method to 
boolean
Reviewed-by: jlaskey, attila

! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/api/scripting/ScriptUtils.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
+ test/script/basic/JDK-8027828.js
+ test/script/basic/JDK-8027828.js.EXPECTED
+ test/script/basic/convert.js
+ test/script/basic/convert.js.EXPECTED
! test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java

Changeset: 3b794f364c77
Author:sundar
Date:  2013-11-07 18:11 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3b794f364c77

Merge

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: ae5f2130c3b9
Author:sundar
Date:  2013-11-01 19:54 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ae5f2130c3b9

8027700: function redeclaration checks missing for declaration binding 
instantiation
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/MapCreator.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! test/script/basic/JDK-8015355.js
+ test/script/basic/JDK-8027700.js

Changeset: 98bab0cdd7bf
Author:attila
Date:  2013-11-01 15:36 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/98bab0cdd7bf

8027236: Ensure ScriptObject and ConsString aren't visible to Java
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/runtime/ConsString.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java
! src/jdk/nashorn/internal/runtime/linker/JavaSuperAdapterLinker.java
+ src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java
+ test/script/basic/JDK-8027236.js
+ test/script/basic/JDK-8027236.js.EXPECTED
+ test/src/jdk/nashorn/api/javaaccess/ConsStringTest.java

Changeset: 144861e24260
Author:sundar
Date:  2013-11-04 09:29 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/144861e24260

Merge

hg: jdk8/tl/nashorn: 5 new changesets

[sundararajan . athijegannathan]

Changeset: d8d5b7919c57
Author:sundar
Date:  2013-10-22 14:27 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8d5b7919c57

8027016: Array.prototype.indexOf should return -1 when array is of length zero
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8027016.js

Changeset: 6d339d98074e
Author:hannesw
Date:  2013-10-22 11:12 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6d339d98074e

8027015: AutoCloseable no longer implements @FunctionalInterface
Reviewed-by: lagergren, sundar

! test/script/basic/NASHORN-397.js

Changeset: d24a4fabdce1
Author:hannesw
Date:  2013-10-22 11:31 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d24a4fabdce1

8026955: for-in should convert primitive values to object
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
+ test/script/basic/JDK-8026955.js
+ test/script/basic/JDK-8026955.js.EXPECTED

Changeset: 360761288b38
Author:sundar
Date:  2013-10-22 17:38 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/360761288b38

8027024: String.prototype.charAt and charCodeAt do not evaluate 'self' and 
'pos' arguments in right order
Reviewed-by: jlaskey, attila, lagergren

! src/jdk/nashorn/internal/objects/NativeString.java
! src/overview.html
+ test/script/basic/JDK-8027024.js
+ test/script/basic/JDK-8027024.js.EXPECTED

Changeset: d04028e6b624
Author:sundar
Date:  2013-10-22 17:47 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d04028e6b624

Merge

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: d8aa87d292eb
Author:hannesw
Date:  2013-10-18 22:42 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8aa87d292eb

8026858: Array length does not handle defined properties correctly
Reviewed-by: jlaskey

! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ test/script/basic/JDK-8026858.js

Changeset: 612886fe324d
Author:sundar
Date:  2013-10-21 10:09 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/612886fe324d

Merge

hg: jdk8/tl/nashorn: 4 new changesets

[sundararajan . athijegannathan]

Changeset: b01a10c7c7c2
Author:attila
Date:  2013-10-17 12:38 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b01a10c7c7c2

8026161: Don't narrow floating-point literals in the lexer
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/runtime/JSType.java
+ test/script/basic/JDK-8026161.js
+ test/script/basic/JDK-8026161.js.EXPECTED
! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java

Changeset: a2065f67857c
Author:hannesw
Date:  2013-10-17 17:33 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a2065f67857c

8026701: Array.prototype.splice is slow on dense arrays
Reviewed-by: lagergren, sundar, jlaskey

! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java
! test/examples/array-micro.js
+ test/script/basic/JDK-8026701.js
+ test/script/basic/JDK-8026701.js.EXPECTED

Changeset: 66d27c77b455
Author:hannesw
Date:  2013-10-18 12:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/66d27c77b455

8026805: Array.prototype.length doesn't work as expected
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
+ test/script/basic/JDK-8026805.js

Changeset: b5b4c98b072b
Author:sundar
Date:  2013-10-18 18:26 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b5b4c98b072b

Merge

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 1899da5c71d3
Author:hannesw
Date:  2013-10-16 10:12 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1899da5c71d3

8026692: eval() throws NullPointerException with --compile-only
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Lower.java
+ test/script/basic/JDK-8026692.js

Changeset: 2d5f9f77c199
Author:hannesw
Date:  2013-10-16 10:15 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2d5f9f77c199

8026693: getType() called on DISCARD node
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/codegen/BranchOptimizer.java
+ test/script/basic/JDK-8026693.js

Changeset: adc5639fc4b9
Author:sundar
Date:  2013-10-17 13:02 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/adc5639fc4b9

Merge

hg: jdk8/tl/nashorn: 7 new changesets

[sundararajan . athijegannathan]

Changeset: 6cb4f20d971f
Author:jlaskey
Date:  2013-10-11 14:54 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6cb4f20d971f

8026309: latest runsunspider.js tests contains several bugs
Reviewed-by: sundar, lagergren
Contributed-by: james.las...@oracle.com

! test/script/basic/runsunspider.js

Changeset: 8c617a092d68
Author:hannesw
Date:  2013-10-14 11:45 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8c617a092d68

8026016: too many relinks dominate avatar.js http benchmark
Reviewed-by: sundar, jlaskey, attila

! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ test/script/basic/JDK-8026016.js
+ test/script/basic/JDK-8026016.js.EXPECTED

Changeset: d155c4a7703c
Author:attila
Date:  2013-10-14 12:41 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d155c4a7703c

8026113: Nashorn arrays should automatically convert to Java arrays
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java
+ test/src/jdk/nashorn/api/javaaccess/ArrayConversionTest.java

Changeset: 64e841576c68
Author:attila
Date:  2013-10-15 15:57 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/64e841576c68

8026397: Fix ambiguity with array conversion, including passing JS NativeArrays 
in Java variable arity methods' vararg array position
Reviewed-by: jlaskey, sundar

! src/jdk/internal/dynalink/beans/SingleDynamicMethod.java
! src/jdk/internal/dynalink/support/Guards.java
! src/jdk/internal/dynalink/support/messages.properties
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java
! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
! test/src/jdk/nashorn/api/javaaccess/ArrayConversionTest.java

Changeset: aa452eb4a5d0
Author:hannesw
Date:  2013-10-15 17:37 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aa452eb4a5d0

8026367: Add a sync keyword to mozilla_compat
Reviewed-by: sundar, attila, lagergren

! src/jdk/nashorn/api/scripting/ScriptUtils.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
+ test/script/basic/JDK-8026367.js
! test/script/sandbox/loadcompat.js

Changeset: b3ee112a328e
Author:jlaskey
Date:  2013-10-15 13:14 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b3ee112a328e

8026498: Revert: latest runsunspider.js tests contains several bugs
Reviewed-by: sundar, hannesw
Contributed-by: james.las...@oracle.com

! test/script/basic/runsunspider.js

Changeset: 9a13e95cc40f
Author:sundar
Date:  2013-10-15 22:13 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9a13e95cc40f

Merge

hg: jdk8/tl/nashorn: 5 new changesets

[sundararajan . athijegannathan]

Changeset: 34f7a699cdef
Author:sundar
Date:  2013-10-10 14:43 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/34f7a699cdef

8026162: this in SAM adapter functions is wrong
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java
+ test/script/basic/JDK-8026162.js

Changeset: ed3da7a574a0
Author:lagergren
Date:  2013-10-10 16:16 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ed3da7a574a0

8026250: Logging nullpointer bugfix and javadoc warnings
Reviewed-by: hannesw, jlaskey, sundar

! src/jdk/nashorn/api/scripting/JSObject.java
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/DebugLogger.java
! src/jdk/nashorn/internal/runtime/GlobalObject.java
! src/jdk/nashorn/internal/runtime/ListAdapter.java
! src/jdk/nashorn/internal/runtime/ScriptLoader.java
! src/jdk/nashorn/internal/runtime/WithObject.java

Changeset: a781ea074521
Author:sundar
Date:  2013-10-10 21:43 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a781ea074521

8026264: Getter, setter function name mangling issues
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
+ test/script/basic/JDK-8026264.js

Changeset: 375c2f2d41c8
Author:sundar
Date:  2013-10-11 06:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/375c2f2d41c8

8026263: [NASHORN] Test test/script/basic/JDK-8025488.js fails in nightly builds
Reviewed-by: jlaskey

! test/script/basic/JDK-8025488.js

Changeset: 56be5161f0d2
Author:sundar
Date:  2013-10-11 09:09 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/56be5161f0d2

Merge

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 03a68e7ca1d5
Author:lagergren
Date:  2013-10-09 17:53 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/03a68e7ca1d5

8026137: Fix Issues with Binary Evaluation Order
Reviewed-by: hannesw, jlaskey
Contributed-by: marcus.lagerg...@oracle.com, attila.szeg...@oracle.com

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/BranchOptimizer.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompileUnit.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/codegen/types/BooleanType.java
! src/jdk/nashorn/internal/codegen/types/ObjectType.java
! src/jdk/nashorn/internal/codegen/types/Type.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/BaseNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
- src/jdk/nashorn/internal/ir/TypeOverride.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
! src/jdk/nashorn/internal/parser/TokenType.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/arrays/JavaArrayIterator.java
! src/jdk/nashorn/internal/runtime/arrays/ReverseJavaArrayIterator.java
! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java
+ test/script/basic/JDK-8026137.js
+ test/script/basic/JDK-8026137.js.EXPECTED

Changeset: 7cc5ff16380f
Author:sundar
Date:  2013-10-10 11:48 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7cc5ff16380f

8026167: Class cache/reuse of 'eval' scripts results in ClassCastException in 
some cases.
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/runtime/CodeInstaller.java
! src/jdk/nashorn/internal/runtime/Context.java
! test/script/assert.js
! test/script/basic/JDK-8019508.js
! test/script/basic/JDK-8019508.js.EXPECTED
! test/script/basic/JDK-8019553.js
! test/script/basic/JDK-8019553.js.EXPECTED
! test/script/basic/JDK-8019791.js
! test/script/basic/JDK-8019791.js.EXPECTED
! test/script/basic/JDK-8019805.js
! test/script/basic/JDK-8019805.js.EXPECTED
+ test/script/basic/JDK-8026167.js
! test/script/basic/NASHORN-100.js
! test/script/basic/NASHORN-100.js.EXPECTED
! test/script/basic/NASHORN-293.js
! test/script/basic/NASHORN-293.js.EXPECTED
! test/script/basic/NASHORN-40.js
! test/script/basic/NASHORN-40.js.EXPECTED
! test/script/basic/NASHORN-51.js
! test/script/basic/NASHORN-51.js.EXPECTED
! test/script/basic/NASHORN-98.js
! test/script/basic/NASHORN-98.js.EXPECTED
! test/script/basic/eval.js
! test/script/basic/eval.js.EXPECTED

Changeset: e60bbcf2f6b6
Author:sundar
Date:  2013-10-10 13:17 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e60bbcf2f6b6

8026248: importClass has to be a varargs function
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
+ test/script/basic/JDK-8026248.js
+ test/script/basic/JDK-8026248.js.EXPECTED

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 8d29733ad609
Author:sundar
Date:  2013-10-09 10:47 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8d29733ad609

8026112: Function(with(x ? 1e81 : (x2.constructor = 0.1)){}) throws 
AssertionError: double is not compatible with object
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8026112.js

Changeset: 1e03d7caa68b
Author:sundar
Date:  2013-10-09 13:26 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1e03d7caa68b

8026125: Array.prototype.slice.call(Java.type(java.util.HashMap)) throws 
ClassCastException: jdk.internal.dynalink.beans.StaticClass cannot be cast to 
jdk.nashorn.internal.runtime.ScriptObject
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8026125.js

Changeset: ec3094d9d5d5
Author:hannesw
Date:  2013-10-09 14:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ec3094d9d5d5

8026008: Constant folding removes var statement
Reviewed-by: sundar, jlaskey

! src/jdk/nashorn/internal/codegen/FoldConstants.java
+ test/script/basic/JDK-8026008.js
+ test/script/basic/JDK-8026008.js.EXPECTED

hg: jdk8/tl/nashorn: 6 new changesets

[sundararajan . athijegannathan]

Changeset: 6345d08fd5de
Author:hannesw
Date:  2013-10-08 11:55 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6345d08fd5de

8025213: Assignment marks variable as defined too early
Reviewed-by: jlaskey, lagergren, sundar

! src/jdk/nashorn/internal/codegen/Attr.java
+ test/script/basic/JDK-8025213.js
+ test/script/basic/JDK-8025213.js.EXPECTED

Changeset: 8c326f8c6799
Author:sundar
Date:  2013-10-08 13:02 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8c326f8c6799

8026033: Switch should load expression even when there are no cases in it
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8026033.js
+ test/script/basic/JDK-8026033.js.EXPECTED

Changeset: 025e2ff9e91b
Author:hannesw
Date:  2013-10-08 13:11 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/025e2ff9e91b

8025965: Specialized functions with same weight replace each other in TreeSet
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/runtime/CompiledFunction.java

Changeset: 19dba6637f20
Author:sundar
Date:  2013-10-08 14:57 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/19dba6637f20

8026039: future strict names are allowed as function name and argument name of 
a strict function
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/error/JDK-8026039.js
+ test/script/error/JDK-8026039.js.EXPECTED

Changeset: c9921761903b
Author:hannesw
Date:  2013-10-08 15:53 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c9921761903b

8026042: FoldConstants need to guard against ArrayLiteralNode
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
+ test/script/basic/JDK-8026042.js
+ test/script/basic/JDK-8026042.js.EXPECTED

Changeset: 346ba5b8a488
Author:sundar
Date:  2013-10-08 16:46 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/346ba5b8a488

8026048: Function constructor should convert arguments to String before 
performing any syntax checks
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/objects/NativeFunction.java
+ test/script/basic/JDK-8026048.js

hg: jdk8/tl/nashorn: 8025771: Enhance Nashorn Contexts

[sundararajan . athijegannathan]

Changeset: 3470bc26128f
Author:sundar
Date:  2013-10-04 16:21 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3470bc26128f

8025771: Enhance Nashorn Contexts
Reviewed-by: jlaskey, hannesw

- make/java.security.override
! make/project.properties
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java
! test/script/basic/JDK-8023026.js
+ test/script/sandbox/arrayclass.js
+ test/script/sandbox/arrayclass.js.EXPECTED

hg: jdk8/tl/nashorn: 8 new changesets

[sundararajan . athijegannathan]

Changeset: 2016a6b9e1f3
Author:hannesw
Date:  2013-09-27 16:59 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2016a6b9e1f3

8025515: Performance issues with Source.getLine()
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/ir/LexicalContext.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/Source.java
+ test/script/basic/JDK-8025515.js

Changeset: 1809c9e97c71
Author:hannesw
Date:  2013-09-27 17:00 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1809c9e97c71

8025520: Array.prototype.slice should only copy defined elements
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8025520.js

Changeset: efc40aacaee4
Author:hannesw
Date:  2013-09-30 15:54 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/efc40aacaee4

8025589: Array.prototype.shift should only copy defined elements in generic mode
Reviewed-by: sundar, attila

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8025589.js

Changeset: ad5f9ce2a95b
Author:jlaskey
Date:  2013-09-30 10:24 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ad5f9ce2a95b

Merge


Changeset: 787e36fdf69a
Author:jlaskey
Date:  2013-09-30 12:06 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/787e36fdf69a

Merge


Changeset: 7272ec90f2c6
Author:sundar
Date:  2013-09-30 21:33 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7272ec90f2c6

8025629: load function should support a way to load scripts from classpath
Reviewed-by: lagergren, hannesw, attila

! make/build.xml
! src/jdk/nashorn/internal/runtime/Context.java
+ test/script/trusted/JDK-8025629.js
+ test/src/jdk/nashorn/internal/runtime/resources/load_test.js

Changeset: f5aefbe76cec
Author:jlaskey
Date:  2013-09-30 18:09 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f5aefbe76cec

8025689: fx:base.js classes not loading
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/runtime/resources/fx/base.js

Changeset: cd7fb58043cb
Author:sundar
Date:  2013-10-01 14:38 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/cd7fb58043cb

8025488: Error.captureStackTrace should not format error stack
Reviewed-by: hannesw, attila

! src/jdk/nashorn/internal/objects/NativeError.java
+ test/script/basic/JDK-8025488.js
+ test/script/basic/JDK-8025488.js.EXPECTED

hg: jdk8/tl/nashorn: 4 new changesets

[sundararajan . athijegannathan]

Changeset: 279f47b353f3
Author:sundar
Date:  2013-09-20 20:55 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/279f47b353f3

8025147: Trailing comma is not allowed in JSONArray and JSONObject
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/parser/JSONParser.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/script/basic/JDK-8025147.js
+ test/script/basic/JDK-8025147.js.EXPECTED

Changeset: 16b6db9f7225
Author:sundar
Date:  2013-09-20 22:37 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/16b6db9f7225

8025149: JSON.stringify does not handle 'space' argument as per the spec.
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/objects/NativeJSON.java
+ test/script/basic/JDK-8025149.js
+ test/script/basic/JDK-8025149.js.EXPECTED

Changeset: b8d9a63578e2
Author:hannesw
Date:  2013-09-21 10:11 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b8d9a63578e2

8025163: Date methods should not return -0
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeDate.java
+ test/script/basic/JDK-8025163.js
+ test/script/basic/JDK-8025163.js.EXPECTED

Changeset: 8f6304373671
Author:sundar
Date:  2013-09-23 14:20 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8f6304373671

Merge

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: 195be8ca5c97
Author:sundar
Date:  2013-09-20 12:56 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/195be8ca5c97

8025111: undefined or null 'with' expression in empty with block should throw 
TypeError
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8025111.js

Changeset: fa491b75d3e4
Author:hannesw
Date:  2013-09-20 12:11 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fa491b75d3e4

8022587: ClassCache is not optimal and leaks Source instances
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/objects/Global.java

hg: jdk8/tl/nashorn: 4 new changesets

[sundararajan . athijegannathan]

Changeset: f954d3f4d192
Author:sundar
Date:  2013-09-19 13:34 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f954d3f4d192

8025048: true as case label results in ClassCastException
Reviewed-by: lagergren

! src/jdk/nashorn/internal/codegen/Attr.java
+ test/script/basic/JDK-8025048-2.js
+ test/script/basic/JDK-8025048.js

Changeset: 740b1133f1b6
Author:hannesw
Date:  2013-09-19 15:39 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/740b1133f1b6

8023154: compileAllTests fails with: 2 tests failed to compile
Reviewed-by: sundar, jlaskey

! make/build-benchmark.xml
! make/build.xml
! make/project.properties

Changeset: 821b0b610861
Author:sundar
Date:  2013-09-19 21:20 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/821b0b610861

8025080: Object literal getter, setter function with number format property 
name results in ClassFormatError
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8025080.js
+ test/script/basic/JDK-8025080.js.EXPECTED
! test/script/basic/parser/objectLitExpr.js.EXPECTED

Changeset: 18d64bc4937d
Author:sundar
Date:  2013-09-19 23:48 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/18d64bc4937d

8025090: 'while' statement with 'test' using var before being declared in body 
results in VerifyError
Reviewed-by: jlaskey

! src/jdk/nashorn/internal/ir/WhileNode.java
+ test/script/basic/JDK-8025090.js

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: 1971c2d770ae
Author:sundar
Date:  2013-09-18 13:06 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1971c2d770ae

8024972: for (LeftHandSideExpression in Expression) crashes the compiler
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8024972.js
+ test/script/basic/JDK-8024972.js.EXPECTED

Changeset: a62172fe5bae
Author:sundar
Date:  2013-09-18 16:36 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a62172fe5bae

8024973: Using a different ScriptContext with a CompiledScript results in 
ScriptException
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/runtime/Source.java
! test/script/trusted/JDK-8008305.js
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

hg: jdk8/tl/nashorn: 5 new changesets

[sundararajan . athijegannathan]

Changeset: e60f6add90d7
Author:hannesw
Date:  2013-09-12 14:02 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e60f6add90d7

8024476: Octane regression on Richards
Reviewed-by: sundar, jlaskey

! src/jdk/nashorn/internal/runtime/JSType.java

Changeset: 572a2e50ba9e
Author:hannesw
Date:  2013-09-12 17:13 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/572a2e50ba9e

8024512: Regex /[^\[]/ doesn't match
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8024512.js
+ test/script/basic/JDK-8024512.js.EXPECTED

Changeset: 917b16e509bd
Author:sundar
Date:  2013-09-12 22:16 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/917b16e509bd

8024693: Various minor issues with JSONWriter used by script parser API
Reviewed-by: jlaskey, hannesw

! make/build.xml
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! test/script/basic/NASHORN-737.js
! test/script/basic/NASHORN-737.js.EXPECTED
+ test/script/basic/parser/assignmentExpr.js
+ test/script/basic/parser/assignmentExpr.js.EXPECTED
+ test/script/basic/parser/binaryExpr.js
+ test/script/basic/parser/binaryExpr.js.EXPECTED
+ test/script/basic/parser/breakStat.js
+ test/script/basic/parser/breakStat.js.EXPECTED
+ test/script/basic/parser/condExpr.js
+ test/script/basic/parser/condExpr.js.EXPECTED
+ test/script/basic/parser/continueStat.js
+ test/script/basic/parser/continueStat.js.EXPECTED
+ test/script/basic/parser/debuggerStat.js
+ test/script/basic/parser/debuggerStat.js.EXPECTED
+ test/script/basic/parser/functions.js
+ test/script/basic/parser/functions.js.EXPECTED
+ test/script/basic/parser/ifStat.js
+ test/script/basic/parser/ifStat.js.EXPECTED
+ test/script/basic/parser/labelledStat.js
+ test/script/basic/parser/labelledStat.js.EXPECTED
+ test/script/basic/parser/lhsExpr.js
+ test/script/basic/parser/lhsExpr.js.EXPECTED
+ test/script/basic/parser/loopStat.js
+ test/script/basic/parser/loopStat.js.EXPECTED
+ test/script/basic/parser/objectLitExpr.js
+ test/script/basic/parser/objectLitExpr.js.EXPECTED
+ test/script/basic/parser/parenExpr.js
+ test/script/basic/parser/parenExpr.js.EXPECTED
+ test/script/basic/parser/primaryExpr.js
+ test/script/basic/parser/primaryExpr.js.EXPECTED
+ test/script/basic/parser/returnStat.js
+ test/script/basic/parser/returnStat.js.EXPECTED
+ test/script/basic/parser/switchStat.js
+ test/script/basic/parser/switchStat.js.EXPECTED
+ test/script/basic/parser/throwStat.js
+ test/script/basic/parser/throwStat.js.EXPECTED
+ test/script/basic/parser/tryCatchStat.js
+ test/script/basic/parser/tryCatchStat.js.EXPECTED
+ test/script/basic/parser/unaryExpr.js
+ test/script/basic/parser/unaryExpr.js.EXPECTED
+ test/script/basic/parser/useStrict.js
+ test/script/basic/parser/useStrict.js.EXPECTED
+ test/script/basic/parser/util.js
+ test/script/basic/parser/varDecl.js
+ test/script/basic/parser/varDecl.js.EXPECTED
+ test/script/basic/parser/withStat.js
+ test/script/basic/parser/withStat.js.EXPECTED

Changeset: 8b0914b25430
Author:sundar
Date:  2013-09-13 16:45 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8b0914b25430

8024619: JDBC java.sql.DriverManager is not usable from JS script
Reviewed-by: jlaskey, lagergren, attila

! make/build.xml
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/NashornLoader.java
! src/jdk/nashorn/internal/runtime/ScriptLoader.java
! src/jdk/nashorn/internal/runtime/StructureLoader.java
+ test/script/basic/JDK-8024619.js
+ test/src/META-INF/services/java.sql.Driver
+ test/src/jdk/nashorn/api/NashornSQLDriver.java

Changeset: 5683eca2967a
Author:sundar
Date:  2013-09-13 17:50 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5683eca2967a

Merge

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 7ae169639485
Author:sundar
Date:  2013-09-05 21:17 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7ae169639485

8024255: When a keyword is used as object property name, the property can not 
be deleted
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8024255.js

Changeset: c3b6ce7b74bf
Author:sundar
Date:  2013-09-09 20:10 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c3b6ce7b74bf

8024180: Incorrect handling of expression and parent scope in 'with' statements
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/GlobalObject.java
! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/WithObject.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/script/basic/8024180/global_var_delete.js
+ test/script/basic/8024180/global_var_delete.js.EXPECTED
+ test/script/basic/8024180/global_var_shadow.js
+ test/script/basic/8024180/global_var_shadow.js.EXPECTED
+ test/script/basic/8024180/scope_no_such_prop.js
+ test/script/basic/8024180/scope_no_such_prop.js.EXPECTED
+ test/script/basic/8024180/with_expr_prop_add.js
+ test/script/basic/8024180/with_expr_prop_add.js.EXPECTED
+ test/script/basic/8024180/with_expr_proto_prop_add.js
+ test/script/basic/8024180/with_expr_proto_prop_add.js.EXPECTED
+ test/script/basic/8024180/with_java_object.js
+ test/script/basic/8024180/with_java_object.js.EXPECTED
! test/src/jdk/nashorn/internal/runtime/ContextTest.java

Changeset: 1eca380a221f
Author:sundar
Date:  2013-09-09 20:16 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1eca380a221f

Merge

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: b5ff11e00050
Author:sundar
Date:  2013-09-04 14:29 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b5ff11e00050

8024120: Setting __proto__ to null removes the __proto__ property
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
! test/script/basic/JDK-8023368.js
! test/script/basic/JDK-8023368.js.EXPECTED
+ test/script/basic/JDK-8024120.js
! test/script/basic/circular_proto.js
! test/script/basic/nonextensible_proto_assign.js

Changeset: e43ab4062636
Author:sundar
Date:  2013-09-04 19:58 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e43ab4062636

8024174: Setting __proto__ property in Object literal should be supported
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ test/script/basic/JDK-8024174.js

hg: jdk8/tl/nashorn: 10 new changesets

[sundararajan . athijegannathan]

Changeset: badc919cd621
Author:lagergren
Date:  2013-08-23 14:16 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/badc919cd621

8023550: -d option was broken for any dir but '.'. Fixed Java warnings.
Reviewed-by: jlaskey, sundar

! 
buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java
! 
buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java
! src/jdk/internal/dynalink/ChainedCallSite.java
! src/jdk/internal/dynalink/DefaultBootstrapper.java
! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
! src/jdk/internal/dynalink/beans/OverloadedDynamicMethod.java
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/DebuggerSupport.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java
! src/jdk/nashorn/internal/runtime/regexp/joni/BitSet.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java
! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Region.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java
! src/jdk/nashorn/internal/runtime/regexp/joni/SearchAlgorithm.java
! src/jdk/nashorn/internal/runtime/regexp/joni/StackMachine.java
! src/jdk/nashorn/internal/runtime/regexp/joni/WarnCallback.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ast/EncloseNode.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ast/Node.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ast/QuantifierNode.java
! src/jdk/nashorn/internal/runtime/regexp/joni/exception/ErrorMessages.java
! tools/fxshell/jdk/nashorn/tools/FXShell.java

Changeset: e2d94d032760
Author:jlaskey
Date:  2013-08-23 09:56 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e2d94d032760

8020946: TokenType#toString returned null
Reviewed-by: hannesw, lagergren
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/parser/TokenType.java

Changeset: eb7b8340ce3a
Author:lagergren
Date:  2013-08-23 15:46 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eb7b8340ce3a

8023454: Updated DEVELOPER_README and command line flags, ensuring that 
undocumented flags that aren't guaranteed to work (disabled by default) and 
that are work in progress show up with an EXPERIMENTAL tag.
Reviewed-by: attila, jlaskey

! docs/DEVELOPER_README
! src/jdk/nashorn/internal/runtime/resources/Options.properties

Changeset: 12820c8d0a5d
Author:jlaskey
Date:  2013-08-23 12:20 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/12820c8d0a5d

8019987: String trimRight and trimLeft could be defined
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/objects/NativeString.java
+ test/script/basic/JDK-8019987.js

Changeset: c19c66e661a9
Author:hannesw
Date:  2013-08-26 15:59 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c19c66e661a9

8023650: Regexp m flag does not recognize CRNL or CR
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Config.java
! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Matcher.java
! src/jdk/nashorn/tools/Shell.java
+ test/script/basic/JDK-8023650.js

Changeset: 99e48c76d11f
Author:jlaskey
Date:  2013-08-26 15:33 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/99e48c76d11f

8023721: Simplify eval in DebuggerSupport.
Reviewed-by: sundar, lagergren, hannesw
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/runtime/DebuggerSupport.java

Changeset: 3bd077423a08
Author:sundar
Date:  2013-08-27 15:54 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3bd077423a08

8022773: ScriptEngineTest.printManyTest fails
Reviewed-by: lagergren, attila

! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 47f0a4c4b729
Author:attila
Date:  2013-08-27 13:17 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/47f0a4c4b729

8023780: Gracefully handle @CS methods while binding bean properties
Reviewed-by: jlaskey, lagergren, sundar

! src/jdk/nashorn/internal/objects/NativeObject.java
+ test/script/basic/JDK-8023780.js
+ test/script/basic/JDK-8023780.js.EXPECTED

Changeset: bda0e89f88ae
Author:sundar
Date:  2013-08-27 18:57 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bda0e89f88ae

8023784: 

hg: jdk8/tl/nashorn: 7 new changesets

[sundararajan . athijegannathan]

Changeset: bbc4e9d37315
Author:jlaskey
Date:  2013-08-12 18:00 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bbc4e9d37315

8022676: Confusing error message checking instanceof non-class
Reviewed-by: jlaskey, sundar
Contributed-by: michael.horow...@oracle.com

! src/jdk/nashorn/internal/runtime/resources/Messages.properties

Changeset: ba507ac08719
Author:sundar
Date:  2013-08-14 20:51 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ba507ac08719

8023026: Array.prototype iterator functions like forEach, reduce should work 
for Java arrays, lists
Reviewed-by: jlaskey, lagergren

- src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/JavaArrayIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/JavaListIterator.java
- src/jdk/nashorn/internal/runtime/arrays/MapIterator.java
- src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/ReverseJavaArrayIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/ReverseJavaListIterator.java
- src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/ReverseScriptArrayIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/ReverseScriptObjectIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/ScriptArrayIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/ScriptObjectIterator.java
+ test/script/basic/JDK-8023026.js
+ test/script/basic/JDK-8023026.js.EXPECTED

Changeset: 09c99b58b81e
Author:sundar
Date:  2013-08-16 15:04 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/09c99b58b81e

8020355: bind on built-in constructors don't use bound argument values
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
+ test/script/basic/JDK-8020355.js

Changeset: 1d29d2e27590
Author:hannesw
Date:  2013-08-16 13:42 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1d29d2e27590

8019985: Date.parse(2000-01-01T00:00:00.Z) should return NaN
Reviewed-by: sundar, jlaskey

! src/jdk/nashorn/internal/parser/DateParser.java
+ test/script/basic/JDK-8019985.js

Changeset: 36fb36217e1d
Author:lagergren
Date:  2013-08-16 18:51 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/36fb36217e1d

8023017: SUB missing for widest op == number for BinaryNode
Reviewed-by: sundar, jlaskey

! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/ObjectCreator.java
! src/jdk/nashorn/internal/ir/BinaryNode.java
! src/jdk/nashorn/internal/ir/BreakableNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/LexicalContextNode.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java
! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java
! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethod.java
! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java

Changeset: bd0174b1a42f
Author:sundar
Date:  2013-08-19 17:16 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bd0174b1a42f

8023210: jjs tools should support a mode where it will load few command line 
scripts and then entering into interactive shell
Reviewed-by: hannesw, attila, lagergren, jlaskey

! src/jdk/nashorn/internal/runtime/options/Options.java
! src/jdk/nashorn/tools/Shell.java

Changeset: e628aefac504
Author:sundar
Date:  2013-08-19 19:37 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e628aefac504

Merge

- src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java
- src/jdk/nashorn/internal/runtime/arrays/MapIterator.java
- src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java
- src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java

hg: jdk8/tl/nashorn: 9 new changesets

[sundararajan . athijegannathan]

Changeset: 14ea21d58f83
Author:jlaskey
Date:  2013-08-08 11:20 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/14ea21d58f83

Merge

- src/jdk/internal/dynalink/support/Backport.java

Changeset: 47e2b609fe31
Author:sundar
Date:  2013-08-09 20:48 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/47e2b609fe31

8022707: Revisit all doPrivileged blocks
Reviewed-by: jlaskey, hannesw

! make/project.properties
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ECMAErrors.java
! src/jdk/nashorn/internal/runtime/Logging.java
! src/jdk/nashorn/internal/runtime/linker/ClassAndLoader.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java
! src/jdk/nashorn/internal/runtime/options/Options.java
! src/jdk/nashorn/tools/Shell.java

Changeset: 01304b0550fb
Author:sundar
Date:  2013-08-12 14:43 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/01304b0550fb

8022782: publicLookup access failures in ScriptObject, ScriptFunction and 
ScriptFunction
Reviewed-by: lagergren, attila, hannesw

! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java

Changeset: 3c13fba4d727
Author:attila
Date:  2013-08-12 12:46 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3c13fba4d727

8022789: Revisit doPrivileged blocks in Dynalink
Reviewed-by: lagergren, sundar

! src/jdk/internal/dynalink/DynamicLinkerFactory.java
+ src/jdk/internal/dynalink/support/ClassLoaderGetterContextProvider.java
! src/jdk/internal/dynalink/support/ClassMap.java
! src/jdk/internal/dynalink/support/TypeConverterFactory.java

Changeset: 0bbaa0ac36ab
Author:sundar
Date:  2013-08-12 16:52 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0bbaa0ac36ab

8022614: Please exclude test test/script/trusted/JDK-8020809.js from Nashorn 
code coverage run
Reviewed-by: jlaskey, lagergren

! exclude/exclude_list_cc.txt

Changeset: 03ba1cd734c0
Author:hannesw
Date:  2013-08-12 13:31 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/03ba1cd734c0

8022731: NativeArguments has wrong implementation of isMapped()
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeArguments.java
+ test/script/basic/JDK-8022731.js
+ test/script/basic/JDK-8022731.js.EXPECTED

Changeset: 821b605c7046
Author:sundar
Date:  2013-08-12 17:08 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/821b605c7046

8022615: [nightly] Two nashorn print tests fail in nightly builds on Windows
Reviewed-by: lagergren, jlaskey

! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: f2e1673db03b
Author:sundar
Date:  2013-08-12 18:16 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f2e1673db03b

8022598: Object.getPrototypeOf should return null for host objects rather than 
throwing TypeError
Reviewed-by: lagergren, jlaskey, attila, hannesw

! src/jdk/nashorn/internal/objects/NativeObject.java
+ test/script/basic/JDK-8022598.js

Changeset: a0807e889be3
Author:sundar
Date:  2013-08-12 20:37 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a0807e889be3

Merge

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 9a3e3bb30db3
Author:attila
Date:  2013-08-07 16:38 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9a3e3bb30db3

8022509: Various Dynalink security enhancements
Reviewed-by: jlaskey, hannesw

! src/jdk/internal/dynalink/ChainedCallSite.java
! src/jdk/internal/dynalink/DynamicLinkerFactory.java
! src/jdk/internal/dynalink/beans/ClassString.java
! src/jdk/internal/dynalink/beans/StaticClassLinker.java
- src/jdk/internal/dynalink/support/Backport.java
! src/jdk/internal/dynalink/support/ClassMap.java
! src/jdk/internal/dynalink/support/Guards.java
! src/jdk/internal/dynalink/support/Lookup.java
! src/jdk/internal/dynalink/support/TypeConverterFactory.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java

Changeset: dd79c04ef7df
Author:sundar
Date:  2013-08-08 16:38 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/dd79c04ef7df

8022524: Memory leaks in nashorn sources and tests found by jhat analysis
Reviewed-by: attila, hannesw

! make/project.properties
! src/jdk/nashorn/internal/codegen/CompileUnit.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeDate.java
! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/runtime/GlobalObject.java
! src/jdk/nashorn/internal/runtime/JSONFunctions.java
! src/jdk/nashorn/internal/runtime/ListAdapter.java
! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! test/script/basic/JDK-8020357.js
! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java
! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java
! test/src/jdk/nashorn/internal/codegen/CompilerTest.java
! test/src/jdk/nashorn/internal/parser/ParserTest.java

Changeset: 0d7484bf8597
Author:sundar
Date:  2013-08-08 18:19 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0d7484bf8597

Merge

- src/jdk/internal/dynalink/support/Backport.java

hg: jdk8/tl/jdk: 8022483: Nashorn compatibility issues in jhat's OQL feature

[sundararajan . athijegannathan]

Changeset: 99f4319763a9
Author:sundar
Date:  2013-08-07 18:16 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99f4319763a9

8022483: Nashorn compatibility issues in jhat's OQL feature
Reviewed-by: lagergren, attila, hannesw

! src/share/classes/com/sun/tools/hat/resources/hat.js
! src/share/classes/com/sun/tools/hat/resources/oqlhelp.html

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: 0ad00ae4fec6
Author:hannesw
Date:  2013-08-01 12:23 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0ad00ae4fec6

8020132: Big object literal with numerical keys exceeds method size
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java
! src/jdk/nashorn/internal/codegen/MapCreator.java
! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java
! src/jdk/nashorn/internal/objects/ArrayBufferView.java
! src/jdk/nashorn/internal/runtime/NashornLoader.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java
! src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/NoTypeArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java
! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/UndefinedArrayFilter.java
+ test/script/basic/JDK-8020132.js
+ test/script/basic/JDK-8020132.js.EXPECTED

Changeset: bb0f3c896cb7
Author:sundar
Date:  2013-08-06 13:10 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bb0f3c896cb7

Merge

hg: jdk8/tl/jdk: 8016531: jconsole-plugin script demo does not work with nashorn

[sundararajan . athijegannathan]

Changeset: 87367a1c7f76
Author:sundar
Date:  2013-08-05 21:31 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87367a1c7f76

8016531: jconsole-plugin script demo does not work with nashorn
Reviewed-by: lagergren, hannesw
Contributed-by: rieberandr...@gmail.com

! 
src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java
! src/share/demo/scripting/jconsole-plugin/src/resources/jconsole.js
! src/share/demo/scripting/jconsole-plugin/src/scripts/invoke.js
! src/share/demo/scripting/jconsole-plugin/src/scripts/jstack.js
! src/share/demo/scripting/jconsole-plugin/src/scripts/jtop.js
! src/share/demo/scripting/jconsole-plugin/src/scripts/sysprops.js
! src/share/sample/scripting/scriptpad/README.txt
! src/share/sample/scripting/scriptpad/src/resources/conc.js
! src/share/sample/scripting/scriptpad/src/resources/mm.js

hg: jdk8/tl/nashorn: 4 new changesets

[sundararajan . athijegannathan]

Changeset: f6588f168d79
Author:hannesw
Date:  2013-07-26 13:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f6588f168d79

8020719: Run tests with reduced splitter threshold
Reviewed-by: lagergren, sundar, jlaskey

! make/build.xml
! make/project.properties
+ test/script/basic/NASHORN-592-dual.js
+ test/script/basic/NASHORN-592-dual.js.EXPECTED
+ test/script/basic/compile-octane-splitter.js
+ test/script/basic/compile-octane-splitter.js.EXPECTED
+ test/script/basic/splitter.js
+ test/script/basic/splitter.js.EXPECTED
- test/script/representations/NASHORN-592a.js
! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java
! test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java
! test/src/jdk/nashorn/internal/test/framework/TestConfig.java
! test/src/jdk/nashorn/internal/test/framework/TestFinder.java

Changeset: 17a947418e65
Author:jlaskey
Date:  2013-07-26 09:17 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/17a947418e65

8021321: Two runsunspider tests fail after updating sunspider to 1.0
Reviewed-by: jlaskey, sundar
Contributed-by: michael.horow...@oracle.com

! test/script/basic/runsunspider.js

Changeset: fbd21b00197b
Author:sundar
Date:  2013-07-26 20:10 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fbd21b00197b

8021571: @fork tests should use VM options passed from project.properties
Reviewed-by: lagergren, hannesw, jlaskey

! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java
! 
buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java
! 
buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java
! make/project.properties
! src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java
! src/jdk/nashorn/internal/objects/PrototypeObject.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ListAdapter.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java
! src/jdk/nashorn/internal/runtime/WithObject.java
! src/jdk/nashorn/internal/runtime/linker/AdaptationException.java
! src/jdk/nashorn/internal/runtime/linker/AdaptationResult.java
! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java
! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java
! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java
! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java
! src/jdk/nashorn/internal/runtime/options/KeyValueOption.java
! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java
! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java
! test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java
! test/src/jdk/nashorn/internal/test/framework/TestConfig.java

Changeset: 5fc6b7f11289
Author:sundar
Date:  2013-07-29 10:28 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5fc6b7f11289

Merge

- test/script/representations/NASHORN-592a.js

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: 0532397d0732
Author:sundar
Date:  2013-07-29 18:07 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0532397d0732

8012792: print function defined in engine.js does not handle multiple arguments
Reviewed-by: hannesw

! src/jdk/nashorn/api/scripting/resources/engine.js
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 7d5d24bdb671
Author:sundar
Date:  2013-07-29 21:56 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7d5d24bdb671

Merge

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 5c035c4ccc61
Author:sundar
Date:  2013-07-25 14:05 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5c035c4ccc61

8021252: invokeMethod throws NoSuchMethodException when script object is from 
different script context
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: f74faac51bfb
Author:hannesw
Date:  2013-07-25 11:56 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f74faac51bfb

8021244: Inconsistent stackmap with splitter threshold set very low
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/ir/Block.java

Changeset: f22ca0f9b6ee
Author:sundar
Date:  2013-07-25 20:10 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f22ca0f9b6ee

8021361: ClassCastException:.ScriptObjectMirror - ScriptObject when 
getInterface called on object from different ScriptContext
Reviewed-by: jlaskey, attila

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
+ src/jdk/nashorn/api/scripting/resources/Messages.properties
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

hg: jdk8/tl/nashorn: 7 new changesets

[sundararajan . athijegannathan]

Changeset: 8b97fe2b7c98
Author:attila
Date:  2013-07-23 18:28 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8b97fe2b7c98

8021129: Use public lookup again
Reviewed-by: lagergren, sundar

! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
! src/jdk/internal/dynalink/beans/FacetIntrospector.java
- src/jdk/internal/dynalink/beans/SafeUnreflector.java
- src/jdk/internal/dynalink/beans/SafeUnreflectorImpl.java
- src/jdk/internal/dynalink/beans/SandboxClassLoader.java
- src/jdk/internal/dynalink/beans/sandbox/Unreflector.java
+ test/script/trusted/JDK-8021129.js
+ test/script/trusted/JDK-8021129.js.EXPECTED
+ test/src/jdk/nashorn/internal/test/models/InternalRunnable.java
+ test/src/jdk/nashorn/internal/test/models/RestrictedRunnable.java
+ test/src/jdk/nashorn/test/models/InternalRunnableSuperclass.java

Changeset: a58a07a00122
Author:attila
Date:  2013-07-24 11:13 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a58a07a00122

8021189: Prevent access to constructors of restricted classes
Reviewed-by: lagergren, sundar

! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
! src/jdk/internal/dynalink/beans/FacetIntrospector.java
! src/jdk/internal/dynalink/beans/StaticClassLinker.java
! test/script/trusted/JDK-8006529.js
! test/script/trusted/JDK-8021129.js
+ test/script/trusted/JDK-8021189.js
+ test/script/trusted/JDK-8021189.js.EXPECTED

Changeset: e4efb3ce97b2
Author:attila
Date:  2013-07-24 12:48 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e4efb3ce97b2

8021246: Fix regression for 8021189
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
! test/script/trusted/JDK-8006529.js

Changeset: 2a2591f7
Author:hannesw
Date:  2013-07-24 13:16 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2a2591f7

8020718: RETURN symbol has wrong type in split functions
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/SplitMethodEmitter.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/Symbol.java

Changeset: 573cc6eb66ae
Author:jlaskey
Date:  2013-07-24 08:25 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/573cc6eb66ae

Merge

- src/jdk/internal/dynalink/beans/SafeUnreflector.java
- src/jdk/internal/dynalink/beans/SafeUnreflectorImpl.java
- src/jdk/internal/dynalink/beans/SandboxClassLoader.java
- src/jdk/internal/dynalink/beans/sandbox/Unreflector.java

Changeset: dc54df348a58
Author:sundar
Date:  2013-07-24 20:28 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/dc54df348a58

8021262: Make nashorn access checks consistent with underlying dynalink
Reviewed-by: jlaskey, lagergren, attila

! make/code_coverage.xml
! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java
! src/jdk/nashorn/internal/objects/NativeDate.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/NashornLoader.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/Source.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java
! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java
! test/script/sandbox/nashorninternals.js
! test/script/trusted/JDK-8006529.js
! test/script/trusted/JDK-8021129.js
! test/script/trusted/JDK-8021189.js
! test/script/trusted/JDK-8021189.js.EXPECTED
! test/src/jdk/nashorn/test/models/InternalRunnableSuperclass.java

Changeset: d203d68f6624
Author:sundar
Date:  2013-07-24 21:01 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d203d68f6624

8021294: --verify-code option results in AnalyzerException
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/runtime/Context.java

hg: jdk8/tl/nashorn: 10 new changesets

[sundararajan . athijegannathan]

Changeset: e1d19f9fd5a9
Author:jlaskey
Date:  2013-07-16 17:40 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e1d19f9fd5a9

8017585: Exclude two failing tests from Nashorn CC run
Reviewed-by: jlaskey, sundar, attila
Contributed-by: konstantin.she...@oracle.com

+ exclude/exclude_list.txt
+ exclude/exclude_list_cc.txt
! make/build.xml

Changeset: 71cfe4e66bcb
Author:jlaskey
Date:  2013-07-17 11:53 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/71cfe4e66bcb

8020596: Initialization of white space strings in scanner should be done with 
\u strings
Reviewed-by: attila, hannesw
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/parser/Lexer.java

Changeset: 3d6f6b8d8bc8
Author:hannesw
Date:  2013-07-17 18:20 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3d6f6b8d8bc8

8020356: ClassCastException Undefined-Scope on spiltter class generated for a 
large switch statement
Reviewed-by: jlaskey, attila

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/Label.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/LexicalContext.java
+ test/script/basic/JDK-8020356.js
+ test/script/basic/JDK-8020356.js.EXPECTED

Changeset: e3307f1a30e5
Author:sundar
Date:  2013-07-18 18:08 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e3307f1a30e5

8020731: Revisit checkPermission calls in Context class
Reviewed-by: attila, hannesw

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/WithObject.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java
- src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java

Changeset: 624f8be5c3fe
Author:attila
Date:  2013-07-18 16:22 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/624f8be5c3fe

8020809: Java adapter should not allow overriding of caller sensitive methods
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
+ test/script/trusted/JDK-8020809.js
+ test/script/trusted/JDK-8020809.js.EXPECTED

Changeset: 4b06441b7624
Author:attila
Date:  2013-07-18 16:47 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4b06441b7624

8020820: Limit access to static members of reflective classes
Reviewed-by: jlaskey, sundar

! make/build.xml
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java
! test/script/basic/JDK-8010946-2.js
! test/script/basic/JDK-8010946-2.js.EXPECTED
! test/script/basic/NASHORN-473.js
+ test/script/basic/classloader.js
+ test/script/basic/classloader.js.EXPECTED
! test/script/basic/javaarray.js
! test/script/sandbox/classloader.js.EXPECTED
! test/script/sandbox/reflection.js
! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java

Changeset: 0cfa27ed82fe
Author:sundar
Date:  2013-07-23 18:17 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0cfa27ed82fe

8021122: Not all callables are handled for toString and other function valued 
properties
Reviewed-by: attila, hannesw, jlaskey

! src/jdk/nashorn/internal/ir/debug/ASTWriter.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeDate.java
! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ListAdapter.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
+ test/script/basic/JDK-8021122.js
+ test/script/basic/JDK-8021122.js.EXPECTED

Changeset: e86b297d26aa
Author:jlaskey
Date:  2013-07-23 12:00 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e86b297d26aa

8021130: Comments need to be tokens
Reviewed-by: lagergren, attila
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/Lexer.java
! 

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 965d876853ec
Author:attila
Date:  2013-07-16 15:28 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/965d876853ec

8020357: throw RangeError for too large NativeArrayBuffer size
Reviewed-by: jlaskey, hannesw, sundar

! src/jdk/nashorn/internal/objects/ArrayBufferView.java
+ test/script/basic/JDK-8020357.js
+ test/script/basic/JDK-8020357.js.EXPECTED

Changeset: 7503f30c1355
Author:hannesw
Date:  2013-07-16 16:12 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7503f30c1355

8010821: [findbugs] Some classes in jdk.nashorn.internal.runtime.regexp expose 
mutable objects
Reviewed-by: attila, jlaskey, sundar

! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodePrinter.java
! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java
! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ScanEnvironment.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Token.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ast/BackRefNode.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ast/CClassNode.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ast/StateNode.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ast/StringNode.java
! src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPCode.java

Changeset: 78bdb8a7f1e7
Author:attila
Date:  2013-07-16 17:03 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/78bdb8a7f1e7

8015356: array concatenation should skip empty elements
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8015356.js
+ test/script/basic/JDK-8015356.js.EXPECTED

hg: jdk8/tl/nashorn: 7 new changesets

[sundararajan . athijegannathan]

Changeset: 973d78ee0728
Author:attila
Date:  2013-07-15 12:33 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/973d78ee0728

8020324: Implement Object.bindProperties(target, source) for beans
Reviewed-by: hannesw, sundar

! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
! src/jdk/internal/dynalink/beans/BeansLinker.java
! src/jdk/internal/dynalink/beans/StaticClassLinker.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
+ src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethod.java
+ src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java
+ test/script/basic/JDK-8020324.js
+ test/script/basic/JDK-8020324.js.EXPECTED
+ test/src/jdk/nashorn/test/models/PropertyBind.java

Changeset: 62c552bcc342
Author:hannesw
Date:  2013-07-15 15:51 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/62c552bcc342

8020354: Object literal property initialization is not done in source order
Reviewed-by: sundar, jlaskey

! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8020354.js
+ test/script/basic/JDK-8020354.js.EXPECTED

Changeset: ede320e13c82
Author:attila
Date:  2013-07-15 16:31 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ede320e13c82

8020508: Enforce reflection access restrictions on Object.bindProperties
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java
+ test/script/basic/JDK-8020508.js
+ test/script/basic/JDK-8020508.js.EXPECTED

Changeset: e5505f0b10de
Author:hannesw
Date:  2013-07-15 16:35 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e5505f0b10de

8020283: Don't use exceptions for widening of ArrayData
Reviewed-by: jlaskey, attila

! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java

Changeset: 01212f5e7dad
Author:attila
Date:  2013-07-15 16:58 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/01212f5e7dad

8011210: fix reporting of call site locations; print them on -tcs=miss
Reviewed-by: jlaskey, hannesw

! src/jdk/internal/dynalink/DynamicLinker.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java

Changeset: 28f1f2374004
Author:hannesw
Date:  2013-07-15 18:32 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/28f1f2374004

8020358: Array(0xfff) throws OutOfMemoryError
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java
+ test/script/basic/JDK-8020358.js
+ test/script/basic/JDK-8020358.js.EXPECTED

Changeset: d685fec24d13
Author:sundar
Date:  2013-07-16 09:54 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d685fec24d13

Merge

hg: jdk8/tl/nashorn: 18 new changesets

[sundararajan . athijegannathan]

Changeset: 5106d43feed7
Author:hannesw
Date:  2013-07-08 19:34 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5106d43feed7

8019963: empty char range in regex
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java
+ test/script/basic/JDK-8019963.js
+ test/script/basic/JDK-8019963.js.EXPECTED

Changeset: d3f4e5dea634
Author:attila
Date:  2013-07-09 13:57 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d3f4e5dea634

8009758: reactivate the 8006529 test.
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/types/Type.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/FunctionScope.java
- test/script/currently-failing/JDK-8006529.js
+ test/script/trusted/JDK-8006529.js

Changeset: 7538a59ca241
Author:sundar
Date:  2013-07-09 17:37 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7538a59ca241

8014785: Ability to extend global instance by binding properties of another 
object
Reviewed-by: attila, hannesw, jlaskey, lagergren

! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java
+ test/script/basic/JDK-8014785.js
+ test/script/basic/JDK-8014785.js.EXPECTED

Changeset: d480015ab732
Author:lagergren
Date:  2013-07-09 15:56 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d480015ab732

8020124: In the case of an eval switch, we might need explicit conversions of 
the tag store, as it was not known in the surrounding environment.
Reviewed-by: sundar, jlaskey

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8020124.js

Changeset: 997a3215744a
Author:sundar
Date:  2013-07-10 13:25 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/997a3215744a

8020224: LinkageError: attempted duplicate class definition when 
--loader-per-compiler=false
Reviewed-by: hannesw

! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/runtime/CodeInstaller.java
! src/jdk/nashorn/internal/runtime/Context.java
! test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java

Changeset: a9b74daed4f9
Author:hannesw
Date:  2013-07-10 10:54 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a9b74daed4f9

8016681: regex capture behaves differently than on V8
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8016681.js
+ test/script/basic/JDK-8016681.js.EXPECTED

Changeset: c501b1666bda
Author:sundar
Date:  2013-07-10 19:08 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c501b1666bda

8020276: interface checks in Invocable.getInterface implementation
Reviewed-by: jlaskey, hannesw, attila

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 798e3aa19718
Author:sundar
Date:  2013-07-11 16:34 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/798e3aa19718

8020325: static property does not work on accessible, public classes
Reviewed-by: attila, hannesw, lagergren

! make/build.xml
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/lookup/Lookup.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/objects/NativeNumber.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java
+ test/script/basic/JDK-8020325.js
+ test/script/basic/JDK-8020325.js.EXPECTED
! test/script/trusted/JDK-8006529.js
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 58614b556a0d
Author:sundar
Date:  2013-07-11 18:23 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/58614b556a0d

8020380: __noSuchProperty__ defined in mozilla_compat.js script should be 
non-enumerable
Reviewed-by: jlaskey, hannesw, attila

! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
+ test/script/basic/JDK-8020380.js

Changeset: 2c007a8bb0e7
Author:attila
Date:  2013-07-11 18:33 +0200
URL:   

hg: jdk8/tl/jdk: 7187144: JavaDoc for ScriptEngineFactory.getProgram() contains an error

[sundararajan . athijegannathan]

Changeset: dadcfd84d33f
Author:sundar
Date:  2013-07-11 18:50 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dadcfd84d33f

7187144: JavaDoc for ScriptEngineFactory.getProgram() contains an error
Reviewed-by: mcimadamore, jlaskey, hannesw, attila

! src/share/classes/javax/script/ScriptEngineFactory.java

hg: jdk8/tl/nashorn: 20 new changesets

[sundararajan . athijegannathan]

Changeset: 313bdcd2fd22
Author:sundar
Date:  2013-07-03 00:08 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/313bdcd2fd22

8019629: void operator should always evaluate to undefined
Reviewed-by: jlaskey

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
+ test/script/basic/JDK-8019629.js

Changeset: 9d3a9fdab668
Author:sundar
Date:  2013-07-03 13:13 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9d3a9fdab668

8019783: typeof does not work properly for java methods and foreign objects
Reviewed-by: hannesw

! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
+ test/script/basic/JDK-8019783.js
+ test/script/basic/JDK-8019783.js.EXPECTED
! test/script/basic/NASHORN-759.js.EXPECTED

Changeset: 4afdc5bec43b
Author:sundar
Date:  2013-07-03 14:08 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4afdc5bec43b

8019791: ~ is a unary operator
Reviewed-by: hannesw

! src/jdk/nashorn/internal/parser/TokenType.java
+ test/script/basic/JDK-8019791.js
+ test/script/basic/JDK-8019791.js.EXPECTED

Changeset: 18d467e94150
Author:attila
Date:  2013-07-03 12:39 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/18d467e94150

8010946: AccessControl.doPrivileged is broken when called from js script
Reviewed-by: jlaskey, sundar

! make/build.xml
! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
! src/jdk/internal/dynalink/beans/ApplicableOverloadedMethods.java
+ src/jdk/internal/dynalink/beans/CallerSensitiveDetector.java
+ src/jdk/internal/dynalink/beans/CallerSensitiveDynamicMethod.java
! src/jdk/internal/dynalink/beans/ClassString.java
! src/jdk/internal/dynalink/beans/DynamicMethod.java
! src/jdk/internal/dynalink/beans/DynamicMethodLinker.java
! src/jdk/internal/dynalink/beans/FacetIntrospector.java
! src/jdk/internal/dynalink/beans/MaximallySpecific.java
! src/jdk/internal/dynalink/beans/OverloadedDynamicMethod.java
! src/jdk/internal/dynalink/beans/OverloadedMethod.java
! src/jdk/internal/dynalink/beans/SimpleDynamicMethod.java
+ src/jdk/internal/dynalink/beans/SingleDynamicMethod.java
! src/jdk/internal/dynalink/beans/StaticClassIntrospector.java
! src/jdk/internal/dynalink/beans/StaticClassLinker.java
! src/jdk/internal/dynalink/support/AbstractCallSiteDescriptor.java
! src/jdk/internal/dynalink/support/Lookup.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java
+ test/script/basic/JDK-8010946-2.js
+ test/script/basic/JDK-8010946-2.js.EXPECTED
+ test/script/basic/JDK-8010946-privileged.js
+ test/script/basic/JDK-8010946.js
+ test/script/basic/JDK-8010946.js.EXPECTED

Changeset: b1980b5f00a1
Author:lagergren
Date:  2013-07-03 13:03 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b1980b5f00a1

8019585: Sometimes a var declaration using itself in its init wasn't declared 
as canBeUndefined, causing erroneous bytecode
Reviewed-by: sundar, attila

! src/jdk/nashorn/api/scripting/NashornException.java
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/objects/ArrayBufferView.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/objects/NativeFloat32Array.java
! src/jdk/nashorn/internal/objects/NativeFloat64Array.java
! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/objects/NativeInt16Array.java
! src/jdk/nashorn/internal/objects/NativeInt32Array.java
! src/jdk/nashorn/internal/objects/NativeInt8Array.java
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/objects/NativeUint16Array.java
! src/jdk/nashorn/internal/objects/NativeUint32Array.java
! src/jdk/nashorn/internal/objects/NativeUint8Array.java
! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java
+ test/script/basic/JDK-8019585.js

Changeset: eb1437d16ab4
Author:sundar
Date:  2013-07-03 17:26 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eb1437d16ab4

8019805: for each (init; test; modify) is invalid
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/script/basic/JDK-8019805.js
+ test/script/basic/JDK-8019805.js.EXPECTED
! test/script/basic/forin.js
! 

hg: jdk8/tl/nashorn: 12 new changesets

[sundararajan . athijegannathan]

Changeset: 218c2833c344
Author:sundar
Date:  2013-06-28 19:36 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/218c2833c344

8019365: Error stack format
Reviewed-by: hannesw

! src/jdk/nashorn/api/scripting/NashornException.java
! src/jdk/nashorn/internal/objects/NativeError.java
! test/script/basic/JDK-8014781.js.EXPECTED
! test/script/basic/JDK-8017950.js.EXPECTED
! test/script/basic/JDK-8019226.js
! test/script/basic/JDK-8019226.js.EXPECTED

Changeset: 02588d68399d
Author:sundar
Date:  2013-07-01 12:38 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/02588d68399d

8019473: Parser issues related to functions and blocks
Reviewed-by: lagergren

! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8019473.js

Changeset: 10c7a1e9e24f
Author:sundar
Date:  2013-07-01 14:15 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/10c7a1e9e24f

8019478: Object.prototype.toString.call(/a/.exec(a)) === [object Array] 
should be true
Reviewed-by: hannesw

! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java
+ test/script/basic/JDK-8019478.js

Changeset: 47099609a48b
Author:sundar
Date:  2013-07-01 17:21 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/47099609a48b

8019482: Number(0x0.0p0) should evaluate to NaN
Reviewed-by: lagergren

! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/runtime/ECMAException.java
! src/jdk/nashorn/internal/runtime/JSType.java
+ test/script/basic/JDK-8019482.js

Changeset: ab3ea5b3e507
Author:sundar
Date:  2013-07-01 19:52 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ab3ea5b3e507

8019488: switch on literals result in NoSuchMethodError or VerifyError
Reviewed-by: hannesw

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
+ test/script/basic/JDK-8019488.js

Changeset: 9165138b427c
Author:sundar
Date:  2013-07-01 23:36 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9165138b427c

8019508: Comma handling in object literal parsing is wrong
Reviewed-by: hannesw

! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/script/basic/JDK-8019508.js
+ test/script/basic/JDK-8019508.js.EXPECTED

Changeset: 5f9abeb0bb50
Author:jlaskey
Date:  2013-07-02 07:45 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5f9abeb0bb50

8019580: Build Script Change for Nashorn promotion testing
Reviewed-by: jlaskey
Contributed-by: eugene.drobi...@oracle.com

! make/build.xml

Changeset: a7b82e333c31
Author:lagergren
Date:  2013-07-02 13:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a7b82e333c31

8016667: Wrong bytecode when testing/setting due to null check shortcut 
checking against primitive too
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8016667.js

Changeset: 74049fe3ba46
Author:sundar
Date:  2013-07-02 18:00 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/74049fe3ba46

8019553: NPE on illegal l-value for increment and decrement
Reviewed-by: jlaskey, attila, lagergren

! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/script/basic/JDK-8019553.js
+ test/script/basic/JDK-8019553.js.EXPECTED
! test/script/basic/NASHORN-51.js
! test/script/basic/NASHORN-51.js.EXPECTED
! test/script/error/NASHORN-57.js.EXPECTED

Changeset: 9396e42bae4f
Author:lagergren
Date:  2013-07-02 14:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9396e42bae4f

8017082: Long array literals were slightly broken
Reviewed-by: sundar, attila

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/types/Type.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
+ test/script/basic/JDK-8017082.js

Changeset: 69ec02d12a31
Author:lagergren
Date:  2013-07-02 15:01 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/69ec02d12a31

Merge


Changeset: 16c4535abcf8
Author:sundar
Date:  2013-07-02 18:39 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/16c4535abcf8

Merge

hg: jdk8/tl/nashorn: 11 new changesets

[sundararajan . athijegannathan]

Changeset: c30beaf3c42a
Author:jlaskey
Date:  2013-06-21 14:34 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c30beaf3c42a

8010732: BigDecimal, BigInteger and Long handling in nashorn
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

+ test/script/basic/JDK-8010732.js
+ test/script/basic/JDK-8010732.js.EXPECTED

Changeset: 2ded2fc08c94
Author:jlaskey
Date:  2013-06-22 10:12 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2ded2fc08c94

8017448: JDK-8010732.js.EXPECTED truncated
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

! test/script/basic/JDK-8010732.js.EXPECTED

Changeset: 51a5ee93d6bc
Author:sundar
Date:  2013-06-24 19:06 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/51a5ee93d6bc

8015959: Can't call foreign constructor
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/api/scripting/JSObject.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java
+ test/script/basic/JDK-8015959.js
+ test/script/basic/JDK-8015959.js.EXPECTED

Changeset: 26a345c26e62
Author:sundar
Date:  2013-06-25 17:31 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/26a345c26e62

8015969: Needs to enforce and document that global context and engine can't 
be modified when running via jsr223
Reviewed-by: hannesw, jlaskey

! docs/JavaScriptingProgrammersGuide.html
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java
+ test/script/basic/JDK-8015969.js

Changeset: 39e17373d8df
Author:sundar
Date:  2013-06-26 16:36 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/39e17373d8df

8017950: error.stack should be a string rather than an array
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/runtime/ECMAException.java
! test/script/basic/JDK-8012164.js
! test/script/basic/JDK-8012164.js.EXPECTED
+ test/script/basic/JDK-8017950.js
+ test/script/basic/JDK-8017950.js.EXPECTED
! test/script/basic/NASHORN-109.js
! test/script/basic/NASHORN-296.js
! test/script/basic/errorstack.js

Changeset: 682889823712
Author:jlaskey
Date:  2013-06-26 08:36 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/682889823712

8008458: Strict functions dont share property map
Reviewed-by: sundar, hannesw
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/objects/NativeStrictArguments.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/FindProperty.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java

Changeset: 80c66d3fd872
Author:hannesw
Date:  2013-06-26 15:40 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/80c66d3fd872

8019157: Avoid calling ScriptObject.setProto() if possible
Reviewed-by: jlaskey, sundar

! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java
! 
buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/ArrayBufferView.java
! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java
! src/jdk/nashorn/internal/objects/NativeBoolean.java
! src/jdk/nashorn/internal/objects/NativeDate.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/objects/NativeEvalError.java
! src/jdk/nashorn/internal/objects/NativeFloat32Array.java
! src/jdk/nashorn/internal/objects/NativeFloat64Array.java
! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/objects/NativeInt16Array.java
! src/jdk/nashorn/internal/objects/NativeInt32Array.java
! src/jdk/nashorn/internal/objects/NativeInt8Array.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! 

hg: jdk8/tl/nashorn: 7 new changesets

[sundararajan . athijegannathan]

Changeset: 6a75a505301f
Author:sundar
Date:  2013-06-18 18:43 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6a75a505301f

8012698: [nashorn] tests fail to run with agentvm or samevm
Reviewed-by: hannesw, jlaskey

! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java
! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java

Changeset: 7276d66b7118
Author:jlaskey
Date:  2013-06-19 09:10 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7276d66b7118

8010697: DeletedArrayFilter seems to leak memory
Reviewed-by: hannesw, sundar
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java
+ test/script/basic/JDK-8010697.js
+ test/script/basic/JDK-8010697.js.EXPECTED

Changeset: c7c9222cfe69
Author:sundar
Date:  2013-06-19 21:07 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c7c9222cfe69

8015347: Parsing issue with decodeURIComponent
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/runtime/URIUtils.java
+ test/script/basic/JDK-8015347.js

Changeset: ac404bf3f8c8
Author:sundar
Date:  2013-06-20 13:45 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ac404bf3f8c8

8017046: Cannot assign undefined to a function argument if the function uses 
arguments object
Reviewed-by: hannesw

! src/jdk/nashorn/internal/objects/NativeArguments.java
+ test/script/basic/JDK-8017046.js

Changeset: c7672e621b14
Author:sundar
Date:  2013-06-20 17:34 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c7672e621b14

Merge


Changeset: 8e03121cc286
Author:sundar
Date:  2013-06-21 16:55 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8e03121cc286

8017260: adjust lookup code in objects.* classes
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/objects/NativeStrictArguments.java
! src/jdk/nashorn/internal/objects/PrototypeObject.java

Changeset: b4e2bccf9598
Author:sundar
Date:  2013-06-21 17:33 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b4e2bccf9598

Merge

hg: jdk8/tl/nashorn: 14 new changesets

[sundararajan . athijegannathan]

Changeset: df5d7f34e35e
Author:hannesw
Date:  2013-06-11 17:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/df5d7f34e35e

8015379: PropertyMap.addProperty() is slow
Reviewed-by: attila, jlaskey

! src/jdk/nashorn/internal/runtime/PropertyMap.java

Changeset: aa16622193e1
Author:jlaskey
Date:  2013-06-12 11:22 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aa16622193e1

8016453: loadWithNewGlobal does not allow apply operation
Reviewed-by: hannesw, sundar
Contributed-by: james.las...@oracle.com

! samples/test.js
! src/jdk/nashorn/internal/objects/Global.java

Changeset: d26e069353c0
Author:hannesw
Date:  2013-06-12 16:41 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d26e069353c0

8011893: JS Object builtin prototype is not thread safe
Reviewed-by: sundar, jlaskey

! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java
+ test/script/basic/JDK-8011893.js
+ test/script/basic/JDK-8011893.js.EXPECTED

Changeset: b0dcc3727fc3
Author:sundar
Date:  2013-06-13 16:08 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b0dcc3727fc3

8015355: Array.prototype functions don't honour non-writable length and / or 
index properties
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/objects/NativeEvalError.java
! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeJavaImporter.java
! src/jdk/nashorn/internal/objects/NativeRangeError.java
! src/jdk/nashorn/internal/objects/NativeReferenceError.java
! src/jdk/nashorn/internal/objects/NativeSyntaxError.java
! src/jdk/nashorn/internal/objects/NativeTypeError.java
! src/jdk/nashorn/internal/objects/NativeURIError.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/JSONFunctions.java
! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java
+ test/script/basic/JDK-8015355.js

Changeset: 6d6133ef1fd5
Author:hannesw
Date:  2013-06-13 12:52 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6d6133ef1fd5

8016518: Parsing of octal string escapes is broken
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/parser/Lexer.java
+ test/script/basic/JDK-8016518.js
+ test/script/basic/JDK-8016518.js.EXPECTED

Changeset: 18362e95e638
Author:hannesw
Date:  2013-06-13 14:02 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/18362e95e638

8016522: Numeric literal must not be followed by IdentifierStart
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/script/error/JDK-8016522.js
+ test/script/error/JDK-8016522.js.EXPECTED

Changeset: fe80eda7b57e
Author:hannesw
Date:  2013-06-13 15:26 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fe80eda7b57e

8016528: Hex code from escape() should be padded
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/GlobalFunctions.java
+ test/script/basic/JDK-8016528.js
+ test/script/basic/JDK-8016528.js.EXPECTED

Changeset: c5f783d83180
Author:hannesw
Date:  2013-06-13 20:50 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c5f783d83180

8016542: String.prototype.replace called with function argument should not 
replace $ patterns
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeRegExp.java
+ test/script/basic/JDK-8016542.js
+ test/script/basic/JDK-8016542.js.EXPECTED

Changeset: 3efa56767847
Author:lagergren
Date:  2013-06-14 13:53 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3efa56767847

8016235: Use in catch block that may not have been executed in try block caused 
illegal byte code to be generated
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/parser/JSONParser.java
! src/jdk/nashorn/internal/parser/Lexer.java
+ test/script/basic/JDK-8016235.js

Changeset: 3d947baa33cc
Author:sundar
Date:  2013-06-14 21:16 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3d947baa33cc

8016618: script mirror object access should be improved
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/ir/BreakableNode.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! 

hg: jdk8/tl/nashorn: 7 new changesets

[sundararajan . athijegannathan]

Changeset: bab844827181
Author:sundar
Date:  2013-06-06 21:41 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bab844827181

8015346: JSON parsing issues with escaped strings, octal, decimal numbers
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/ir/BlockLexicalContext.java
! src/jdk/nashorn/internal/parser/JSONParser.java
! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/runtime/JSONFunctions.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/script/basic/JDK-8015346.js

Changeset: 918a986b0478
Author:hannesw
Date:  2013-06-07 17:44 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/918a986b0478

8012291: NativeArray is inconsistent in using long for length and index in some 
places and int for the same in other places
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java
! src/jdk/nashorn/internal/codegen/MapCreator.java
! src/jdk/nashorn/internal/objects/ArrayBufferView.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/runtime/JSONFunctions.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java
! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/examples/array-micro.js
+ test/script/basic/JDK-8012291.js
+ test/script/basic/JDK-8012291.js.EXPECTED

Changeset: 8f890b6bf6de
Author:lagergren
Date:  2013-06-10 13:21 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8f890b6bf6de

8015892: canBeUndefined too conservative for some use before declaration cases
Reviewed-by: attila, hannesw

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/ir/Symbol.java
+ test/script/basic/JDK-8015892.js
+ test/script/basic/fib_wtf.js
+ test/script/basic/fib_wtf.js.EXPECTED

Changeset: a6f8ea57f048
Author:lagergren
Date:  2013-06-10 13:27 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a6f8ea57f048

8016226: backing out test without third party license approval
Reviewed-by: attila, sundar

- test/script/basic/fib_wtf.js
- test/script/basic/fib_wtf.js.EXPECTED

Changeset: 966868ef75ee
Author:sundar
Date:  2013-06-10 19:54 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/966868ef75ee

8016239: loadWithNewGlobal should support user supplied arguments from the 
caller
Reviewed-by: lagergren, attila, jlaskey

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/runtime/Context.java
+ test/script/basic/JDK-8016239.js
+ test/script/basic/JDK-8016239.js.EXPECTED

Changeset: 1a5d67424e83
Author:sundar
Date:  2013-06-11 13:09 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1a5d67424e83

8015357: a = []; a[0x7fff]=1; a.sort()[0] should evaluate to 1 instead of 
undefined
Reviewed-by: hannesw, lagergren

+ test/script/basic/JDK-8015357.js

Changeset: fe830f6daa3f
Author:sundar
Date:  2013-06-11 13:12 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fe830f6daa3f

Merge

hg: jdk8/tl/nashorn: 16 new changesets

[sundararajan . athijegannathan]

Changeset: 66b2fde90c9d
Author:jlaskey
Date:  2013-05-29 16:23 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/66b2fde90c9d

8015636: Add more typed arrays code coverage tests.
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

+ test/script/basic/typedarrays.js

Changeset: eda227663eda
Author:sundar
Date:  2013-05-30 16:49 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eda227663eda

8015353: Date.parse illegal string parsing issues
Reviewed-by: jlaskey, lagergren

- src/jdk/nashorn/internal/objects/DateParser.java
! src/jdk/nashorn/internal/objects/NativeDate.java
+ src/jdk/nashorn/internal/parser/DateParser.java
+ test/script/basic/JDK-8015353.js

Changeset: 818946884410
Author:attila
Date:  2013-05-31 12:56 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/818946884410

8015693: reduce NodeLiteralNode to NullLiteralNode
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/ir/LiteralNode.java

Changeset: d8a7727a519e
Author:attila
Date:  2013-05-31 12:57 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8a7727a519e

8015684: FieldObjectCreator.putField ignores getValueType
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java

Changeset: cab639125b98
Author:attila
Date:  2013-05-31 12:57 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/cab639125b98

8015674: CodeGenerator.initSymbols mutates a list
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/CodeGenerator.java

Changeset: 11b81fa7125a
Author:attila
Date:  2013-05-31 12:58 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/11b81fa7125a

8015673: Type for :e symbol is wrong
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java

Changeset: b4e6cc05ce09
Author:sundar
Date:  2013-05-31 17:39 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b4e6cc05ce09

8012164: Error.stack needs trimming
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeError.java
+ test/script/basic/JDK-8012164.js
+ test/script/basic/JDK-8012164.js.EXPECTED
! test/script/basic/NASHORN-108.js.EXPECTED
! test/script/basic/NASHORN-109.js.EXPECTED
! test/script/basic/errorstack.js.EXPECTED

Changeset: 64250b3a2f2a
Author:jlaskey
Date:  2013-05-31 13:04 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/64250b3a2f2a

8015727: Thread safe print function
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/objects/Global.java

Changeset: 295c91f5fdde
Author:sundar
Date:  2013-06-03 15:58 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/295c91f5fdde

8015345: Function(}),print('test'),({) should throw SyntaxError
Reviewed-by: lagergren, hannesw, jlaskey

! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8015345.js
+ test/script/basic/JDK-8015345.js.EXPECTED
! test/script/basic/funcconstructor.js.EXPECTED

Changeset: 08a8fda6c0bf
Author:jlaskey
Date:  2013-06-03 08:34 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/08a8fda6c0bf

8015741: Need a global.load function that starts with a new global scope.
Reviewed-by: sundar, lagergren
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/runtime/Context.java
+ test/script/basic/JDK-8015741.js
+ test/script/basic/JDK-8015741.js.EXPECTED

Changeset: 2df08f4c531d
Author:jlaskey
Date:  2013-06-03 11:16 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2df08f4c531d

8015796: Race condition in RuntimeCallsites
Reviewed-by: lagergren, attila
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java

Changeset: 0946c8a60f39
Author:jlaskey
Date:  2013-06-03 12:57 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0946c8a60f39

8015814: loadWithNewGlobal needs to wrap createGlobal in 
AccessController.doPrivileged
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/runtime/Context.java

Changeset: 78113cda23bf
Author:sundar
Date:  2013-06-04 17:33 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/78113cda23bf

8015855: test/script/basic/JDK-8012164.js fails on Windows
Reviewed-by: hannesw, lagergren, jlaskey

! test/script/basic/JDK-8012164.js

Changeset: c70f60578385
Author:sundar
Date:  2013-06-04 22:31 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c70f60578385

8015830: Javascript mapping of ScriptEngine bindings does not expose keys
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! 

hg: jdk8/tl/nashorn: 4 new changesets

[sundararajan . athijegannathan]

Changeset: 6fc7b51e83d6
Author:lagergren
Date:  2013-05-23 15:51 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6fc7b51e83d6

8012522: Clean up lexical contexts - split out stack based functionality in 
CodeGenerator and generify NodeVisitors based on their LexicalContext type to 
avoid casts
Reviewed-by: attila, jlaskey

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ src/jdk/nashorn/internal/codegen/CodeGeneratorLexicalContext.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/RangeAnalyzer.java
! src/jdk/nashorn/internal/codegen/SharedScopeCall.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/BinaryNode.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/BreakNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CaseNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ContinueNode.java
! src/jdk/nashorn/internal/ir/EmptyNode.java
! src/jdk/nashorn/internal/ir/ExecuteNode.java
! src/jdk/nashorn/internal/ir/ForNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IfNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
! src/jdk/nashorn/internal/ir/LexicalContextNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/ObjectNode.java
! src/jdk/nashorn/internal/ir/PropertyNode.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/TernaryNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/ir/WhileNode.java
! src/jdk/nashorn/internal/ir/WithNode.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
! src/jdk/nashorn/internal/objects/ArrayBufferView.java
! src/jdk/nashorn/internal/runtime/DebugLogger.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java

Changeset: fdfb4edd78d6
Author:hannesw
Date:  2013-05-24 13:54 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fdfb4edd78d6

8011630: JSON parsing performance issue
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/FindProperty.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java

Changeset: 4d2eca4d4d66
Author:sundar
Date:  2013-05-24 18:39 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4d2eca4d4d66

8015354: JSON.parse should not use [[Put]] but use [[DefineOwnProperty]] instead
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/NativeFloat32Array.java
! src/jdk/nashorn/internal/objects/NativeFloat64Array.java
! src/jdk/nashorn/internal/objects/NativeInt16Array.java
! src/jdk/nashorn/internal/objects/NativeInt32Array.java
! src/jdk/nashorn/internal/objects/NativeInt8Array.java
! src/jdk/nashorn/internal/objects/NativeUint16Array.java
! src/jdk/nashorn/internal/objects/NativeUint32Array.java
! src/jdk/nashorn/internal/objects/NativeUint8Array.java
! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java
! src/jdk/nashorn/internal/runtime/JSONFunctions.java
! src/jdk/nashorn/internal/runtime/Property.java
+ test/script/basic/JDK-8015354.js

Changeset: 751cfefff5eb
Author:sundar
Date:  2013-05-24 23:27 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/751cfefff5eb

8015351: Nashorn shell does not start with Turkish locale
Reviewed-by: jlaskey

! make/project.properties
! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 92164a5742db
Author:lagergren
Date:  2013-05-20 16:38 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/92164a5742db

8006069: Range analysis first iteration, runtime specializations
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
+ src/jdk/nashorn/internal/codegen/RangeAnalyzer.java
+ src/jdk/nashorn/internal/codegen/types/Range.java
! src/jdk/nashorn/internal/codegen/types/Type.java
! src/jdk/nashorn/internal/ir/BinaryNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/LexicalContext.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/runtime/CompiledFunction.java
! src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/resources/Options.properties
+ test/script/basic/ranges_disabled.js
+ test/script/basic/ranges_disabled.js.EXPECTED
+ test/script/basic/ranges_enabled.js
+ test/script/basic/ranges_enabled.js.EXPECTED
+ test/script/basic/ranges_payload.js

Changeset: b558e19d5de5
Author:sundar
Date:  2013-05-20 23:04 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b558e19d5de5

8014909: ant test compilation error with JoniTest.java
Reviewed-by: jlaskey

! make/build.xml

Changeset: 1fd18f40ab52
Author:attila
Date:  2013-05-20 21:25 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1fd18f40ab52

8014797: rename Java.toJavaArray/toJavaScriptArray to Java.to/from, 
respectively.
Reviewed-by: jlaskey, sundar

! docs/JavaScriptingProgrammersGuide.html
! docs/source/javaarray.js
! src/jdk/nashorn/api/scripting/resources/engine.js
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
! test/script/basic/NASHORN-556.js
! test/script/basic/javaarrayconversion.js
! test/script/currently-failing/logcoverage.js
! test/script/trusted/NASHORN-638.js
! test/script/trusted/NASHORN-653.js

hg: jdk8/tl/nashorn: 15 new changesets

[sundararajan . athijegannathan]

Changeset: 80d4db063d5a
Author:jlaskey
Date:  2013-05-14 11:15 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/80d4db063d5a

8014512: Exclude testing and infrastructure packages from code coverage
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

! make/code_coverage.xml

Changeset: eeed4db61215
Author:jlaskey
Date:  2013-05-14 11:16 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eeed4db61215

Merge

- src/jdk/nashorn/internal/ir/LineNumberNode.java
- src/jdk/nashorn/internal/ir/Location.java
- test/script/trusted/logcoverage.js

Changeset: fc20983ef38e
Author:attila
Date:  2013-05-14 19:18 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fc20983ef38e

8011718: binding already bound function with extra arguments fails
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
+ test/script/basic/JDK-8011718.js
+ test/script/basic/JDK-8011718.js.EXPECTED

Changeset: f88a4818a4dc
Author:lagergren
Date:  2013-05-14 19:56 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f88a4818a4dc

8014426: Original exception no longer thrown away when a finally rethrows
Reviewed-by: attila, jlaskey

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8014426.js
+ test/script/basic/JDK-8014426.js.EXPECTED

Changeset: 64ef1aeaeb4e
Author:attila
Date:  2013-05-15 10:28 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/64ef1aeaeb4e

8014639: Remove debug flag from test runs
Reviewed-by: hannesw, lagergren

! make/project.properties

Changeset: b37eb709ae27
Author:attila
Date:  2013-05-15 14:54 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b37eb709ae27

8014646: Update the Java interop documentation in the Java Scripting 
Programmer's Guide
Reviewed-by: jlaskey, hannesw, lagergren

! docs/JavaScriptingProgrammersGuide.html

Changeset: 1eaa542cc8e2
Author:sundar
Date:  2013-05-15 19:45 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1eaa542cc8e2

8012305: Function.bind can't be called on prototype function inside constructor
Reviewed-by: lagergren, attila

+ test/script/basic/JDK-8012305.js
+ test/script/basic/JDK-8012305.js.EXPECTED

Changeset: 6344644b81ec
Author:jlaskey
Date:  2013-05-15 12:09 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6344644b81ec

8014648: Exclude testing and infrastructure packages from code coverage, round 
two
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

! make/code_coverage.xml
! src/jdk/nashorn/internal/runtime/options/Option.java
! src/jdk/nashorn/internal/runtime/options/Options.java
- src/jdk/nashorn/internal/runtime/options/ValueOption.java
! test/script/basic/allgettersetters.js

Changeset: 19e9cd9c7010
Author:attila
Date:  2013-05-15 20:21 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/19e9cd9c7010

8014647: Allow class-based overrides to be initialized with a ScriptFunction
Reviewed-by: hannesw, jlaskey, sundar

! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
+ test/script/basic/JDK-8014647.js
+ test/script/basic/JDK-8014647.js.EXPECTED

Changeset: ac14a1fb0cab
Author:sundar
Date:  2013-05-16 14:52 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ac14a1fb0cab

8009141: Avoid netscape.javascript.JSObject in nashorn code
Reviewed-by: lagergren, hannesw

+ src/jdk/nashorn/api/scripting/JSObject.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java
- src/netscape/javascript/JSObject.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 4c67a692ef97
Author:lagergren
Date:  2013-05-16 13:44 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4c67a692ef97

8013919: Original exception no longer thrown away when a finally rethrows
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
+ test/script/basic/JDK-8013919.js
+ test/script/basic/JDK-8013919.js.EXPECTED

Changeset: 98798a6336de
Author:hannesw
Date:  2013-05-16 19:52 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/98798a6336de

8012359: Increase code coverage in Joni
Reviewed-by: jlaskey, lagergren

! make/build.xml
- src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java
+ src/jdk/nashorn/internal/runtime/regexp/JdkRegExp.java
! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java
! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java
- 

hg: jdk8/tl/nashorn: 21 new changesets

[sundararajan . athijegannathan]

Changeset: 0547a1c76259
Author:attila
Date:  2013-04-23 12:52 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0547a1c76259

8011065: Problems when script implements an interface with variadic methods
Reviewed-by: jlaskey, hannesw, sundar

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java
+ test/src/jdk/nashorn/api/scripting/VariableArityTestInterface.java

Changeset: 32036918585d
Author:attila
Date:  2013-04-23 16:48 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/32036918585d

8010731: Don't expose internal symbols to scripts
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java

Changeset: a6c53280343d
Author:hannesw
Date:  2013-04-24 13:28 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a6c53280343d

8012334: ToUint32, ToInt32, and ToUint16 don't conform to spec
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeUint32Array.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java
+ test/examples/int-micro.js
+ test/script/basic/JDK-8012334.js
+ test/script/basic/JDK-8012334.js.EXPECTED
! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java

Changeset: 3974ce844f17
Author:hannesw
Date:  2013-04-24 13:34 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3974ce844f17

8012931: NativeDate.safeToString() throws RangeError for invalid date
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/objects/NativeDate.java
+ test/script/basic/JDK-8012931.js
+ test/script/basic/JDK-8012931.js.EXPECTED

Changeset: e959c7969f3b
Author:hannesw
Date:  2013-04-24 13:36 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e959c7969f3b

8008238: Labeled break in finally causes stack overflow in Node copy
Reviewed-by: lagergren, attila

+ test/script/basic/JDK-8008238.js

Changeset: c0a10bbf6752
Author:jlaskey
Date:  2013-04-24 14:25 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c0a10bbf6752

8012251: jjs should support -fx option
Reviewed-by: sundar, attila, lagergren
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java
! src/jdk/nashorn/internal/runtime/resources/Options.properties
+ src/jdk/nashorn/internal/runtime/resources/fx/base.js
+ src/jdk/nashorn/internal/runtime/resources/fx/bootstrap.js
+ src/jdk/nashorn/internal/runtime/resources/fx/controls.js
+ src/jdk/nashorn/internal/runtime/resources/fx/fxml.js
+ src/jdk/nashorn/internal/runtime/resources/fx/graphics.js
+ src/jdk/nashorn/internal/runtime/resources/fx/media.js
+ src/jdk/nashorn/internal/runtime/resources/fx/swing.js
+ src/jdk/nashorn/internal/runtime/resources/fx/swt.js
+ src/jdk/nashorn/internal/runtime/resources/fx/web.js
! src/jdk/nashorn/tools/Shell.java
! tools/fxshell/jdk/nashorn/tools/FXShell.java

Changeset: 9ad1ebb44c86
Author:hannesw
Date:  2013-04-25 14:20 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9ad1ebb44c86

8013131: Various compatibility issues in String.prototype.split()
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java
! src/jdk/nashorn/internal/objects/NativeString.java
+ test/script/basic/JDK-8013131.js
+ test/script/basic/JDK-8013131.js.EXPECTED

Changeset: ff1e4655a57f
Author:attila
Date:  2013-04-25 14:47 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ff1e4655a57f

8013203: A collection of smaller speedups to compilation pipeline
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java

Changeset: fd0b969a6d07
Author:attila
Date:  2013-04-25 15:31 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fd0b969a6d07

8013167: Vararg constructor not found
Reviewed-by: jlaskey, lagergren, sundar

! src/jdk/internal/dynalink/beans/StaticClassIntrospector.java
! src/jdk/internal/dynalink/beans/StaticClassLinker.java
+ test/script/basic/JDK-8013167.js
+ 

hg: jdk8/tl/nashorn: 9 new changesets

[sundararajan . athijegannathan]

Changeset: ac309d492b8d
Author:sundar
Date:  2013-04-18 15:50 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ac309d492b8d

8012462: Date.prototype.toJSON does not handle non-Date 'this' as per the spec.
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/internal/objects/NativeDate.java
+ test/script/basic/JDK-8012462.js

Changeset: d1d564f5cf82
Author:hannesw
Date:  2013-04-18 14:25 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d1d564f5cf82

8012460: RegExp regression
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java
+ test/script/basic/JDK-8012460.js
+ test/script/basic/JDK-8012460.js.EXPECTED

Changeset: bc251a7b5103
Author:sundar
Date:  2013-04-19 17:46 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bc251a7b5103

8012612: Compile failed
Reviewed-by: hannesw, jlaskey, attila

! src/jdk/nashorn/internal/runtime/Context.java

Changeset: c8460f668d0c
Author:sundar
Date:  2013-04-19 18:23 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c8460f668d0c

8012593: JSAdapter overrides impacts strongly construction time
Reviewed-by: jlaskey, attila

! src/jdk/nashorn/internal/objects/NativeJSAdapter.java

Changeset: 3a209cbd1d8f
Author:lagergren
Date:  2013-04-19 16:11 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3a209cbd1d8f

8010701: Immutable nodes - final iteration
Reviewed-by: sundar, hannesw, jlaskey

! bin/verbose_octane.sh
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
- src/jdk/nashorn/internal/codegen/Frame.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/Namespace.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/ObjectCreator.java
+ src/jdk/nashorn/internal/codegen/SplitMethodEmitter.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/BaseNode.java
! src/jdk/nashorn/internal/ir/BinaryNode.java
! src/jdk/nashorn/internal/ir/Block.java
+ src/jdk/nashorn/internal/ir/BlockLexicalContext.java
! src/jdk/nashorn/internal/ir/BreakNode.java
! src/jdk/nashorn/internal/ir/BreakableNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CaseNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ContinueNode.java
- src/jdk/nashorn/internal/ir/DoWhileNode.java
! src/jdk/nashorn/internal/ir/EmptyNode.java
! src/jdk/nashorn/internal/ir/ExecuteNode.java
+ src/jdk/nashorn/internal/ir/Flags.java
! src/jdk/nashorn/internal/ir/ForNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IfNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
- src/jdk/nashorn/internal/ir/LabeledNode.java
! src/jdk/nashorn/internal/ir/LexicalContext.java
+ src/jdk/nashorn/internal/ir/LexicalContextNode.java
! src/jdk/nashorn/internal/ir/LineNumberNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/ir/Location.java
+ src/jdk/nashorn/internal/ir/LoopNode.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/ObjectNode.java
! src/jdk/nashorn/internal/ir/PropertyNode.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/ir/TernaryNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/ir/WhileNode.java
! src/jdk/nashorn/internal/ir/WithNode.java
+ src/jdk/nashorn/internal/ir/annotations/Immutable.java
! src/jdk/nashorn/internal/ir/debug/ASTWriter.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
! src/jdk/nashorn/internal/lookup/MethodHandleFactory.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! 

hg: jdk8/tl/nashorn: 5 new changesets

[sundararajan . athijegannathan]

Changeset: aa8170c0dec9
Author:sundar
Date:  2013-04-15 20:12 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aa8170c0dec9

8012240: Array.prototype.map.call({length: -1, get 0(){throw 0}}, 
function(){}).length does not throw error
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/runtime/arrays/MapIterator.java
+ test/script/basic/JDK-8012240.js

Changeset: 486d92559c37
Author:sundar
Date:  2013-04-17 16:52 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/486d92559c37

8012457: Function.prototype.apply should accept any array-like argument for 
function arguments
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeFunction.java
+ test/script/basic/JDK-8012457.js

Changeset: d4468316fe73
Author:jlaskey
Date:  2013-04-17 08:48 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d4468316fe73

Merge


Changeset: 04b36c02c0e2
Author:jlaskey
Date:  2013-04-17 15:36 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/04b36c02c0e2

8012529: Remove -esa from testing jvmargs
Reviewed-by: sundar
Contributed-by: james.las...@oracle.com

! make/project.properties

Changeset: 2bb3b22392d7
Author:sundar
Date:  2013-04-18 15:47 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2bb3b22392d7

Merge

hg: jdk8/tl/nashorn: 9 new changesets

[sundararajan . athijegannathan]

Changeset: 635a93b61d34
Author:hannesw
Date:  2013-04-10 14:00 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/635a93b61d34

8011714: Regexp decimal escape handling still not correct
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8011714.js
+ test/script/basic/JDK-8011714.js.EXPECTED

Changeset: b4ea8678bf15
Author:hannesw
Date:  2013-04-10 14:05 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b4ea8678bf15

8011749: Bugs with empty character class handling
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8011749.js
+ test/script/basic/JDK-8011749.js.EXPECTED

Changeset: 8ae9ed1ac1e2
Author:hannesw
Date:  2013-04-10 14:08 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8ae9ed1ac1e2

8011756: Wrong characters supported in RegExp \c escape
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8011756.js
+ test/script/basic/JDK-8011756.js.EXPECTED

Changeset: 571e06d5d23c
Author:sundar
Date:  2013-04-11 13:20 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/571e06d5d23c

8011960: [2,1].sort(null) should throw TypeError
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011960.js

Changeset: 256bb030ce0a
Author:sundar
Date:  2013-04-11 15:04 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/256bb030ce0a

8011974: Comparator function returning negative and positive Infinity does not 
work as expected with Array.prototype.sort
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011974.js

Changeset: a3fc89d33072
Author:hannesw
Date:  2013-04-11 12:16 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a3fc89d33072

8011980: Allow NUL character in character class
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8011980.js
+ test/script/basic/JDK-8011980.js.EXPECTED

Changeset: ed4293ceec0e
Author:hannesw
Date:  2013-04-12 16:31 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ed4293ceec0e

8011884: Regexp literals are compiled twice
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java
! src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ast/QuantifierNode.java

Changeset: 36e36a2d4312
Author:hannesw
Date:  2013-04-12 16:32 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/36e36a2d4312

8011885: Switch to Joni as default Regexp engine
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java

Changeset: e70e6b38826b
Author:jlaskey
Date:  2013-04-15 08:39 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e70e6b38826b

Merge

hg: jdk8/tl/nashorn: 20 new changesets

[sundararajan . athijegannathan]

Changeset: af6fc67aa73d
Author:jlaskey
Date:  2013-04-02 11:37 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/af6fc67aa73d

8011233: Create a Nashorn shell for JavaFX
Reviewed-by: lagergren, sundar
Contributed-by: james.las...@oracle.com

! make/build.xml
! make/project.properties
+ tools/fxshell/jdk/nashorn/tools/FXShell.java

Changeset: be5d2e472e22
Author:jlaskey
Date:  2013-04-02 11:38 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/be5d2e472e22

Merge


Changeset: 159dbe2e02eb
Author:sundar
Date:  2013-04-02 20:42 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/159dbe2e02eb

8011237: Object.isExtensible(Object.getOwnPropertyDescriptor(function(){use 
strict},caller).get) should be false
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ test/script/basic/JDK-8011237.js

Changeset: e9af5451d2d1
Author:sundar
Date:  2013-04-02 23:01 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e9af5451d2d1

8011274: Object.getOwnPropertyDescriptor(function(){use 
strict},caller).get.hasOwnProperty(prototype) should be false
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ test/script/basic/JDK-8011274.js

Changeset: e63b20d4f08a
Author:sundar
Date:  2013-04-03 11:41 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e63b20d4f08a

8011357: Array.prototype.slice and Array.prototype.splice should not call user 
defined valueOf of start, end arguments more than once
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011357.js

Changeset: 51da1afbab26
Author:attila
Date:  2013-04-03 11:13 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/51da1afbab26

8011362: Overloaded method resolution foiled by nulls
Reviewed-by: hannesw, sundar

! src/jdk/internal/dynalink/beans/ClassString.java
! src/jdk/internal/dynalink/beans/OverloadedMethod.java
+ test/script/basic/JDK-8011362.js
+ test/script/basic/JDK-8011362.js.EXPECTED
+ test/src/jdk/nashorn/test/models/Jdk8011362TestSubject.java

Changeset: b4191da366be
Author:sundar
Date:  2013-04-03 15:27 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b4191da366be

8011365: Array.prototype.join and Array.prototype.toString do not throw 
TypeError on null, undefined
Reviewed-by: attila, hannesw, lagergren

! src/jdk/nashorn/internal/objects/NativeArray.java
! test/script/basic/JDK-8011362.js.EXPECTED
+ test/script/basic/JDK-8011365.js

Changeset: 4f7d7576e8c4
Author:hannesw
Date:  2013-04-03 12:43 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4f7d7576e8c4

8007774: Enable code cache again
Reviewed-by: lagergren, attila, sundar

! src/jdk/nashorn/internal/runtime/resources/Options.properties

Changeset: 82fed56d8dce
Author:sundar
Date:  2013-04-03 20:17 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/82fed56d8dce

8011382: Data prototype methods and constructor do not call user defined 
toISOString, valueOf methods per spec.
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeDate.java
+ test/script/basic/JDK-8011382.js

Changeset: a5a8ddc2e028
Author:sundar
Date:  2013-04-04 10:24 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a5a8ddc2e028

8011394: RegExp.prototype.test() does not call valueOf on lastIndex property as 
per the spec.
Reviewed-by: lagergren, jlaskey, hannesw

! src/jdk/nashorn/internal/objects/NativeRegExp.java
+ test/script/basic/JDK-8011394.js

Changeset: 0548c134b9ac
Author:sundar
Date:  2013-04-04 13:54 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0548c134b9ac

8011421: When using Object.defineProperty on arrays, PropertyDescriptor's 
property accessors are invoked multiple times
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011421.js

Changeset: f638f2f094f7
Author:jlaskey
Date:  2013-04-04 09:05 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f638f2f094f7

8011540: PropertyMap histories should not begin with empty map
Reviewed-by: lagergren, sundar
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/runtime/PropertyMap.java

Changeset: 069923cc9de5
Author:jlaskey
Date:  2013-04-04 09:06 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/069923cc9de5

Merge


Changeset: 18df6640e63f
Author:sundar
Date:  2013-04-04 18:30 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/18df6640e63f

8011543: .split(undefined,{valueOf:function(){throw 2}}) does not throw 
exception
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeString.java
+ test/script/basic/JDK-8011543.js

Changeset: 5eb1427b6a6d
Author:attila
Date:  2013-04-04 15:53 +0200
URL:   

hg: jdk8/tl/nashorn: 2 new changesets

[sundararajan . athijegannathan]

Changeset: 3e4369fb810b
Author:hannesw
Date:  2013-04-02 13:55 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3e4369fb810b

8011219: Regression with recent PropertyMap history changes
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/PropertyMap.java

Changeset: 5362d96d5915
Author:sundar
Date:  2013-04-02 17:40 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5362d96d5915

8011209: Object.getOwnPropertyDescriptor(function(){use 
strict},caller).get.length is not 0
Reviewed-by: lagergren, hannesw, jlaskey

! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ test/script/basic/JDK-8011209.js

hg: jdk8/tl/nashorn: 4 new changesets

[sundararajan . athijegannathan]

Changeset: 41a212ea8c0c
Author:sundar
Date:  2013-03-28 20:48 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/41a212ea8c0c

8010924: Dealing with undefined property gets you a fatal stack
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
+ test/script/basic/JDK-8010924.js

Changeset: e2ea7a29b9c1
Author:lagergren
Date:  2013-03-29 08:55 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e2ea7a29b9c1

8010995: The bug ID 8010710 accidentally got two digits transposed in the 
checkin and unit test name
Reviewed-by: hannesw, sundar

+ test/script/basic/JDK-8010710.js
+ test/script/basic/JDK-8010710.js.EXPECTED
- test/script/basic/JDK-8017010.js
- test/script/basic/JDK-8017010.js.EXPECTED

Changeset: 704f3083af8a
Author:sundar
Date:  2013-03-29 18:38 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/704f3083af8a

8011063: With older ant, we get the error The property type doesn't support 
nested text data (${run.te...jvmargs}).
Reviewed-by: hannesw, ksrini

! make/build.xml

Changeset: a094fc010120
Author:jlaskey
Date:  2013-03-31 08:19 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a094fc010120

8011095: PropertyHashMap.rehash() does not grow enough
Reviewed-by: hannesw, lagergren
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/runtime/PropertyHashMap.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java

hg: jdk8/tl/jdk: 8010991: Enable test/javax/script/GetInterfaceTest.java again

[sundararajan . athijegannathan]

Changeset: 811c771acf65
Author:sundar
Date:  2013-03-28 14:36 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/811c771acf65

8010991: Enable test/javax/script/GetInterfaceTest.java again
Reviewed-by: lagergren, hannesw

! test/javax/script/GetInterfaceTest.java

hg: jdk8/tl/nashorn: 4 new changesets

[sundararajan . athijegannathan]

Changeset: ae4ef3102d9c
Author:lagergren
Date:  2013-03-25 12:01 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ae4ef3102d9c

8017010: index evaluation to a temporary location for index operator much 
change temporaries to slots, but never scoped vars
Reviewed-by: hannesw, sundar

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java
! src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java
+ test/script/basic/JDK-8017010.js
+ test/script/basic/JDK-8017010.js.EXPECTED
! test/script/basic/NASHORN-258.js
! test/script/basic/NASHORN-258.js.EXPECTED

Changeset: 15dac7439921
Author:sundar
Date:  2013-03-25 18:20 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/15dac7439921

8010709: org on the top level doesn't resolve
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/Global.java
+ test/script/basic/JDK-8010709.js

Changeset: 43e40c08e7f8
Author:lagergren
Date:  2013-03-26 08:42 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/43e40c08e7f8

8010706: -Dnashorn.args system property to create command lines to wrapped 
nashorn.jar:s
Reviewed-by: hannesw, sundar

! docs/DEVELOPER_README
! src/jdk/nashorn/internal/runtime/options/Options.java

Changeset: ed60078f0a80
Author:sundar
Date:  2013-03-26 18:26 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ed60078f0a80

8010720: Linkage problem with java.lang.String.length()
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java
+ test/script/basic/JDK-8010720.js

hg: jdk8/tl/nashorn: 3 new changesets

[sundararajan . athijegannathan]

Changeset: 3b0a0d9d51f0
Author:sundar
Date:  2013-03-18 21:03 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3b0a0d9d51f0

8010199: javax.script.Invocable implementation for nashorn does not return null 
when matching functions are missing
Reviewed-by: lagergren, jlaskey

! bin/jjs
! bin/jjssecure
! bin/nashorn
! bin/nashornsecure
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
+ test/script/basic/JDK-8010199.js
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 606a1946e3e2
Author:jlaskey
Date:  2013-03-19 11:03 -0300
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/606a1946e3e2

8009969: CodeCoverage should use template
Reviewed-by: jlaskey, sundar
Contributed-by: pavel.stepa...@oracle.com

! make/build.xml
! make/code_coverage.xml
! make/project.properties

Changeset: 4be452026847
Author:attila
Date:  2013-03-23 00:58 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4be452026847

8010652: Eliminate non-child references in Block/FunctionNode, and make few 
node types immutable
Reviewed-by: jlaskey, lagergren

! make/project.properties
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/codegen/FunctionSignature.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/Assignment.java
! src/jdk/nashorn/internal/ir/BaseNode.java
! src/jdk/nashorn/internal/ir/BinaryNode.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/BreakNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CaseNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ContinueNode.java
! src/jdk/nashorn/internal/ir/DoWhileNode.java
! src/jdk/nashorn/internal/ir/EmptyNode.java
! src/jdk/nashorn/internal/ir/ExecuteNode.java
! src/jdk/nashorn/internal/ir/ForNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IfNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
+ src/jdk/nashorn/internal/ir/LexicalContext.java
! src/jdk/nashorn/internal/ir/LineNumberNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/ir/Location.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/ObjectNode.java
! src/jdk/nashorn/internal/ir/PropertyNode.java
- src/jdk/nashorn/internal/ir/ReferenceNode.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/ir/TernaryNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/TypeOverride.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/ir/WhileNode.java
! src/jdk/nashorn/internal/ir/WithNode.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
! test/script/basic/JDK-8006755.js
! test/script/basic/NASHORN-837.js
! test/src/jdk/nashorn/internal/codegen/CompilerTest.java

hg: jdk8/tl/jdk: 8010704: The test closed/java/lang/SecurityManager/CheckPackageDefinition.java failed after fix for 8009869

[sundararajan . athijegannathan]

Changeset: d92a96dcbfe1
Author:sundar
Date:  2013-03-25 19:25 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d92a96dcbfe1

8010704: The test closed/java/lang/SecurityManager/CheckPackageDefinition.java 
failed after fix for 8009869
Reviewed-by: lagergren, hannesw

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-solaris

hg: jdk8/tl/jdk: 8009869: Need to modify java.security property package.access to include nashorn packages

[sundararajan . athijegannathan]

Changeset: 9ee1aff76498
Author:sundar
Date:  2013-03-21 19:19 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ee1aff76498

8009869: Need to modify java.security property package.access to include 
nashorn packages
Reviewed-by: ahgross, jlaskey, lagergren

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows

hg: jdk8/tl/jdk: 8010136: Make jrunscript's init.js to work on nashorn

[sundararajan . athijegannathan]

Changeset: 46ad8dfabd5f
Author:sundar
Date:  2013-03-15 19:30 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ad8dfabd5f

8010136: Make jrunscript's init.js to work on nashorn
Reviewed-by: lagergren, hannesw

! src/share/classes/com/sun/tools/script/shell/init.js

hg: jdk8/tl/langtools: 7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {}

[sundararajan . athijegannathan]

Changeset: f071cd32d297
Author:sundar
Date:  2012-08-08 22:17 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f071cd32d297

7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {}
Reviewed-by: darcy, jjg

! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java
+ test/tools/javac/TryWithResources/T7178324.java

hg: jdk8/tl/langtools: 7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type

[sundararajan . athijegannathan]

Changeset: 96a8278e323c
Author:sundar
Date:  2012-05-11 20:06 +0530
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96a8278e323c

7166990: java/compiler Inherited interfaces using generics sometimes looses the 
generic type
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/Lower.java
+ test/tools/javac/TryWithResources/T7164542.java