Re: [13] RFR: JDK-8225682: Reference to JNI spec on java.sun.com

2019-06-14 Thread serguei . spitsyn 

Hi Alex,

Looks good.

Thanks,
Serguei


On 6/14/19 11:08 AM, Alex Menkov wrote:

Hi all,

Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").

jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev: 
http://cr.openjdk.java.net/~amenkov/docs/jdwp-protocol_jni_link/webrev/


--alex

Re: [13] RFR: JDK-8225682: Reference to JNI spec on java.sun.com

2019-06-14 Thread Chris Plummer 

Ok. Looks good then.

Chris

On 6/14/19 12:13 PM, Alex Menkov wrote:
It works in local build directory, also I checked jdk12 online docs 
(https://docs.oracle.com/en/java/javase/12/docs/specs/jdwp/jdwp-protocol.html) 
- relative paths preserve.


--alex

On 06/14/2019 11:40, Chris Plummer wrote:

Have you confirmed the link is working?

Chris

On 6/14/19 11:08 AM, Alex Menkov wrote:

Hi all,

Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").

jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev: 
http://cr.openjdk.java.net/~amenkov/docs/jdwp-protocol_jni_link/webrev/


--alex

Re: [13] RFR: JDK-8225682: Reference to JNI spec on java.sun.com

2019-06-14 Thread Alex Menkov 

Thanks Gary,

I'll update copyright year before push

--alex

On 06/14/2019 11:15, Gary Adams wrote:

And the copyright.

Looks good to me.

On 6/14/19, 2:08 PM, Alex Menkov wrote:

Hi all,

Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").

jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev: 
http://cr.openjdk.java.net/~amenkov/docs/jdwp-protocol_jni_link/webrev/


--alex

Re: [13] RFR: JDK-8225682: Reference to JNI spec on java.sun.com

2019-06-14 Thread Alex Menkov 
It works in local build directory, also I checked jdk12 online docs 
(https://docs.oracle.com/en/java/javase/12/docs/specs/jdwp/jdwp-protocol.html) 
- relative paths preserve.


--alex

On 06/14/2019 11:40, Chris Plummer wrote:

Have you confirmed the link is working?

Chris

On 6/14/19 11:08 AM, Alex Menkov wrote:

Hi all,

Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").

jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev: 
http://cr.openjdk.java.net/~amenkov/docs/jdwp-protocol_jni_link/webrev/


--alex

Re: [13] RFR: JDK-8225682: Reference to JNI spec on java.sun.com

2019-06-14 Thread Chris Plummer 

Have you confirmed the link is working?

Chris

On 6/14/19 11:08 AM, Alex Menkov wrote:

Hi all,

Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").

jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev: 
http://cr.openjdk.java.net/~amenkov/docs/jdwp-protocol_jni_link/webrev/


--alex

Re: [13] RFR: JDK-8225682: Reference to JNI spec on java.sun.com

2019-06-14 Thread Gary Adams 

And the copyright.

Looks good to me.

On 6/14/19, 2:08 PM, Alex Menkov wrote:

Hi all,

Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").

jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev: 
http://cr.openjdk.java.net/~amenkov/docs/jdwp-protocol_jni_link/webrev/


--alex

[13] RFR: JDK-8225682: Reference to JNI spec on java.sun.com

2019-06-14 Thread Alex Menkov 

Hi all,

Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").

jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev: 
http://cr.openjdk.java.net/~amenkov/docs/jdwp-protocol_jni_link/webrev/


--alex