RE: Remove unused import proposal: in JdpController.java
Thank you Christoph Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: "Langer, Christoph" To: David Holmes , Andrew Leonard , "serviceability-dev@openjdk.java.net" Date: 22/02/2018 08:26 Subject: RE: Remove unused import proposal: in JdpController.java Hi Andrew, I'll take this on as I have a similar include cleanup change in my queue for java/util/jar/Attributes.java. Will post a separate review request... Best regards > -Original Message- > From: serviceability-dev [mailto:serviceability-dev- > boun...@openjdk.java.net] On Behalf Of David Holmes > Sent: Donnerstag, 22. Februar 2018 05:12 > To: Andrew Leonard ; serviceability- > d...@openjdk.java.net > Subject: Re: Remove unused import proposal: in JdpController.java > > Hi Andrew, > > I've filed: > > https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8198539&d=DwIFAw&c=jf_iaSHvJObTbx-siA1ZOg&r=NaV8Iy8Ld-vjpXZFDdTbgGlRTghGHnwM75wUPd5_NUQ&m=ViGiFidumq45NMcWmohOp_xM59zUHYwEnA94bbvXpvA&s=tp8_Q0Fm7qSARlXkA1Qew-9-vQ_rXuKic8vN8-SXlf0&e= > > to clean up your leftover import from JDK-8183123 :) (which was fixed in > 10 not 9). > > If someone from serviceability doesn't pick this up I may be able to. > > David > > On 22/02/2018 1:29 AM, Andrew Leonard wrote: > > Hi, > > I would like to find a sponsor please for this simple tidy up of > > JdpController.java ? > > It contains an unused "import sun.management.VMManagement;" which > is for > > a sun specific java.management class which this class used to use prior > > to jdk9. > > Thanks > > Andrew > > > > diff --git > > > a/src/jdk.management.agent/share/classes/sun/management/jdp/JdpCont > roller.java > > > b/src/jdk.management.agent/share/classes/sun/management/jdp/JdpCont > roller.java > > > > --- > > > a/src/jdk.management.agent/share/classes/sun/management/jdp/JdpCont > roller.java > > > > +++ > > > b/src/jdk.management.agent/share/classes/sun/management/jdp/JdpCont > roller.java > > > > @@ -34,7 +34,6 @@ > > import java.lang.reflect.Field; > > import java.lang.reflect.Method; > > import java.lang.UnsupportedOperationException; > > -import sun.management.VMManagement; > > > > /** > >* JdpController is responsible to create and manage a broadcast loop. > > > > > > > > > > > > Andrew Leonard > > Java Runtimes Development > > IBM Hursley > > IBM United Kingdom Ltd > > Phone internal: 245913, external: 01962 815913 > > internet email: andrew_m_leon...@uk.ibm.com > > > > > > Unless stated otherwise above: > > IBM United Kingdom Limited - Registered in England and Wales with > number > > 741598. > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
RE: Remove unused import proposal: in JdpController.java
Hi Andrew, I'll take this on as I have a similar include cleanup change in my queue for java/util/jar/Attributes.java. Will post a separate review request... Best regards Christoph > -Original Message- > From: serviceability-dev [mailto:serviceability-dev- > boun...@openjdk.java.net] On Behalf Of David Holmes > Sent: Donnerstag, 22. Februar 2018 05:12 > To: Andrew Leonard ; serviceability- > d...@openjdk.java.net > Subject: Re: Remove unused import proposal: in JdpController.java > > Hi Andrew, > > I've filed: > > https://bugs.openjdk.java.net/browse/JDK-8198539 > > to clean up your leftover import from JDK-8183123 :) (which was fixed in > 10 not 9). > > If someone from serviceability doesn't pick this up I may be able to. > > David > > On 22/02/2018 1:29 AM, Andrew Leonard wrote: > > Hi, > > I would like to find a sponsor please for this simple tidy up of > > JdpController.java ? > > It contains an unused "import sun.management.VMManagement;" which > is for > > a sun specific java.management class which this class used to use prior > > to jdk9. > > Thanks > > Andrew > > > > diff --git > > > a/src/jdk.management.agent/share/classes/sun/management/jdp/JdpCont > roller.java > > > b/src/jdk.management.agent/share/classes/sun/management/jdp/JdpCont > roller.java > > > > --- > > > a/src/jdk.management.agent/share/classes/sun/management/jdp/JdpCont > roller.java > > > > +++ > > > b/src/jdk.management.agent/share/classes/sun/management/jdp/JdpCont > roller.java > > > > @@ -34,7 +34,6 @@ > > import java.lang.reflect.Field; > > import java.lang.reflect.Method; > > import java.lang.UnsupportedOperationException; > > -import sun.management.VMManagement; > > > > /** > > * JdpController is responsible to create and manage a broadcast loop. > > > > > > > > > > > > Andrew Leonard > > Java Runtimes Development > > IBM Hursley > > IBM United Kingdom Ltd > > Phone internal: 245913, external: 01962 815913 > > internet email: andrew_m_leon...@uk.ibm.com > > > > > > Unless stated otherwise above: > > IBM United Kingdom Limited - Registered in England and Wales with > number > > 741598. > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU
Re: Remove unused import proposal: in JdpController.java
Hi Andrew, I've filed: https://bugs.openjdk.java.net/browse/JDK-8198539 to clean up your leftover import from JDK-8183123 :) (which was fixed in 10 not 9). If someone from serviceability doesn't pick this up I may be able to. David On 22/02/2018 1:29 AM, Andrew Leonard wrote: Hi, I would like to find a sponsor please for this simple tidy up of JdpController.java ? It contains an unused "import sun.management.VMManagement;" which is for a sun specific java.management class which this class used to use prior to jdk9. Thanks Andrew diff --git a/src/jdk.management.agent/share/classes/sun/management/jdp/JdpController.java b/src/jdk.management.agent/share/classes/sun/management/jdp/JdpController.java --- a/src/jdk.management.agent/share/classes/sun/management/jdp/JdpController.java +++ b/src/jdk.management.agent/share/classes/sun/management/jdp/JdpController.java @@ -34,7 +34,6 @@ import java.lang.reflect.Field; import java.lang.reflect.Method; import java.lang.UnsupportedOperationException; -import sun.management.VMManagement; /** * JdpController is responsible to create and manage a broadcast loop. Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: Remove unused import proposal: in JdpController.java
I've done my fair share of import cleanup, but friction is high enough that it should be done in bulk. If you can succeed in loading jdk sources into intellij, then you can get intellij to find all the unused imports for you, e.g. in the jdk core libraries. On Wed, Feb 21, 2018 at 7:29 AM, Andrew Leonard wrote: > Hi, > I would like to find a sponsor please for this simple tidy up of > JdpController.java ? > It contains an unused "import sun.management.VMManagement;" which is for a > sun specific java.management class which this class used to use prior to > jdk9. > Thanks > Andrew > > diff --git > a/src/jdk.management.agent/share/classes/sun/management/jdp/JdpController.java > b/src/jdk.management.agent/share/classes/sun/management/ > jdp/JdpController.java > --- a/src/jdk.management.agent/share/classes/sun/management/ > jdp/JdpController.java > +++ b/src/jdk.management.agent/share/classes/sun/management/ > jdp/JdpController.java > @@ -34,7 +34,6 @@ > import java.lang.reflect.Field; > import java.lang.reflect.Method; > import java.lang.UnsupportedOperationException; > -import sun.management.VMManagement; > > /** > * JdpController is responsible to create and manage a broadcast loop. > > > > > > Andrew Leonard > Java Runtimes Development > IBM Hursley > IBM United Kingdom Ltd > Phone internal: 245913, external: 01962 815913 > internet email: andrew_m_leon...@uk.ibm.com > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU >
