Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928
thanks, i'll push it as soon as I get full test results (assuming there are no new failures). -- Igor > On Apr 27, 2020, at 10:21 PM, serguei.spit...@oracle.com wrote: > > This update looks good too. > > Thanks, > Serguei > > > On 4/27/20 22:12, Igor Ignatyev wrote: >> Thanks Mikael, >> >> there is, thought, one more test failing after 8243928 -- >> serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java. >> the fix is pretty much the same revert part of 8243928: >> >>> diff -r 67cbcf4f >>> test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java >>> --- >>> a/test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java >>> Mon Apr 27 20:06:22 2020 -0700 >>> +++ >>> b/test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java >>> Mon Apr 27 22:11:31 2020 -0700 >>> @@ -30,7 +30,7 @@ >>> * @requires vm.cds >>> * @library /test/lib >>> * @compile CanGenerateAllClassHook.java >>> - * @run driver/native CanGenerateAllClassHook >>> + * @run main/native CanGenerateAllClassHook >>> */ >>> >> >> -- Igor >> >>> On Apr 27, 2020, at 10:10 PM, Mikael Vidstedt >>> wrote: >>> >>> >>> Looks good, thanks for the quick turnaround! >>> >>> Cheers, >>> Mikael >>> On Apr 27, 2020, at 10:02 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 > 2 lines changed: 0 ins; 0 del; 2 mod; Hi all, (so now it's my time to apology for inconvenience) could you please review this small follow-up fix/partial revert of 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and TestDefaultMethods.java test use non-exported API so they can't be run in driver mode (b/c jtreg use vanilla JVM for driver code, meaning even exports from @modules tags are ignored) JBS: https://bugs.openjdk.java.net/browse/JDK-8243946 testing: test/hotspot/jtreg/serviceability (in progress) webrev: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 [1] https://bugs.openjdk.java.net/browse/JDK-8243928 Thanks, -- Igor >
Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928
This update looks good too. Thanks, Serguei On 4/27/20 22:12, Igor Ignatyev wrote: Thanks Mikael, there is, thought, one more test failing after 8243928 -- serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java. the fix is pretty much the same revert part of 8243928: diff -r 67cbcf4f test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java --- a/test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java Mon Apr 27 20:06:22 2020 -0700 +++ b/test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java Mon Apr 27 22:11:31 2020 -0700 @@ -30,7 +30,7 @@ * @requires vm.cds * @library /test/lib * @compile CanGenerateAllClassHook.java - * @run driver/native CanGenerateAllClassHook + * @run main/native CanGenerateAllClassHook */ -- Igor On Apr 27, 2020, at 10:10 PM, Mikael Vidstedt wrote: Looks good, thanks for the quick turnaround! Cheers, Mikael On Apr 27, 2020, at 10:02 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 2 lines changed: 0 ins; 0 del; 2 mod; Hi all, (so now it's my time to apology for inconvenience) could you please review this small follow-up fix/partial revert of 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and TestDefaultMethods.java test use non-exported API so they can't be run in driver mode (b/c jtreg use vanilla JVM for driver code, meaning even exports from @modules tags are ignored) JBS: https://bugs.openjdk.java.net/browse/JDK-8243946 testing: test/hotspot/jtreg/serviceability (in progress) webrev: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 [1] https://bugs.openjdk.java.net/browse/JDK-8243928 Thanks, -- Igor
Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928
Hi Serguei, thanks for review, no I haven't yet as I found another problem w/ 8243928. -- Igor > On Apr 27, 2020, at 10:14 PM, serguei.spit...@oracle.com wrote: > > Hi Igor, > > Looks good but you have already pushed. :) > > Thanks, > Serguei > > > On 4/27/20 22:10, Mikael Vidstedt wrote: >> Looks good, thanks for the quick turnaround! >> >> Cheers, >> Mikael >> >>> On Apr 27, 2020, at 10:02 PM, Igor Ignatyev >>> wrote: >>> >>> http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 2 lines changed: 0 ins; 0 del; 2 mod; >>> Hi all, >>> >>> (so now it's my time to apology for inconvenience) >>> >>> could you please review this small follow-up fix/partial revert of >>> 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and >>> TestDefaultMethods.java test use non-exported API so they can't be run in >>> driver mode (b/c jtreg use vanilla JVM for driver code, meaning even >>> exports from @modules tags are ignored) >>> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8243946 >>> testing: test/hotspot/jtreg/serviceability (in progress) >>> webrev: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 >>> >>> [1] https://bugs.openjdk.java.net/browse/JDK-8243928 >>> >>> Thanks, >>> -- Igor >
Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928
Hi Igor, Looks good but you have already pushed. :) Thanks, Serguei On 4/27/20 22:10, Mikael Vidstedt wrote: Looks good, thanks for the quick turnaround! Cheers, Mikael On Apr 27, 2020, at 10:02 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 2 lines changed: 0 ins; 0 del; 2 mod; Hi all, (so now it's my time to apology for inconvenience) could you please review this small follow-up fix/partial revert of 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and TestDefaultMethods.java test use non-exported API so they can't be run in driver mode (b/c jtreg use vanilla JVM for driver code, meaning even exports from @modules tags are ignored) JBS: https://bugs.openjdk.java.net/browse/JDK-8243946 testing: test/hotspot/jtreg/serviceability (in progress) webrev: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 [1] https://bugs.openjdk.java.net/browse/JDK-8243928 Thanks, -- Igor
Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928
Thanks Mikael, there is, thought, one more test failing after 8243928 -- serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java. the fix is pretty much the same revert part of 8243928: > diff -r 67cbcf4f > test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java > --- > a/test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java > Mon Apr 27 20:06:22 2020 -0700 > +++ > b/test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java > Mon Apr 27 22:11:31 2020 -0700 > @@ -30,7 +30,7 @@ > * @requires vm.cds > * @library /test/lib > * @compile CanGenerateAllClassHook.java > - * @run driver/native CanGenerateAllClassHook > + * @run main/native CanGenerateAllClassHook > */ > -- Igor > On Apr 27, 2020, at 10:10 PM, Mikael Vidstedt > wrote: > > > Looks good, thanks for the quick turnaround! > > Cheers, > Mikael > >> On Apr 27, 2020, at 10:02 PM, Igor Ignatyev wrote: >> >> http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 >>> 2 lines changed: 0 ins; 0 del; 2 mod; >> >> Hi all, >> >> (so now it's my time to apology for inconvenience) >> >> could you please review this small follow-up fix/partial revert of >> 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and >> TestDefaultMethods.java test use non-exported API so they can't be run in >> driver mode (b/c jtreg use vanilla JVM for driver code, meaning even exports >> from @modules tags are ignored) >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8243946 >> testing: test/hotspot/jtreg/serviceability (in progress) >> webrev: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8243928 >> >> Thanks, >> -- Igor >
Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928
Looks good and trivial. Thanks, David On 28/04/2020 3:02 pm, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 2 lines changed: 0 ins; 0 del; 2 mod; Hi all, (so now it's my time to apology for inconvenience) could you please review this small follow-up fix/partial revert of 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and TestDefaultMethods.java test use non-exported API so they can't be run in driver mode (b/c jtreg use vanilla JVM for driver code, meaning even exports from @modules tags are ignored) JBS: https://bugs.openjdk.java.net/browse/JDK-8243946 testing: test/hotspot/jtreg/serviceability (in progress) webrev: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 [1] https://bugs.openjdk.java.net/browse/JDK-8243928 Thanks, -- Igor
Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928
Looks good, thanks for the quick turnaround! Cheers, Mikael > On Apr 27, 2020, at 10:02 PM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 >> 2 lines changed: 0 ins; 0 del; 2 mod; > > Hi all, > > (so now it's my time to apology for inconvenience) > > could you please review this small follow-up fix/partial revert of > 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and > TestDefaultMethods.java test use non-exported API so they can't be run in > driver mode (b/c jtreg use vanilla JVM for driver code, meaning even exports > from @modules tags are ignored) > > JBS: https://bugs.openjdk.java.net/browse/JDK-8243946 > testing: test/hotspot/jtreg/serviceability (in progress) > webrev: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 > > [1] https://bugs.openjdk.java.net/browse/JDK-8243928 > > Thanks, > -- Igor
RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928
http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 > 2 lines changed: 0 ins; 0 del; 2 mod; Hi all, (so now it's my time to apology for inconvenience) could you please review this small follow-up fix/partial revert of 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and TestDefaultMethods.java test use non-exported API so they can't be run in driver mode (b/c jtreg use vanilla JVM for driver code, meaning even exports from @modules tags are ignored) JBS: https://bugs.openjdk.java.net/browse/JDK-8243946 testing: test/hotspot/jtreg/serviceability (in progress) webrev: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 [1] https://bugs.openjdk.java.net/browse/JDK-8243928 Thanks, -- Igor
