Re: RFR: 8236190 : Unproblem list vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java
+1 --alex On 12/20/2019 17:12, Chris Plummer wrote: Looks good. Chris On 12/20/19 4:42 PM, Daniil Titov wrote: Please a review a changeset below that removes vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java and runtime/appcds/cacheObject/RedefineClassTest.java tests from test/hotspot/jtreg/ProblemList-graal.txt. --- a/test/hotspot/jtreg/ProblemList-graal.txt Wed Dec 11 19:20:57 2019 -0800 +++ b/test/hotspot/jtreg/ProblemList-graal.txt Fri Dec 20 11:53:31 2019 -0800 @@ -147,9 +147,7 @@ vmTestbase/nsk/jvmti/ForceEarlyReturn/ForceEarlyReturn001/TestDescription.java 8195674,8195635 generic-all vmTestbase/nsk/jvmti/ForceEarlyReturn/ForceEarlyReturn002/TestDescription.java 8195674,8195635 generic-all -runtime/appcds/cacheObject/RedefineClassTest.java 8204506 macosx-all -vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java 8204506,8195635 macosx-all,generic-all -vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java 8204506 macosx-all +vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java 8195635 generic-all These tests were added in ProblemList-graal.txt in [1] and [2] but issue [1] is no longer reproducible in JDK 15 and the tests run fine in Mach5. The third test vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java appears to run fine as well but it was problem-listed due to several issues and issue [3] is not resolved yet. Thus I decided to keep this test on the problem list. Mach5 tests for tier1,tier2, and tier3 successfully passed. [1] https://bugs.openjdk.java.net/browse/JDK-8204506 [2] https://bugs.openjdk.java.net/browse/JDK-8209587 [3] https://bugs.openjdk.java.net/browse/JDK-8195635 [4] Jira issue: https://bugs.openjdk.java.net/browse/JDK-8236190 Thanks. Daniil
Re: RFR: 8236190 : Unproblem list vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java
LGTM — Igor >> On Dec 20, 2019, at 4:42 PM, Daniil Titov wrote: > Please a review a changeset below that removes > vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java > and runtime/appcds/cacheObject/RedefineClassTest.java tests from > test/hotspot/jtreg/ProblemList-graal.txt. > > > --- a/test/hotspot/jtreg/ProblemList-graal.txt Wed Dec 11 19:20:57 2019 -0800 > +++ b/test/hotspot/jtreg/ProblemList-graal.txt Fri Dec 20 11:53:31 2019 -0800 > @@ -147,9 +147,7 @@ > vmTestbase/nsk/jvmti/ForceEarlyReturn/ForceEarlyReturn001/TestDescription.java > 8195674,8195635 generic-all > vmTestbase/nsk/jvmti/ForceEarlyReturn/ForceEarlyReturn002/TestDescription.java > 8195674,8195635 generic-all > > -runtime/appcds/cacheObject/RedefineClassTest.java > 8204506 macosx-all > -vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java > 8204506,8195635 macosx-all,generic-all > -vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java > 8204506 macosx-all > +vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java > 8195635 generic-all > > > These tests were added in ProblemList-graal.txt in [1] and [2] but issue [1] > is no longer reproducible in JDK 15 and the tests run fine in Mach5. > > The third test > vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java > appears to run fine as well but it was problem-listed > due to several issues and issue [3] is not resolved yet. Thus I decided to > keep this test on the problem list. > > Mach5 tests for tier1,tier2, and tier3 successfully passed. > > [1] https://bugs.openjdk.java.net/browse/JDK-8204506 > [2] https://bugs.openjdk.java.net/browse/JDK-8209587 > [3] https://bugs.openjdk.java.net/browse/JDK-8195635 > [4] Jira issue: https://bugs.openjdk.java.net/browse/JDK-8236190 > > Thanks. > Daniil
RFR: 8236190 : Unproblem list vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java
Please a review a changeset below that removes vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java and runtime/appcds/cacheObject/RedefineClassTest.java tests from test/hotspot/jtreg/ProblemList-graal.txt. --- a/test/hotspot/jtreg/ProblemList-graal.txt Wed Dec 11 19:20:57 2019 -0800 +++ b/test/hotspot/jtreg/ProblemList-graal.txt Fri Dec 20 11:53:31 2019 -0800 @@ -147,9 +147,7 @@ vmTestbase/nsk/jvmti/ForceEarlyReturn/ForceEarlyReturn001/TestDescription.java 8195674,8195635 generic-all vmTestbase/nsk/jvmti/ForceEarlyReturn/ForceEarlyReturn002/TestDescription.java 8195674,8195635 generic-all -runtime/appcds/cacheObject/RedefineClassTest.java 8204506 macosx-all -vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java 8204506,8195635 macosx-all,generic-all -vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java 8204506 macosx-all +vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java 8195635 generic-all These tests were added in ProblemList-graal.txt in [1] and [2] but issue [1] is no longer reproducible in JDK 15 and the tests run fine in Mach5. The third test vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java appears to run fine as well but it was problem-listed due to several issues and issue [3] is not resolved yet. Thus I decided to keep this test on the problem list. Mach5 tests for tier1,tier2, and tier3 successfully passed. [1] https://bugs.openjdk.java.net/browse/JDK-8204506 [2] https://bugs.openjdk.java.net/browse/JDK-8209587 [3] https://bugs.openjdk.java.net/browse/JDK-8195635 [4] Jira issue: https://bugs.openjdk.java.net/browse/JDK-8236190 Thanks. Daniil
