Re: RFR: 8246196: javax/management/MBeanServer/OldMBeanServerTest fails with AssertionError
Hi David and Alex, Thank for reviewing this change. I will push it to jdk15 repo as David suggested. Best regards, Daniil On 6/11/20, 5:28 PM, "Alex Menkov" wrote: +1 --alex On 06/11/2020 16:51, David Holmes wrote: > Hi Daniil, > > On 12/06/2020 5:56 am, Daniil Titov wrote: >> Please review change [1] that fixes an intermittent failure of the >> test when it is runs with -Xcomp. >> >> The problem here is that the timespan the test uses to count >> notifications is not adjusted for "test.timeout.factor" system property. > > The adjustment looks fine. > >> The original issue is reproducible in JDK 11 and on Solaris platform >> only. However, I think it makes sense to apply this change in JDK 15 >> to prevent this from possible happening in the future and then >> backport it to 11. > > Do you still intend this for 15 or just 16? If 15 then push to jdk15 > repo and it will get forward ported to jdk/jdk automatically. > > Thanks, > David > >> [1] http://cr.openjdk.java.net/~dtitov/8246196/webrev.01/ >> [2] https://bugs.openjdk.java.net/browse/JDK-8246196 >> >> Thank you, >> Daniil >> >> >>
Re: RFR: 8246196: javax/management/MBeanServer/OldMBeanServerTest fails with AssertionError
+1 Thanks, Serguei On 6/11/20 17:28, Alex Menkov wrote: +1 --alex On 06/11/2020 16:51, David Holmes wrote: Hi Daniil, On 12/06/2020 5:56 am, Daniil Titov wrote: Please review change [1] that fixes an intermittent failure of the test when it is runs with -Xcomp. The problem here is that the timespan the test uses to count notifications is not adjusted for "test.timeout.factor" system property. The adjustment looks fine. The original issue is reproducible in JDK 11 and on Solaris platform only. However, I think it makes sense to apply this change in JDK 15 to prevent this from possible happening in the future and then backport it to 11. Do you still intend this for 15 or just 16? If 15 then push to jdk15 repo and it will get forward ported to jdk/jdk automatically. Thanks, David [1] http://cr.openjdk.java.net/~dtitov/8246196/webrev.01/ [2] https://bugs.openjdk.java.net/browse/JDK-8246196 Thank you, Daniil
Re: RFR: 8246196: javax/management/MBeanServer/OldMBeanServerTest fails with AssertionError
+1 --alex On 06/11/2020 16:51, David Holmes wrote: Hi Daniil, On 12/06/2020 5:56 am, Daniil Titov wrote: Please review change [1] that fixes an intermittent failure of the test when it is runs with -Xcomp. The problem here is that the timespan the test uses to count notifications is not adjusted for "test.timeout.factor" system property. The adjustment looks fine. The original issue is reproducible in JDK 11 and on Solaris platform only. However, I think it makes sense to apply this change in JDK 15 to prevent this from possible happening in the future and then backport it to 11. Do you still intend this for 15 or just 16? If 15 then push to jdk15 repo and it will get forward ported to jdk/jdk automatically. Thanks, David [1] http://cr.openjdk.java.net/~dtitov/8246196/webrev.01/ [2] https://bugs.openjdk.java.net/browse/JDK-8246196 Thank you, Daniil
Re: RFR: 8246196: javax/management/MBeanServer/OldMBeanServerTest fails with AssertionError
Hi Daniil, On 12/06/2020 5:56 am, Daniil Titov wrote: Please review change [1] that fixes an intermittent failure of the test when it is runs with -Xcomp. The problem here is that the timespan the test uses to count notifications is not adjusted for "test.timeout.factor" system property. The adjustment looks fine. The original issue is reproducible in JDK 11 and on Solaris platform only. However, I think it makes sense to apply this change in JDK 15 to prevent this from possible happening in the future and then backport it to 11. Do you still intend this for 15 or just 16? If 15 then push to jdk15 repo and it will get forward ported to jdk/jdk automatically. Thanks, David [1] http://cr.openjdk.java.net/~dtitov/8246196/webrev.01/ [2] https://bugs.openjdk.java.net/browse/JDK-8246196 Thank you, Daniil
RFR: 8246196: javax/management/MBeanServer/OldMBeanServerTest fails with AssertionError
Please review change [1] that fixes an intermittent failure of the test when it is runs with -Xcomp. The problem here is that the timespan the test uses to count notifications is not adjusted for "test.timeout.factor" system property. The original issue is reproducible in JDK 11 and on Solaris platform only. However, I think it makes sense to apply this change in JDK 15 to prevent this from possible happening in the future and then backport it to 11. [1] http://cr.openjdk.java.net/~dtitov/8246196/webrev.01/ [2] https://bugs.openjdk.java.net/browse/JDK-8246196 Thank you, Daniil
