Re: RFR: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
On Fri, 11 Sep 2020 01:08:53 GMT, Daniil Titov wrote: > The change fixes the regression introduced by > https://bugs.openjdk.java.net/browse/JDK-8241080. > > Method validateAssignment() in com.sun.tools.jdi.ObjectReferenceImpl now > always retrieves the reference type and that > requires one more JDWP packet if the value is not cached yet. Before > https://bugs.openjdk.java.net/browse/JDK-8241080 > this happened for arrays only. Testing: tier1-tier3 tests passes. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/124
Re: RFR: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
On Fri, 11 Sep 2020 16:27:57 GMT, Daniil Titov wrote: >> The changes look good to me. Can I ask how you noticed the extra unnecessary >> JDWP packet? > > Thanks @plummercj for the review. The issue with an extra JDWP packet was > reported in serviceability-dev mail list : > https://mail.openjdk.java.net/pipermail/serviceability-dev/2020-September/032960.html > . Hi Daniil, it looks good. - PR: https://git.openjdk.java.net/jdk/pull/124
Re: RFR: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
On Fri, 11 Sep 2020 04:00:35 GMT, Chris Plummer wrote: >> The change fixes the regression introduced by >> https://bugs.openjdk.java.net/browse/JDK-8241080. >> >> Method validateAssignment() in com.sun.tools.jdi.ObjectReferenceImpl now >> always retrieves the reference type and that >> requires one more JDWP packet if the value is not cached yet. Before >> https://bugs.openjdk.java.net/browse/JDK-8241080 >> this happened for arrays only. Testing: tier1-tier3 tests passes. > > The changes look good to me. Can I ask how you noticed the extra unnecessary > JDWP packet? Thanks @plummercj for the review. The issue with an extra JDWP packet was reported in serviceability-dev mail list : https://mail.openjdk.java.net/pipermail/serviceability-dev/2020-September/032960.html . - PR: https://git.openjdk.java.net/jdk/pull/124
Re: RFR: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
On Fri, 11 Sep 2020 01:08:53 GMT, Daniil Titov wrote: > The change fixes the regression introduced by > https://bugs.openjdk.java.net/browse/JDK-8241080. > > Method validateAssignment() in com.sun.tools.jdi.ObjectReferenceImpl now > always retrieves the reference type and that > requires one more JDWP packet if the value is not cached yet. Before > https://bugs.openjdk.java.net/browse/JDK-8241080 > this happened for arrays only. Testing: tier1-tier3 tests passes. The changes look good to me. Can I ask how you noticed the extra unnecessary JDWP packet? - Marked as reviewed by cjplummer (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/124
RFR: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
The change fixes the regression introduced by https://bugs.openjdk.java.net/browse/JDK-8241080. Method validateAssignment() in com.sun.tools.jdi.ObjectReferenceImpl now always retrieves the reference type and that requires one more JDWP packet if the value is not cached yet. Before https://bugs.openjdk.java.net/browse/JDK-8241080 this happened for arrays only. Testing: tier1-tier3 tests passes. - Commit messages: - 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType Changes: https://git.openjdk.java.net/jdk/pull/124/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=124=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252933 Stats: 6 lines in 1 file changed: 3 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/124.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/124/head:pull/124 PR: https://git.openjdk.java.net/jdk/pull/124
