Re: RFR: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs [v2]

2021-09-30 Thread Joe Darcy
> Follow-up change to JDK-8232442, augmentations to javac's Xlint:serial 
> checking are out for review (#5709) and various management libraries would 
> need some changes to pass under the expanded checks.
> 
> The changes are to suppress warnings where non-transient fields in 
> serializable types are not declared with a type statically known to be 
> serializable. That isn't necessarily a correctness issues, but it does merit 
> further scrutiny.
> 
> I'll run a script to update copyright years before a push.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains three additional commits since the 
last revision:

 - Add comments and update copyrights.
 - Merge branch 'master' into JDK-8274398
 - 8274398: Suppress more warnings on non-serializable non-transient instance 
fields in management libs

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5726/files
  - new: https://git.openjdk.java.net/jdk/pull/5726/files/bc8dde4f..a6f37fa5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5726=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5726=00-01

  Stats: 5574 lines in 212 files changed: 3989 ins; 1022 del; 563 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5726.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5726/head:pull/5726

PR: https://git.openjdk.java.net/jdk/pull/5726


Re: RFR: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs

2021-09-30 Thread Joe Darcy
On Thu, 30 Sep 2021 09:56:45 GMT, Serguei Spitsyn  wrote:

> 
> 
> Looks good. Thanks, Serguei

Thanks Serguei, I'll add some explanatory comments and check for any needed 
copyright updates before pushing.

-

PR: https://git.openjdk.java.net/jdk/pull/5726


Re: RFR: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs

2021-09-30 Thread Serguei Spitsyn
On Mon, 27 Sep 2021 21:49:06 GMT, Joe Darcy  wrote:

> Follow-up change to JDK-8232442, augmentations to javac's Xlint:serial 
> checking are out for review (#5709) and various management libraries would 
> need some changes to pass under the expanded checks.
> 
> The changes are to suppress warnings where non-transient fields in 
> serializable types are not declared with a type statically known to be 
> serializable. That isn't necessarily a correctness issues, but it does merit 
> further scrutiny.
> 
> I'll run a script to update copyright years before a push.

Looks good.
Thanks,
Serguei

-

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5726


RFR: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs

2021-09-27 Thread Joe Darcy
Follow-up change to JDK-8232442, augmentations to javac's Xlint:serial checking 
are out for review (#5709) and various management libraries would need some 
changes to pass under the expanded checks.

The changes are to suppress warnings where non-transient fields in serializable 
types are not declared with a type statically known to be serializable. That 
isn't necessarily a correctness issues, but it does merit further scrutiny.

I'll run a script to update copyright years before a push.

-

Commit messages:
 - 8274398: Suppress more warnings on non-serializable non-transient instance 
fields in management libs

Changes: https://git.openjdk.java.net/jdk/pull/5726/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5726=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8274398
  Stats: 12 lines in 8 files changed: 12 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5726.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5726/head:pull/5726

PR: https://git.openjdk.java.net/jdk/pull/5726