Re: RFR: 8276208: vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java fails with "AssertionError: Unexpected output" [v2]
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote: >> This will fix a few issues with the tests added in #5290: >> >> - [x] intermittent failures >> - [x] tests should use `failure` method to report problems rather than >> throwing `AssertionError` > > Jakob Cornell has updated the pull request incrementally with one additional > commit since the last revision: > > Fix incorrect use of `receiveReplyFor' causing test failures LGTM - Marked as reviewed by iklam (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6182
Re: RFR: 8276208: vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java fails with "AssertionError: Unexpected output" [v2]
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote: >> This will fix a few issues with the tests added in #5290: >> >> - [x] intermittent failures >> - [x] tests should use `failure` method to report problems rather than >> throwing `AssertionError` > > Jakob Cornell has updated the pull request incrementally with one additional > commit since the last revision: > > Fix incorrect use of `receiveReplyFor' causing test failures @iklam - Can you review this fix? You were one of the original reviewers on: JDK-8271356 Modify jdb to treat an empty command as a repeat of the previous command Thanks! - PR: https://git.openjdk.java.net/jdk/pull/6182
Re: RFR: 8276208: vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java fails with "AssertionError: Unexpected output" [v2]
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote: >> This will fix a few issues with the tests added in #5290: >> >> - [x] intermittent failures >> - [x] tests should use `failure` method to report problems rather than >> throwing `AssertionError` > > Jakob Cornell has updated the pull request incrementally with one additional > commit since the last revision: > > Fix incorrect use of `receiveReplyFor' causing test failures Marked as reviewed by cjplummer (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6182
Re: RFR: 8276208: vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java fails with "AssertionError: Unexpected output" [v2]
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote: >> This will fix a few issues with the tests added in #5290: >> >> - [x] intermittent failures >> - [x] tests should use `failure` method to report problems rather than >> throwing `AssertionError` > > Jakob Cornell has updated the pull request incrementally with one additional > commit since the last revision: > > Fix incorrect use of `receiveReplyFor' causing test failures Oh good. I haven't been following recent releases very closely. So this is ready for review then. - PR: https://git.openjdk.java.net/jdk/pull/6182
Re: RFR: 8276208: vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java fails with "AssertionError: Unexpected output" [v2]
> This will fix a few issues with the tests added in #5290: > > - [x] intermittent failures > - [x] tests should use `failure` method to report problems rather than > throwing `AssertionError` Jakob Cornell has updated the pull request incrementally with one additional commit since the last revision: Fix incorrect use of `receiveReplyFor' causing test failures - Changes: - all: https://git.openjdk.java.net/jdk/pull/6182/files - new: https://git.openjdk.java.net/jdk/pull/6182/files/817884d9..8359ab8b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6182&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6182&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6182.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6182/head:pull/6182 PR: https://git.openjdk.java.net/jdk/pull/6182
