Re: RFR: JDK-8215571: jdb does not include jdk.* in the default class filter

[Chris Plummer]

Looks good. I've been using it for a while now with no issues.

Chris

On 12/20/18 4:52 AM, Gary Adams wrote:

This should be a trivial update.

The default "excludes" filter for jdb
should have been updated when the jdk.* packages were first introduced.


diff --git 
a/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java 
b/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java

--- a/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java
+++ b/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1998, 2011, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -108,7 +108,7 @@

 static private List excludes() {
 if (excludes == null) {
-    setExcludes("java.*, javax.*, sun.*, com.sun.*");
+    setExcludes("java.*, javax.*, sun.*, com.sun.*, jdk.*");
 }
 return excludes;
 }

Re: RFR: JDK-8215571: jdb does not include jdk.* in the default class filter

[Alan Bateman]

On 20/12/2018 12:52, Gary Adams wrote:

This should be a trivial update.

The default "excludes" filter for jdb
should have been updated when the jdk.* packages were first introduced.
This looks okay to me. One thing to mention is that produce a more 
accurate exclude filter from the packages of the modules in the run-time 
image. That would allow it work with libraries on the class path with 
javax.* APIs for example.


-Alan

RFR: JDK-8215571: jdb does not include jdk.* in the default class filter

[Gary Adams]

This should be a trivial update.

The default "excludes" filter for jdb
should have been updated when the jdk.* packages were first introduced.


diff --git 
a/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java 
b/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java

--- a/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java
+++ b/src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1998, 2011, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -108,7 +108,7 @@

 static private List excludes() {
 if (excludes == null) {
-setExcludes("java.*, javax.*, sun.*, com.sun.*");
+setExcludes("java.*, javax.*, sun.*, com.sun.*, jdk.*");
 }
 return excludes;
 }