Re: RFR (XS) 8236968: jmap -clstats fails to work after JDK-8232759

2020-01-15 Thread coleen . phillimore 

Thanks David and thanks for the discussion.
Coleen

On 1/14/20 6:11 PM, David Holmes wrote:

Hi Coleen,

I concur with the discussion in the bug report. This change looks good.

Thanks,
David

On 15/01/2020 6:37 am, coleen.phillim...@oracle.com wrote:
Summary: Make jmap -clstats call jcmd VM.classloader_stats instead 
which better matches the documentation


Tested with tier1 and * 
jtreg:open/test/jdk/sun/tools/jmap/BasicJMapTest.java

  locally.

open webrev at 
http://cr.openjdk.java.net/~coleenp/2020/8236968.01/webrev

bug link https://bugs.openjdk.java.net/browse/JDK-8236968

Thanks,
Coleen

Re: RFR (XS) 8236968: jmap -clstats fails to work after JDK-8232759

2020-01-14 Thread coleen . phillimore 



Thanks Chris,
I'll fix the copyrights on commit.
Coleen

On 1/14/20 6:11 PM, Chris Plummer wrote:

Hi Coleen,

Looks good. Please update the copyright.

thanks,

Chris

On 1/14/20 12:37 PM, coleen.phillim...@oracle.com wrote:
Summary: Make jmap -clstats call jcmd VM.classloader_stats instead 
which better matches the documentation


Tested with tier1 and * 
jtreg:open/test/jdk/sun/tools/jmap/BasicJMapTest.java

 locally.

open webrev at 
http://cr.openjdk.java.net/~coleenp/2020/8236968.01/webrev

bug link https://bugs.openjdk.java.net/browse/JDK-8236968

Thanks,
Coleen

Re: RFR (XS) 8236968: jmap -clstats fails to work after JDK-8232759

2020-01-14 Thread Chris Plummer 

Hi Coleen,

Looks good. Please update the copyright.

thanks,

Chris

On 1/14/20 12:37 PM, coleen.phillim...@oracle.com wrote:
Summary: Make jmap -clstats call jcmd VM.classloader_stats instead 
which better matches the documentation


Tested with tier1 and * 
jtreg:open/test/jdk/sun/tools/jmap/BasicJMapTest.java

 locally.

open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236968.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8236968

Thanks,
Coleen

Re: RFR (XS) 8236968: jmap -clstats fails to work after JDK-8232759

2020-01-14 Thread David Holmes 

Hi Coleen,

I concur with the discussion in the bug report. This change looks good.

Thanks,
David

On 15/01/2020 6:37 am, coleen.phillim...@oracle.com wrote:
Summary: Make jmap -clstats call jcmd VM.classloader_stats instead which 
better matches the documentation


Tested with tier1 and * 
jtreg:open/test/jdk/sun/tools/jmap/BasicJMapTest.java

  locally.

open webrev at http://cr.openjdk.java.net/~coleenp/2020/8236968.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8236968

Thanks,
Coleen