Re: RFR 8235300: VM_HeapDumper hits assert with bad dump_len
Thanks, David. Thought I needed a final review of the changes you asked for. :) On 1/21/20, 3:04 PM, "David Holmes" wrote: Hi Paul, On 22/01/2020 1:34 am, Hohensee, Paul wrote: > Hi, David, > > Is it ok to put this CSR in Finalized state? Of course. Didn't realize you were expecting an ACK from me. Cheers, David > Thanks, > Paul > > On 1/15/20, 5:12 PM, "serviceability-dev on behalf of Hohensee, Paul" wrote: > > Thanks for your review and updates, David. I've updated the CSR as you requested in its comments. > > Paul > > On 1/14/20, 5:12 PM, "David Holmes" wrote: > > Hi Paul, > > I made some minor updates to the CSR request and added myself as a reviewer. > > Thanks, > David > > On 15/01/2020 10:00 am, Hohensee, Paul wrote: > > Please review this CSR for a backport of JDK-8144732 to jdk8u. > > > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8144732 > > > > JBS release note issue: https://bugs.openjdk.java.net/browse/JDK-8174881 > > > > 8u backport JBS issue: https://bugs.openjdk.java.net/browse/JDK-8235299 > > > > 8u backport CSR: https://bugs.openjdk.java.net/browse/JDK-8235300 > > > > The original patch went through the Oracle CCC process prior to the > > creation of the public CSR process, so there’s no public CSR issue, > > hence the release note JBS issue reference. > > > > Thanks, > > > > Paul > > > > > >
Re: RFR 8235300: VM_HeapDumper hits assert with bad dump_len
Hi Paul, On 22/01/2020 1:34 am, Hohensee, Paul wrote: Hi, David, Is it ok to put this CSR in Finalized state? Of course. Didn't realize you were expecting an ACK from me. Cheers, David Thanks, Paul On 1/15/20, 5:12 PM, "serviceability-dev on behalf of Hohensee, Paul" wrote: Thanks for your review and updates, David. I've updated the CSR as you requested in its comments. Paul On 1/14/20, 5:12 PM, "David Holmes" wrote: Hi Paul, I made some minor updates to the CSR request and added myself as a reviewer. Thanks, David On 15/01/2020 10:00 am, Hohensee, Paul wrote: > Please review this CSR for a backport of JDK-8144732 to jdk8u. > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8144732 > > JBS release note issue: https://bugs.openjdk.java.net/browse/JDK-8174881 > > 8u backport JBS issue: https://bugs.openjdk.java.net/browse/JDK-8235299 > > 8u backport CSR: https://bugs.openjdk.java.net/browse/JDK-8235300 > > The original patch went through the Oracle CCC process prior to the > creation of the public CSR process, so there’s no public CSR issue, > hence the release note JBS issue reference. > > Thanks, > > Paul >
Re: RFR 8235300: VM_HeapDumper hits assert with bad dump_len
Hi, David, Is it ok to put this CSR in Finalized state? Thanks, Paul On 1/15/20, 5:12 PM, "serviceability-dev on behalf of Hohensee, Paul" wrote: Thanks for your review and updates, David. I've updated the CSR as you requested in its comments. Paul On 1/14/20, 5:12 PM, "David Holmes" wrote: Hi Paul, I made some minor updates to the CSR request and added myself as a reviewer. Thanks, David On 15/01/2020 10:00 am, Hohensee, Paul wrote: > Please review this CSR for a backport of JDK-8144732 to jdk8u. > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8144732 > > JBS release note issue: https://bugs.openjdk.java.net/browse/JDK-8174881 > > 8u backport JBS issue: https://bugs.openjdk.java.net/browse/JDK-8235299 > > 8u backport CSR: https://bugs.openjdk.java.net/browse/JDK-8235300 > > The original patch went through the Oracle CCC process prior to the > creation of the public CSR process, so there’s no public CSR issue, > hence the release note JBS issue reference. > > Thanks, > > Paul >
Re: RFR 8235300: VM_HeapDumper hits assert with bad dump_len
Thanks for your review and updates, David. I've updated the CSR as you requested in its comments. Paul On 1/14/20, 5:12 PM, "David Holmes" wrote: Hi Paul, I made some minor updates to the CSR request and added myself as a reviewer. Thanks, David On 15/01/2020 10:00 am, Hohensee, Paul wrote: > Please review this CSR for a backport of JDK-8144732 to jdk8u. > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8144732 > > JBS release note issue: https://bugs.openjdk.java.net/browse/JDK-8174881 > > 8u backport JBS issue: https://bugs.openjdk.java.net/browse/JDK-8235299 > > 8u backport CSR: https://bugs.openjdk.java.net/browse/JDK-8235300 > > The original patch went through the Oracle CCC process prior to the > creation of the public CSR process, so there’s no public CSR issue, > hence the release note JBS issue reference. > > Thanks, > > Paul >
Re: RFR 8235300: VM_HeapDumper hits assert with bad dump_len
Hi Paul, I made some minor updates to the CSR request and added myself as a reviewer. Thanks, David On 15/01/2020 10:00 am, Hohensee, Paul wrote: Please review this CSR for a backport of JDK-8144732 to jdk8u. JBS issue: https://bugs.openjdk.java.net/browse/JDK-8144732 JBS release note issue: https://bugs.openjdk.java.net/browse/JDK-8174881 8u backport JBS issue: https://bugs.openjdk.java.net/browse/JDK-8235299 8u backport CSR: https://bugs.openjdk.java.net/browse/JDK-8235300 The original patch went through the Oracle CCC process prior to the creation of the public CSR process, so there’s no public CSR issue, hence the release note JBS issue reference. Thanks, Paul
