RE: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-03-02 Thread Langer, Christoph 
Thank you, Steven. I just took the bug.

Thanks Volker and Chris for reviewing.

I just posted in 8u-dev for approval...

Best regards
Christoph

> -Original Message-
> From: Stephen Fitch [mailto:stephen.fi...@oracle.com]
> Sent: Montag, 26. Februar 2018 21:31
> To: Chris Plummer ; Volker Simonis
> ; Langer, Christoph
> 
> Cc: serviceability-dev@openjdk.java.net
> Subject: Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug
> JDK 9 VM
> 
> Happy to see this get done (ahead of when I can get to it) feel
> free to take the JBS backport back into your name Christoph.
> 
> s.
> 
> On 2/26/18 11:22 AM, Chris Plummer wrote:
> > I'm not sure the old code was doing anything useful by essentially checking
> > for jdwpMajor == 0. When was it ever zero?
> >
> > Chris
> >
> > On 2/26/18 2:28 AM, Volker Simonis wrote:
> >> Hi Christoph,
> >>
> >> I think the new code is wrong for "jdwpMajor == 0", which was
> >> correctly handled before.
> >>
> >> But I'm not sure if that is relevant at all nowadays and taking into
> >> account that this is a verbatim downport from 9 I don't think we have
> >> to do better in 8u.
> >>
> >> Otherwise looks good from my side. Reviewed for 8u.
> >>
> >> Thank you and best regards,
> >> Volker
> >>
> >>
> >> On Thu, Feb 22, 2018 at 11:21 AM, Langer, Christoph
> >>  wrote:
> >>> Hi JDK 8 reviewers,
> >>>
> >>>
> >>>
> >>> I’d like to propose a fix for a backport of JDI changes that came with
> >>> modularization.
> >>>
> >>>
> >>>
> >>> Egor has brought this up in 8u-dev:
> >>> http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-
> February/007230.html
> >>>
> >>>
> >>>
> >>> The fix is straightforward and is used by Egor in JetBrains, as well as we
> >>> at SAP have this already patched for a while in our JDK8 port.
> >>>
> >>>
> >>>
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8197943
> >>>
> >>> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8197943.0/
> >>>
> >>>
> >>>
> >>> The build went through fine and jtreg tests are running.
> >>>
> >>>
> >>>
> >>> @Stephen: In the bug I read that you wanted to backport this. I hope
> this
> >>> matches your intentions. Otherwise I’d step back and wait for your
> proposal…

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-02-26 Thread Stephen Fitch 

Happy to see this get done (ahead of when I can get to it) feel
free to take the JBS backport back into your name Christoph.

s.

On 2/26/18 11:22 AM, Chris Plummer wrote:
I'm not sure the old code was doing anything useful by essentially checking 
for jdwpMajor == 0. When was it ever zero?


Chris

On 2/26/18 2:28 AM, Volker Simonis wrote:

Hi Christoph,

I think the new code is wrong for "jdwpMajor == 0", which was
correctly handled before.

But I'm not sure if that is relevant at all nowadays and taking into
account that this is a verbatim downport from 9 I don't think we have
to do better in 8u.

Otherwise looks good from my side. Reviewed for 8u.

Thank you and best regards,
Volker


On Thu, Feb 22, 2018 at 11:21 AM, Langer, Christoph
 wrote:

Hi JDK 8 reviewers,



I’d like to propose a fix for a backport of JDI changes that came with
modularization.



Egor has brought this up in 8u-dev:
http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-February/007230.html



The fix is straightforward and is used by Egor in JetBrains, as well as we
at SAP have this already patched for a while in our JDK8 port.



Bug: https://bugs.openjdk.java.net/browse/JDK-8197943

Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8197943.0/



The build went through fine and jtreg tests are running.



@Stephen: In the bug I read that you wanted to backport this. I hope this
matches your intentions. Otherwise I’d step back and wait for your proposal…

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-02-26 Thread Chris Plummer 
I'm not sure the old code was doing anything useful by essentially 
checking for jdwpMajor == 0. When was it ever zero?


Chris

On 2/26/18 2:28 AM, Volker Simonis wrote:

Hi Christoph,

I think the new code is wrong for "jdwpMajor == 0", which was
correctly handled before.

But I'm not sure if that is relevant at all nowadays and taking into
account that this is a verbatim downport from 9 I don't think we have
to do better in 8u.

Otherwise looks good from my side. Reviewed for 8u.

Thank you and best regards,
Volker


On Thu, Feb 22, 2018 at 11:21 AM, Langer, Christoph
 wrote:

Hi JDK 8 reviewers,



I’d like to propose a fix for a backport of JDI changes that came with
modularization.



Egor has brought this up in 8u-dev:
http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-February/007230.html



The fix is straightforward and is used by Egor in JetBrains, as well as we
at SAP have this already patched for a while in our JDK8 port.



Bug: https://bugs.openjdk.java.net/browse/JDK-8197943

Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8197943.0/



The build went through fine and jtreg tests are running.



@Stephen: In the bug I read that you wanted to backport this. I hope this
matches your intentions. Otherwise I’d step back and wait for your proposal…



Best regards

Christoph

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-02-26 Thread Volker Simonis 
Hi Christoph,

I think the new code is wrong for "jdwpMajor == 0", which was
correctly handled before.

But I'm not sure if that is relevant at all nowadays and taking into
account that this is a verbatim downport from 9 I don't think we have
to do better in 8u.

Otherwise looks good from my side. Reviewed for 8u.

Thank you and best regards,
Volker


On Thu, Feb 22, 2018 at 11:21 AM, Langer, Christoph
 wrote:
> Hi JDK 8 reviewers,
>
>
>
> I’d like to propose a fix for a backport of JDI changes that came with
> modularization.
>
>
>
> Egor has brought this up in 8u-dev:
> http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-February/007230.html
>
>
>
> The fix is straightforward and is used by Egor in JetBrains, as well as we
> at SAP have this already patched for a while in our JDK8 port.
>
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8197943
>
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8197943.0/
>
>
>
> The build went through fine and jtreg tests are running.
>
>
>
> @Stephen: In the bug I read that you wanted to backport this. I hope this
> matches your intentions. Otherwise I’d step back and wait for your proposal…
>
>
>
> Best regards
>
> Christoph
>
>