Re: RFR:8207048: jhsdb debugd cannot specify a port number

2018-07-14 Thread KUBOTA Yuji
Hi David and all,

My goal is we can set the port of RMI and RMI registry through command
line option in jhsdb debugd. So I want to create a CSR request of
JDK-8207048 which propose to change jhsdb command line option.

P.S.: I have never created a CSR request before. I'll need some time
to learn that.

Thanks,
Yuji

2018-07-12 10:40 GMT+09:00 KUBOTA Yuji :
> Hi David,
>
> Thank you for comment and updating JBS. I'll create a CSR request
> after getting comments whether this change is welcomed by community.
>
> Thanks,
> Yuji
>
> 2018-07-12 10:21 GMT+09:00 David Holmes :
>> Hi Yuji,
>>
>> I can't comment on the actual change proposed in this enhancement request,
>> but it will need to have a CSR request created and approved due to the use
>> of a new system property.
>>
>> Thanks,
>> David
>>
>>
>>
>>
>> On 11/07/2018 11:55 PM, KUBOTA Yuji wrote:
>>>
>>> Hi all,
>>>
>>> I filed bugzilla for small fix to improvement of `jhsdb debugd` to set
>>> a port of UnicastRemoteObject aka
>>> sun.jvm.hotspot.debugger.remote.RemoteDebuggerServer by
>>> `sun.jvm.hotspot.rmi.debugger.port`.
>>>
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8207048
>>> Webrev: http://cr.openjdk.java.net/~ykubota/8207048/webrev.00/
>>>
>>> We can set an RMI registry port of debugd server by
>>> `sun.jvm.hotspot.rmi.port`, but can not set a port of RemoteObject. So
>>> RemoteObject always uses an anonymous port. For security, we should
>>> not open ports widely to use debugd, so I want to fix.
>>>
>>> Could you review it?
>>>
>>> Thanks,
>>> Yuji
>>>
>>


Re: RFR:8207048: jhsdb debugd cannot specify a port number

2018-07-11 Thread KUBOTA Yuji
Hi David,

Thank you for comment and updating JBS. I'll create a CSR request
after getting comments whether this change is welcomed by community.

Thanks,
Yuji

2018-07-12 10:21 GMT+09:00 David Holmes :
> Hi Yuji,
>
> I can't comment on the actual change proposed in this enhancement request,
> but it will need to have a CSR request created and approved due to the use
> of a new system property.
>
> Thanks,
> David
>
>
>
>
> On 11/07/2018 11:55 PM, KUBOTA Yuji wrote:
>>
>> Hi all,
>>
>> I filed bugzilla for small fix to improvement of `jhsdb debugd` to set
>> a port of UnicastRemoteObject aka
>> sun.jvm.hotspot.debugger.remote.RemoteDebuggerServer by
>> `sun.jvm.hotspot.rmi.debugger.port`.
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8207048
>> Webrev: http://cr.openjdk.java.net/~ykubota/8207048/webrev.00/
>>
>> We can set an RMI registry port of debugd server by
>> `sun.jvm.hotspot.rmi.port`, but can not set a port of RemoteObject. So
>> RemoteObject always uses an anonymous port. For security, we should
>> not open ports widely to use debugd, so I want to fix.
>>
>> Could you review it?
>>
>> Thanks,
>> Yuji
>>
>


Re: RFR:8207048: jhsdb debugd cannot specify a port number

2018-07-11 Thread David Holmes

Hi Yuji,

I can't comment on the actual change proposed in this enhancement 
request, but it will need to have a CSR request created and approved due 
to the use of a new system property.


Thanks,
David



On 11/07/2018 11:55 PM, KUBOTA Yuji wrote:

Hi all,

I filed bugzilla for small fix to improvement of `jhsdb debugd` to set
a port of UnicastRemoteObject aka
sun.jvm.hotspot.debugger.remote.RemoteDebuggerServer by
`sun.jvm.hotspot.rmi.debugger.port`.

Issue: https://bugs.openjdk.java.net/browse/JDK-8207048
Webrev: http://cr.openjdk.java.net/~ykubota/8207048/webrev.00/

We can set an RMI registry port of debugd server by
`sun.jvm.hotspot.rmi.port`, but can not set a port of RemoteObject. So
RemoteObject always uses an anonymous port. For security, we should
not open ports widely to use debugd, so I want to fix.

Could you review it?

Thanks,
Yuji