RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-12 Thread Doug Simon 
Please review this change that removes the existing Graal service provider for 
hooking into the Platform MBean Server and makes 
jdk.internal.vm.compiler.management an upgradeable module.

Please refer to 
https://bugs.openjdk.java.net/browse/JDK-8187490?focusedCommentId=14170942=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14170942
 for discussion on the latter point.

The Graal changes that dynamically register an MBean for accessing Graal will 
be part of a subsequent Graal update.

http://cr.openjdk.java.net/~dnsimon/8187490/

-Doug

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-12 Thread David Holmes 

Hi Doug,

Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with 
this ???


Thanks,
David

On 13/04/2018 4:24 AM, Doug Simon wrote:

Please review this change that removes the existing Graal service provider for 
hooking into the Platform MBean Server and makes 
jdk.internal.vm.compiler.management an upgradeable module.

Please refer to 
https://bugs.openjdk.java.net/browse/JDK-8187490?focusedCommentId=14170942=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14170942
 for discussion on the latter point.

The Graal changes that dynamically register an MBean for accessing Graal will 
be part of a subsequent Graal update.

http://cr.openjdk.java.net/~dnsimon/8187490/

-Doug

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-12 Thread mandy chung 



On 4/13/18 2:24 AM, Doug Simon wrote:

Please review this change that removes the existing Graal service provider for 
hooking into the Platform MBean Server and makes 
jdk.internal.vm.compiler.management an upgradeable module.

Please refer to 
https://bugs.openjdk.java.net/browse/JDK-8187490?focusedCommentId=14170942=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14170942
 for discussion on the latter point.

The Graal changes that dynamically register an MBean for accessing Graal will 
be part of a subsequent Graal update.

http://cr.openjdk.java.net/~dnsimon/8187490/




This looks okay.   jdk.internal.vm.compiler.management will become empty 
until the next Graal update and I guess this makes it easier to make 
Graal change in the upstream project.   This is fine with me.


Mandy

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-12 Thread Igor Veresov 
Looks good to me.

igor

> On Apr 12, 2018, at 11:24 AM, Doug Simon  wrote:
> 
> Please review this change that removes the existing Graal service provider 
> for hooking into the Platform MBean Server and makes 
> jdk.internal.vm.compiler.management an upgradeable module.
> 
> Please refer to 
> https://bugs.openjdk.java.net/browse/JDK-8187490?focusedCommentId=14170942=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14170942
>  for discussion on the latter point.
> 
> The Graal changes that dynamically register an MBean for accessing Graal will 
> be part of a subsequent Graal update.
> 
> http://cr.openjdk.java.net/~dnsimon/8187490/
> 
> -Doug