[jira] Commented: (SOLR-142) RawResponseWriter - replace /admin/get-file.jsp
[ https://issues.apache.org/jira/browse/SOLR-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470729 ] Hoss Man commented on SOLR-142: --- Ryan, i really like the idea of a RawResponseWriter, and your GetAdminFileRequestHandler ... for a hwile now i've been thinking that it would be good to change the admin/gettableFiles section of hte solrconfig so that... * files could have a default content-type specified * direcotries could be listed (with a content-type to assume for all files in that directory) ...and then replace get-file.jsp with a servlet that used the extra path info to find the filename, and supported query args to override the default content-type with text/plain my motivation being to help with things like SOLR-75 where we sometimes need the schema as XML, but othertimes we want to return it as plain text ... and to let the XmlResponseWriter start supporting useful params telling it what stylesheet from the xslt directory to include in the response (for client site styling using a stylesheet served from the solr server) -- but i like your idea of a RequestHandler/ResponseWriter better. we should consier deprecating admin/gettableFiles completley, and moving the info about what file are gettable directly into the init params for the GetAdminFileRequestHandler (where it can also support the content-type/direcotry stuff that i described) in that case, we'd need to leave get-files.jsp where it is, so something still supports the legacy admin/gettableFiles list of files. > RawResponseWriter - replace /admin/get-file.jsp > --- > > Key: SOLR-142 > URL: https://issues.apache.org/jira/browse/SOLR-142 > Project: Solr > Issue Type: Improvement > Components: web gui >Reporter: Ryan McKinley >Priority: Trivial > Attachments: SOLR-142-RawResponseWriter.patch > > > A RawResponseWriter writes a ContentStream directly to the response. > This is useful to spit back a file directly from solr. This implementation > looks for a response property named "content" and sends it to the client. If > it can't find one, it delegates the response to another ResponseWriter. > As an example, I added a GetAdminFileRequestHandler to replace > /admin/get-file.jsp -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-143) Support for PMD and Clover
[ https://issues.apache.org/jira/browse/SOLR-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470721 ] Hoss Man commented on SOLR-143: --- my thinking is that initially PMD would be a completely optional step, which committers are encouraged to run before committing, and which the nightly build runs with the "serious" threshold low enough that only extreme rules cause a build failure. ... the main goal would be having a report on the live site showing where in the nightly builds questionable behavior is (mush as the goal of clover is to have the reports about hte nightlies to see where we need more test coverage) i agree -- it PMD shouldn't be mandatory just to build Solr. I can't make any specific comments about PMD being better then the tools that various IDEs have ... as i understand it many IDEs use either PMD or FindBugs ... my goal was just to have something that could be run as part of theautomated builds. (by all means: people using IDEs with code inspectors should run them and fix anything that looks suspicious) > Support for PMD and Clover > -- > > Key: SOLR-143 > URL: https://issues.apache.org/jira/browse/SOLR-143 > Project: Solr > Issue Type: Improvement >Reporter: Hoss Man >Priority: Minor > Attachments: pmd-and-clover.diff > > > had some time on a plane this weekend, so I adapted some of the clover hooks > from Java-Lucene to Solr's build.xml and also put in hooks for running PMD (a > bug pattern finding tool). > the PMD hook actually teste the PMD ruleset twice, once warning about any > violations, and once failing the build if any serious violations were found > ... the goal would be to hook this into the "ant test" target so you can't > successfully build if you have any serious rule violations. > i strarted with a custom ruleset based on some of the bigger rules from PMD > ... the theory being that as well clean up the code base we can add more > nit-picky rules if we want to :) > User is required to provide their own copy of PMD and/or clover on in an > ANT_LIB. Clover requires (ASF committer) license, PMD is freely available... > http://pmd.sourceforge.net/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-69) PATCH:MoreLikeThis support
[ https://issues.apache.org/jira/browse/SOLR-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470690 ] Erik Hatcher commented on SOLR-69: -- In Collex, we do more-like-this on a single object not within search results. A separate handler would be sufficient for our current needs and avoid the other handlers from becoming overloaded with options. Highlighting is not needed on MLT documents in our case. > PATCH:MoreLikeThis support > -- > > Key: SOLR-69 > URL: https://issues.apache.org/jira/browse/SOLR-69 > Project: Solr > Issue Type: Improvement > Components: search >Reporter: Bertrand Delacretaz >Priority: Minor > Attachments: lucene-queries-2.0.0.jar, SOLR-69.patch, SOLR-69.patch, > SOLR-69.patch > > > Here's a patch that implements simple support of Lucene's MoreLikeThis class. > The MoreLikeThisHelper code is heavily based on (hmm..."lifted from" might be > more appropriate ;-) Erik Hatcher's example mentioned in > http://www.mail-archive.com/solr-user@lucene.apache.org/msg00878.html > To use it, add at least the following parameters to a standard or dismax > query: > mlt=true > mlt.fl=list,of,fields,which,define,similarity > See the MoreLikeThisHelper source code for more parameters. > Here are two URLs that work with the example config, after loading all > documents found in exampledocs in the index (just to show that it seems to > work - of course you need a larger corpus to make it interesting): > http://localhost:8983/solr/select/?stylesheet=&q=apache&qt=standard&mlt=true&mlt.fl=manu,cat&mlt.mindf=1&mlt.mindf=1&fl=id,score > http://localhost:8983/solr/select/?stylesheet=&q=apache&qt=dismax&mlt=true&mlt.fl=manu,cat&mlt.mindf=1&mlt.mindf=1&fl=id,score > Results are added to the output like this: > > ... > > > > 1.5293242 > SOLR1000 > > > > > 1.5293242 > UTF8TEST > > > > I haven't tested this extensively yet, will do in the next few days. But > comments are welcome of course. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-69) PATCH:MoreLikeThis support
[ https://issues.apache.org/jira/browse/SOLR-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470660 ] Bertrand Delacretaz commented on SOLR-69: - Making this a separate handler would probably make the code easier to understand, but the current code makes case 2) easier, while making case 1) easy as well (just query on the document's unique ID, with MoreLikeThis enabled). I'm for keeping it as is, integrated in the handlers as an option. If someone needs it as a separate handler, it wouldn't be hard to factor our the common parts. I have no strong feelings, however, as I built this patch to experiment with this feature but I'm not using it yet. > PATCH:MoreLikeThis support > -- > > Key: SOLR-69 > URL: https://issues.apache.org/jira/browse/SOLR-69 > Project: Solr > Issue Type: Improvement > Components: search >Reporter: Bertrand Delacretaz >Priority: Minor > Attachments: lucene-queries-2.0.0.jar, SOLR-69.patch, SOLR-69.patch, > SOLR-69.patch > > > Here's a patch that implements simple support of Lucene's MoreLikeThis class. > The MoreLikeThisHelper code is heavily based on (hmm..."lifted from" might be > more appropriate ;-) Erik Hatcher's example mentioned in > http://www.mail-archive.com/solr-user@lucene.apache.org/msg00878.html > To use it, add at least the following parameters to a standard or dismax > query: > mlt=true > mlt.fl=list,of,fields,which,define,similarity > See the MoreLikeThisHelper source code for more parameters. > Here are two URLs that work with the example config, after loading all > documents found in exampledocs in the index (just to show that it seems to > work - of course you need a larger corpus to make it interesting): > http://localhost:8983/solr/select/?stylesheet=&q=apache&qt=standard&mlt=true&mlt.fl=manu,cat&mlt.mindf=1&mlt.mindf=1&fl=id,score > http://localhost:8983/solr/select/?stylesheet=&q=apache&qt=dismax&mlt=true&mlt.fl=manu,cat&mlt.mindf=1&mlt.mindf=1&fl=id,score > Results are added to the output like this: > > ... > > > > 1.5293242 > SOLR1000 > > > > > 1.5293242 > UTF8TEST > > > > I haven't tested this extensively yet, will do in the next few days. But > comments are welcome of course. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-69) PATCH:MoreLikeThis support
[ https://issues.apache.org/jira/browse/SOLR-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470652 ] Yonik Seeley commented on SOLR-69: -- Should this be an integrated part of the standard/dismax handlers, or should it be a separate request handler? I guess the answer would depend on how it's used mos of the time: Case 1) The GUI queries the standard request handler and displays a list of documents with a little "more-like-this" button next to each document. When pressed, the GUI queries the more-like-this handler with the specific document id, and then displays the results to the user. Case 2) The GUI queries the standard request handler to display a list of documents, with a sub-list of similar "mlt" documents automatically displayed under each. Or, those lists could be collapsed by default, but instantly displayed since the GUI already has the info. If case (2) were rare, then perhaps mlt should be a separate handler. Case (2) can still be done, it would just require more requests from the GUI to do it. In either case, will highlighting be desired on any of the mlt docs? Other thoughts? > PATCH:MoreLikeThis support > -- > > Key: SOLR-69 > URL: https://issues.apache.org/jira/browse/SOLR-69 > Project: Solr > Issue Type: Improvement > Components: search >Reporter: Bertrand Delacretaz >Priority: Minor > Attachments: lucene-queries-2.0.0.jar, SOLR-69.patch, SOLR-69.patch, > SOLR-69.patch > > > Here's a patch that implements simple support of Lucene's MoreLikeThis class. > The MoreLikeThisHelper code is heavily based on (hmm..."lifted from" might be > more appropriate ;-) Erik Hatcher's example mentioned in > http://www.mail-archive.com/solr-user@lucene.apache.org/msg00878.html > To use it, add at least the following parameters to a standard or dismax > query: > mlt=true > mlt.fl=list,of,fields,which,define,similarity > See the MoreLikeThisHelper source code for more parameters. > Here are two URLs that work with the example config, after loading all > documents found in exampledocs in the index (just to show that it seems to > work - of course you need a larger corpus to make it interesting): > http://localhost:8983/solr/select/?stylesheet=&q=apache&qt=standard&mlt=true&mlt.fl=manu,cat&mlt.mindf=1&mlt.mindf=1&fl=id,score > http://localhost:8983/solr/select/?stylesheet=&q=apache&qt=dismax&mlt=true&mlt.fl=manu,cat&mlt.mindf=1&mlt.mindf=1&fl=id,score > Results are added to the output like this: > > ... > > > > 1.5293242 > SOLR1000 > > > > > 1.5293242 > UTF8TEST > > > > I haven't tested this extensively yet, will do in the next few days. But > comments are welcome of course. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-122) Add optional support for Ruby-libxml2 (vs. REXML)
[ https://issues.apache.org/jira/browse/SOLR-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470650 ] Coda Hale commented on SOLR-122: Thanks, Erik! I didn't refactor Solr::Response::Xml mainly because it's much harder -- REXML's XPath support is, um, unique and special like a snowflake, so it's more than just making the method profiles line up. I figured eventually I or someone else would write Solr::XML::Parser, then have that run either REXML or libxml-ruby, depending on what loaded. I'll open another issue when it comes to that. ;-) > Add optional support for Ruby-libxml2 (vs. REXML) > - > > Key: SOLR-122 > URL: https://issues.apache.org/jira/browse/SOLR-122 > Project: Solr > Issue Type: Improvement > Components: clients - ruby - flare >Reporter: Coda Hale > Attachments: libxml.rb, libxml.rb, solrb_libxml_support.diff > > > This file adds drop-in support for the ruby-libxml2, which is a wrapper for > the libxml2 library, which is an order of magnitude or so faster than REXML. > This depends on my SOLR-121 patch for multi-document adds, since the behavior > of Solr::Request::AddDocument#to_s is different. > Requiring this makes some tests fail, but for trivial reasons: some tests are > directly tied to REXML, others fail due to interelement whitespace added by > libxml2 (which you can't disable via the Ruby interface). Functionally, it's > identical, and passes all functional tests. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-143) Support for PMD and Clover
[ https://issues.apache.org/jira/browse/SOLR-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470614 ] Yonik Seeley commented on SOLR-143: --- While checking is nice, I'm not sure about requiring PMD before you can build Solr. Is PMD better than the code inspections in IntelliJ/Eclipse? > Support for PMD and Clover > -- > > Key: SOLR-143 > URL: https://issues.apache.org/jira/browse/SOLR-143 > Project: Solr > Issue Type: Improvement >Reporter: Hoss Man >Priority: Minor > Attachments: pmd-and-clover.diff > > > had some time on a plane this weekend, so I adapted some of the clover hooks > from Java-Lucene to Solr's build.xml and also put in hooks for running PMD (a > bug pattern finding tool). > the PMD hook actually teste the PMD ruleset twice, once warning about any > violations, and once failing the build if any serious violations were found > ... the goal would be to hook this into the "ant test" target so you can't > successfully build if you have any serious rule violations. > i strarted with a custom ruleset based on some of the bigger rules from PMD > ... the theory being that as well clean up the code base we can add more > nit-picky rules if we want to :) > User is required to provide their own copy of PMD and/or clover on in an > ANT_LIB. Clover requires (ASF committer) license, PMD is freely available... > http://pmd.sourceforge.net/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-144) Harmonizing different XML technologies and their usage in Solr
Harmonizing different XML technologies and their usage in Solr -- Key: SOLR-144 URL: https://issues.apache.org/jira/browse/SOLR-144 Project: Solr Issue Type: Task Reporter: Thorsten Scherler Resulting out of some comments in SOLR-133, we should harmonize our usage of different xml technologies. IMO we should move to StAX, since it is an upcoming standard and in comparison to SAX easier to use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-113) Some example + post.sh in docs in client/solrb
[ https://issues.apache.org/jira/browse/SOLR-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher resolved SOLR-113. --- Resolution: Fixed Antonio - thanks for the comments! I'll close this issue per your request, but rest assured we'll get more samples added, and documentation bulked up. > Some example + post.sh in docs in client/solrb > -- > > Key: SOLR-113 > URL: https://issues.apache.org/jira/browse/SOLR-113 > Project: Solr > Issue Type: Wish > Components: clients - ruby - flare > Environment: OSX 10.4 >Reporter: Antonio Eggberg >Priority: Trivial > > I tried flare today really nice :=) > It would be nice to add some example docs like current Solr distro for the > Ruby/Flare client.. If I understand correctly the exampledocs in Solr i.e > /example/exampledocs is not compatible with solrb.. Maybe I am doing > something wrong? if so please clarify and delete the issue. The issue is not > so important but good for the folks that are impetiant. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-122) Add optional support for Ruby-libxml2 (vs. REXML)
[ https://issues.apache.org/jira/browse/SOLR-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Hatcher resolved SOLR-122. --- Resolution: Fixed Coda - nicely done! I've committed this. There are still some uses of REXML directly left over in the response classes. Should these be adjusted to use Solr::XML also? Is so, and you want to tackle it, let's open a new issue. Thanks for this contribution! > Add optional support for Ruby-libxml2 (vs. REXML) > - > > Key: SOLR-122 > URL: https://issues.apache.org/jira/browse/SOLR-122 > Project: Solr > Issue Type: Improvement > Components: clients - ruby - flare >Reporter: Coda Hale > Attachments: libxml.rb, libxml.rb, solrb_libxml_support.diff > > > This file adds drop-in support for the ruby-libxml2, which is a wrapper for > the libxml2 library, which is an order of magnitude or so faster than REXML. > This depends on my SOLR-121 patch for multi-document adds, since the behavior > of Solr::Request::AddDocument#to_s is different. > Requiring this makes some tests fail, but for trivial reasons: some tests are > directly tied to REXML, others fail due to interelement whitespace added by > libxml2 (which you can't disable via the Ruby interface). Functionally, it's > identical, and passes all functional tests. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r504071 - /lucene/solr/trunk/client/ruby/solrb/lib/solr/connection.rb
Oh, and adding support for the indexinfo request handler. Erik On Feb 6, 2007, at 5:47 AM, [EMAIL PROTECTED] wrote: Author: ehatcher Date: Tue Feb 6 02:47:24 2007 New Revision: 504071 URL: http://svn.apache.org/viewvc?view=rev&rev=504071 Log: removing superfluous return statements Modified: lucene/solr/trunk/client/ruby/solrb/lib/solr/connection.rb Modified: lucene/solr/trunk/client/ruby/solrb/lib/solr/connection.rb URL: http://svn.apache.org/viewvc/lucene/solr/trunk/client/ruby/ solrb/lib/solr/connection.rb?view=diff&rev=504071&r1=504070&r2=504071 == --- lucene/solr/trunk/client/ruby/solrb/lib/solr/connection.rb (original) +++ lucene/solr/trunk/client/ruby/solrb/lib/solr/connection.rb Tue Feb 6 02:47:24 2007 @@ -114,21 +114,25 @@ def delete(document_id) response = send(Solr::Request::Delete.new(:id => document_id)) commit if @autocommit -return response.ok? +response.ok? end # delete using a query def delete_by_query(query) response = send(Solr::Request::Delete.new(:query => query)) commit if @autocommit -return response.ok? +response.ok? end - + + def info +send(Solr::Request::IndexInfo.new) + end + # send a given Solr::Request and return a RubyResponse or XmlResponse # depending on the type of request def send(request) data = post(request) -return Solr::Response::Base.make_response(request, data) +Solr::Response::Base.make_response(request, data) end # send the http post request to solr; for convenience there are shortcuts
[jira] Commented: (SOLR-84) New Solr logo?
[ https://issues.apache.org/jira/browse/SOLR-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470513 ] Thorsten Scherler commented on SOLR-84: --- >From the logo grid, b (all capital letter and same size). > New Solr logo? > -- > > Key: SOLR-84 > URL: https://issues.apache.org/jira/browse/SOLR-84 > Project: Solr > Issue Type: Improvement >Reporter: Bertrand Delacretaz >Priority: Minor > Attachments: logo-grid.jpg, logo-solr-d.jpg, logo-solr-e.jpg, > logo-solr-source-files-take2.zip, solr-84-source-files.zip, > solr-logo-20061214.jpg, solr-logo-20061218.JPG, solr-logo-20070124.JPG, > solr.jpg, solr.jpg > > > Following up on SOLR-76, our trainee Nicolas Barbay (nicolas (put at here) > sarraux-dessous.ch) has reworked his logo proposal to be more "solar". > This can either be the start of a logo contest, or if people like it we could > adopt it. The gradients can make it a bit hard to integrate, not sure if this > is really a problem. > WDYT? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-143) Support for PMD and Clover
[ https://issues.apache.org/jira/browse/SOLR-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-143: -- Attachment: pmd-and-clover.diff this patch includes some XSLT/javascript from the PMD 3.9 release so i'm not granting lcense for inclusion until i double check that is viable. > Support for PMD and Clover > -- > > Key: SOLR-143 > URL: https://issues.apache.org/jira/browse/SOLR-143 > Project: Solr > Issue Type: Improvement >Reporter: Hoss Man >Priority: Minor > Attachments: pmd-and-clover.diff > > > had some time on a plane this weekend, so I adapted some of the clover hooks > from Java-Lucene to Solr's build.xml and also put in hooks for running PMD (a > bug pattern finding tool). > the PMD hook actually teste the PMD ruleset twice, once warning about any > violations, and once failing the build if any serious violations were found > ... the goal would be to hook this into the "ant test" target so you can't > successfully build if you have any serious rule violations. > i strarted with a custom ruleset based on some of the bigger rules from PMD > ... the theory being that as well clean up the code base we can add more > nit-picky rules if we want to :) > User is required to provide their own copy of PMD and/or clover on in an > ANT_LIB. Clover requires (ASF committer) license, PMD is freely available... > http://pmd.sourceforge.net/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (SOLR-143) Support for PMD and Clover
Support for PMD and Clover -- Key: SOLR-143 URL: https://issues.apache.org/jira/browse/SOLR-143 Project: Solr Issue Type: Improvement Reporter: Hoss Man Priority: Minor had some time on a plane this weekend, so I adapted some of the clover hooks from Java-Lucene to Solr's build.xml and also put in hooks for running PMD (a bug pattern finding tool). the PMD hook actually teste the PMD ruleset twice, once warning about any violations, and once failing the build if any serious violations were found ... the goal would be to hook this into the "ant test" target so you can't successfully build if you have any serious rule violations. i strarted with a custom ruleset based on some of the bigger rules from PMD ... the theory being that as well clean up the code base we can add more nit-picky rules if we want to :) User is required to provide their own copy of PMD and/or clover on in an ANT_LIB. Clover requires (ASF committer) license, PMD is freely available... http://pmd.sourceforge.net/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
