[jira] Commented: (SOLR-267) log handler + query + hits
[ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520691 ] Hoss Man commented on SOLR-267: --- format looks fine to me, some minor nits from a quick skim of the patch... 1) "protected NamedList toLog" should have some javadocs. 2) "public NamedList getResponseHeader()" seems to have incorrect javadocs 3) I'm pretty sure the use HttpServletResponse.addHeader in SolrDispatchFilter requires that the header names not contains spaces ... that's not something currently guaranteed by solrRsp.getResponseHeader() 4) although the odds of the ClassCastException in SolrDispatchFilter asymptotically approach zero, it should still be logged properly instead of using cce.printStackTrace() > log handler + query + hits > -- > > Key: SOLR-267 > URL: https://issues.apache.org/jira/browse/SOLR-267 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 1.3 >Reporter: Will Johnson >Priority: Minor > Fix For: 1.3 > > Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, > LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, > LogQueryHitCounts.patch, LogQueryHitCounts.patch > > > adds a logger to log handler, query string and hit counts for each query -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-267) log handler + query + hits
[ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520633 ] Yonik Seeley commented on SOLR-267: --- So what do people think of the logging format? Any objections? > log handler + query + hits > -- > > Key: SOLR-267 > URL: https://issues.apache.org/jira/browse/SOLR-267 > Project: Solr > Issue Type: Improvement > Components: search >Affects Versions: 1.3 >Reporter: Will Johnson >Priority: Minor > Fix For: 1.3 > > Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, > LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, > LogQueryHitCounts.patch, LogQueryHitCounts.patch > > > adds a logger to log handler, query string and hit counts for each query -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-139) Support updateable/modifiable documents
[ https://issues.apache.org/jira/browse/SOLR-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520554 ] Erik Hatcher commented on SOLR-139: --- I'm experimenting with this patch with tagging. I'm modeling the fields in this way, beyond general document metadata fields: _tags usernames And copyFielding *_tags into "tags". usernames field allows seeing all users who have tagged documents. Users are allowed to "uncollect" an object, which would remove the _tags field and remove their name from the usernames field. Removing the _tags field use case is covered with the _tags:OVERWRITE mode. But removing a username from the multiValued and non-duplicating usernames field is not. An example (from some conversations with Ryan): id: 10 usernames: ryan, erik You want to be able to remove 'ryan' but keep 'erik'. Perhaps we need to add a 'REMOVE' mode to remove the first (all?) matching values /update?mode=OVERWRITE,username=REMOVE id=10, usernames=ryan and make the output: id: 10 usernames: erik But what about duplicate values? > Support updateable/modifiable documents > --- > > Key: SOLR-139 > URL: https://issues.apache.org/jira/browse/SOLR-139 > Project: Solr > Issue Type: Improvement > Components: update >Reporter: Ryan McKinley >Assignee: Ryan McKinley > Attachments: getStoredFields.patch, getStoredFields.patch, > getStoredFields.patch, getStoredFields.patch, getStoredFields.patch, > SOLR-139-IndexDocumentCommand.patch, SOLR-139-IndexDocumentCommand.patch, > SOLR-139-IndexDocumentCommand.patch, SOLR-139-IndexDocumentCommand.patch, > SOLR-139-IndexDocumentCommand.patch, SOLR-139-IndexDocumentCommand.patch, > SOLR-139-IndexDocumentCommand.patch, SOLR-139-IndexDocumentCommand.patch, > SOLR-139-IndexDocumentCommand.patch, SOLR-139-IndexDocumentCommand.patch, > SOLR-139-IndexDocumentCommand.patch, SOLR-139-ModifyInputDocuments.patch, > SOLR-139-ModifyInputDocuments.patch, SOLR-139-ModifyInputDocuments.patch, > SOLR-139-ModifyInputDocuments.patch, SOLR-139-XmlUpdater.patch, > SOLR-269+139-ModifiableDocumentUpdateProcessor.patch > > > It would be nice to be able to update some fields on a document without > having to insert the entire document. > Given the way lucene is structured, (for now) one can only modify stored > fields. > While we are at it, we can support incrementing an existing value - I think > this only makes sense for numbers. > for background, see: > http://www.nabble.com/loading-many-documents-by-ID-tf3145666.html#a8722293 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-281) Search Components (plugins)
[ https://issues.apache.org/jira/browse/SOLR-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharad Agarwal updated SOLR-281: Attachment: SOLR-281-SearchComponents.patch Fixed the patch to work with the trunk. > Search Components (plugins) > --- > > Key: SOLR-281 > URL: https://issues.apache.org/jira/browse/SOLR-281 > Project: Solr > Issue Type: New Feature >Reporter: Ryan McKinley > Attachments: SOLR-281-SearchComponents.patch, > SOLR-281-SearchComponents.patch, SOLR-281-SearchComponents.patch, > SOLR-281-SearchComponents.patch > > > A request handler with pluggable search components for things like: > - standard > - dismax > - more-like-this > - highlighting > - field collapsing > For more discussion, see: > http://www.nabble.com/search-components-%28plugins%29-tf3898040.html#a11050274 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
