[jira] Updated: (SOLR-1396) standardize the updateprocessorchain syntax
[
https://issues.apache.org/jira/browse/SOLR-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-1396:
-
Affects Version/s: 1.3
Fix Version/s: (was: 1.5)
1.4
standardize the updateprocessorchain syntax
---
Key: SOLR-1396
URL: https://issues.apache.org/jira/browse/SOLR-1396
Project: Solr
Issue Type: Improvement
Affects Versions: 1.3
Reporter: Noble Paul
Fix For: 1.4
updateprocessorChain follows a non-standard syntax in solr . Usually, all the
components are initialized as top level components and they are assembled and
used using a NamedList syntax .for example search components.
I propose to change it as follows
{code:xml}
updateRequestProcessorChain name=custom
class=solr.UpdateRequestProcessorChain
arr name=chain
strcustom/str
strrunUpdate/str
strlog/str
/arr
/updateRequestProcessorChain
updateProcessor name=custom
class=solr.CustomUpdateRequestProcessorFactory
lst name=name
str name=n1x1/str
str name=n2x2/str
/lst
/updateProcessor
updateProcessor name=runUpdate class=solr.RunUpdateProcessorFactory /
updateProcessor name=log class=solr.LogUpdateProcessorFactory /
{code}
The wiki documentation says this was supposed to be reviewed. If possible we
should clean it up in 1.4 itself. We can support the old syntax too
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1396) standardize the updateprocessorchain syntax
[
https://issues.apache.org/jira/browse/SOLR-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-1396.
--
Resolution: Won't Fix
with SOLR-1326 this kind of syntax is now standard for any type of plugin . so
no changes required
standardize the updateprocessorchain syntax
---
Key: SOLR-1396
URL: https://issues.apache.org/jira/browse/SOLR-1396
Project: Solr
Issue Type: Improvement
Affects Versions: 1.3
Reporter: Noble Paul
Fix For: 1.5
updateprocessorChain follows a non-standard syntax in solr . Usually, all the
components are initialized as top level components and they are assembled and
used using a NamedList syntax .for example search components.
I propose to change it as follows
{code:xml}
updateRequestProcessorChain name=custom
class=solr.UpdateRequestProcessorChain
arr name=chain
strcustom/str
strrunUpdate/str
strlog/str
/arr
/updateRequestProcessorChain
updateProcessor name=custom
class=solr.CustomUpdateRequestProcessorFactory
lst name=name
str name=n1x1/str
str name=n2x2/str
/lst
/updateProcessor
updateProcessor name=runUpdate class=solr.RunUpdateProcessorFactory /
updateProcessor name=log class=solr.LogUpdateProcessorFactory /
{code}
The wiki documentation says this was supposed to be reviewed. If possible we
should clean it up in 1.4 itself. We can support the old syntax too
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1326) New interface PluginInfoInitialized
[
https://issues.apache.org/jira/browse/SOLR-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-1326.
--
Resolution: Fixed
committed r817165
New interface PluginInfoInitialized
---
Key: SOLR-1326
URL: https://issues.apache.org/jira/browse/SOLR-1326
Project: Solr
Issue Type: Improvement
Affects Versions: 1.3
Reporter: Noble Paul
Assignee: Noble Paul
Fix For: 1.4
Attachments: SOLR-1326.patch, SOLR-1326.patch, SOLR-1326.patch
There is no way for a plugin to know the information of the attributes
mentioned in the tag itself (like name). We should have a new interface to
initialize with PluginInfo such as
{code:java}
public interface PluginInfoInitialized{
public void init(PluginInfo pluginInfo);
}
{code}
The PluginInfo class has been enhanced to allow sub components as well. So
the current syntax of UpdateprocessorChain/highlighter can also be supported
by implementing this interface .
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1447) Simple property injection
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12757827#action_12757827 ] Noble Paul commented on SOLR-1447: -- Jason .I am fine with this. I plan to commit this shortly Simple property injection -- Key: SOLR-1447 URL: https://issues.apache.org/jira/browse/SOLR-1447 Project: Solr Issue Type: Improvement Components: update Affects Versions: 1.4 Reporter: Jason Rutherglen Assignee: Noble Paul Priority: Trivial Fix For: 1.4 Attachments: SOLR-1447.patch, SOLR-1447.patch Original Estimate: 48h Remaining Estimate: 48h MergePolicy and MergeScheduler require property injection. We'll allow these and probably other cases in this patch using Java reflection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1447) Simple property injection
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-1447: - Attachment: SOLR-1447.patch all the conf files needed to be modified for this Simple property injection -- Key: SOLR-1447 URL: https://issues.apache.org/jira/browse/SOLR-1447 Project: Solr Issue Type: Improvement Components: update Affects Versions: 1.4 Reporter: Jason Rutherglen Assignee: Noble Paul Priority: Trivial Fix For: 1.4 Attachments: SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch Original Estimate: 48h Remaining Estimate: 48h MergePolicy and MergeScheduler require property injection. We'll allow these and probably other cases in this patch using Java reflection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [Solr Wiki] Update of DataImportHandler by NoblePaul
the wiki screwed up the page. It has chopped off most of the content
and now i am unable to roll it back to the previous version (208).
On Mon, Sep 21, 2009 at 2:50 PM, Apache Wiki wikidi...@apache.org wrote:
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Solr Wiki for change
notification.
The DataImportHandler page has been changed by NoblePaul:
http://wiki.apache.org/solr/DataImportHandler?action=diffrev1=208rev2=209
{{{
dataSource type=JdbcDataSource driver=com.mysql.jdbc.Driver
url=jdbc:mysql://localhost/dbname user=db_username
password=db_password/
}}}
- * The datasource configuration can also be done in solr config xml
[[#solrconfigdatasource]]
* The attribute 'type' specifies the implementation class. It is optional.
The default value is `'JdbcDataSource'`
* The attribute 'name' can be used if there are [[#multipleds|multiple
datasources]] used by multiple entities
* All other attributes in the dataSource tag are specific to the
particular dataSource implementation being configured.
@@ -679, +678 @@
{{{
requestHandler name=/dataimport
class=org.apache.solr.handler.dataimport.DataImportHandler
+ lst na0D
- lst name=defaults
- str name=configdata-config.xml/str
- /lst
- lst name=invariants
- !-- Pass through the prefix which needs stripped from
- an absolute disk path to give an absolute web path --
- str name=img_installdir/usr/local/apache2/htdocs/str
- /lst
- /requestHandler
- }}}
-
-
- {{{
- dataConfig
- dataSource name=myfilereader type=FileDataSource/
- document
- entity name=jc rootEntity=false dataSource=null
- processor=FileListEntityProcessor
- fileName=^.*\.xml$ recursive=true
- baseDir=/usr/local/apache2/htdocs/imagery
-
- entity name=xrootEntity=true
- dataSource=myfilereader
- processor=XPathEntityProcessor
- url=${jc.fileAbsolutePath}
- stream=false forEach=/mediaBlock
-
transformer=DateFormatTransformer,TemplateTransformer,RegexTransformer,LogTransformer
- logTemplate= processing ${jc.fileAbsolutePath}
- logLevel=info
-
-
- field column=fileAbsPath template=${jc.fileAbsolutePath}
/
-
- field column=fileWebPath template=${x.fileAbsolutePath}
-
regex=${dataimporter.request.img_installdir}(.*) replaceWith=$1/
-
- field column=fileWebDir regex=^(.*)/.* replaceWith=$1
sourceColName=fileWebPath/
-
- field column=imgFilename xpath=/mediaBlock/@url /
- field column=imgCaption xpath=/mediaBlock/caption /
- field column=imgSrcArticle xpath=/mediaBlock/source
-
template=${x.fileWebDir}/${x.imgSrcArticle}//
-
- field column=uid regex=^(.*)$
replaceWith=$1#${x.imgFilename} sourceColName=fileWebPath/
-
- !-- if imgFilename is not defined all the following will also not
be defined --
- field column=imgWebPathFULL
template=${x.fileWebDir}/images/${x.imgFilename}/
- field column=imgWebPathICON regex=^(.*)\.\w+$
replaceWith=${x.fileWebDir}/images/s$1.png
- sourceColName=imgFilename/
-
- /entity
- /entity
- /document
- /dataConfig
- }}}
-
- Anchor(custom-transformers)
- === Writing Custom Transformers ===
- It is simple to add you own transformers and this documented on the page
[[DIHCustomTransformer]]
-
- Anchor(entityprocessor)
- == EntityProcessor ==
- Each entity is handled by a default Entity processor called
!SqlEntityProcessor. This works well for systems which use RDBMS as a
datasource. For other kind of datasources like REST or Non Sql datasources
you can choose to extend this abstract class
`org.apache.solr.handler.dataimport.Entityprocessor`. This is designed to
Stream rows one by one from an entity. The simplest way to implement your own
!EntityProcessor is to extend !EntityProcessorBase and override the `public
MapString,Object nextRow()` method.
- '!EntityProcessor' rely on the !DataSource for fetching data. The return
type of the !DataSource is important for an !EntityProcessor. The built-in
ones are,
-
- === SqlEntityProcessor ===
- This is the defaut. The !DataSource must be of type
`DataSourceIteratorMapString, Object` . !JdbcDataSource can be used
with this.
-
- === XPathEntityProcessor ===
- Used when indexing XML type data. The !DataSource must be of type
`DataSourceReader` . URL!DataSource ! [[Solr1.4]] or !FileDataSource is
commonly used with X!PathEntityProcessor.
-
- === FileListEntityProcessor ===
- A simple entity processor which can be used to enumerate the list of files
from a
[jira] Updated: (SOLR-1447) Simple property injection
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-1447: - Attachment: SOLR-1447.patch a test was failing Simple property injection -- Key: SOLR-1447 URL: https://issues.apache.org/jira/browse/SOLR-1447 Project: Solr Issue Type: Improvement Components: update Affects Versions: 1.4 Reporter: Jason Rutherglen Assignee: Noble Paul Priority: Trivial Fix For: 1.4 Attachments: SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch Original Estimate: 48h Remaining Estimate: 48h MergePolicy and MergeScheduler require property injection. We'll allow these and probably other cases in this patch using Java reflection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1326) New interface PluginInfoInitialized
[
https://issues.apache.org/jira/browse/SOLR-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-1326:
-
Attachment: SOLR-1326.patch
highlighter also simplified
New interface PluginInfoInitialized
---
Key: SOLR-1326
URL: https://issues.apache.org/jira/browse/SOLR-1326
Project: Solr
Issue Type: Improvement
Affects Versions: 1.3
Reporter: Noble Paul
Assignee: Noble Paul
Fix For: 1.4
Attachments: SOLR-1326.patch, SOLR-1326.patch, SOLR-1326.patch,
SOLR-1326.patch
There is no way for a plugin to know the information of the attributes
mentioned in the tag itself (like name). We should have a new interface to
initialize with PluginInfo such as
{code:java}
public interface PluginInfoInitialized{
public void init(PluginInfo pluginInfo);
}
{code}
The PluginInfo class has been enhanced to allow sub components as well. So
the current syntax of UpdateprocessorChain/highlighter can also be supported
by implementing this interface .
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1447) Simple property injection
[
https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758050#action_12758050
]
Jason Rutherglen commented on SOLR-1447:
Noble, looks good, and all tests pass. I think it's tricky to commit this as
is, because there's no back compat? Maybe we can allow:
{code}
mergePolicyorg.apache.lucene.index.LogByteSizeMergePolicy/mergePolicy
mergeSchedulerorg.apache.lucene.index.ConcurrentMergeScheduler/mergeScheduler
{code}
or
{code}
mergePolicy14 class=org.apache.lucene.index.LogByteSizeMergePolicy
double name=maxMergeMB64.0/double
/mergePolicy14
mergeSceduler14 class=org.apache.lucene.index.ConcurrentMergeScheduler
int name=maxThreadCount3/int
/mergeScheduler14
{code}
It's ugly but more clear and this way users' installations won't immediately
break on deployment.
Simple property injection
--
Key: SOLR-1447
URL: https://issues.apache.org/jira/browse/SOLR-1447
Project: Solr
Issue Type: Improvement
Components: update
Affects Versions: 1.4
Reporter: Jason Rutherglen
Assignee: Noble Paul
Priority: Trivial
Fix For: 1.4
Attachments: SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch,
SOLR-1447.patch
Original Estimate: 48h
Remaining Estimate: 48h
MergePolicy and MergeScheduler require property injection. We'll allow these
and probably other cases in this patch using Java reflection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1447) Simple property injection
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758111#action_12758111 ] Noble Paul commented on SOLR-1447: -- yes, there is no back-compat. but changing the tag-name is not an option The ideal fix would be to support both syntaxes.I guess it is still possible. Simple property injection -- Key: SOLR-1447 URL: https://issues.apache.org/jira/browse/SOLR-1447 Project: Solr Issue Type: Improvement Components: update Affects Versions: 1.4 Reporter: Jason Rutherglen Assignee: Noble Paul Priority: Trivial Fix For: 1.4 Attachments: SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch Original Estimate: 48h Remaining Estimate: 48h MergePolicy and MergeScheduler require property injection. We'll allow these and probably other cases in this patch using Java reflection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1447) Simple property injection
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758113#action_12758113 ] Jason Rutherglen commented on SOLR-1447: Why is changing the tag name not an option? Simple property injection -- Key: SOLR-1447 URL: https://issues.apache.org/jira/browse/SOLR-1447 Project: Solr Issue Type: Improvement Components: update Affects Versions: 1.4 Reporter: Jason Rutherglen Assignee: Noble Paul Priority: Trivial Fix For: 1.4 Attachments: SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch Original Estimate: 48h Remaining Estimate: 48h MergePolicy and MergeScheduler require property injection. We'll allow these and probably other cases in this patch using Java reflection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1447) Simple property injection
[ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758118#action_12758118 ] Noble Paul commented on SOLR-1447: -- the back-compat thing is a temporary thing. After we remove it we would love to keep the name as mergePolicy or mergeScheduler itself. There is no reason we should have this arbitrary number at the end. Simple property injection -- Key: SOLR-1447 URL: https://issues.apache.org/jira/browse/SOLR-1447 Project: Solr Issue Type: Improvement Components: update Affects Versions: 1.4 Reporter: Jason Rutherglen Assignee: Noble Paul Priority: Trivial Fix For: 1.4 Attachments: SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch Original Estimate: 48h Remaining Estimate: 48h MergePolicy and MergeScheduler require property injection. We'll allow these and probably other cases in this patch using Java reflection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1427) SearchComponents aren't listed on registry.jsp
[ https://issues.apache.org/jira/browse/SOLR-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man resolved SOLR-1427. Resolution: Fixed got feedback on solr-user from two who had thread locks with SOLR-1427.patch indicating that SOLR-1427.afterlatch.patch worked fine for them, so hoss...@coaster:~/lucene/solr$ svn commit -m SOLR-1427: redo of Grant's previous commit that yonik rolled back - but this time with the registration postponed until the latch is released ... Committed revision 817499. SearchComponents aren't listed on registry.jsp -- Key: SOLR-1427 URL: https://issues.apache.org/jira/browse/SOLR-1427 Project: Solr Issue Type: Bug Reporter: Hoss Man Assignee: Grant Ingersoll Priority: Minor Fix For: 1.4 Attachments: SOLR-1427.afterlatch.patch, SOLR-1427.patch, SOLR-1427.patch, SOLR-1427.patch SearchComponent implements SolrInfoMBean using getCategory() of OTHER but they aren't listed on the registry.jsp display of loaded plugins. This may be a one-of-glitch because of the way SearchComponents get loaded, or it may indicate some other problem with the infoRegistry. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: dist download size
: Agreed, it was just when I had time set aside based on my schedule. If you : have the bandwidth now, go for it! My bad ... i had this weird impression that you ment they shouldn't be addressed until the release process. I used the bandwidth i had to work on SOLR-1449 -- i figure that can kill two birds: reduce the dist size by not needing to copy jars for the example, and make plugins easier to use. -Hoss
