[jira] Commented: (SOLR-154) Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
[ https://issues.apache.org/jira/browse/SOLR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472263 ] Erik Hatcher commented on SOLR-154: --- Jamie's latest patch has been applied. Though I think there is a bit more to come on this. > Added package tasks for creating Rails plugin and namespaced both the rails > and gem packaging > - > > Key: SOLR-154 > URL: https://issues.apache.org/jira/browse/SOLR-154 > Project: Solr > Issue Type: Improvement > Components: clients - ruby - flare > Environment: Ruby and Ruby on Rails >Reporter: Jamie Orchard-Hays > Attachments: Rakefile.diff, Rakefile_2.diff > > > Solrb's (sol.rb's?) rake file has a package:vendor task that is not > generating proper rails plugin structure. Rather than just fix this, I've > added a PackageTask to package up a proper Rails plugin directory structure > and also build distributable packages. Included are the README, LICENSE.txt, > and init.rb generated and destroyed on the fly. Also, I've namespaced the Gem > PackageTask and the Rails PackageTask, so the commands: > rake rails:package (and repackage, clobber, clobber_package) > rake gem:package (and the rest...) > package their files up and dump them into pkg/rails and pkg/gem, > respectively. Their clobber tasks will only remove the sub-directory under > pkg/, not pkg/ itself. > rake package, rake repackage run both package tasks, while rake clobber and > rake clobber_package remove the complete pkg/ directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-154) Added package tasks for creating Rails plugin and namespaced both the rails and gem packaging
[ https://issues.apache.org/jira/browse/SOLR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471818 ] Erik Hatcher commented on SOLR-154: --- I've committed this patch, but Jamie is up to a few more tweaks, so I'll close after those patches are applied. > Added package tasks for creating Rails plugin and namespaced both the rails > and gem packaging > - > > Key: SOLR-154 > URL: https://issues.apache.org/jira/browse/SOLR-154 > Project: Solr > Issue Type: Improvement > Components: clients - ruby - flare > Environment: Ruby and Ruby on Rails >Reporter: Jamie Orchard-Hays > Attachments: Rakefile.diff > > > Solrb's (sol.rb's?) rake file has a package:vendor task that is not > generating proper rails plugin structure. Rather than just fix this, I've > added a PackageTask to package up a proper Rails plugin directory structure > and also build distributable packages. Included are the README, LICENSE.txt, > and init.rb generated and destroyed on the fly. Also, I've namespaced the Gem > PackageTask and the Rails PackageTask, so the commands: > rake rails:package (and repackage, clobber, clobber_package) > rake gem:package (and the rest...) > package their files up and dump them into pkg/rails and pkg/gem, > respectively. Their clobber tasks will only remove the sub-directory under > pkg/, not pkg/ itself. > rake package, rake repackage run both package tasks, while rake clobber and > rake clobber_package remove the complete pkg/ directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
