Re: CloudSolrStream client doesn't validate sort order

2017-01-07 Thread Yago Riveiro
Ok, good to know :)



-
Best regards

/Yago
--
View this message in context: 
http://lucene.472066.n3.nabble.com/CloudSolrStream-client-doesn-t-validate-sort-order-tp4312936p4312943.html
Sent from the Solr - User mailing list archive at Nabble.com.


Re: CloudSolrStream client doesn't validate sort order

2017-01-07 Thread Joel Bernstein
We have this fixed in Solr 6.4 coming out next week. Here is the jira:
SOLR-9495.

Joel Bernstein
http://joelsolr.blogspot.com/

On Sat, Jan 7, 2017 at 3:41 PM, Yago Riveiro  wrote:

> Hi,
>
> The CloudSolrStream client (Solr 6.3.0) assumes that the sort param always
> have the order.
>
> starting in line 326:
>
> String[] sorts = sort.split(",");
> StreamComparator[] comps = new StreamComparator[sorts.length];
> for(int i=0; i   String s = sorts[i];
>
>   String[] spec = s.trim().split("\\s+"); //This should take into
> account spaces in the sort spec.
>
>   String fieldName = spec[0].trim();
>   String order = spec[1].trim();
>
>   
>
> This code doesn't check that the spec param can be inserted incorrectly
> like
> "id" and not like "id asc|desc" and as a result the spec has only one
> index.
>
> The CloudSolrStream client returns null without any kind of message warning
> the user that the order is mandatory.
>
>
>
> -
> Best regards
>
> /Yago
> --
> View this message in context: http://lucene.472066.n3.
> nabble.com/CloudSolrStream-client-doesn-t-validate-sort-
> order-tp4312936.html
> Sent from the Solr - User mailing list archive at Nabble.com.
>


CloudSolrStream client doesn't validate sort order

2017-01-07 Thread Yago Riveiro
Hi,

The CloudSolrStream client (Solr 6.3.0) assumes that the sort param always
have the order.

starting in line 326:

String[] sorts = sort.split(",");
StreamComparator[] comps = new StreamComparator[sorts.length];
for(int i=0; ihttp://lucene.472066.n3.nabble.com/CloudSolrStream-client-doesn-t-validate-sort-order-tp4312936.html
Sent from the Solr - User mailing list archive at Nabble.com.