re: CVS commit: src/share/mk

2014-01-25 Thread matthew green

  Do you have any suggestion without boring work to rename all
  #include machine/foo.h lines and expand the machine path
  in MI files to ${MACHINE}/include?
 
 I wish that cc/clang supported -isystem:NAME PATH and iquote:NAME PATH
 which would look starting at PATH for includes that start with {,}NAME
 
 If we had that, we wouldn't need the damn links at all. :)
 
 -isystem:arm ${NETBSDSRCTOP}/sys/arch/arm/include

this sounds like a level of magic i'd rather my build system avoided.


re: CVS commit: src/sys/opencrypto

2014-01-25 Thread matthew green

  Implement in-module ref-counting, and do not allow auto-unload if there
  are existing references.
  
  Note that manual unloading is not prevented.
  
  OK christos@
  
  XXX Also note that there is still a small window where the ref-count can
  XXX be decremented, and then the process/thread preempted.  If auto-unload
  XXX happens before that thread can return from the module's code, bad
  XXX things (tm) could happen.
 
 in this case, please simply disallow unload for this module always.
 if the race is fixed, it can be enabled again.
 
 I think that most module unloads suffer from this race, any ideas how to
 fix it?

phase one:  disable auto-unload.

phase two:  ???

the rest left as an exercise for the reader.  :-)


re: CVS commit: src/sys/opencrypto

2014-01-25 Thread Paul Goyette

Phase 1 has been done.

On Sat, 25 Jan 2014, matthew green wrote:




Implement in-module ref-counting, and do not allow auto-unload if there
are existing references.

Note that manual unloading is not prevented.

OK christos@

XXX Also note that there is still a small window where the ref-count can
XXX be decremented, and then the process/thread preempted.  If auto-unload
XXX happens before that thread can return from the module's code, bad
XXX things (tm) could happen.


in this case, please simply disallow unload for this module always.
if the race is fixed, it can be enabled again.


I think that most module unloads suffer from this race, any ideas how to
fix it?


phase one:  disable auto-unload.

phase two:  ???

the rest left as an exercise for the reader.  :-)

!DSPAM:52e37018210366601841969!




-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |  | pgoyette at netbsd.org  |
-


re: CVS commit: src/sys/opencrypto

2014-01-25 Thread matthew green

  phase one:  disable auto-unload.

 Phase 1 has been done.

for the whole kernel?


re: CVS commit: src/sys/opencrypto

2014-01-25 Thread Paul Goyette

On Sun, 26 Jan 2014, matthew green wrote:




phase one:  disable auto-unload.



Phase 1 has been done.


for the whole kernel?


No.  Only for this specific module.


-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |  | pgoyette at netbsd.org  |
-


re: CVS commit: src/sys/opencrypto

2014-01-25 Thread matthew green

  phase one:  disable auto-unload.
 
  Phase 1 has been done.
 
  for the whole kernel?
 
 No.  Only for this specific module.

right - my suggestion was that since this problem affects a
large class of modules, until that is fixed, we should
disable auto unload globally.


.mrg.


CVS commit: src/sys/arch

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 15:16:50 UTC 2014

Modified Files:
src/sys/arch/amd64/include: vmparam.h
src/sys/arch/i386/include: vmparam.h
src/sys/arch/mips/include: vmparam.h
src/sys/arch/powerpc/include: vmparam.h
src/sys/arch/vax/include: vmparam.h

Log Message:
delete VM_DEFAULT_ADDRESS; some of those should be GC'ed because they match
the default definition.


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/sys/arch/amd64/include/vmparam.h
cvs rdiff -u -r1.76 -r1.77 src/sys/arch/i386/include/vmparam.h
cvs rdiff -u -r1.51 -r1.52 src/sys/arch/mips/include/vmparam.h
cvs rdiff -u -r1.17 -r1.18 src/sys/arch/powerpc/include/vmparam.h
cvs rdiff -u -r1.48 -r1.49 src/sys/arch/vax/include/vmparam.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/amd64/include/vmparam.h
diff -u src/sys/arch/amd64/include/vmparam.h:1.33 src/sys/arch/amd64/include/vmparam.h:1.34
--- src/sys/arch/amd64/include/vmparam.h:1.33	Sat Jan 25 00:09:59 2014
+++ src/sys/arch/amd64/include/vmparam.h	Sat Jan 25 10:16:49 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: vmparam.h,v 1.33 2014/01/25 05:09:59 christos Exp $	*/
+/*	$NetBSD: vmparam.h,v 1.34 2014/01/25 15:16:49 christos Exp $	*/
 
 /*-
  * Copyright (c) 1990 The Regents of the University of California.
@@ -133,12 +133,12 @@
 #include opt_uvm.h
 #endif
 #define __USE_TOPDOWN_VM
+
 #define VM_DEFAULT_ADDRESS_TOPDOWN(da, sz) \
 trunc_page(USRSTACK - MAXSSIZ - (sz))
-#define VM_DEFAULT_ADDRESS(da, sz) VM_DEFAULT_ADDRESS_TOPDOWN(da, sz)
-
 #define VM_DEFAULT_ADDRESS_BOTTOMUP(da, sz) \
 round_page((vaddr_t)(da) + (vsize_t)maxdmap)
+
 #define VM_DEFAULT_ADDRESS32_TOPDOWN(da, sz) \
 	trunc_page(USRSTACK32 - MAXSSIZ32 - (sz))
 #define VM_DEFAULT_ADDRESS32_BOTTOMUP(da, sz) \

Index: src/sys/arch/i386/include/vmparam.h
diff -u src/sys/arch/i386/include/vmparam.h:1.76 src/sys/arch/i386/include/vmparam.h:1.77
--- src/sys/arch/i386/include/vmparam.h:1.76	Tue Nov 13 09:10:24 2012
+++ src/sys/arch/i386/include/vmparam.h	Sat Jan 25 10:16:50 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: vmparam.h,v 1.76 2012/11/13 14:10:24 chs Exp $	*/
+/*	$NetBSD: vmparam.h,v 1.77 2014/01/25 15:16:50 christos Exp $	*/
 
 /*-
  * Copyright (c) 1990 The Regents of the University of California.
@@ -110,8 +110,10 @@
 #include opt_xen.h
 #endif
 #define __USE_TOPDOWN_VM
-#define VM_DEFAULT_ADDRESS(da, sz) \
-	trunc_page(USRSTACK - MAXSSIZ - (sz))
+#define VM_DEFAULT_ADDRESS_TOPDOWN(da, sz) \
+trunc_page(USRSTACK - MAXSSIZ - (sz))
+#define VM_DEFAULT_ADDRESS_BOTTOMUP(da, sz) \
+round_page((vaddr_t)(da) + (vsize_t)maxdmap)
 
 /* XXX max. amount of KVM to be used by buffers. */
 #ifndef VM_MAX_KERNEL_BUF

Index: src/sys/arch/mips/include/vmparam.h
diff -u src/sys/arch/mips/include/vmparam.h:1.51 src/sys/arch/mips/include/vmparam.h:1.52
--- src/sys/arch/mips/include/vmparam.h:1.51	Wed Jan 22 15:49:19 2014
+++ src/sys/arch/mips/include/vmparam.h	Sat Jan 25 10:16:50 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: vmparam.h,v 1.51 2014/01/22 20:49:19 christos Exp $	*/
+/*	$NetBSD: vmparam.h,v 1.52 2014/01/25 15:16:50 christos Exp $	*/
 
 /*
  * Copyright (c) 1988 University of Utah.
@@ -178,10 +178,16 @@
  * The address to which unspecified mapping requests default
  */
 #define __USE_TOPDOWN_VM
-#define VM_DEFAULT_ADDRESS(da, sz) \
-	trunc_page(USRSTACK - MAXSSIZ - (sz))
-#define VM_DEFAULT_ADDRESS32(da, sz) \
-	trunc_page(USRSTACK32 - MAXSSIZ32 - (sz))
+
+#define VM_DEFAULT_ADDRESS_TOPDOWN(da, sz) \
+trunc_page(USRSTACK - MAXSSIZ - (sz))
+#define VM_DEFAULT_ADDRESS_BOTTOMUP(da, sz) \
+round_page((vaddr_t)(da) + (vsize_t)maxdmap)
+
+#define VM_DEFAULT_ADDRESS32_TOPDOWN(da, sz) \
+trunc_page(USRSTACK32 - MAXSSIZ32 - (sz))
+#define VM_DEFAULT_ADDRESS32_BOTTOMUP(da, sz) \
+round_page((vaddr_t)(da) + (vsize_t)MAXDSIZ32)
 
 /* virtual sizes (bytes) for various kernel submaps */
 #define VM_PHYS_SIZE		(USRIOSIZE*PAGE_SIZE)

Index: src/sys/arch/powerpc/include/vmparam.h
diff -u src/sys/arch/powerpc/include/vmparam.h:1.17 src/sys/arch/powerpc/include/vmparam.h:1.18
--- src/sys/arch/powerpc/include/vmparam.h:1.17	Thu Feb 23 15:33:29 2012
+++ src/sys/arch/powerpc/include/vmparam.h	Sat Jan 25 10:16:50 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: vmparam.h,v 1.17 2012/02/23 20:33:29 matt Exp $	*/
+/*	$NetBSD: vmparam.h,v 1.18 2014/01/25 15:16:50 christos Exp $	*/
 
 #ifndef _POWERPC_VMPARAM_H_
 #define _POWERPC_VMPARAM_H_
@@ -25,8 +25,10 @@
  * top of the next lower segment.
  */
 #define	__USE_TOPDOWN_VM
-#define	VM_DEFAULT_ADDRESS(da, sz) \
-	((VM_MAXUSER_ADDRESS - MAXSSIZ) - round_page(sz))
+#define	VM_DEFAULT_ADDRESS_TOPDOWN(da, sz) \
+((VM_MAXUSER_ADDRESS - MAXSSIZ) - round_page(sz))
+#define VM_DEFAULT_ADDRESS_BOTTOMUP(da, sz) \
+round_page((vaddr_t)(da) + (vsize_t)maxdmap)
 
 #if defined(_MODULE) || defined(MODULAR)
 /*

Index: 

CVS commit: src/sys/uvm

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 17:21:49 UTC 2014

Modified Files:
src/sys/uvm: uvm_mmap.c

Log Message:
deal with COMPAT_10 issue.


To generate a diff of this commit:
cvs rdiff -u -r1.146 -r1.147 src/sys/uvm/uvm_mmap.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/uvm/uvm_mmap.c
diff -u src/sys/uvm/uvm_mmap.c:1.146 src/sys/uvm/uvm_mmap.c:1.147
--- src/sys/uvm/uvm_mmap.c:1.146	Sat Jan 25 00:14:03 2014
+++ src/sys/uvm/uvm_mmap.c	Sat Jan 25 12:21:49 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: uvm_mmap.c,v 1.146 2014/01/25 05:14:03 christos Exp $	*/
+/*	$NetBSD: uvm_mmap.c,v 1.147 2014/01/25 17:21:49 christos Exp $	*/
 
 /*
  * Copyright (c) 1997 Charles D. Cranor and Washington University.
@@ -46,7 +46,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: uvm_mmap.c,v 1.146 2014/01/25 05:14:03 christos Exp $);
+__KERNEL_RCSID(0, $NetBSD: uvm_mmap.c,v 1.147 2014/01/25 17:21:49 christos Exp $);
 
 #include opt_compat_netbsd.h
 #include opt_pax.h
@@ -334,8 +334,17 @@ sys_mmap(struct lwp *l, const struct sys
 	 * Fixup the old deprecated MAP_COPY into MAP_PRIVATE, and
 	 * validate the flags.
 	 */
-	if (flags  MAP_COPY)
+	if (flags  MAP_COPY) {
 		flags = (flags  ~MAP_COPY) | MAP_PRIVATE;
+#if defined(COMPAT_10)  defined(__i386__)
+		/*
+		 * Ancient kernel on x86 did not obey PROT_EXEC on i386 at least
+		 * and ld.so did not turn it on. We take care of this on amd64
+		 * in compat32.
+		 */
+		SCARG(ua, prot) |= PROT_EXEC;
+#endif
+	}
 	if ((flags  (MAP_SHARED|MAP_PRIVATE)) == (MAP_SHARED|MAP_PRIVATE))
 		return (EINVAL);
 



CVS commit: src/sys/arch/sparc64/doc

2014-01-25 Thread Palle Lyckegaard
Module Name:src
Committed By:   palle
Date:   Sat Jan 25 19:07:25 UTC 2014

Added Files:
src/sys/arch/sparc64/doc: TODO

Log Message:
Add a TODO file to document things to be done for the sparc64 port


To generate a diff of this commit:
cvs rdiff -u -r0 -r1.1 src/sys/arch/sparc64/doc/TODO

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Added files:

Index: src/sys/arch/sparc64/doc/TODO
diff -u /dev/null src/sys/arch/sparc64/doc/TODO:1.1
--- /dev/null	Sat Jan 25 19:07:25 2014
+++ src/sys/arch/sparc64/doc/TODO	Sat Jan 25 19:07:25 2014
@@ -0,0 +1,9 @@
+ /* $NetBSD: TODO,v 1.1 2014/01/25 19:07:25 palle Exp $ */
+
+Things to be done:
+
+sun4u:
+
+sun4v:
+- 64-bit kernel support
+- 32-bit kernel support



CVS commit: src/sys/arch/i386/include

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 19:10:56 UTC 2014

Modified Files:
src/sys/arch/i386/include: npx.h

Log Message:
help lint.


To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/sys/arch/i386/include/npx.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/i386/include/npx.h
diff -u src/sys/arch/i386/include/npx.h:1.29 src/sys/arch/i386/include/npx.h:1.30
--- src/sys/arch/i386/include/npx.h:1.29	Sun Jan 19 18:27:30 2014
+++ src/sys/arch/i386/include/npx.h	Sat Jan 25 14:10:56 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: npx.h,v 1.29 2014/01/19 23:27:30 dsl Exp $	*/
+/*	$NetBSD: npx.h,v 1.30 2014/01/25 19:10:56 christos Exp $	*/
 
 /*-
  * Copyright (c) 1990 The Regents of the University of California.
@@ -91,7 +91,10 @@ struct save87 {
 	uint8_t		s87_pad[8 * 2 - 2 * 4];	/* bogus historical padding */
 #endif
 };
+#ifndef __lint__
+// Has different packing semantics, adding packed to save87 works
 __CTASSERT(sizeof (struct save87) == 108 + 16);
+#endif
 
 /* FPU regsters in the extended save format. */
 struct fpaccxmm {
@@ -122,7 +125,10 @@ struct fxsave {
 	uint32_t sv_ex_sw;		/* saved SW from last exception */
 	uint32_t sv_ex_tw;		/* saved TW from last exception */
 } __aligned(16);
+#ifndef __lint__
+// lint does not know aligned
 __CTASSERT(sizeof (struct fxsave) == 512 + 16);
+#endif
 
 
 union savefpu {



CVS commit: src/sys/arch/sparc64/sparc64

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 19:42:25 UTC 2014

Modified Files:
src/sys/arch/sparc64/sparc64: machdep.c

Log Message:
__USING_TOPDOWN_VM is gone.


To generate a diff of this commit:
cvs rdiff -u -r1.274 -r1.275 src/sys/arch/sparc64/sparc64/machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/sparc64/sparc64/machdep.c
diff -u src/sys/arch/sparc64/sparc64/machdep.c:1.274 src/sys/arch/sparc64/sparc64/machdep.c:1.275
--- src/sys/arch/sparc64/sparc64/machdep.c:1.274	Sat Dec 14 00:28:47 2013
+++ src/sys/arch/sparc64/sparc64/machdep.c	Sat Jan 25 14:42:25 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: machdep.c,v 1.274 2013/12/14 05:28:47 nakayama Exp $ */
+/*	$NetBSD: machdep.c,v 1.275 2014/01/25 19:42:25 christos Exp $ */
 
 /*-
  * Copyright (c) 1996, 1997, 1998 The NetBSD Foundation, Inc.
@@ -71,7 +71,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: machdep.c,v 1.274 2013/12/14 05:28:47 nakayama Exp $);
+__KERNEL_RCSID(0, $NetBSD: machdep.c,v 1.275 2014/01/25 19:42:25 christos Exp $);
 
 #include opt_ddb.h
 #include opt_multiprocessor.h
@@ -2754,7 +2754,7 @@ sparc64_elf_mcmodel_check(struct exec_pa
 	if (epp-ep_flags  EXEC_32)
 		return;
 
-#ifdef __USING_TOPDOWN_VM
+#ifdef __USE_TOPDOWN_VM
 	/*
 	 * we allow TOPDOWN_VM for all processes where the binary is compiled
 	 * with the medany or medmid code model.



CVS commit: src/sys/kern

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 19:44:11 UTC 2014

Modified Files:
src/sys/kern: exec_elf.c kern_exec.c kern_proc.c

Log Message:
__USING_TOPDOWN_VM is no more, __USE_TOPDOWN_VM...


To generate a diff of this commit:
cvs rdiff -u -r1.53 -r1.54 src/sys/kern/exec_elf.c
cvs rdiff -u -r1.369 -r1.370 src/sys/kern/kern_exec.c
cvs rdiff -u -r1.190 -r1.191 src/sys/kern/kern_proc.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/kern/exec_elf.c
diff -u src/sys/kern/exec_elf.c:1.53 src/sys/kern/exec_elf.c:1.54
--- src/sys/kern/exec_elf.c:1.53	Sat Dec 21 12:44:33 2013
+++ src/sys/kern/exec_elf.c	Sat Jan 25 14:44:11 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: exec_elf.c,v 1.53 2013/12/21 17:44:33 skrll Exp $	*/
+/*	$NetBSD: exec_elf.c,v 1.54 2014/01/25 19:44:11 christos Exp $	*/
 
 /*-
  * Copyright (c) 1994, 2000, 2005 The NetBSD Foundation, Inc.
@@ -57,7 +57,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(1, $NetBSD: exec_elf.c,v 1.53 2013/12/21 17:44:33 skrll Exp $);
+__KERNEL_RCSID(1, $NetBSD: exec_elf.c,v 1.54 2014/01/25 19:44:11 christos Exp $);
 
 #ifdef _KERNEL_OPT
 #include opt_pax.h
@@ -425,7 +425,7 @@ elf_load_file(struct lwp *l, struct exec
 	if (__predict_true(p-p_vmspace != proc0.p_vmspace)) {
 		use_topdown = p-p_vmspace-vm_map.flags  VM_MAP_TOPDOWN;
 	} else {
-#ifdef __USING_TOPDOWN_VM
+#ifdef __USE_TOPDOWN_VM
 		use_topdown = epp-ep_flags  EXEC_TOPDOWN_VM;
 #else
 		use_topdown = false;

Index: src/sys/kern/kern_exec.c
diff -u src/sys/kern/kern_exec.c:1.369 src/sys/kern/kern_exec.c:1.370
--- src/sys/kern/kern_exec.c:1.369	Fri Jan  3 10:49:49 2014
+++ src/sys/kern/kern_exec.c	Sat Jan 25 14:44:11 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: kern_exec.c,v 1.369 2014/01/03 15:49:49 christos Exp $	*/
+/*	$NetBSD: kern_exec.c,v 1.370 2014/01/25 19:44:11 christos Exp $	*/
 
 /*-
  * Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -59,7 +59,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: kern_exec.c,v 1.369 2014/01/03 15:49:49 christos Exp $);
+__KERNEL_RCSID(0, $NetBSD: kern_exec.c,v 1.370 2014/01/25 19:44:11 christos Exp $);
 
 #include opt_exec.h
 #include opt_execfmt.h
@@ -113,7 +113,7 @@ __KERNEL_RCSID(0, $NetBSD: kern_exec.c,
 #include compat/common/compat_util.h
 
 #ifndef MD_TOPDOWN_INIT
-#ifdef __USING_TOPDOWN_VM
+#ifdef __USE_TOPDOWN_VM
 #define	MD_TOPDOWN_INIT(epp)	(epp)-ep_flags |= EXEC_TOPDOWN_VM
 #else
 #define	MD_TOPDOWN_INIT(epp)

Index: src/sys/kern/kern_proc.c
diff -u src/sys/kern/kern_proc.c:1.190 src/sys/kern/kern_proc.c:1.191
--- src/sys/kern/kern_proc.c:1.190	Thu Nov 14 07:07:11 2013
+++ src/sys/kern/kern_proc.c	Sat Jan 25 14:44:11 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: kern_proc.c,v 1.190 2013/11/14 12:07:11 martin Exp $	*/
+/*	$NetBSD: kern_proc.c,v 1.191 2014/01/25 19:44:11 christos Exp $	*/
 
 /*-
  * Copyright (c) 1999, 2006, 2007, 2008 The NetBSD Foundation, Inc.
@@ -62,7 +62,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: kern_proc.c,v 1.190 2013/11/14 12:07:11 martin Exp $);
+__KERNEL_RCSID(0, $NetBSD: kern_proc.c,v 1.191 2014/01/25 19:44:11 christos Exp $);
 
 #ifdef _KERNEL_OPT
 #include opt_kstack.h
@@ -484,7 +484,7 @@ proc0_init(void)
 	 */
 	uvmspace_init(vmspace0, pmap_kernel(), round_page(VM_MIN_ADDRESS),
 	trunc_page(VM_MAX_ADDRESS),
-#ifdef __USING_TOPDOWN_VM
+#ifdef __USE_TOPDOWN_VM
 	true
 #else
 	false



CVS commit: src/sys/arch/i386/i386

2014-01-25 Thread David Laight
Module Name:src
Committed By:   dsl
Date:   Sat Jan 25 19:51:32 UTC 2014

Modified Files:
src/sys/arch/i386/i386: process_machdep.c

Log Message:
Rewrite the code that converts the x87 tag word between its full and
  abridged versions.
The code in xmm_to_s87_tag() looked at the wrong register when trying
  to generate 0b01 (zero) and 0b10 (NaN etc) because the registers are
  relative to the stack top, but the tag words are absolute.
Since even a real 387 generates the correct tag values when the tag word
  (or register value) is loaded there is no point generating other than
  0b00 (used) and 0b11 (unused).
The compiler also made a pig's breakfast of the register copy loop.
When convering from fsave to (the larger) fxsave format don't bother
  copying the fp register values if none are in use.
Converting the other way we do copy them all because the target buffer
  is often written to userspace (and has no padding).
i386 core dumps still seem ok - and do use this code.


To generate a diff of this commit:
cvs rdiff -u -r1.77 -r1.78 src/sys/arch/i386/i386/process_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/i386/i386/process_machdep.c
diff -u src/sys/arch/i386/i386/process_machdep.c:1.77 src/sys/arch/i386/i386/process_machdep.c:1.78
--- src/sys/arch/i386/i386/process_machdep.c:1.77	Sun Jan 19 14:30:37 2014
+++ src/sys/arch/i386/i386/process_machdep.c	Sat Jan 25 19:51:31 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: process_machdep.c,v 1.77 2014/01/19 14:30:37 dsl Exp $	*/
+/*	$NetBSD: process_machdep.c,v 1.78 2014/01/25 19:51:31 dsl Exp $	*/
 
 /*-
  * Copyright (c) 1998, 2000, 2001, 2008 The NetBSD Foundation, Inc.
@@ -52,7 +52,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: process_machdep.c,v 1.77 2014/01/19 14:30:37 dsl Exp $);
+__KERNEL_RCSID(0, $NetBSD: process_machdep.c,v 1.78 2014/01/25 19:51:31 dsl Exp $);
 
 #include opt_vm86.h
 #include opt_ptrace.h
@@ -91,47 +91,41 @@ process_fpframe(struct lwp *l)
 	return pcb-pcb_savefpu;
 }
 
-static int
-xmm_to_s87_tag(const uint8_t *fpac, int regno, uint8_t tw)
-{
-	static const uint8_t empty_significand[8] = { 0 };
-	int tag;
-	uint16_t exponent;
-
-	if (tw  (1U  regno)) {
-		exponent = fpac[8] | (fpac[9]  8);
-		switch (exponent) {
-		case 0x7fff:
-			tag = 2;
-			break;
-
-		case 0x:
-			if (memcmp(empty_significand, fpac,
-   sizeof(empty_significand)) == 0)
-tag = 1;
-			else
-tag = 2;
-			break;
-
-		default:
-			if ((fpac[7]  0x80) == 0)
-tag = 2;
-			else
-tag = 0;
-			break;
-		}
-	} else
-		tag = 3;
-
-	return (tag);
-}
-
 void
 process_xmm_to_s87(const struct fxsave *sxmm, struct save87 *s87)
 {
+	unsigned int tag, ab_tag;
+	const struct fpaccxmm *fx_reg;
+	struct fpacc87 *s87_reg;
 	int i;
 
-	/* Convert context sent by userspace */
+	/*
+	 * For historic reasons core dumps and ptrace all use the old save87
+	 * layout.  Convert the important parts.
+	 * getucontext gets what we give it.
+	 * setucontext should return something given by getucontext, but
+	 * we are (at the moment) willing to change it.
+	 *
+	 * It really isn't worth setting the 'tag' bits to 01 (zero) or
+	 * 10 (NaN etc) since the processor will set any internal bits
+	 * correctly when the value is loaded (the 287 believed them).
+	 *
+	 * Additionally the s87_tw and s87_tw are 'indexed' by the actual
+	 * register numbers, whereas the registers themselves have ST(0)
+	 * first. Pairing the values and tags can only be done with
+	 * reference to the 'top of stack'.
+	 *
+	 * If any x87 registers are used, they will typically be from
+	 * r7 downwards - so the high bits of the tag register indicate
+	 * used registers. The conversions are not optimised for this.
+	 *
+	 * The ABI we use requires the FP stack to be empty on every
+	 * function call. I think this means that the stack isn't expected
+	 * to overflow - overflow doesn't drop a core in my testing.
+	 *
+	 * Note that this code writes to all of the 's87' structure that
+	 * actually gets written to userspace.
+	 */
 
 	/* FPU control/status */
 	s87-s87_cw = sxmm-fx_cw;
@@ -141,31 +135,47 @@ process_xmm_to_s87(const struct fxsave *
 	s87-s87_opcode = sxmm-fx_opcode;
 	s87-s87_dp = sxmm-fx_dp;
 
-	/* Tag word and registers. */
-	s87-s87_tw = 0;
-	s87-s87_ex_tw = 0;
-	for (i = 0; i  8; i++) {
-		s87-s87_tw |=
-		(xmm_to_s87_tag(sxmm-sv_ac[i].fp_bytes, i,
-		 sxmm-fx_tw)  (i * 2));
-
-		s87-s87_ex_tw |=
-		(xmm_to_s87_tag(sxmm-sv_ac[i].fp_bytes, i,
-		 sxmm-sv_ex_tw)  (i * 2));
+	/* FP registers (in stack order) */
+	fx_reg = sxmm-sv_ac;
+	s87_reg = s87-s87_ac;
+	for (i = 0; i  8; fx_reg++, s87_reg++, i++)
+		memcpy(s87_reg-fp_bytes, fx_reg-fp_bytes,
+		sizeof(s87_reg-fp_bytes));
 
-		memcpy(s87-s87_ac[i].fp_bytes, sxmm-sv_ac[i].fp_bytes,
-		sizeof(s87-s87_ac[i].fp_bytes));
+	/* Tag word and registers. */
+	ab_tag = sxmm-fx_tw  0xff;	/* 

CVS commit: src/sys/arch/i386

2014-01-25 Thread David Laight
Module Name:src
Committed By:   dsl
Date:   Sat Jan 25 20:12:53 UTC 2014

Modified Files:
src/sys/arch/i386/i386: process_machdep.c
src/sys/arch/i386/include: npx.h

Log Message:
Change the way the x87 fp register is defined so that the copies between
  fsave and fxsave layouts can be done by structure assignments.


To generate a diff of this commit:
cvs rdiff -u -r1.78 -r1.79 src/sys/arch/i386/i386/process_machdep.c
cvs rdiff -u -r1.30 -r1.31 src/sys/arch/i386/include/npx.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/i386/i386/process_machdep.c
diff -u src/sys/arch/i386/i386/process_machdep.c:1.78 src/sys/arch/i386/i386/process_machdep.c:1.79
--- src/sys/arch/i386/i386/process_machdep.c:1.78	Sat Jan 25 19:51:31 2014
+++ src/sys/arch/i386/i386/process_machdep.c	Sat Jan 25 20:12:53 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: process_machdep.c,v 1.78 2014/01/25 19:51:31 dsl Exp $	*/
+/*	$NetBSD: process_machdep.c,v 1.79 2014/01/25 20:12:53 dsl Exp $	*/
 
 /*-
  * Copyright (c) 1998, 2000, 2001, 2008 The NetBSD Foundation, Inc.
@@ -52,7 +52,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: process_machdep.c,v 1.78 2014/01/25 19:51:31 dsl Exp $);
+__KERNEL_RCSID(0, $NetBSD: process_machdep.c,v 1.79 2014/01/25 20:12:53 dsl Exp $);
 
 #include opt_vm86.h
 #include opt_ptrace.h
@@ -95,7 +95,7 @@ void
 process_xmm_to_s87(const struct fxsave *sxmm, struct save87 *s87)
 {
 	unsigned int tag, ab_tag;
-	const struct fpaccxmm *fx_reg;
+	const struct fpaccfx *fx_reg;
 	struct fpacc87 *s87_reg;
 	int i;
 
@@ -136,11 +136,10 @@ process_xmm_to_s87(const struct fxsave *
 	s87-s87_dp = sxmm-fx_dp;
 
 	/* FP registers (in stack order) */
-	fx_reg = sxmm-sv_ac;
+	fx_reg = sxmm-fx_87_ac;
 	s87_reg = s87-s87_ac;
 	for (i = 0; i  8; fx_reg++, s87_reg++, i++)
-		memcpy(s87_reg-fp_bytes, fx_reg-fp_bytes,
-		sizeof(s87_reg-fp_bytes));
+		*s87_reg = fx_reg-r;
 
 	/* Tag word and registers. */
 	ab_tag = sxmm-fx_tw  0xff;	/* Bits set if valid */
@@ -162,7 +161,7 @@ void
 process_s87_to_xmm(const struct save87 *s87, struct fxsave *sxmm)
 {
 	unsigned int tag, ab_tag;
-	struct fpaccxmm *fx_reg;
+	struct fpaccfx *fx_reg;
 	const struct fpacc87 *s87_reg;
 	int i;
 
@@ -203,11 +202,10 @@ process_s87_to_xmm(const struct save87 *
 	sxmm-fx_tw = ab_tag;
 
 	/* FP registers (in stack order) */
-	fx_reg = sxmm-sv_ac;
+	fx_reg = sxmm-fx_87_ac;
 	s87_reg = s87-s87_ac;
 	for (i = 0; i  8; fx_reg++, s87_reg++, i++)
-		memcpy(fx_reg-fp_bytes, s87_reg-fp_bytes,
-		sizeof(fx_reg-fp_bytes));
+		fx_reg-r = *s87_reg;
 }
 
 int

Index: src/sys/arch/i386/include/npx.h
diff -u src/sys/arch/i386/include/npx.h:1.30 src/sys/arch/i386/include/npx.h:1.31
--- src/sys/arch/i386/include/npx.h:1.30	Sat Jan 25 19:10:56 2014
+++ src/sys/arch/i386/include/npx.h	Sat Jan 25 20:12:53 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: npx.h,v 1.30 2014/01/25 19:10:56 christos Exp $	*/
+/*	$NetBSD: npx.h,v 1.31 2014/01/25 20:12:53 dsl Exp $	*/
 
 /*-
  * Copyright (c) 1990 The Regents of the University of California.
@@ -57,16 +57,15 @@ union fp_addr {
 	} fa_32;
 } __packed;
 
-/* Contents of each floating point accumulator */
+/* The x87 registers are 80 bits (in ST(n) order) */
 struct fpacc87 {
-#ifdef dontdef	/* too unportable */
-	uint32_t fp_mantlo;	/* mantissa low (31:0) */
-	uint32_t fp_manthi;	/* mantissa high (63:32) */
-	int	 fp_exp:15;	/* exponent */
-	int	 fp_sgn:1;	/* mantissa sign */
-#else
-	uint8_t	 fp_bytes[10];
-#endif
+	uint64_t	f87_mantissa;	/* mantissa */
+	uint16_t	f87_exp_sign;	/* exponent and sign */
+} __packed;
+
+/* The x87 registers padded out for fxsave */
+struct fpaccfx {
+	struct fpacc87 r __aligned(16);
 };
 
 /*
@@ -96,12 +95,6 @@ struct save87 {
 __CTASSERT(sizeof (struct save87) == 108 + 16);
 #endif
 
-/* FPU regsters in the extended save format. */
-struct fpaccxmm {
-	uint8_t fp_bytes[10];
-	uint8_t fp_rsvd[6];
-};
-
 /* SSE/SSE2 registers. */
 struct xmmreg {
 	uint8_t sse_bytes[16];
@@ -118,7 +111,7 @@ struct fxsave {
 /*16*/	union fp_addr fx_dp;	/* FPU Data pointer */
 	uint32_t fx_mxcsr;	/* MXCSR Register State */
 	uint32_t fx_mxcsr_mask;
-	struct fpaccxmm sv_ac[8];	/* ST/MM regs */
+	struct fpaccfx fx_87_ac[8];	/* 8 x87 registers */
 	struct xmmreg sv_xmmregs[8];	/* XMM regs */
 	uint8_t sv_rsvd[16 * 14];
 	/* 512-bytes --- end of hardware portion of save area */



CVS commit: src/sys/net

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:10:29 UTC 2014

Modified Files:
src/sys/net: if.h

Log Message:
add a lint comment


To generate a diff of this commit:
cvs rdiff -u -r1.159 -r1.160 src/sys/net/if.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/net/if.h
diff -u src/sys/net/if.h:1.159 src/sys/net/if.h:1.160
--- src/sys/net/if.h:1.159	Mon Oct 28 17:38:01 2013
+++ src/sys/net/if.h	Sat Jan 25 16:10:29 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: if.h,v 1.159 2013/10/28 21:38:01 christos Exp $	*/
+/*	$NetBSD: if.h,v 1.160 2014/01/25 21:10:29 christos Exp $	*/
 
 /*-
  * Copyright (c) 1999, 2000, 2001 The NetBSD Foundation, Inc.
@@ -609,6 +609,7 @@ struct	ifreq {
 #define	ifreq_getbroadaddr	ifreq_getaddr
 
 static inline const struct sockaddr *
+/*ARGSUSED*/
 ifreq_getaddr(u_long cmd, const struct ifreq *ifr)
 {
 	return ifr-ifr_addr;



CVS commit: src/sys/net

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:10:41 UTC 2014

Modified Files:
src/sys/net: if_etherip.c

Log Message:
add __USE


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/sys/net/if_etherip.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/net/if_etherip.c
diff -u src/sys/net/if_etherip.c:1.33 src/sys/net/if_etherip.c:1.34
--- src/sys/net/if_etherip.c:1.33	Fri Jul 27 20:43:24 2012
+++ src/sys/net/if_etherip.c	Sat Jan 25 16:10:41 2014
@@ -1,4 +1,4 @@
-/*  $NetBSD: if_etherip.c,v 1.33 2012/07/28 00:43:24 matt Exp $*/
+/*  $NetBSD: if_etherip.c,v 1.34 2014/01/25 21:10:41 christos Exp $*/
 
 /*
  *  Copyright (c) 2006, Hans Rosenfeld rosenf...@grumpf.hope-2000.org
@@ -86,7 +86,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: if_etherip.c,v 1.33 2012/07/28 00:43:24 matt Exp $);
+__KERNEL_RCSID(0, $NetBSD: if_etherip.c,v 1.34 2014/01/25 21:10:41 christos Exp $);
 
 #include opt_inet.h
 
@@ -397,6 +397,7 @@ etheripintr(void *arg)
 		} else  m_freem(m);
 	}
 	mutex_exit(softnet_lock);
+	__USE(error);
 }
 
 static int



CVS commit: src/sys/arch/i386/pci

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:11:03 UTC 2014

Modified Files:
src/sys/arch/i386/pci: via8231.c

Log Message:
remove unused


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/arch/i386/pci/via8231.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/i386/pci/via8231.c
diff -u src/sys/arch/i386/pci/via8231.c:1.4 src/sys/arch/i386/pci/via8231.c:1.5
--- src/sys/arch/i386/pci/via8231.c:1.4	Fri Jul  1 13:37:27 2011
+++ src/sys/arch/i386/pci/via8231.c	Sat Jan 25 16:11:03 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: via8231.c,v 1.4 2011/07/01 17:37:27 dyoung Exp $	*/
+/*	$NetBSD: via8231.c,v 1.5 2014/01/25 21:11:03 christos Exp $	*/
 /*	OpenBSD: via8231.c,v 1.6 2005/10/27 16:41:06 mickey Exp 	*/
 
 /*-
@@ -66,7 +66,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: via8231.c,v 1.4 2011/07/01 17:37:27 dyoung Exp $);
+__KERNEL_RCSID(0, $NetBSD: via8231.c,v 1.5 2014/01/25 21:11:03 christos Exp $);
 
 #include sys/param.h
 #include sys/systm.h
@@ -258,7 +258,7 @@ int
 via8231_set_trigger(pciintr_icu_handle_t v, int irq, int trigger)
 {
 	struct via8231_handle *ph = v;
-	int reg, clink, m, pciirq;
+	int reg, clink, pciirq;
 
 	if (VIA8231_PIRQ_LEGAL(irq) == 0 || VIA8231_TRIG_LEGAL(trigger) == 0)
 		return (1);
@@ -268,7 +268,6 @@ via8231_set_trigger(pciintr_icu_handle_t
 	via8231_pir_dump(via8231_set_trig: , ph);
 #endif
 
-	m = ph-flags  VT8237? VIA8237_LINK_MAX : VIA8231_LINK_MAX;
 	for (clink = 0; clink = VIA8231_LINK_MAX; clink++) {
 		via8231_get_intr(v, clink, pciirq);
 		if (pciirq == irq) {



CVS commit: src/sys/dev/acpi

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:11:20 UTC 2014

Modified Files:
src/sys/dev/acpi: acpi.c

Log Message:
fix unused


To generate a diff of this commit:
cvs rdiff -u -r1.256 -r1.257 src/sys/dev/acpi/acpi.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/acpi/acpi.c
diff -u src/sys/dev/acpi/acpi.c:1.256 src/sys/dev/acpi/acpi.c:1.257
--- src/sys/dev/acpi/acpi.c:1.256	Wed Oct 16 13:30:42 2013
+++ src/sys/dev/acpi/acpi.c	Sat Jan 25 16:11:20 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: acpi.c,v 1.256 2013/10/16 17:30:42 christos Exp $	*/
+/*	$NetBSD: acpi.c,v 1.257 2014/01/25 21:11:20 christos Exp $	*/
 
 /*-
  * Copyright (c) 2003, 2007 The NetBSD Foundation, Inc.
@@ -100,7 +100,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: acpi.c,v 1.256 2013/10/16 17:30:42 christos Exp $);
+__KERNEL_RCSID(0, $NetBSD: acpi.c,v 1.257 2014/01/25 21:11:20 christos Exp $);
 
 #include opt_acpi.h
 #include opt_pcifixup.h
@@ -1853,7 +1853,9 @@ acpi_allocate_resources(ACPI_HANDLE hand
 	ACPI_BUFFER bufp, bufc, bufn;
 	ACPI_RESOURCE *resp, *resc, *resn;
 	ACPI_RESOURCE_IRQ *irq;
+#if 0
 	ACPI_RESOURCE_EXTENDED_IRQ *xirq;
+#endif
 	ACPI_STATUS rv;
 	uint delta;
 
@@ -1891,8 +1893,8 @@ acpi_allocate_resources(ACPI_HANDLE hand
 		case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
 			memcpy(resn-Data, resp-Data,
 			   sizeof(ACPI_RESOURCE_EXTENDED_IRQ));
-			xirq = (ACPI_RESOURCE_EXTENDED_IRQ *)resn-Data;
 #if 0
+			xirq = (ACPI_RESOURCE_EXTENDED_IRQ *)resn-Data;
 			/*
 			 * XXX:	Not duplicating the interrupt logic above
 			 *	because its not clear what it accomplishes.



CVS commit: src/sys/kern

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:11:49 UTC 2014

Modified Files:
src/sys/kern: sys_pmc.c

Log Message:
fix unused


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/kern/sys_pmc.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/kern/sys_pmc.c
diff -u src/sys/kern/sys_pmc.c:1.10 src/sys/kern/sys_pmc.c:1.11
--- src/sys/kern/sys_pmc.c:1.10	Mon Apr 21 08:56:31 2008
+++ src/sys/kern/sys_pmc.c	Sat Jan 25 16:11:49 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: sys_pmc.c,v 1.10 2008/04/21 12:56:31 ad Exp $	*/
+/*	$NetBSD: sys_pmc.c,v 1.11 2014/01/25 21:11:49 christos Exp $	*/
 
 /*
  * Copyright (c) 2002 Wasabi Systems, Inc.
@@ -36,7 +36,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: sys_pmc.c,v 1.10 2008/04/21 12:56:31 ad Exp $);
+__KERNEL_RCSID(0, $NetBSD: sys_pmc.c,v 1.11 2014/01/25 21:11:49 christos Exp $);
 
 #include opt_perfctrs.h
 
@@ -71,6 +71,7 @@ sys_pmc_control(struct lwp *l, const str
 	int ctr, operation, error=0;
 
 	ctr = SCARG(uap, ctr);
+	__USE(ctr);
 	operation = SCARG(uap, op);
 
 	KERNEL_LOCK(1, NULL);
@@ -140,6 +141,7 @@ sys_pmc_get_info(struct lwp *l, const st
 	ctr = SCARG(uap, ctr);
 	request = SCARG(uap, op);
 	args = SCARG(uap, args);
+	__USE(flags);
 
 	KERNEL_LOCK(1, NULL);
 	nctrs = pmc_get_num_counters();



CVS commit: src/sys/arch/arm/arm32

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 23:11:08 UTC 2014

Modified Files:
src/sys/arch/arm/arm32: netbsd32_machdep.c

Log Message:
use the topdown hint.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/arch/arm/arm32/netbsd32_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/arm/arm32/netbsd32_machdep.c
diff -u src/sys/arch/arm/arm32/netbsd32_machdep.c:1.2 src/sys/arch/arm/arm32/netbsd32_machdep.c:1.3
--- src/sys/arch/arm/arm32/netbsd32_machdep.c:1.2	Wed Jan  1 13:57:15 2014
+++ src/sys/arch/arm/arm32/netbsd32_machdep.c	Sat Jan 25 18:11:08 2014
@@ -29,7 +29,7 @@
 
 #include sys/cdefs.h
 
-__KERNEL_RCSID(1, $NetBSD: netbsd32_machdep.c,v 1.2 2014/01/01 18:57:15 dsl Exp $);
+__KERNEL_RCSID(1, $NetBSD: netbsd32_machdep.c,v 1.3 2014/01/25 23:11:08 christos Exp $);
 
 #include sys/param.h
 #include sys/core.h
@@ -93,5 +93,9 @@ netbsd32_sysarch(struct lwp *l, const st
 vaddr_t
 netbsd32_vm_default_addr(struct proc *p, vaddr_t base, vsize_t size)
 {
-	return VM_DEFAULT_ADDRESS(base, size);
+if (p-p_vmspace-vm_map.flags  VM_MAP_TOPDOWN)
+return VM_DEFAULT_ADDRESS32_TOPDOWN(base, sz);
+else
+return VM_DEFAULT_ADDRESS32_BOTTOMUP(base, sz);
+
 }



CVS commit: src/sys/compat/netbsd32

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 23:58:10 UTC 2014

Modified Files:
src/sys/compat/netbsd32: netbsd32_exec_aout.c

Log Message:
Clear the VM_TOPDOWN flag only when we succeed.


To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 src/sys/compat/netbsd32/netbsd32_exec_aout.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/compat/netbsd32/netbsd32_exec_aout.c
diff -u src/sys/compat/netbsd32/netbsd32_exec_aout.c:1.26 src/sys/compat/netbsd32/netbsd32_exec_aout.c:1.27
--- src/sys/compat/netbsd32/netbsd32_exec_aout.c:1.26	Sat Jan 25 00:15:43 2014
+++ src/sys/compat/netbsd32/netbsd32_exec_aout.c	Sat Jan 25 18:58:10 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: netbsd32_exec_aout.c,v 1.26 2014/01/25 05:15:43 christos Exp $	*/
+/*	$NetBSD: netbsd32_exec_aout.c,v 1.27 2014/01/25 23:58:10 christos Exp $	*/
 /*	from: NetBSD: exec_aout.c,v 1.15 1996/09/26 23:34:46 cgd Exp */
 
 /*
@@ -57,7 +57,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: netbsd32_exec_aout.c,v 1.26 2014/01/25 05:15:43 christos Exp $);
+__KERNEL_RCSID(0, $NetBSD: netbsd32_exec_aout.c,v 1.27 2014/01/25 23:58:10 christos Exp $);
 
 #include sys/param.h
 #include sys/systm.h
@@ -113,7 +113,6 @@ exec_netbsd32_makecmds(struct lwp *l, st
 
 	/* this is already needed by setup_stack() */
 	epp-ep_flags |= EXEC_32;
-	epp-ep_flags = ~EXEC_TOPDOWN_VM;
 
 	switch (midmag) {
 	case (NETBSD32_MID_MACHINE  16) | ZMAGIC:
@@ -134,7 +133,8 @@ exec_netbsd32_makecmds(struct lwp *l, st
 	if (error) {
 		kill_vmcmds(epp-ep_vmcmds);
 		epp-ep_flags = ~EXEC_32;
-	}
+	} else
+		epp-ep_flags = ~EXEC_TOPDOWN_VM;
 	return error;
 }
 



CVS commit: src/sys/kern

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 23:58:41 UTC 2014

Modified Files:
src/sys/kern: exec_aout.c

Log Message:
kill the topdown flag only if we succeed.


To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sys/kern/exec_aout.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/kern/exec_aout.c
diff -u src/sys/kern/exec_aout.c:1.37 src/sys/kern/exec_aout.c:1.38
--- src/sys/kern/exec_aout.c:1.37	Sat Jan 25 00:15:05 2014
+++ src/sys/kern/exec_aout.c	Sat Jan 25 18:58:41 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: exec_aout.c,v 1.37 2014/01/25 05:15:05 christos Exp $	*/
+/*	$NetBSD: exec_aout.c,v 1.38 2014/01/25 23:58:41 christos Exp $	*/
 
 /*
  * Copyright (c) 1993, 1994 Christopher G. Demetriou
@@ -31,7 +31,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: exec_aout.c,v 1.37 2014/01/25 05:15:05 christos Exp $);
+__KERNEL_RCSID(0, $NetBSD: exec_aout.c,v 1.38 2014/01/25 23:58:41 christos Exp $);
 
 #ifdef _KERNEL_OPT
 #include opt_coredump.h
@@ -116,8 +116,6 @@ exec_aout_makecmds(struct lwp *l, struct
 
 	midmag = mid  16 | magic;
 
-	epp-ep_flags = ~EXEC_TOPDOWN_VM;
-
 	switch (midmag) {
 	case (MID_MACHINE  16) | ZMAGIC:
 		error = exec_aout_prep_zmagic(l, epp);
@@ -134,6 +132,8 @@ exec_aout_makecmds(struct lwp *l, struct
 
 	if (error)
 		kill_vmcmds(epp-ep_vmcmds);
+	else
+		epp-ep_flags = ~EXEC_TOPDOWN_VM;
 
 	return error;
 }



CVS commit: src/sys/arch/mac68k/dev

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 00:08:48 UTC 2014

Modified Files:
src/sys/arch/mac68k/dev: grf_compat.c

Log Message:
kill VM_DEFAULT_ADDRESS use


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/arch/mac68k/dev/grf_compat.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/mac68k/dev/grf_compat.c
diff -u src/sys/arch/mac68k/dev/grf_compat.c:1.22 src/sys/arch/mac68k/dev/grf_compat.c:1.23
--- src/sys/arch/mac68k/dev/grf_compat.c:1.22	Sun Jun  6 00:52:17 2010
+++ src/sys/arch/mac68k/dev/grf_compat.c	Sat Jan 25 19:08:48 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: grf_compat.c,v 1.22 2010/06/06 04:52:17 mrg Exp $	*/
+/*	$NetBSD: grf_compat.c,v 1.23 2014/01/26 00:08:48 christos Exp $	*/
 
 /*
  * Copyright (C) 1999 Scott Reynolds
@@ -34,7 +34,7 @@
 #include opt_grf_compat.h
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: grf_compat.c,v 1.22 2010/06/06 04:52:17 mrg Exp $);
+__KERNEL_RCSID(0, $NetBSD: grf_compat.c,v 1.23 2014/01/26 00:08:48 christos Exp $);
 
 #include sys/param.h
 #include sys/systm.h
@@ -315,7 +315,8 @@ grfmap(dev_t dev, struct macfb_softc *sc
 	int error, flags;
 
 	len = m68k_round_page(sc-sc_dc-dc_offset + sc-sc_dc-dc_size);
-	*addrp = (void *)VM_DEFAULT_ADDRESS(p-p_vmspace-vm_daddr, len);
+	*addrp = (void *)p-p_emul-e_vm_default_addr(p,
+	p-p_vmspace-vm_daddr, len);
 	flags = MAP_SHARED | MAP_FIXED;
 
 	vn.v_type = VCHR;		/* XXX */



CVS commit: src/sys/arch/x68k/dev

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 00:09:46 UTC 2014

Modified Files:
src/sys/arch/x68k/dev: grf.c

Log Message:
kill VM_DEFAULT_ADDRESS use.


To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 src/sys/arch/x68k/dev/grf.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/x68k/dev/grf.c
diff -u src/sys/arch/x68k/dev/grf.c:1.40 src/sys/arch/x68k/dev/grf.c:1.41
--- src/sys/arch/x68k/dev/grf.c:1.40	Tue Feb  8 15:20:25 2011
+++ src/sys/arch/x68k/dev/grf.c	Sat Jan 25 19:09:46 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: grf.c,v 1.40 2011/02/08 20:20:25 rmind Exp $	*/
+/*	$NetBSD: grf.c,v 1.41 2014/01/26 00:09:46 christos Exp $	*/
 
 /*
  * Copyright (c) 1988 University of Utah.
@@ -45,7 +45,7 @@
  */
 
 #include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: grf.c,v 1.40 2011/02/08 20:20:25 rmind Exp $);
+__KERNEL_RCSID(0, $NetBSD: grf.c,v 1.41 2014/01/26 00:09:46 christos Exp $);
 
 #include sys/param.h
 #include sys/systm.h
@@ -270,8 +270,9 @@ grfmap(dev_t dev, void **addrp, struct p
 	if (*addrp)
 		flags |= MAP_FIXED;
 	else
-		*addrp =
-		(void *)VM_DEFAULT_ADDRESS(p-p_vmspace-vm_daddr, len);
+		*addrp = (void *)p-p_emul-e_vm_default_addr(p, 
+		p-p_vmspace-vm_daddr, len);
+
 	vn.v_type = VCHR;			/* XXX */
 	vn.v_rdev = dev;			/* XXX */
 	error = uvm_mmap(p-p_vmspace-vm_map, (vaddr_t *)addrp,



CVS commit: src/sys/arch/arm/arm32

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 00:21:18 UTC 2014

Modified Files:
src/sys/arch/arm/arm32: netbsd32_machdep.c

Log Message:
whitespace


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/arch/arm/arm32/netbsd32_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/arm/arm32/netbsd32_machdep.c
diff -u src/sys/arch/arm/arm32/netbsd32_machdep.c:1.3 src/sys/arch/arm/arm32/netbsd32_machdep.c:1.4
--- src/sys/arch/arm/arm32/netbsd32_machdep.c:1.3	Sat Jan 25 18:11:08 2014
+++ src/sys/arch/arm/arm32/netbsd32_machdep.c	Sat Jan 25 19:21:18 2014
@@ -29,7 +29,7 @@
 
 #include sys/cdefs.h
 
-__KERNEL_RCSID(1, $NetBSD: netbsd32_machdep.c,v 1.3 2014/01/25 23:11:08 christos Exp $);
+__KERNEL_RCSID(1, $NetBSD: netbsd32_machdep.c,v 1.4 2014/01/26 00:21:18 christos Exp $);
 
 #include sys/param.h
 #include sys/core.h
@@ -93,9 +93,9 @@ netbsd32_sysarch(struct lwp *l, const st
 vaddr_t
 netbsd32_vm_default_addr(struct proc *p, vaddr_t base, vsize_t size)
 {
-if (p-p_vmspace-vm_map.flags  VM_MAP_TOPDOWN)
-return VM_DEFAULT_ADDRESS32_TOPDOWN(base, sz);
-else
-return VM_DEFAULT_ADDRESS32_BOTTOMUP(base, sz);
+	if (p-p_vmspace-vm_map.flags  VM_MAP_TOPDOWN)
+		return VM_DEFAULT_ADDRESS32_TOPDOWN(base, sz);
+	else
+		return VM_DEFAULT_ADDRESS32_BOTTOMUP(base, sz);
 
 }



CVS commit: src/usr.sbin/pwd_mkdb

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 01:57:04 UTC 2014

Modified Files:
src/usr.sbin/pwd_mkdb: pwd_mkdb.c

Log Message:
Fix the separate root test. If we get a permission error check for separate
root. But if we get ENOENT, always succeed. Otherwise if someone removes
the db files or they get corrupted, you can never recreate them.


To generate a diff of this commit:
cvs rdiff -u -r1.56 -r1.57 src/usr.sbin/pwd_mkdb/pwd_mkdb.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/usr.sbin/pwd_mkdb/pwd_mkdb.c
diff -u src/usr.sbin/pwd_mkdb/pwd_mkdb.c:1.56 src/usr.sbin/pwd_mkdb/pwd_mkdb.c:1.57
--- src/usr.sbin/pwd_mkdb/pwd_mkdb.c:1.56	Mon Nov 26 15:13:54 2012
+++ src/usr.sbin/pwd_mkdb/pwd_mkdb.c	Sat Jan 25 20:57:04 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: pwd_mkdb.c,v 1.56 2012/11/26 20:13:54 pooka Exp $	*/
+/*	$NetBSD: pwd_mkdb.c,v 1.57 2014/01/26 01:57:04 christos Exp $	*/
 
 /*
  * Copyright (c) 2000, 2009 The NetBSD Foundation, Inc.
@@ -90,7 +90,7 @@ __COPYRIGHT(@(#) Copyright (c) 2000, 20
  The NetBSD Foundation, Inc.  All rights reserved.\
   Copyright (c) 1991, 1993, 1994\
  The Regents of the University of California.  All rights reserved.);
-__RCSID($NetBSD: pwd_mkdb.c,v 1.56 2012/11/26 20:13:54 pooka Exp $);
+__RCSID($NetBSD: pwd_mkdb.c,v 1.57 2014/01/26 01:57:04 christos Exp $);
 #endif /* not lint */
 
 #if HAVE_NBTOOL_CONFIG_H
@@ -741,7 +741,7 @@ getversion(const char *fname)
 	db = dbopen(fname, O_RDONLY, PERM_INSECURE, DB_HASH, NULL);
 	if (db == NULL) {
 		/* If we are building on a separate root, assume version 1 */
-		if ((errno == EACCES || errno == ENOENT)  prefix[0])
+		if ((errno == EACCES  prefix[0]) || errno == ENOENT)
 			return 1;
 		mkpw_warning(Cannot open database `%s', fname);
 		bailout();



CVS commit: src/external/bsd/ntp/dist/ntpd

2014-01-25 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jan 26 02:21:08 UTC 2014

Modified Files:
src/external/bsd/ntp/dist/ntpd: ntp_io.c

Log Message:
stoa() already includes the scope, no need to print it twice.


To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/external/bsd/ntp/dist/ntpd/ntp_io.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/external/bsd/ntp/dist/ntpd/ntp_io.c
diff -u src/external/bsd/ntp/dist/ntpd/ntp_io.c:1.13 src/external/bsd/ntp/dist/ntpd/ntp_io.c:1.14
--- src/external/bsd/ntp/dist/ntpd/ntp_io.c:1.13	Fri Jan 17 17:25:47 2014
+++ src/external/bsd/ntp/dist/ntpd/ntp_io.c	Sun Jan 26 02:21:08 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: ntp_io.c,v 1.13 2014/01/17 17:25:47 roy Exp $	*/
+/*	$NetBSD: ntp_io.c,v 1.14 2014/01/26 02:21:08 mlelstv Exp $	*/
 
 /*
  * ntp_io.c - input/output routines for ntpd.	The socket-opening code
@@ -2818,7 +2818,6 @@ open_socket(
 {
 	SOCKET	fd;
 	int	errval;
-	char	scopetext[16];
 	/*
 	 * int is OK for REUSEADR per
 	 * http://www.kohala.com/start/mcast.api.txt
@@ -2968,16 +2967,10 @@ open_socket(
 		|| debug  1
 #endif
 		) {
-			if (SCOPE(addr))
-snprintf(scopetext, sizeof(scopetext),
-	 %%%d, SCOPE(addr));
-			else
-scopetext[0] = 0;
-
 			msyslog(LOG_ERR,
-bind(%d) AF_INET%s %s%s#%d%s flags 0x%x failed: %m,
+bind(%d) AF_INET%s %s#%d%s flags 0x%x failed: %m,
 fd, IS_IPV6(addr) ? 6 : ,
-stoa(addr), scopetext, SRCPORT(addr),
+stoa(addr), SRCPORT(addr),
 IS_MCAST(addr) ?  (multicast) : ,
 interf-flags);
 		}



CVS commit: src/sys/arch/vax/include

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 03:18:39 UTC 2014

Modified Files:
src/sys/arch/vax/include: vmparam.h

Log Message:
don't re-specify the defaults


To generate a diff of this commit:
cvs rdiff -u -r1.49 -r1.50 src/sys/arch/vax/include/vmparam.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/vax/include/vmparam.h
diff -u src/sys/arch/vax/include/vmparam.h:1.49 src/sys/arch/vax/include/vmparam.h:1.50
--- src/sys/arch/vax/include/vmparam.h:1.49	Sat Jan 25 10:16:50 2014
+++ src/sys/arch/vax/include/vmparam.h	Sat Jan 25 22:18:39 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: vmparam.h,v 1.49 2014/01/25 15:16:50 christos Exp $	*/
+/*	$NetBSD: vmparam.h,v 1.50 2014/01/26 03:18:39 christos Exp $	*/
 
 /*-
  * Copyright (c) 1990 The Regents of the University of California.
@@ -98,14 +98,7 @@
 #define VM_MIN_KERNEL_ADDRESS	((vaddr_t)KERNBASE)
 #define VM_MAX_KERNEL_ADDRESS	((vaddr_t)(0xC000))
 
-/*
- * The address to which unspecified mapping requests default
- */
 #define __USE_TOPDOWN_VM
-#define VM_DEFAULT_ADDRESS_TOPDOWN(da, sz) \
-trunc_page(VM_MAXUSER_ADDRESS - MAXSSIZ - (sz))
-#define VM_DEFAULT_ADDRESS_BOTTOMUP(da, sz) \
-round_page((vaddr_t)(da) + (vsize_t)maxdmap)
 
 #define	USRIOSIZE		(8 * VAX_NPTEPG)	/* 512MB */
 #define	VM_PHYS_SIZE		(USRIOSIZE*VAX_NBPG)



CVS commit: src/tests/lib/libc/gen

2014-01-25 Thread Nick Hudson
Module Name:src
Committed By:   skrll
Date:   Sat Jan 25 10:09:47 UTC 2014

Modified Files:
src/tests/lib/libc/gen: t_siginfo.c

Log Message:
Use English spelling of alignment.


To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/tests/lib/libc/gen/t_siginfo.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys

2014-01-25 Thread Nick Hudson
Module Name:src
Committed By:   skrll
Date:   Sat Jan 25 10:14:29 UTC 2014

Modified Files:
src/sys/compat/linux/arch/powerpc: linux_exec.h
src/sys/dev: kloader.c
src/sys/dev/ic: mfi.c
src/sys/ufs/chfs: chfs_wbuf.c

Log Message:
More alignment spellos


To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/sys/compat/linux/arch/powerpc/linux_exec.h
cvs rdiff -u -r1.25 -r1.26 src/sys/dev/kloader.c
cvs rdiff -u -r1.50 -r1.51 src/sys/dev/ic/mfi.c
cvs rdiff -u -r1.5 -r1.6 src/sys/ufs/chfs/chfs_wbuf.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/rump/kern/lib/libsys_linux

2014-01-25 Thread Nicolas Joly
Module Name:src
Committed By:   njoly
Date:   Sat Jan 25 10:30:22 UTC 2014

Modified Files:
src/sys/rump/kern/lib/libsys_linux: syscalls.master

Log Message:
Add pipe2 and lchown syscalls.


To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 src/sys/rump/kern/lib/libsys_linux/syscalls.master

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/rump/kern/lib/libsys_linux

2014-01-25 Thread Nicolas Joly
Module Name:src
Committed By:   njoly
Date:   Sat Jan 25 10:31:01 UTC 2014

Modified Files:
src/sys/rump/kern/lib/libsys_linux: rump_linux_syscall.h
rump_linux_syscallargs.h rump_linux_syscalls.c rump_linux_sysent.c

Log Message:
Regen for pipe2 and lchown.


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 \
src/sys/rump/kern/lib/libsys_linux/rump_linux_syscall.h
cvs rdiff -u -r1.13 -r1.14 \
src/sys/rump/kern/lib/libsys_linux/rump_linux_syscallargs.h \
src/sys/rump/kern/lib/libsys_linux/rump_linux_syscalls.c \
src/sys/rump/kern/lib/libsys_linux/rump_linux_sysent.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/rump/kern/lib/libsys_linux

2014-01-25 Thread Nicolas Joly
Module Name:src
Committed By:   njoly
Date:   Sat Jan 25 10:40:41 UTC 2014

Modified Files:
src/sys/rump/kern/lib/libsys_linux: Makefile

Log Message:
Add now needed linux_pipe.c sources.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/rump/kern/lib/libsys_linux/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/compat/linux

2014-01-25 Thread Nicolas Joly
Module Name:src
Committed By:   njoly
Date:   Sat Jan 25 13:49:27 UTC 2014

Modified Files:
src/sys/compat/linux/arch/alpha: linux_socket.h
src/sys/compat/linux/arch/amd64: linux_socket.h
src/sys/compat/linux/arch/arm: linux_socket.h
src/sys/compat/linux/arch/i386: linux_socket.h
src/sys/compat/linux/arch/m68k: linux_socket.h
src/sys/compat/linux/arch/mips: linux_socket.h
src/sys/compat/linux/arch/powerpc: linux_socket.h
Added Files:
src/sys/compat/linux/common: linux_socket_generic.h

Log Message:
Update linux socket socket options (SO_*). Add common version to its
own file (linux_socket_generic.h); use it for all but alpha and mips.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/compat/linux/arch/alpha/linux_socket.h
cvs rdiff -u -r1.2 -r1.3 src/sys/compat/linux/arch/amd64/linux_socket.h
cvs rdiff -u -r1.4 -r1.5 src/sys/compat/linux/arch/arm/linux_socket.h
cvs rdiff -u -r1.8 -r1.9 src/sys/compat/linux/arch/i386/linux_socket.h
cvs rdiff -u -r1.4 -r1.5 src/sys/compat/linux/arch/m68k/linux_socket.h
cvs rdiff -u -r1.5 -r1.6 src/sys/compat/linux/arch/mips/linux_socket.h
cvs rdiff -u -r1.6 -r1.7 src/sys/compat/linux/arch/powerpc/linux_socket.h
cvs rdiff -u -r0 -r1.1 src/sys/compat/linux/common/linux_socket_generic.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 15:16:50 UTC 2014

Modified Files:
src/sys/arch/amd64/include: vmparam.h
src/sys/arch/i386/include: vmparam.h
src/sys/arch/mips/include: vmparam.h
src/sys/arch/powerpc/include: vmparam.h
src/sys/arch/vax/include: vmparam.h

Log Message:
delete VM_DEFAULT_ADDRESS; some of those should be GC'ed because they match
the default definition.


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/sys/arch/amd64/include/vmparam.h
cvs rdiff -u -r1.76 -r1.77 src/sys/arch/i386/include/vmparam.h
cvs rdiff -u -r1.51 -r1.52 src/sys/arch/mips/include/vmparam.h
cvs rdiff -u -r1.17 -r1.18 src/sys/arch/powerpc/include/vmparam.h
cvs rdiff -u -r1.48 -r1.49 src/sys/arch/vax/include/vmparam.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/uvm

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 15:17:17 UTC 2014

Modified Files:
src/sys/uvm: uvm_param.h

Log Message:
delete VM_DEFAULT_ADDRESS and commentary which is no longer used/true.


To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/uvm/uvm_param.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/mips/mips

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 15:20:55 UTC 2014

Modified Files:
src/sys/arch/mips/mips: netbsd32_machdep.c

Log Message:
handle non-topdown binaries


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/arch/mips/mips/netbsd32_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/usr.bin/vndcompress

2014-01-25 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Sat Jan 25 15:31:06 UTC 2014

Modified Files:
src/usr.bin/vndcompress: offtab.c vndcompress.c vnduncompress.c

Log Message:
Fix some more integer overflow/truncation issues.

Arithmetic in C is hard.  Let's go shopping!


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/usr.bin/vndcompress/offtab.c \
src/usr.bin/vndcompress/vnduncompress.c
cvs rdiff -u -r1.23 -r1.24 src/usr.bin/vndcompress/vndcompress.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/usr.bin/vndcompress

2014-01-25 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Sat Jan 25 16:26:17 UTC 2014

Modified Files:
src/usr.bin/vndcompress: offtab.c

Log Message:
Factor out an offtab_compute_window_position routine.


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/usr.bin/vndcompress/offtab.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/usr.bin/vndcompress

2014-01-25 Thread Taylor R Campbell
Module Name:src
Committed By:   riastradh
Date:   Sat Jan 25 16:38:15 UTC 2014

Modified Files:
src/usr.bin/vndcompress: offtab.c

Log Message:
Get SIZE_MAX and OFF_MAX straight...


To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 src/usr.bin/vndcompress/offtab.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/compat/aoutm68k

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 16:43:03 UTC 2014

Modified Files:
src/sys/compat/aoutm68k: aoutm68k_syscall.h aoutm68k_syscallargs.h
aoutm68k_syscalls.c aoutm68k_sysent.c

Log Message:
regen


To generate a diff of this commit:
cvs rdiff -u -r1.42 -r1.43 src/sys/compat/aoutm68k/aoutm68k_syscall.h
cvs rdiff -u -r1.40 -r1.41 src/sys/compat/aoutm68k/aoutm68k_syscallargs.h
cvs rdiff -u -r1.39 -r1.40 src/sys/compat/aoutm68k/aoutm68k_syscalls.c
cvs rdiff -u -r1.44 -r1.45 src/sys/compat/aoutm68k/aoutm68k_sysent.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/uvm

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 17:21:49 UTC 2014

Modified Files:
src/sys/uvm: uvm_mmap.c

Log Message:
deal with COMPAT_10 issue.


To generate a diff of this commit:
cvs rdiff -u -r1.146 -r1.147 src/sys/uvm/uvm_mmap.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/kern

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 17:24:46 UTC 2014

Modified Files:
src/sys/kern: vfs_syscalls.c

Log Message:
Add compat_10, open NULL == open .


To generate a diff of this commit:
cvs rdiff -u -r1.474 -r1.475 src/sys/kern/vfs_syscalls.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/arm/vfp

2014-01-25 Thread Nick Hudson
Module Name:src
Committed By:   skrll
Date:   Sat Jan 25 17:30:56 UTC 2014

Modified Files:
src/sys/arch/arm/vfp: vfp_init.c

Log Message:
Improve PCU/VFP handling to the point that the atf tests don't trigger
KASSERTs on the Raspberry PI and its arm1176jzf-s.

XXX Need to emulate bounce instructions to get correct exception codes,
XXX etc.


To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/arch/arm/vfp/vfp_init.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/distrib/notes/common

2014-01-25 Thread Sebastian Wiedenroth
Module Name:src
Committed By:   wiedi
Date:   Sat Jan 25 18:03:10 UTC 2014

Modified Files:
src/distrib/notes/common: main

Log Message:
add myself


To generate a diff of this commit:
cvs rdiff -u -r1.502 -r1.503 src/distrib/notes/common/main

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/sparc64/doc

2014-01-25 Thread Palle Lyckegaard
Module Name:src
Committed By:   palle
Date:   Sat Jan 25 19:07:25 UTC 2014

Added Files:
src/sys/arch/sparc64/doc: TODO

Log Message:
Add a TODO file to document things to be done for the sparc64 port


To generate a diff of this commit:
cvs rdiff -u -r0 -r1.1 src/sys/arch/sparc64/doc/TODO

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/i386/include

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 19:10:56 UTC 2014

Modified Files:
src/sys/arch/i386/include: npx.h

Log Message:
help lint.


To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/sys/arch/i386/include/npx.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/sparc64/sparc64

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 19:42:25 UTC 2014

Modified Files:
src/sys/arch/sparc64/sparc64: machdep.c

Log Message:
__USING_TOPDOWN_VM is gone.


To generate a diff of this commit:
cvs rdiff -u -r1.274 -r1.275 src/sys/arch/sparc64/sparc64/machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/kern

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 19:44:11 UTC 2014

Modified Files:
src/sys/kern: exec_elf.c kern_exec.c kern_proc.c

Log Message:
__USING_TOPDOWN_VM is no more, __USE_TOPDOWN_VM...


To generate a diff of this commit:
cvs rdiff -u -r1.53 -r1.54 src/sys/kern/exec_elf.c
cvs rdiff -u -r1.369 -r1.370 src/sys/kern/kern_exec.c
cvs rdiff -u -r1.190 -r1.191 src/sys/kern/kern_proc.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/i386/i386

2014-01-25 Thread David Laight
Module Name:src
Committed By:   dsl
Date:   Sat Jan 25 19:51:32 UTC 2014

Modified Files:
src/sys/arch/i386/i386: process_machdep.c

Log Message:
Rewrite the code that converts the x87 tag word between its full and
  abridged versions.
The code in xmm_to_s87_tag() looked at the wrong register when trying
  to generate 0b01 (zero) and 0b10 (NaN etc) because the registers are
  relative to the stack top, but the tag words are absolute.
Since even a real 387 generates the correct tag values when the tag word
  (or register value) is loaded there is no point generating other than
  0b00 (used) and 0b11 (unused).
The compiler also made a pig's breakfast of the register copy loop.
When convering from fsave to (the larger) fxsave format don't bother
  copying the fp register values if none are in use.
Converting the other way we do copy them all because the target buffer
  is often written to userspace (and has no padding).
i386 core dumps still seem ok - and do use this code.


To generate a diff of this commit:
cvs rdiff -u -r1.77 -r1.78 src/sys/arch/i386/i386/process_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/i386

2014-01-25 Thread David Laight
Module Name:src
Committed By:   dsl
Date:   Sat Jan 25 20:12:53 UTC 2014

Modified Files:
src/sys/arch/i386/i386: process_machdep.c
src/sys/arch/i386/include: npx.h

Log Message:
Change the way the x87 fp register is defined so that the copies between
  fsave and fxsave layouts can be done by structure assignments.


To generate a diff of this commit:
cvs rdiff -u -r1.78 -r1.79 src/sys/arch/i386/i386/process_machdep.c
cvs rdiff -u -r1.30 -r1.31 src/sys/arch/i386/include/npx.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/net

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:10:29 UTC 2014

Modified Files:
src/sys/net: if.h

Log Message:
add a lint comment


To generate a diff of this commit:
cvs rdiff -u -r1.159 -r1.160 src/sys/net/if.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/net

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:10:41 UTC 2014

Modified Files:
src/sys/net: if_etherip.c

Log Message:
add __USE


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/sys/net/if_etherip.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/kern

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:11:49 UTC 2014

Modified Files:
src/sys/kern: sys_pmc.c

Log Message:
fix unused


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/kern/sys_pmc.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/dev/acpi

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:11:20 UTC 2014

Modified Files:
src/sys/dev/acpi: acpi.c

Log Message:
fix unused


To generate a diff of this commit:
cvs rdiff -u -r1.256 -r1.257 src/sys/dev/acpi/acpi.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/i386/pci

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 21:11:03 UTC 2014

Modified Files:
src/sys/arch/i386/pci: via8231.c

Log Message:
remove unused


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/arch/i386/pci/via8231.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/arm/arm32

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 23:11:08 UTC 2014

Modified Files:
src/sys/arch/arm/arm32: netbsd32_machdep.c

Log Message:
use the topdown hint.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/arch/arm/arm32/netbsd32_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/compat/netbsd32

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 23:58:10 UTC 2014

Modified Files:
src/sys/compat/netbsd32: netbsd32_exec_aout.c

Log Message:
Clear the VM_TOPDOWN flag only when we succeed.


To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 src/sys/compat/netbsd32/netbsd32_exec_aout.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/kern

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sat Jan 25 23:58:41 UTC 2014

Modified Files:
src/sys/kern: exec_aout.c

Log Message:
kill the topdown flag only if we succeed.


To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sys/kern/exec_aout.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/mac68k/dev

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 00:08:48 UTC 2014

Modified Files:
src/sys/arch/mac68k/dev: grf_compat.c

Log Message:
kill VM_DEFAULT_ADDRESS use


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/arch/mac68k/dev/grf_compat.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/x68k/dev

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 00:09:46 UTC 2014

Modified Files:
src/sys/arch/x68k/dev: grf.c

Log Message:
kill VM_DEFAULT_ADDRESS use.


To generate a diff of this commit:
cvs rdiff -u -r1.40 -r1.41 src/sys/arch/x68k/dev/grf.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/arm/arm32

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 00:21:18 UTC 2014

Modified Files:
src/sys/arch/arm/arm32: netbsd32_machdep.c

Log Message:
whitespace


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/arch/arm/arm32/netbsd32_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/usr.sbin/pwd_mkdb

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 01:57:04 UTC 2014

Modified Files:
src/usr.sbin/pwd_mkdb: pwd_mkdb.c

Log Message:
Fix the separate root test. If we get a permission error check for separate
root. But if we get ENOENT, always succeed. Otherwise if someone removes
the db files or they get corrupted, you can never recreate them.


To generate a diff of this commit:
cvs rdiff -u -r1.56 -r1.57 src/usr.sbin/pwd_mkdb/pwd_mkdb.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/external/bsd/ntp/dist/ntpd

2014-01-25 Thread Michael van Elst
Module Name:src
Committed By:   mlelstv
Date:   Sun Jan 26 02:21:08 UTC 2014

Modified Files:
src/external/bsd/ntp/dist/ntpd: ntp_io.c

Log Message:
stoa() already includes the scope, no need to print it twice.


To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/external/bsd/ntp/dist/ntpd/ntp_io.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



CVS commit: src/sys/arch/vax/include

2014-01-25 Thread Christos Zoulas
Module Name:src
Committed By:   christos
Date:   Sun Jan 26 03:18:39 UTC 2014

Modified Files:
src/sys/arch/vax/include: vmparam.h

Log Message:
don't re-specify the defaults


To generate a diff of this commit:
cvs rdiff -u -r1.49 -r1.50 src/sys/arch/vax/include/vmparam.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.